diff options
author | Wengang Wang <wen.gang.wang@oracle.com> | 2010-01-21 13:50:02 -0500 |
---|---|---|
committer | Joel Becker <joel.becker@oracle.com> | 2010-02-03 02:50:55 -0500 |
commit | 0b94a909eb2e2f6990d05fd486a0cb4902ef1ae7 (patch) | |
tree | 197c4da141781f52f72fe4f28e0e82e9432500b1 /fs/ocfs2 | |
parent | 34e6c59af06cbca07b1490ec0015ea2d303470d3 (diff) |
ocfs2: Fix setting of OCFS2_LOCK_BLOCKED during bast
During bast, set the OCFS2_LOCK_BLOCKED flag only if the lock needs to
downconverted.
Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
Acked-by: Sunil Mushran <sunil.mushran@oracle.com>
Acked-by: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Diffstat (limited to 'fs/ocfs2')
-rw-r--r-- | fs/ocfs2/dlmglue.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 172f4c6ce1be..0cdf63042b76 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c | |||
@@ -907,8 +907,6 @@ static int ocfs2_generic_handle_bast(struct ocfs2_lock_res *lockres, | |||
907 | 907 | ||
908 | assert_spin_locked(&lockres->l_lock); | 908 | assert_spin_locked(&lockres->l_lock); |
909 | 909 | ||
910 | lockres_or_flags(lockres, OCFS2_LOCK_BLOCKED); | ||
911 | |||
912 | if (level > lockres->l_blocking) { | 910 | if (level > lockres->l_blocking) { |
913 | /* only schedule a downconvert if we haven't already scheduled | 911 | /* only schedule a downconvert if we haven't already scheduled |
914 | * one that goes low enough to satisfy the level we're | 912 | * one that goes low enough to satisfy the level we're |
@@ -921,6 +919,9 @@ static int ocfs2_generic_handle_bast(struct ocfs2_lock_res *lockres, | |||
921 | lockres->l_blocking = level; | 919 | lockres->l_blocking = level; |
922 | } | 920 | } |
923 | 921 | ||
922 | if (needs_downconvert) | ||
923 | lockres_or_flags(lockres, OCFS2_LOCK_BLOCKED); | ||
924 | |||
924 | mlog_exit(needs_downconvert); | 925 | mlog_exit(needs_downconvert); |
925 | return needs_downconvert; | 926 | return needs_downconvert; |
926 | } | 927 | } |