diff options
author | Tao Ma <boyu.mt@taobao.com> | 2011-03-07 03:43:21 -0500 |
---|---|---|
committer | Tao Ma <boyu.mt@taobao.com> | 2011-03-07 03:43:21 -0500 |
commit | c1e8d35ef5ffb393b94a192034b5e3541e005d75 (patch) | |
tree | b9a7f089acd3408c2835a3dfd6aa7bb0407587b3 /fs/ocfs2/symlink.c | |
parent | ef6b689b63b9f5227ccee6f16dd9ee3faf58a464 (diff) |
ocfs2: Remove EXIT from masklog.
mlog_exit is used to record the exit status of a function.
But because it is added in so many functions, if we enable it,
the system logs get filled up quickly and cause too much I/O.
So actually no one can open it for a production system or even
for a test.
This patch just try to remove it or change it. So:
1. if all the error paths already use mlog_errno, it is just removed.
Otherwise, it will be replaced by mlog_errno.
2. if it is used to print some return value, it is replaced with
mlog(0,...).
mlog_exit_ptr is changed to mlog(0.
All those mlog(0,...) will be replaced with trace events later.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Diffstat (limited to 'fs/ocfs2/symlink.c')
-rw-r--r-- | fs/ocfs2/symlink.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c index 8a81688c57df..5485b19ec8f2 100644 --- a/fs/ocfs2/symlink.c +++ b/fs/ocfs2/symlink.c | |||
@@ -72,7 +72,6 @@ static char *ocfs2_fast_symlink_getlink(struct inode *inode, | |||
72 | fe = (struct ocfs2_dinode *) (*bh)->b_data; | 72 | fe = (struct ocfs2_dinode *) (*bh)->b_data; |
73 | link = (char *) fe->id2.i_symlink; | 73 | link = (char *) fe->id2.i_symlink; |
74 | bail: | 74 | bail: |
75 | mlog_exit(status); | ||
76 | 75 | ||
77 | return link; | 76 | return link; |
78 | } | 77 | } |
@@ -100,7 +99,8 @@ static int ocfs2_readlink(struct dentry *dentry, | |||
100 | 99 | ||
101 | brelse(bh); | 100 | brelse(bh); |
102 | out: | 101 | out: |
103 | mlog_exit(ret); | 102 | if (ret < 0) |
103 | mlog_errno(ret); | ||
104 | return ret; | 104 | return ret; |
105 | } | 105 | } |
106 | 106 | ||
@@ -136,7 +136,8 @@ bail: | |||
136 | nd_set_link(nd, status ? ERR_PTR(status) : link); | 136 | nd_set_link(nd, status ? ERR_PTR(status) : link); |
137 | brelse(bh); | 137 | brelse(bh); |
138 | 138 | ||
139 | mlog_exit(status); | 139 | if (status) |
140 | mlog_errno(status); | ||
140 | return NULL; | 141 | return NULL; |
141 | } | 142 | } |
142 | 143 | ||