diff options
author | Eric Paris <eparis@redhat.com> | 2010-07-28 10:18:37 -0400 |
---|---|---|
committer | Eric Paris <eparis@redhat.com> | 2010-07-28 10:18:49 -0400 |
commit | 8c1934c8d70b22ca8333b216aec6c7d09fdbd6a6 (patch) | |
tree | 25fffb46e0b1594aa692ed10e755b6ae041022bc /fs/notify/inotify/inotify_fsnotify.c | |
parent | 611da04f7a31b2208e838be55a42c7a1310ae321 (diff) |
inotify: allow users to request not to recieve events on unlinked children
An inotify watch on a directory will send events for children even if those
children have been unlinked. This patch add a new inotify flag IN_EXCL_UNLINK
which allows a watch to specificy they don't care about unlinked children.
This should fix performance problems seen by tasks which add a watch to
/tmp and then are overrun with events when other processes are reading and
writing to unlinked files they created in /tmp.
https://bugzilla.kernel.org/show_bug.cgi?id=16296
Requested-by: Matthias Clasen <mclasen@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'fs/notify/inotify/inotify_fsnotify.c')
-rw-r--r-- | fs/notify/inotify/inotify_fsnotify.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/fs/notify/inotify/inotify_fsnotify.c b/fs/notify/inotify/inotify_fsnotify.c index 388a150c3d4a..9d332e7f5a5c 100644 --- a/fs/notify/inotify/inotify_fsnotify.c +++ b/fs/notify/inotify/inotify_fsnotify.c | |||
@@ -22,6 +22,7 @@ | |||
22 | * General Public License for more details. | 22 | * General Public License for more details. |
23 | */ | 23 | */ |
24 | 24 | ||
25 | #include <linux/dcache.h> /* d_unlinked */ | ||
25 | #include <linux/fs.h> /* struct inode */ | 26 | #include <linux/fs.h> /* struct inode */ |
26 | #include <linux/fsnotify_backend.h> | 27 | #include <linux/fsnotify_backend.h> |
27 | #include <linux/inotify.h> | 28 | #include <linux/inotify.h> |
@@ -157,6 +158,14 @@ static bool inotify_should_send_event(struct fsnotify_group *group, struct inode | |||
157 | mask = (mask & ~FS_EVENT_ON_CHILD); | 158 | mask = (mask & ~FS_EVENT_ON_CHILD); |
158 | send = (fsn_mark->mask & mask); | 159 | send = (fsn_mark->mask & mask); |
159 | 160 | ||
161 | if (send && (fsn_mark->mask & FS_EXCL_UNLINK) && | ||
162 | (data_type == FSNOTIFY_EVENT_PATH)) { | ||
163 | struct path *path = data; | ||
164 | |||
165 | if (d_unlinked(path->dentry)) | ||
166 | send = false; | ||
167 | } | ||
168 | |||
160 | /* find took a reference */ | 169 | /* find took a reference */ |
161 | fsnotify_put_mark(fsn_mark); | 170 | fsnotify_put_mark(fsn_mark); |
162 | 171 | ||