NFSD: Check acl returned from get_acl/posix_acl_from_mode

Commit 4ac7249ea5 (nfsd: use get_acl and ->set_acl)
don't check the acl returned from get_acl()/posix_acl_from_mode().

Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/fs/nfsd/nfs3acl.c b/fs/nfsd/nfs3acl.c
index 2a514e21dc74..34cbbab6abd7 100644
--- a/fs/nfsd/nfs3acl.c
+++ b/fs/nfsd/nfs3acl.c
@@ -47,14 +47,14 @@ static __be32 nfsd3_proc_getacl(struct svc_rqst * rqstp,
 
         if (resp->mask & (NFS_ACL|NFS_ACLCNT)) {
                 acl = get_acl(inode, ACL_TYPE_ACCESS);
-                if (IS_ERR(acl)) {
-                        nfserr = nfserrno(PTR_ERR(acl));
-                        goto fail;
-                }
                 if (acl == NULL) {
                         /* Solaris returns the inode's minimum ACL. */
                         acl = posix_acl_from_mode(inode->i_mode, GFP_KERNEL);
                 }
+                if (IS_ERR(acl)) {
+                        nfserr = nfserrno(PTR_ERR(acl));
+                        goto fail;
+                }
                 resp->acl_access = acl;
         }
         if (resp->mask & (NFS_DFACL|NFS_DFACLCNT)) {