aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfs
diff options
context:
space:
mode:
authorTrond Myklebust <trond.myklebust@primarydata.com>2014-09-27 17:02:26 -0400
committerTrond Myklebust <trond.myklebust@primarydata.com>2014-09-28 16:03:03 -0400
commita4339b7b686b4acc8b6de2b07d7bacbe3ae44b83 (patch)
tree1ed0bd94604352b67d808f07e0a22c1233555ef3 /fs/nfs
parentf3f760314afcb8522d2349b970b065589c5c8e48 (diff)
NFSv4: Fix lock recovery when CREATE_SESSION/SETCLIENTID_CONFIRM fails
If a NFSv4.x server returns NFS4ERR_STALE_CLIENTID in response to a CREATE_SESSION or SETCLIENTID_CONFIRM in order to tell us that it rebooted a second time, then the client will currently take this to mean that it must declare all locks to be stale, and hence ineligible for reboot recovery. RFC3530 and RFC5661 both suggest that the client should instead rely on the server to respond to inelegible open share, lock and delegation reclaim requests with NFS4ERR_NO_GRACE in this situation. Cc: stable@vger.kernel.org Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/nfs')
-rw-r--r--fs/nfs/nfs4state.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 22fe35104c0c..26d510d11efd 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -1761,7 +1761,6 @@ static int nfs4_handle_reclaim_lease_error(struct nfs_client *clp, int status)
1761 break; 1761 break;
1762 case -NFS4ERR_STALE_CLIENTID: 1762 case -NFS4ERR_STALE_CLIENTID:
1763 clear_bit(NFS4CLNT_LEASE_CONFIRM, &clp->cl_state); 1763 clear_bit(NFS4CLNT_LEASE_CONFIRM, &clp->cl_state);
1764 nfs4_state_clear_reclaim_reboot(clp);
1765 nfs4_state_start_reclaim_reboot(clp); 1764 nfs4_state_start_reclaim_reboot(clp);
1766 break; 1765 break;
1767 case -NFS4ERR_CLID_INUSE: 1766 case -NFS4ERR_CLID_INUSE: