diff options
author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2012-05-04 13:54:24 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2012-05-04 14:59:51 -0400 |
commit | 1385b8117325e79f74c1e7d1cbf45c789deb85c5 (patch) | |
tree | b1afbd0a9ecd49d29621d1c931d685d705e285d7 /fs/nfs | |
parent | bf5fc4028ef751904a114ffc4b5d2cd9f0233142 (diff) |
NFS: Fix sparse warnings
Fix the following sparse warnings:
fs/nfs/direct.c:221:6: warning: symbol 'nfs_direct_readpage_release' was
not declared. Should it be static?
fs/nfs/read.c:38:43: warning: non-ANSI function declaration of function
'nfs_readhdr_alloc'
fs/nfs/objlayout/objio_osd.c:214:5: warning: symbol '__alloc_objio_seg'
was not declared. Should it be static?
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Fred Isaman <iisaman@netapp.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>
Diffstat (limited to 'fs/nfs')
-rw-r--r-- | fs/nfs/direct.c | 2 | ||||
-rw-r--r-- | fs/nfs/objlayout/objio_osd.c | 2 | ||||
-rw-r--r-- | fs/nfs/read.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index dca9c8143009..257d0091148b 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs/direct.c | |||
@@ -218,7 +218,7 @@ static void nfs_direct_complete(struct nfs_direct_req *dreq) | |||
218 | nfs_direct_req_release(dreq); | 218 | nfs_direct_req_release(dreq); |
219 | } | 219 | } |
220 | 220 | ||
221 | void nfs_direct_readpage_release(struct nfs_page *req) | 221 | static void nfs_direct_readpage_release(struct nfs_page *req) |
222 | { | 222 | { |
223 | dprintk("NFS: direct read done (%s/%lld %d@%lld)\n", | 223 | dprintk("NFS: direct read done (%s/%lld %d@%lld)\n", |
224 | req->wb_context->dentry->d_inode->i_sb->s_id, | 224 | req->wb_context->dentry->d_inode->i_sb->s_id, |
diff --git a/fs/nfs/objlayout/objio_osd.c b/fs/nfs/objlayout/objio_osd.c index fbf4874ec252..b47277baebab 100644 --- a/fs/nfs/objlayout/objio_osd.c +++ b/fs/nfs/objlayout/objio_osd.c | |||
@@ -211,7 +211,7 @@ static void copy_single_comp(struct ore_components *oc, unsigned c, | |||
211 | memcpy(ocomp->cred, src_comp->oc_cap.cred, sizeof(ocomp->cred)); | 211 | memcpy(ocomp->cred, src_comp->oc_cap.cred, sizeof(ocomp->cred)); |
212 | } | 212 | } |
213 | 213 | ||
214 | int __alloc_objio_seg(unsigned numdevs, gfp_t gfp_flags, | 214 | static int __alloc_objio_seg(unsigned numdevs, gfp_t gfp_flags, |
215 | struct objio_segment **pseg) | 215 | struct objio_segment **pseg) |
216 | { | 216 | { |
217 | /* This is the in memory structure of the objio_segment | 217 | /* This is the in memory structure of the objio_segment |
diff --git a/fs/nfs/read.c b/fs/nfs/read.c index 37c9eb2930b0..f23cf255bd39 100644 --- a/fs/nfs/read.c +++ b/fs/nfs/read.c | |||
@@ -35,7 +35,7 @@ static const struct nfs_pgio_completion_ops nfs_async_read_completion_ops; | |||
35 | 35 | ||
36 | static struct kmem_cache *nfs_rdata_cachep; | 36 | static struct kmem_cache *nfs_rdata_cachep; |
37 | 37 | ||
38 | struct nfs_read_header *nfs_readhdr_alloc() | 38 | struct nfs_read_header *nfs_readhdr_alloc(void) |
39 | { | 39 | { |
40 | struct nfs_read_header *rhdr; | 40 | struct nfs_read_header *rhdr; |
41 | 41 | ||