SUNRPC: Define rpcsec_gss_info structure

The NFSv4 SECINFO procedure returns a list of security flavors.  Any
GSS flavor also has a GSS tuple containing an OID, a quality-of-
protection value, and a service value, which specifies a particular
GSS pseudoflavor.

For simplicity and efficiency, I'd like to return each GSS tuple
from the NFSv4 SECINFO XDR decoder and pass it straight into the RPC
client.

Define a data structure that is visible to both the NFS client and
the RPC client.  Take structure and field names from the relevant
standards to avoid confusion.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

1 files changed, 6 insertions, 6 deletions

diff --git a/fs/nfs/nfs4namespace.c b/fs/nfs/nfs4namespace.c
index 0dd766079e1c..88231c92317c 100644
--- a/fs/nfs/nfs4namespace.c
+++ b/fs/nfs/nfs4namespace.c
@@ -138,23 +138,23 @@ rpc_authflavor_t nfs_find_best_sec(struct nfs4_secinfo_flavors *flavors)
 {
         struct gss_api_mech *mech;
         struct xdr_netobj oid;
-        int i;
+        unsigned int i;
         rpc_authflavor_t pseudoflavor = RPC_AUTH_UNIX;
 
         for (i = 0; i < flavors->num_flavors; i++) {
-                struct nfs4_secinfo_flavor *flavor;
-                flavor = &flavors->flavors[i];
+                struct nfs4_secinfo4 *flavor = &flavors->flavors[i];
 
                 if (flavor->flavor == RPC_AUTH_NULL || flavor->flavor == RPC_AUTH_UNIX) {
                         pseudoflavor = flavor->flavor;
                         break;
                 } else if (flavor->flavor == RPC_AUTH_GSS) {
-                        oid.len  = flavor->gss.sec_oid4.len;
-                        oid.data = flavor->gss.sec_oid4.data;
+                        oid.len  = flavor->flavor_info.oid.len;
+                        oid.data = flavor->flavor_info.oid.data;
                         mech = gss_mech_get_by_OID(&oid);
                         if (!mech)
                                 continue;
-                        pseudoflavor = gss_svc_to_pseudoflavor(mech, flavor->gss.service);
+                        pseudoflavor = gss_svc_to_pseudoflavor(mech,
+                                                flavor->flavor_info.service);
                         gss_mech_put(mech);
                         break;
                 }