aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfs/dns_resolve.c
diff options
context:
space:
mode:
authorStanislav Kinsbursky <skinsbursky@parallels.com>2013-02-04 06:02:40 -0500
committerJ. Bruce Fields <bfields@redhat.com>2013-02-15 10:43:36 -0500
commit462b8f6bf1d3f5feb7a346394036dbc1df3a8ed5 (patch)
tree3ff18fadfefa42d972409ab1965e90bdf126d1cb /fs/nfs/dns_resolve.c
parent483479c26a65e5f0cc95e9324f313bc95c7dc6fd (diff)
NFS: simplify and clean cache library
This is a cleanup patch. Such helpers like nfs_cache_init() and nfs_cache_destroy() are redundant, because they are just a wrappers around sunrpc_init_cache_detail() and sunrpc_destroy_cache_detail() respectively. So let's remove them completely and move corresponding logic to nfs_cache_register_net() and nfs_cache_unregister_net() respectively (since they are called together anyway). Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfs/dns_resolve.c')
-rw-r--r--fs/nfs/dns_resolve.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c
index d5ce5f4f0f5f..9cbc98a4159d 100644
--- a/fs/nfs/dns_resolve.c
+++ b/fs/nfs/dns_resolve.c
@@ -377,14 +377,12 @@ int nfs_dns_resolver_cache_init(struct net *net)
377 if (IS_ERR(nn->nfs_dns_resolve)) 377 if (IS_ERR(nn->nfs_dns_resolve))
378 return PTR_ERR(nn->nfs_dns_resolve); 378 return PTR_ERR(nn->nfs_dns_resolve);
379 379
380 nfs_cache_init(nn->nfs_dns_resolve);
381 err = nfs_cache_register_net(net, nn->nfs_dns_resolve); 380 err = nfs_cache_register_net(net, nn->nfs_dns_resolve);
382 if (err) 381 if (err)
383 goto err_reg; 382 goto err_reg;
384 return 0; 383 return 0;
385 384
386err_reg: 385err_reg:
387 nfs_cache_destroy(nn->nfs_dns_resolve);
388 cache_destroy_net(nn->nfs_dns_resolve, net); 386 cache_destroy_net(nn->nfs_dns_resolve, net);
389 return err; 387 return err;
390} 388}
@@ -392,10 +390,8 @@ err_reg:
392void nfs_dns_resolver_cache_destroy(struct net *net) 390void nfs_dns_resolver_cache_destroy(struct net *net)
393{ 391{
394 struct nfs_net *nn = net_generic(net, nfs_net_id); 392 struct nfs_net *nn = net_generic(net, nfs_net_id);
395 struct cache_detail *cd = nn->nfs_dns_resolve;
396 393
397 nfs_cache_unregister_net(net, cd); 394 nfs_cache_unregister_net(net, nn->nfs_dns_resolve);
398 nfs_cache_destroy(cd);
399 cache_destroy_net(nn->nfs_dns_resolve, net); 395 cache_destroy_net(nn->nfs_dns_resolve, net);
400} 396}
401 397