diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-05 09:40:36 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:07 -0400 |
commit | 6cfd0148425e528b859b26e436b01f23f6926224 (patch) | |
tree | 60e3257053554ff198fe5825e6f12a00c3b4422a /fs/ncpfs/inode.c | |
parent | a9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff) |
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.
[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ncpfs/inode.c')
-rw-r--r-- | fs/ncpfs/inode.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c index d642f0e5b365..b99ce205b1bd 100644 --- a/fs/ncpfs/inode.c +++ b/fs/ncpfs/inode.c | |||
@@ -736,6 +736,8 @@ static void ncp_put_super(struct super_block *sb) | |||
736 | { | 736 | { |
737 | struct ncp_server *server = NCP_SBP(sb); | 737 | struct ncp_server *server = NCP_SBP(sb); |
738 | 738 | ||
739 | lock_kernel(); | ||
740 | |||
739 | ncp_lock_server(server); | 741 | ncp_lock_server(server); |
740 | ncp_disconnect(server); | 742 | ncp_disconnect(server); |
741 | ncp_unlock_server(server); | 743 | ncp_unlock_server(server); |
@@ -769,6 +771,8 @@ static void ncp_put_super(struct super_block *sb) | |||
769 | vfree(server->packet); | 771 | vfree(server->packet); |
770 | sb->s_fs_info = NULL; | 772 | sb->s_fs_info = NULL; |
771 | kfree(server); | 773 | kfree(server); |
774 | |||
775 | unlock_kernel(); | ||
772 | } | 776 | } |
773 | 777 | ||
774 | static int ncp_statfs(struct dentry *dentry, struct kstatfs *buf) | 778 | static int ncp_statfs(struct dentry *dentry, struct kstatfs *buf) |