diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2014-02-13 12:34:30 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2014-10-09 02:38:56 -0400 |
commit | 9b053f3207e8887fed88162a339fdd4001abcdb2 (patch) | |
tree | 7751f057ee6c8ecd6cdb8d613c94db5c6dd632f7 /fs/kernfs | |
parent | 8ed936b5671bfb33d89bc60bdcc7cf0470ba52fe (diff) |
vfs: Remove unnecessary calls of check_submounts_and_drop
Now that check_submounts_and_drop can not fail and is called from
d_invalidate there is no longer a need to call check_submounts_and_drom
from filesystem d_revalidate methods so remove it.
Reviewed-by: Miklos Szeredi <miklos@szeredi.hu>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/kernfs')
-rw-r--r-- | fs/kernfs/dir.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c index a693f5b01ae6..1c771931bb60 100644 --- a/fs/kernfs/dir.c +++ b/fs/kernfs/dir.c | |||
@@ -463,21 +463,10 @@ static int kernfs_dop_revalidate(struct dentry *dentry, unsigned int flags) | |||
463 | goto out_bad; | 463 | goto out_bad; |
464 | 464 | ||
465 | mutex_unlock(&kernfs_mutex); | 465 | mutex_unlock(&kernfs_mutex); |
466 | out_valid: | ||
467 | return 1; | 466 | return 1; |
468 | out_bad: | 467 | out_bad: |
469 | mutex_unlock(&kernfs_mutex); | 468 | mutex_unlock(&kernfs_mutex); |
470 | out_bad_unlocked: | 469 | out_bad_unlocked: |
471 | /* | ||
472 | * @dentry doesn't match the underlying kernfs node, drop the | ||
473 | * dentry and force lookup. If we have submounts we must allow the | ||
474 | * vfs caches to lie about the state of the filesystem to prevent | ||
475 | * leaks and other nasty things, so use check_submounts_and_drop() | ||
476 | * instead of d_drop(). | ||
477 | */ | ||
478 | if (check_submounts_and_drop(dentry) != 0) | ||
479 | goto out_valid; | ||
480 | |||
481 | return 0; | 470 | return 0; |
482 | } | 471 | } |
483 | 472 | ||