diff options
author | Steven Whitehouse <swhiteho@redhat.com> | 2008-12-19 10:32:06 -0500 |
---|---|---|
committer | Steven Whitehouse <swhiteho@redhat.com> | 2009-01-05 02:39:18 -0500 |
commit | fefc03bfedeff2002f14e848ecb7c0cd77ee0b15 (patch) | |
tree | 830ec1d36b8688a70580e8c5c18ac5f40015448f /fs/gfs2/super.c | |
parent | 7ed122e42c72b3e4531f8b4a9f72159e8303ac15 (diff) |
Revert "GFS2: Fix use-after-free bug on umount"
This reverts commit 78802499912f1ba31ce83a94c55b5a980f250a43.
The original patch is causing problems in relation to order of
operations at umount in relation to jdata files. I need to fix
this a different way.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/super.c')
-rw-r--r-- | fs/gfs2/super.c | 34 |
1 files changed, 34 insertions, 0 deletions
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index f14658b20204..141b781f2fcc 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c | |||
@@ -33,6 +33,40 @@ | |||
33 | #include "trans.h" | 33 | #include "trans.h" |
34 | #include "util.h" | 34 | #include "util.h" |
35 | 35 | ||
36 | /** | ||
37 | * gfs2_jindex_free - Clear all the journal index information | ||
38 | * @sdp: The GFS2 superblock | ||
39 | * | ||
40 | */ | ||
41 | |||
42 | void gfs2_jindex_free(struct gfs2_sbd *sdp) | ||
43 | { | ||
44 | struct list_head list, *head; | ||
45 | struct gfs2_jdesc *jd; | ||
46 | struct gfs2_journal_extent *jext; | ||
47 | |||
48 | spin_lock(&sdp->sd_jindex_spin); | ||
49 | list_add(&list, &sdp->sd_jindex_list); | ||
50 | list_del_init(&sdp->sd_jindex_list); | ||
51 | sdp->sd_journals = 0; | ||
52 | spin_unlock(&sdp->sd_jindex_spin); | ||
53 | |||
54 | while (!list_empty(&list)) { | ||
55 | jd = list_entry(list.next, struct gfs2_jdesc, jd_list); | ||
56 | head = &jd->extent_list; | ||
57 | while (!list_empty(head)) { | ||
58 | jext = list_entry(head->next, | ||
59 | struct gfs2_journal_extent, | ||
60 | extent_list); | ||
61 | list_del(&jext->extent_list); | ||
62 | kfree(jext); | ||
63 | } | ||
64 | list_del(&jd->jd_list); | ||
65 | iput(jd->jd_inode); | ||
66 | kfree(jd); | ||
67 | } | ||
68 | } | ||
69 | |||
36 | static struct gfs2_jdesc *jdesc_find_i(struct list_head *head, unsigned int jid) | 70 | static struct gfs2_jdesc *jdesc_find_i(struct list_head *head, unsigned int jid) |
37 | { | 71 | { |
38 | struct gfs2_jdesc *jd; | 72 | struct gfs2_jdesc *jd; |