aboutsummaryrefslogtreecommitdiffstats
path: root/fs/fuse/dev.c
diff options
context:
space:
mode:
authorMaxim Patlasov <mpatlasov@parallels.com>2012-10-26 11:49:24 -0400
committerMiklos Szeredi <mszeredi@suse.cz>2013-01-24 10:21:27 -0500
commitb2430d7567a376b3685627ca7e9d712f6f27d49b (patch)
tree2c59795b27e57f6a0a6c15d0f8aea3aac32f8317 /fs/fuse/dev.c
parent54b966702dafe396b6f4e609f222b8e0fdb4d7a4 (diff)
fuse: add per-page descriptor <offset, length> to fuse_req
The ability to save page pointers along with lengths and offsets in fuse_req will be useful to cover several iovec-s with a single fuse_req. Per-request page_offset is removed because anybody who need it can use req->page_descs[0].offset instead. Signed-off-by: Maxim Patlasov <mpatlasov@parallels.com> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Diffstat (limited to 'fs/fuse/dev.c')
-rw-r--r--fs/fuse/dev.c28
1 files changed, 20 insertions, 8 deletions
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 28d9792de4a2..db4af8f3886a 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -35,15 +35,18 @@ static struct fuse_conn *fuse_get_conn(struct file *file)
35} 35}
36 36
37static void fuse_request_init(struct fuse_req *req, struct page **pages, 37static void fuse_request_init(struct fuse_req *req, struct page **pages,
38 struct fuse_page_desc *page_descs,
38 unsigned npages) 39 unsigned npages)
39{ 40{
40 memset(req, 0, sizeof(*req)); 41 memset(req, 0, sizeof(*req));
41 memset(pages, 0, sizeof(*pages) * npages); 42 memset(pages, 0, sizeof(*pages) * npages);
43 memset(page_descs, 0, sizeof(*page_descs) * npages);
42 INIT_LIST_HEAD(&req->list); 44 INIT_LIST_HEAD(&req->list);
43 INIT_LIST_HEAD(&req->intr_entry); 45 INIT_LIST_HEAD(&req->intr_entry);
44 init_waitqueue_head(&req->waitq); 46 init_waitqueue_head(&req->waitq);
45 atomic_set(&req->count, 1); 47 atomic_set(&req->count, 1);
46 req->pages = pages; 48 req->pages = pages;
49 req->page_descs = page_descs;
47 req->max_pages = npages; 50 req->max_pages = npages;
48} 51}
49 52
@@ -52,18 +55,25 @@ static struct fuse_req *__fuse_request_alloc(unsigned npages, gfp_t flags)
52 struct fuse_req *req = kmem_cache_alloc(fuse_req_cachep, flags); 55 struct fuse_req *req = kmem_cache_alloc(fuse_req_cachep, flags);
53 if (req) { 56 if (req) {
54 struct page **pages; 57 struct page **pages;
58 struct fuse_page_desc *page_descs;
55 59
56 if (npages <= FUSE_REQ_INLINE_PAGES) 60 if (npages <= FUSE_REQ_INLINE_PAGES) {
57 pages = req->inline_pages; 61 pages = req->inline_pages;
58 else 62 page_descs = req->inline_page_descs;
63 } else {
59 pages = kmalloc(sizeof(struct page *) * npages, flags); 64 pages = kmalloc(sizeof(struct page *) * npages, flags);
65 page_descs = kmalloc(sizeof(struct fuse_page_desc) *
66 npages, flags);
67 }
60 68
61 if (!pages) { 69 if (!pages || !page_descs) {
70 kfree(pages);
71 kfree(page_descs);
62 kmem_cache_free(fuse_req_cachep, req); 72 kmem_cache_free(fuse_req_cachep, req);
63 return NULL; 73 return NULL;
64 } 74 }
65 75
66 fuse_request_init(req, pages, npages); 76 fuse_request_init(req, pages, page_descs, npages);
67 } 77 }
68 return req; 78 return req;
69} 79}
@@ -81,8 +91,10 @@ struct fuse_req *fuse_request_alloc_nofs(unsigned npages)
81 91
82void fuse_request_free(struct fuse_req *req) 92void fuse_request_free(struct fuse_req *req)
83{ 93{
84 if (req->pages != req->inline_pages) 94 if (req->pages != req->inline_pages) {
85 kfree(req->pages); 95 kfree(req->pages);
96 kfree(req->page_descs);
97 }
86 kmem_cache_free(fuse_req_cachep, req); 98 kmem_cache_free(fuse_req_cachep, req);
87} 99}
88 100
@@ -186,7 +198,7 @@ static void put_reserved_req(struct fuse_conn *fc, struct fuse_req *req)
186 struct fuse_file *ff = file->private_data; 198 struct fuse_file *ff = file->private_data;
187 199
188 spin_lock(&fc->lock); 200 spin_lock(&fc->lock);
189 fuse_request_init(req, req->pages, req->max_pages); 201 fuse_request_init(req, req->pages, req->page_descs, req->max_pages);
190 BUG_ON(ff->reserved_req); 202 BUG_ON(ff->reserved_req);
191 ff->reserved_req = req; 203 ff->reserved_req = req;
192 wake_up_all(&fc->reserved_req_waitq); 204 wake_up_all(&fc->reserved_req_waitq);
@@ -891,7 +903,7 @@ static int fuse_copy_pages(struct fuse_copy_state *cs, unsigned nbytes,
891{ 903{
892 unsigned i; 904 unsigned i;
893 struct fuse_req *req = cs->req; 905 struct fuse_req *req = cs->req;
894 unsigned offset = req->page_offset; 906 unsigned offset = req->page_descs[0].offset;
895 unsigned count = min(nbytes, (unsigned) PAGE_SIZE - offset); 907 unsigned count = min(nbytes, (unsigned) PAGE_SIZE - offset);
896 908
897 for (i = 0; i < req->num_pages && (nbytes || zeroing); i++) { 909 for (i = 0; i < req->num_pages && (nbytes || zeroing); i++) {
@@ -1599,7 +1611,7 @@ static int fuse_retrieve(struct fuse_conn *fc, struct inode *inode,
1599 req->in.h.nodeid = outarg->nodeid; 1611 req->in.h.nodeid = outarg->nodeid;
1600 req->in.numargs = 2; 1612 req->in.numargs = 2;
1601 req->in.argpages = 1; 1613 req->in.argpages = 1;
1602 req->page_offset = offset; 1614 req->page_descs[0].offset = offset;
1603 req->end = fuse_retrieve_end; 1615 req->end = fuse_retrieve_end;
1604 1616
1605 index = outarg->offset >> PAGE_CACHE_SHIFT; 1617 index = outarg->offset >> PAGE_CACHE_SHIFT;