aboutsummaryrefslogtreecommitdiffstats
path: root/fs/f2fs
diff options
context:
space:
mode:
authorChris Fries <cfries@motorola.com>2014-01-17 15:44:39 -0500
committerJaegeuk Kim <jaegeuk.kim@samsung.com>2014-01-19 20:27:12 -0500
commit6c311ec6c2d9e015d454b4e3fda8008b5bebf316 (patch)
treefaeac598ff5ab624b7080b1793beb6df08183d7b /fs/f2fs
parentc434cbc0edda6a7a59d22b9d5d4279989d0ab804 (diff)
f2fs: clean checkpatch warnings
Fixed a variety of trivial checkpatch warnings. The only delta should be some minor formatting on log strings that were split / too long. Signed-off-by: Chris Fries <cfries@motorola.com> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Diffstat (limited to 'fs/f2fs')
-rw-r--r--fs/f2fs/data.c2
-rw-r--r--fs/f2fs/debug.c2
-rw-r--r--fs/f2fs/dir.c5
-rw-r--r--fs/f2fs/f2fs.h6
-rw-r--r--fs/f2fs/file.c2
-rw-r--r--fs/f2fs/inode.c12
-rw-r--r--fs/f2fs/node.c2
-rw-r--r--fs/f2fs/recovery.c12
-rw-r--r--fs/f2fs/segment.c6
-rw-r--r--fs/f2fs/segment.h13
-rw-r--r--fs/f2fs/super.c8
11 files changed, 40 insertions, 30 deletions
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index bda889e2ca63..f5fac16bc6e7 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -792,7 +792,7 @@ static int f2fs_write_data_page(struct page *page,
792 int err = 0; 792 int err = 0;
793 struct f2fs_io_info fio = { 793 struct f2fs_io_info fio = {
794 .type = DATA, 794 .type = DATA,
795 .rw = (wbc->sync_mode == WB_SYNC_ALL) ? WRITE_SYNC: WRITE, 795 .rw = (wbc->sync_mode == WB_SYNC_ALL) ? WRITE_SYNC : WRITE,
796 }; 796 };
797 797
798 if (page->index < end_index) 798 if (page->index < end_index)
diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c
index 6e4ac9a25dfd..63cb7e215e00 100644
--- a/fs/f2fs/debug.c
+++ b/fs/f2fs/debug.c
@@ -245,7 +245,7 @@ static int stat_show(struct seq_file *s, void *v)
245 seq_printf(s, " - node blocks : %d\n", si->node_blks); 245 seq_printf(s, " - node blocks : %d\n", si->node_blks);
246 seq_printf(s, "\nExtent Hit Ratio: %d / %d\n", 246 seq_printf(s, "\nExtent Hit Ratio: %d / %d\n",
247 si->hit_ext, si->total_ext); 247 si->hit_ext, si->total_ext);
248 seq_printf(s, "\nBalancing F2FS Async:\n"); 248 seq_puts(s, "\nBalancing F2FS Async:\n");
249 seq_printf(s, " - nodes: %4d in %4d\n", 249 seq_printf(s, " - nodes: %4d in %4d\n",
250 si->ndirty_node, si->node_pages); 250 si->ndirty_node, si->node_pages);
251 seq_printf(s, " - dents: %4d in dirs:%4d\n", 251 seq_printf(s, " - dents: %4d in dirs:%4d\n",
diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
index f815ca0c5819..cd055b6fcffe 100644
--- a/fs/f2fs/dir.c
+++ b/fs/f2fs/dir.c
@@ -430,7 +430,8 @@ next:
430 * Caller should grab and release a rwsem by calling f2fs_lock_op() and 430 * Caller should grab and release a rwsem by calling f2fs_lock_op() and
431 * f2fs_unlock_op(). 431 * f2fs_unlock_op().
432 */ 432 */
433int __f2fs_add_link(struct inode *dir, const struct qstr *name, struct inode *inode) 433int __f2fs_add_link(struct inode *dir, const struct qstr *name,
434 struct inode *inode)
434{ 435{
435 unsigned int bit_pos; 436 unsigned int bit_pos;
436 unsigned int level; 437 unsigned int level;
@@ -631,7 +632,7 @@ static int f2fs_readdir(struct file *file, struct dir_context *ctx)
631 632
632 bit_pos = ((unsigned long)ctx->pos % NR_DENTRY_IN_BLOCK); 633 bit_pos = ((unsigned long)ctx->pos % NR_DENTRY_IN_BLOCK);
633 634
634 for ( ; n < npages; n++) { 635 for (; n < npages; n++) {
635 dentry_page = get_lock_data_page(inode, n); 636 dentry_page = get_lock_data_page(inode, n);
636 if (IS_ERR(dentry_page)) 637 if (IS_ERR(dentry_page))
637 continue; 638 continue;
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index ee304fb71e1f..5ab3981938d4 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -607,9 +607,9 @@ static inline int check_nid_range(struct f2fs_sb_info *sbi, nid_t nid)
607static inline int F2FS_HAS_BLOCKS(struct inode *inode) 607static inline int F2FS_HAS_BLOCKS(struct inode *inode)
608{ 608{
609 if (F2FS_I(inode)->i_xattr_nid) 609 if (F2FS_I(inode)->i_xattr_nid)
610 return (inode->i_blocks > F2FS_DEFAULT_ALLOCATED_BLOCKS + 1); 610 return inode->i_blocks > F2FS_DEFAULT_ALLOCATED_BLOCKS + 1;
611 else 611 else
612 return (inode->i_blocks > F2FS_DEFAULT_ALLOCATED_BLOCKS); 612 return inode->i_blocks > F2FS_DEFAULT_ALLOCATED_BLOCKS;
613} 613}
614 614
615static inline bool inc_valid_block_count(struct f2fs_sb_info *sbi, 615static inline bool inc_valid_block_count(struct f2fs_sb_info *sbi,
@@ -1231,7 +1231,7 @@ struct f2fs_stat_info {
1231 1231
1232static inline struct f2fs_stat_info *F2FS_STAT(struct f2fs_sb_info *sbi) 1232static inline struct f2fs_stat_info *F2FS_STAT(struct f2fs_sb_info *sbi)
1233{ 1233{
1234 return (struct f2fs_stat_info*)sbi->stat_info; 1234 return (struct f2fs_stat_info *)sbi->stat_info;
1235} 1235}
1236 1236
1237#define stat_inc_call_count(si) ((si)->call_count++) 1237#define stat_inc_call_count(si) ((si)->call_count++)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 14511b00fffa..85e91ca88d57 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -202,7 +202,7 @@ int truncate_data_blocks_range(struct dnode_of_data *dn, int count)
202 raw_node = F2FS_NODE(dn->node_page); 202 raw_node = F2FS_NODE(dn->node_page);
203 addr = blkaddr_in_node(raw_node) + ofs; 203 addr = blkaddr_in_node(raw_node) + ofs;
204 204
205 for ( ; count > 0; count--, addr++, dn->ofs_in_node++) { 205 for (; count > 0; count--, addr++, dn->ofs_in_node++) {
206 block_t blkaddr = le32_to_cpu(*addr); 206 block_t blkaddr = le32_to_cpu(*addr);
207 if (blkaddr == NULL_ADDR) 207 if (blkaddr == NULL_ADDR)
208 continue; 208 continue;
diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index ffa4c6d0fab4..4d67ed736dca 100644
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -42,9 +42,11 @@ static void __get_inode_rdev(struct inode *inode, struct f2fs_inode *ri)
42 if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode) || 42 if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode) ||
43 S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) { 43 S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) {
44 if (ri->i_addr[0]) 44 if (ri->i_addr[0])
45 inode->i_rdev = old_decode_dev(le32_to_cpu(ri->i_addr[0])); 45 inode->i_rdev =
46 old_decode_dev(le32_to_cpu(ri->i_addr[0]));
46 else 47 else
47 inode->i_rdev = new_decode_dev(le32_to_cpu(ri->i_addr[1])); 48 inode->i_rdev =
49 new_decode_dev(le32_to_cpu(ri->i_addr[1]));
48 } 50 }
49} 51}
50 52
@@ -52,11 +54,13 @@ static void __set_inode_rdev(struct inode *inode, struct f2fs_inode *ri)
52{ 54{
53 if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode)) { 55 if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode)) {
54 if (old_valid_dev(inode->i_rdev)) { 56 if (old_valid_dev(inode->i_rdev)) {
55 ri->i_addr[0] = cpu_to_le32(old_encode_dev(inode->i_rdev)); 57 ri->i_addr[0] =
58 cpu_to_le32(old_encode_dev(inode->i_rdev));
56 ri->i_addr[1] = 0; 59 ri->i_addr[1] = 0;
57 } else { 60 } else {
58 ri->i_addr[0] = 0; 61 ri->i_addr[0] = 0;
59 ri->i_addr[1] = cpu_to_le32(new_encode_dev(inode->i_rdev)); 62 ri->i_addr[1] =
63 cpu_to_le32(new_encode_dev(inode->i_rdev));
60 ri->i_addr[2] = 0; 64 ri->i_addr[2] = 0;
61 } 65 }
62 } 66 }
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index b8c9301db52c..226a05a27e33 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1196,7 +1196,7 @@ static int f2fs_write_node_page(struct page *page,
1196 struct node_info ni; 1196 struct node_info ni;
1197 struct f2fs_io_info fio = { 1197 struct f2fs_io_info fio = {
1198 .type = NODE, 1198 .type = NODE,
1199 .rw = (wbc->sync_mode == WB_SYNC_ALL) ? WRITE_SYNC: WRITE, 1199 .rw = (wbc->sync_mode == WB_SYNC_ALL) ? WRITE_SYNC : WRITE,
1200 }; 1200 };
1201 1201
1202 if (unlikely(sbi->por_doing)) 1202 if (unlikely(sbi->por_doing))
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 655791e518cf..976a7a934db5 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -95,9 +95,9 @@ out_unmap_put:
95 kunmap(page); 95 kunmap(page);
96 f2fs_put_page(page, 0); 96 f2fs_put_page(page, 0);
97out: 97out:
98 f2fs_msg(inode->i_sb, KERN_NOTICE, "recover_inode and its dentry: " 98 f2fs_msg(inode->i_sb, KERN_NOTICE,
99 "ino = %x, name = %s, dir = %lx, err = %d", 99 "%s: ino = %x, name = %s, dir = %lx, err = %d",
100 ino_of_node(ipage), raw_inode->i_name, 100 __func__, ino_of_node(ipage), raw_inode->i_name,
101 IS_ERR(dir) ? 0 : dir->i_ino, err); 101 IS_ERR(dir) ? 0 : dir->i_ino, err);
102 return err; 102 return err;
103} 103}
@@ -366,9 +366,9 @@ err:
366 f2fs_put_dnode(&dn); 366 f2fs_put_dnode(&dn);
367 f2fs_unlock_op(sbi); 367 f2fs_unlock_op(sbi);
368out: 368out:
369 f2fs_msg(sbi->sb, KERN_NOTICE, "recover_data: ino = %lx, " 369 f2fs_msg(sbi->sb, KERN_NOTICE,
370 "recovered_data = %d blocks, err = %d", 370 "recover_data: ino = %lx, recovered = %d blocks, err = %d",
371 inode->i_ino, recovered, err); 371 inode->i_ino, recovered, err);
372 return err; 372 return err;
373} 373}
374 374
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index a934e6f2738b..e82423fbcb9d 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -946,7 +946,8 @@ void write_data_page(struct page *page, struct dnode_of_data *dn,
946 do_write_page(sbi, page, dn->data_blkaddr, new_blkaddr, &sum, fio); 946 do_write_page(sbi, page, dn->data_blkaddr, new_blkaddr, &sum, fio);
947} 947}
948 948
949void rewrite_data_page(struct page *page, block_t old_blkaddr, struct f2fs_io_info *fio) 949void rewrite_data_page(struct page *page, block_t old_blkaddr,
950 struct f2fs_io_info *fio)
950{ 951{
951 struct inode *inode = page->mapping->host; 952 struct inode *inode = page->mapping->host;
952 struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb); 953 struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);
@@ -1647,7 +1648,8 @@ static void build_sit_entries(struct f2fs_sb_info *sbi)
1647 1648
1648 mutex_lock(&curseg->curseg_mutex); 1649 mutex_lock(&curseg->curseg_mutex);
1649 for (i = 0; i < sits_in_cursum(sum); i++) { 1650 for (i = 0; i < sits_in_cursum(sum); i++) {
1650 if (le32_to_cpu(segno_in_journal(sum, i)) == start) { 1651 if (le32_to_cpu(segno_in_journal(sum, i))
1652 == start) {
1651 sit = sit_in_journal(sum, i); 1653 sit = sit_in_journal(sum, i);
1652 mutex_unlock(&curseg->curseg_mutex); 1654 mutex_unlock(&curseg->curseg_mutex);
1653 goto got_it; 1655 goto got_it;
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index e9a10bdd7fed..5731682d7516 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -448,8 +448,8 @@ static inline int reserved_sections(struct f2fs_sb_info *sbi)
448 448
449static inline bool need_SSR(struct f2fs_sb_info *sbi) 449static inline bool need_SSR(struct f2fs_sb_info *sbi)
450{ 450{
451 return ((prefree_segments(sbi) / sbi->segs_per_sec) 451 return (prefree_segments(sbi) / sbi->segs_per_sec)
452 + free_sections(sbi) < overprovision_sections(sbi)); 452 + free_sections(sbi) < overprovision_sections(sbi);
453} 453}
454 454
455static inline bool has_not_enough_free_secs(struct f2fs_sb_info *sbi, int freed) 455static inline bool has_not_enough_free_secs(struct f2fs_sb_info *sbi, int freed)
@@ -460,18 +460,19 @@ static inline bool has_not_enough_free_secs(struct f2fs_sb_info *sbi, int freed)
460 if (unlikely(sbi->por_doing)) 460 if (unlikely(sbi->por_doing))
461 return false; 461 return false;
462 462
463 return ((free_sections(sbi) + freed) <= (node_secs + 2 * dent_secs + 463 return (free_sections(sbi) + freed) <= (node_secs + 2 * dent_secs +
464 reserved_sections(sbi))); 464 reserved_sections(sbi));
465} 465}
466 466
467static inline bool excess_prefree_segs(struct f2fs_sb_info *sbi) 467static inline bool excess_prefree_segs(struct f2fs_sb_info *sbi)
468{ 468{
469 return (prefree_segments(sbi) > SM_I(sbi)->rec_prefree_segments); 469 return prefree_segments(sbi) > SM_I(sbi)->rec_prefree_segments;
470} 470}
471 471
472static inline int utilization(struct f2fs_sb_info *sbi) 472static inline int utilization(struct f2fs_sb_info *sbi)
473{ 473{
474 return div_u64((u64)valid_user_blocks(sbi) * 100, sbi->user_block_count); 474 return div_u64((u64)valid_user_blocks(sbi) * 100,
475 sbi->user_block_count);
475} 476}
476 477
477/* 478/*
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index b070f3010ce9..1a85f83abd53 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -535,7 +535,8 @@ static int segment_info_seq_show(struct seq_file *seq, void *offset)
535{ 535{
536 struct super_block *sb = seq->private; 536 struct super_block *sb = seq->private;
537 struct f2fs_sb_info *sbi = F2FS_SB(sb); 537 struct f2fs_sb_info *sbi = F2FS_SB(sb);
538 unsigned int total_segs = le32_to_cpu(sbi->raw_super->segment_count_main); 538 unsigned int total_segs =
539 le32_to_cpu(sbi->raw_super->segment_count_main);
539 int i; 540 int i;
540 541
541 for (i = 0; i < total_segs; i++) { 542 for (i = 0; i < total_segs; i++) {
@@ -816,8 +817,9 @@ retry:
816 /* sanity checking of raw super */ 817 /* sanity checking of raw super */
817 if (sanity_check_raw_super(sb, *raw_super)) { 818 if (sanity_check_raw_super(sb, *raw_super)) {
818 brelse(*raw_super_buf); 819 brelse(*raw_super_buf);
819 f2fs_msg(sb, KERN_ERR, "Can't find a valid F2FS filesystem " 820 f2fs_msg(sb, KERN_ERR,
820 "in %dth superblock", block + 1); 821 "Can't find valid F2FS filesystem in %dth superblock",
822 block + 1);
821 if (block == 0) { 823 if (block == 0) {
822 block++; 824 block++;
823 goto retry; 825 goto retry;