aboutsummaryrefslogtreecommitdiffstats
path: root/fs/f2fs/checkpoint.c
diff options
context:
space:
mode:
authorJaegeuk Kim <jaegeuk.kim@samsung.com>2013-04-24 00:19:56 -0400
committerJaegeuk Kim <jaegeuk.kim@samsung.com>2013-04-25 21:35:10 -0400
commitc718379b6b0954a04a153d7e5dc8b3136a301ee6 (patch)
treeeca5d2d44291de009acb51ebc934f70de6d0ffa7 /fs/f2fs/checkpoint.c
parent6cb968d9b0358c7e807416a85699a526e820083c (diff)
f2fs: give a chance to merge IOs by IO scheduler
Previously, background GC submits many 4KB read requests to load victim blocks and/or its (i)node blocks. ... f2fs_gc : f2fs_readpage: ino = 1, page_index = 0xb61, blkaddr = 0x3b964ed f2fs_gc : block_rq_complete: 8,16 R () 499854968 + 8 [0] f2fs_gc : f2fs_readpage: ino = 1, page_index = 0xb6f, blkaddr = 0x3b964ee f2fs_gc : block_rq_complete: 8,16 R () 499854976 + 8 [0] f2fs_gc : f2fs_readpage: ino = 1, page_index = 0xb79, blkaddr = 0x3b964ef f2fs_gc : block_rq_complete: 8,16 R () 499854984 + 8 [0] ... However, by the fact that many IOs are sequential, we can give a chance to merge the IOs by IO scheduler. In order to do that, let's use blk_plug. ... f2fs_gc : f2fs_iget: ino = 143 f2fs_gc : f2fs_readpage: ino = 143, page_index = 0x1c6, blkaddr = 0x2e6ee f2fs_gc : f2fs_iget: ino = 143 f2fs_gc : f2fs_readpage: ino = 143, page_index = 0x1c7, blkaddr = 0x2e6ef <idle> : block_rq_complete: 8,16 R () 1519616 + 8 [0] <idle> : block_rq_complete: 8,16 R () 1519848 + 8 [0] <idle> : block_rq_complete: 8,16 R () 1520432 + 96 [0] <idle> : block_rq_complete: 8,16 R () 1520536 + 104 [0] <idle> : block_rq_complete: 8,16 R () 1521008 + 112 [0] <idle> : block_rq_complete: 8,16 R () 1521440 + 152 [0] <idle> : block_rq_complete: 8,16 R () 1521688 + 144 [0] <idle> : block_rq_complete: 8,16 R () 1522128 + 192 [0] <idle> : block_rq_complete: 8,16 R () 1523256 + 328 [0] ... Note that this issue should be addressed in checkpoint, and some readahead flows too. Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Diffstat (limited to 'fs/f2fs/checkpoint.c')
-rw-r--r--fs/f2fs/checkpoint.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index f54b83b4d90b..590ea50c80a7 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -549,6 +549,10 @@ static void block_operations(struct f2fs_sb_info *sbi)
549 .nr_to_write = LONG_MAX, 549 .nr_to_write = LONG_MAX,
550 .for_reclaim = 0, 550 .for_reclaim = 0,
551 }; 551 };
552 struct blk_plug plug;
553
554 blk_start_plug(&plug);
555
552retry_flush_dents: 556retry_flush_dents:
553 mutex_lock_all(sbi); 557 mutex_lock_all(sbi);
554 558
@@ -571,6 +575,7 @@ retry_flush_nodes:
571 sync_node_pages(sbi, 0, &wbc); 575 sync_node_pages(sbi, 0, &wbc);
572 goto retry_flush_nodes; 576 goto retry_flush_nodes;
573 } 577 }
578 blk_finish_plug(&plug);
574} 579}
575 580
576static void unblock_operations(struct f2fs_sb_info *sbi) 581static void unblock_operations(struct f2fs_sb_info *sbi)