aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2013-07-13 00:40:31 -0400
committerTheodore Ts'o <tytso@mit.edu>2013-07-13 00:40:31 -0400
commitbdafe42aaf72859166f784f0fad3e6b4a815fa6d (patch)
tree2d675efcf0e967f708f39ba4d38513d28cde834d /fs/ext4
parente8974c3930ae9692bb4f77380961421e9a2f76ab (diff)
ext4: fix spelling errors and a comment in extent_status tree
Replace "assertation" with "assertion" in lots and lots of debugging messages. Correct the comment stating when ext4_es_insert_extent() is used. It was no doubt tree at one point, but it is no longer true... Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: Zheng Liu <gnehzuil.liu@gmail.com>
Diffstat (limited to 'fs/ext4')
-rw-r--r--fs/ext4/extents_status.c22
-rw-r--r--fs/ext4/inode.c8
2 files changed, 14 insertions, 16 deletions
diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
index ee018d5f397e..4b8df7fbb10a 100644
--- a/fs/ext4/extents_status.c
+++ b/fs/ext4/extents_status.c
@@ -439,7 +439,7 @@ static void ext4_es_insert_extent_ext_check(struct inode *inode,
439 */ 439 */
440 if (!ext4_es_is_written(es) && !ext4_es_is_unwritten(es)) { 440 if (!ext4_es_is_written(es) && !ext4_es_is_unwritten(es)) {
441 if (in_range(es->es_lblk, ee_block, ee_len)) { 441 if (in_range(es->es_lblk, ee_block, ee_len)) {
442 pr_warn("ES insert assertation failed for " 442 pr_warn("ES insert assertion failed for "
443 "inode: %lu we can find an extent " 443 "inode: %lu we can find an extent "
444 "at block [%d/%d/%llu/%c], but we " 444 "at block [%d/%d/%llu/%c], but we "
445 "want to add an delayed/hole extent " 445 "want to add an delayed/hole extent "
@@ -458,7 +458,7 @@ static void ext4_es_insert_extent_ext_check(struct inode *inode,
458 */ 458 */
459 if (es->es_lblk < ee_block || 459 if (es->es_lblk < ee_block ||
460 ext4_es_pblock(es) != ee_start + es->es_lblk - ee_block) { 460 ext4_es_pblock(es) != ee_start + es->es_lblk - ee_block) {
461 pr_warn("ES insert assertation failed for inode: %lu " 461 pr_warn("ES insert assertion failed for inode: %lu "
462 "ex_status [%d/%d/%llu/%c] != " 462 "ex_status [%d/%d/%llu/%c] != "
463 "es_status [%d/%d/%llu/%c]\n", inode->i_ino, 463 "es_status [%d/%d/%llu/%c]\n", inode->i_ino,
464 ee_block, ee_len, ee_start, 464 ee_block, ee_len, ee_start,
@@ -468,7 +468,7 @@ static void ext4_es_insert_extent_ext_check(struct inode *inode,
468 } 468 }
469 469
470 if (ee_status ^ es_status) { 470 if (ee_status ^ es_status) {
471 pr_warn("ES insert assertation failed for inode: %lu " 471 pr_warn("ES insert assertion failed for inode: %lu "
472 "ex_status [%d/%d/%llu/%c] != " 472 "ex_status [%d/%d/%llu/%c] != "
473 "es_status [%d/%d/%llu/%c]\n", inode->i_ino, 473 "es_status [%d/%d/%llu/%c]\n", inode->i_ino,
474 ee_block, ee_len, ee_start, 474 ee_block, ee_len, ee_start,
@@ -481,7 +481,7 @@ static void ext4_es_insert_extent_ext_check(struct inode *inode,
481 * that we don't want to add an written/unwritten extent. 481 * that we don't want to add an written/unwritten extent.
482 */ 482 */
483 if (!ext4_es_is_delayed(es) && !ext4_es_is_hole(es)) { 483 if (!ext4_es_is_delayed(es) && !ext4_es_is_hole(es)) {
484 pr_warn("ES insert assertation failed for inode: %lu " 484 pr_warn("ES insert assertion failed for inode: %lu "
485 "can't find an extent at block %d but we want " 485 "can't find an extent at block %d but we want "
486 "to add an written/unwritten extent " 486 "to add an written/unwritten extent "
487 "[%d/%d/%llu/%llx]\n", inode->i_ino, 487 "[%d/%d/%llu/%llx]\n", inode->i_ino,
@@ -519,7 +519,7 @@ static void ext4_es_insert_extent_ind_check(struct inode *inode,
519 * We want to add a delayed/hole extent but this 519 * We want to add a delayed/hole extent but this
520 * block has been allocated. 520 * block has been allocated.
521 */ 521 */
522 pr_warn("ES insert assertation failed for inode: %lu " 522 pr_warn("ES insert assertion failed for inode: %lu "
523 "We can find blocks but we want to add a " 523 "We can find blocks but we want to add a "
524 "delayed/hole extent [%d/%d/%llu/%llx]\n", 524 "delayed/hole extent [%d/%d/%llu/%llx]\n",
525 inode->i_ino, es->es_lblk, es->es_len, 525 inode->i_ino, es->es_lblk, es->es_len,
@@ -527,13 +527,13 @@ static void ext4_es_insert_extent_ind_check(struct inode *inode,
527 return; 527 return;
528 } else if (ext4_es_is_written(es)) { 528 } else if (ext4_es_is_written(es)) {
529 if (retval != es->es_len) { 529 if (retval != es->es_len) {
530 pr_warn("ES insert assertation failed for " 530 pr_warn("ES insert assertion failed for "
531 "inode: %lu retval %d != es_len %d\n", 531 "inode: %lu retval %d != es_len %d\n",
532 inode->i_ino, retval, es->es_len); 532 inode->i_ino, retval, es->es_len);
533 return; 533 return;
534 } 534 }
535 if (map.m_pblk != ext4_es_pblock(es)) { 535 if (map.m_pblk != ext4_es_pblock(es)) {
536 pr_warn("ES insert assertation failed for " 536 pr_warn("ES insert assertion failed for "
537 "inode: %lu m_pblk %llu != " 537 "inode: %lu m_pblk %llu != "
538 "es_pblk %llu\n", 538 "es_pblk %llu\n",
539 inode->i_ino, map.m_pblk, 539 inode->i_ino, map.m_pblk,
@@ -549,7 +549,7 @@ static void ext4_es_insert_extent_ind_check(struct inode *inode,
549 } 549 }
550 } else if (retval == 0) { 550 } else if (retval == 0) {
551 if (ext4_es_is_written(es)) { 551 if (ext4_es_is_written(es)) {
552 pr_warn("ES insert assertation failed for inode: %lu " 552 pr_warn("ES insert assertion failed for inode: %lu "
553 "We can't find the block but we want to add " 553 "We can't find the block but we want to add "
554 "an written extent [%d/%d/%llu/%llx]\n", 554 "an written extent [%d/%d/%llu/%llx]\n",
555 inode->i_ino, es->es_lblk, es->es_len, 555 inode->i_ino, es->es_lblk, es->es_len,
@@ -632,10 +632,8 @@ out:
632} 632}
633 633
634/* 634/*
635 * ext4_es_insert_extent() adds a space to a extent status tree. 635 * ext4_es_insert_extent() adds information to an inode's extent
636 * 636 * status tree.
637 * ext4_es_insert_extent is called by ext4_da_write_begin and
638 * ext4_es_remove_extent.
639 * 637 *
640 * Return 0 on success, error code on failure. 638 * Return 0 on success, error code on failure.
641 */ 639 */
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 19a1643cbdfa..98b9bff92a8a 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -465,7 +465,7 @@ static void ext4_map_blocks_es_recheck(handle_t *handle,
465 if (es_map->m_lblk != map->m_lblk || 465 if (es_map->m_lblk != map->m_lblk ||
466 es_map->m_flags != map->m_flags || 466 es_map->m_flags != map->m_flags ||
467 es_map->m_pblk != map->m_pblk) { 467 es_map->m_pblk != map->m_pblk) {
468 printk("ES cache assertation failed for inode: %lu " 468 printk("ES cache assertion failed for inode: %lu "
469 "es_cached ex [%d/%d/%llu/%x] != " 469 "es_cached ex [%d/%d/%llu/%x] != "
470 "found ex [%d/%d/%llu/%x] retval %d flags %x\n", 470 "found ex [%d/%d/%llu/%x] retval %d flags %x\n",
471 inode->i_ino, es_map->m_lblk, es_map->m_len, 471 inode->i_ino, es_map->m_lblk, es_map->m_len,
@@ -558,7 +558,7 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
558 558
559#ifdef ES_AGGRESSIVE_TEST 559#ifdef ES_AGGRESSIVE_TEST
560 if (retval != map->m_len) { 560 if (retval != map->m_len) {
561 printk("ES len assertation failed for inode: %lu " 561 printk("ES len assertion failed for inode: %lu "
562 "retval %d != map->m_len %d " 562 "retval %d != map->m_len %d "
563 "in %s (lookup)\n", inode->i_ino, retval, 563 "in %s (lookup)\n", inode->i_ino, retval,
564 map->m_len, __func__); 564 map->m_len, __func__);
@@ -659,7 +659,7 @@ found:
659 659
660#ifdef ES_AGGRESSIVE_TEST 660#ifdef ES_AGGRESSIVE_TEST
661 if (retval != map->m_len) { 661 if (retval != map->m_len) {
662 printk("ES len assertation failed for inode: %lu " 662 printk("ES len assertion failed for inode: %lu "
663 "retval %d != map->m_len %d " 663 "retval %d != map->m_len %d "
664 "in %s (allocation)\n", inode->i_ino, retval, 664 "in %s (allocation)\n", inode->i_ino, retval,
665 map->m_len, __func__); 665 map->m_len, __func__);
@@ -1642,7 +1642,7 @@ add_delayed:
1642 1642
1643#ifdef ES_AGGRESSIVE_TEST 1643#ifdef ES_AGGRESSIVE_TEST
1644 if (retval != map->m_len) { 1644 if (retval != map->m_len) {
1645 printk("ES len assertation failed for inode: %lu " 1645 printk("ES len assertion failed for inode: %lu "
1646 "retval %d != map->m_len %d " 1646 "retval %d != map->m_len %d "
1647 "in %s (lookup)\n", inode->i_ino, retval, 1647 "in %s (lookup)\n", inode->i_ino, retval,
1648 map->m_len, __func__); 1648 map->m_len, __func__);