aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4/inline.c
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2012-12-11 03:31:49 -0500
committerTheodore Ts'o <tytso@mit.edu>2012-12-11 03:31:49 -0500
commitbd9926e80330d43f15b710c2935fa41b792d56fd (patch)
treeccc30335831784996b7435d10df39ee14e92afad /fs/ext4/inline.c
parent9a4c8019471386c6fb039ae9e30f5216b6b55a9e (diff)
ext4: zero out inline data using memset() instead of empty_zero_page
Not all architectures (in particular, sparc64) have empty_zero_page. So instead of copying from empty_zero_page, use memset to clear the inline data by signalling to ext4_xattr_set_entry() via a magic pointer value, EXT4_ZERO_ATTR_VALUE, which is defined by casting -1 to a pointer. This fixes a build failure on sparc64, and the memset() should be more efficient than using memcpy() anyway. Signed-off-by: Tao Ma <boyu.mt@taobao.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/inline.c')
-rw-r--r--fs/ext4/inline.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 53b2f65091dd..387c47c6cda9 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -268,7 +268,7 @@ static int ext4_create_inline_data(handle_t *handle,
268 goto out; 268 goto out;
269 269
270 if (len > EXT4_MIN_INLINE_DATA_SIZE) { 270 if (len > EXT4_MIN_INLINE_DATA_SIZE) {
271 value = (void *)empty_zero_page; 271 value = EXT4_ZERO_XATTR_VALUE;
272 len -= EXT4_MIN_INLINE_DATA_SIZE; 272 len -= EXT4_MIN_INLINE_DATA_SIZE;
273 } else { 273 } else {
274 value = ""; 274 value = "";