aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ext4/ialloc.c
diff options
context:
space:
mode:
authorCurt Wohlgemuth <curtw@google.com>2010-02-16 15:06:29 -0500
committerTheodore Ts'o <tytso@mit.edu>2010-02-16 15:06:29 -0500
commit73b50c1c92666d326b5fa2c945d46509f2f6d91f (patch)
tree87e2cc6fed3259a83364ede33d8f4d68173f8175 /fs/ext4/ialloc.c
parentba869023eac8354b17acdcff82b851ea8e7b1809 (diff)
ext4: Fix BUG_ON at fs/buffer.c:652 in no journal mode
Calls to ext4_handle_dirty_metadata should only pass in an inode pointer for inode-specific metadata, and not for shared metadata blocks such as inode table blocks, block group descriptors, the superblock, etc. The BUG_ON can get tripped when updating a special device (such as a block device) that is opened (so that i_mapping is set in fs/block_dev.c) and the file system is mounted in no journal mode. Addresses-Google-Bug: #2404870 Signed-off-by: Curt Wohlgemuth <curtw@google.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/ialloc.c')
-rw-r--r--fs/ext4/ialloc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index e4aaf619b56d..004c9da9e5c6 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -898,7 +898,7 @@ repeat_in_this_group:
898 BUFFER_TRACE(inode_bitmap_bh, 898 BUFFER_TRACE(inode_bitmap_bh,
899 "call ext4_handle_dirty_metadata"); 899 "call ext4_handle_dirty_metadata");
900 err = ext4_handle_dirty_metadata(handle, 900 err = ext4_handle_dirty_metadata(handle,
901 inode, 901 NULL,
902 inode_bitmap_bh); 902 inode_bitmap_bh);
903 if (err) 903 if (err)
904 goto fail; 904 goto fail;