diff options
author | Theodore Ts'o <tytso@mit.edu> | 2006-09-27 04:50:31 -0400 |
---|---|---|
committer | Steven Whitehouse <swhiteho@redhat.com> | 2006-09-28 08:32:24 -0400 |
commit | bba9dfd83587017de1c55a94c077983e0dfa0251 (patch) | |
tree | 8af76134269374850dea490ee1020cb92f4fdb9b /fs/dlm | |
parent | 185a257f2f73bcd89050ad02da5bedbc28fc43fa (diff) |
[GFS2] inode_diet: Replace inode.u.generic_ip with inode.i_private (gfs)
The following patches reduce the size of the VFS inode structure by 28 bytes
on a UP x86. (It would be more on an x86_64 system). This is a 10% reduction
in the inode size on a UP kernel that is configured in a production mode
(i.e., with no spinlock or other debugging functions enabled; if you want to
save memory taken up by in-core inodes, the first thing you should do is
disable the debugging options; they are responsible for a huge amount of bloat
in the VFS inode structure).
This patch:
The filesystem or device-specific pointer in the inode is inside a union,
which is pretty pointless given that all 30+ users of this field have been
using the void pointer. Get rid of the union and rename it to i_private, with
a comment to explain who is allowed to use the void pointer. This is just a
cleanup, but it allows us to reuse the union 'u' for something something where
the union will actually be used.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Diffstat (limited to 'fs/dlm')
-rw-r--r-- | fs/dlm/debug_fs.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/dlm/debug_fs.c b/fs/dlm/debug_fs.c index 9c3aeddc8667..ca94a837a5bb 100644 --- a/fs/dlm/debug_fs.c +++ b/fs/dlm/debug_fs.c | |||
@@ -282,7 +282,7 @@ static int rsb_open(struct inode *inode, struct file *file) | |||
282 | return ret; | 282 | return ret; |
283 | 283 | ||
284 | seq = file->private_data; | 284 | seq = file->private_data; |
285 | seq->private = inode->u.generic_ip; | 285 | seq->private = inode->i_private; |
286 | 286 | ||
287 | return 0; | 287 | return 0; |
288 | } | 288 | } |
@@ -301,7 +301,7 @@ static struct file_operations rsb_fops = { | |||
301 | 301 | ||
302 | static int waiters_open(struct inode *inode, struct file *file) | 302 | static int waiters_open(struct inode *inode, struct file *file) |
303 | { | 303 | { |
304 | file->private_data = inode->u.generic_ip; | 304 | file->private_data = inode->i_private; |
305 | return 0; | 305 | return 0; |
306 | } | 306 | } |
307 | 307 | ||