aboutsummaryrefslogtreecommitdiffstats
path: root/fs/configfs/item.c
diff options
context:
space:
mode:
authorSatyam Sharma <ssatyam@cse.iitk.ac.in>2007-06-27 06:32:14 -0400
committerMark Fasheh <mark.fasheh@oracle.com>2007-07-10 19:52:25 -0400
commit4c62b53454a83178676e5ecae6665447d363c7b4 (patch)
tree77e5ba7c4afa788500b3a5aed71577cd5d1fc397 /fs/configfs/item.c
parentb23cdde4c6240d70bb3d2e3c4046b60d6f6c8451 (diff)
configfs: misc cleanups
1. item.c:config_item_cleanup() is a private function (only called by config_item_release() in same file). However, it is spuriously exported in include/linux/configfs.h, so remove that export and make it static in item.c. Also, it is no longer exported / interface function, so no need to give comment for this function (the comment was stating obvious thing, anyway). 2. Kernel-doc comment format does not allow empty line between end of comment and start of function (declaration line). There were several such spurious empty lines in item.c, so fix them. fs/configfs/item.c | 15 +++------------ include/linux/configfs.h | 1 - 2 files changed, 3 insertions(+), 13 deletions(-) Signed-off-by: Satyam Sharma <ssatyam@cse.iitk.ac.in> Signed-off-by: Joel Becker <joel.becker@oracle.com> Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
Diffstat (limited to 'fs/configfs/item.c')
-rw-r--r--fs/configfs/item.c15
1 files changed, 3 insertions, 12 deletions
diff --git a/fs/configfs/item.c b/fs/configfs/item.c
index 24421209f854..b762bbeaa0be 100644
--- a/fs/configfs/item.c
+++ b/fs/configfs/item.c
@@ -62,7 +62,6 @@ void config_item_init(struct config_item * item)
62 * dynamically allocated string that @item->ci_name points to. 62 * dynamically allocated string that @item->ci_name points to.
63 * Otherwise, use the static @item->ci_namebuf array. 63 * Otherwise, use the static @item->ci_namebuf array.
64 */ 64 */
65
66int config_item_set_name(struct config_item * item, const char * fmt, ...) 65int config_item_set_name(struct config_item * item, const char * fmt, ...)
67{ 66{
68 int error = 0; 67 int error = 0;
@@ -139,12 +138,7 @@ struct config_item * config_item_get(struct config_item * item)
139 return item; 138 return item;
140} 139}
141 140
142/** 141static void config_item_cleanup(struct config_item * item)
143 * config_item_cleanup - free config_item resources.
144 * @item: item.
145 */
146
147void config_item_cleanup(struct config_item * item)
148{ 142{
149 struct config_item_type * t = item->ci_type; 143 struct config_item_type * t = item->ci_type;
150 struct config_group * s = item->ci_group; 144 struct config_group * s = item->ci_group;
@@ -179,12 +173,10 @@ void config_item_put(struct config_item * item)
179 kref_put(&item->ci_kref, config_item_release); 173 kref_put(&item->ci_kref, config_item_release);
180} 174}
181 175
182
183/** 176/**
184 * config_group_init - initialize a group for use 177 * config_group_init - initialize a group for use
185 * @k: group 178 * @k: group
186 */ 179 */
187
188void config_group_init(struct config_group *group) 180void config_group_init(struct config_group *group)
189{ 181{
190 config_item_init(&group->cg_item); 182 config_item_init(&group->cg_item);
@@ -201,8 +193,8 @@ void config_group_init(struct config_group *group)
201 * looking for a matching config_item. If matching item is found 193 * looking for a matching config_item. If matching item is found
202 * take a reference and return the item. 194 * take a reference and return the item.
203 */ 195 */
204 196struct config_item *config_group_find_obj(struct config_group *group,
205struct config_item * config_group_find_obj(struct config_group * group, const char * name) 197 const char * name)
206{ 198{
207 struct list_head * entry; 199 struct list_head * entry;
208 struct config_item * ret = NULL; 200 struct config_item * ret = NULL;
@@ -219,7 +211,6 @@ struct config_item * config_group_find_obj(struct config_group * group, const ch
219 return ret; 211 return ret;
220} 212}
221 213
222
223EXPORT_SYMBOL(config_item_init); 214EXPORT_SYMBOL(config_item_init);
224EXPORT_SYMBOL(config_group_init); 215EXPORT_SYMBOL(config_group_init);
225EXPORT_SYMBOL(config_item_get); 216EXPORT_SYMBOL(config_item_get);