btrfs: Use WARN_ON()'s return value in place of WARN_ON(1)

Use WARN_ON()'s return value in place of WARN_ON(1) for cleaner source
code that outputs a more descriptive warnings. Also fix the styling
warning of redundant braces that came up as a result of this fix.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Reviewed-by: Zach Brown <zab@redhat.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>

1 files changed, 1 insertions, 3 deletions

diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c
index ae8a5139e0ee..6f3848860283 100644
--- a/fs/btrfs/file-item.c
+++ b/fs/btrfs/file-item.c
@@ -849,10 +849,8 @@ insert:
         path->leave_spinning = 0;
         if (ret < 0)
                 goto fail_unlock;
-        if (ret != 0) {
-                WARN_ON(1);
+        if (WARN_ON(ret != 0))
                 goto fail_unlock;
-        }
         leaf = path->nodes[0];
 csum:
         item = btrfs_item_ptr(leaf, path->slots[0], struct btrfs_csum_item);