Merge commit 'linus/master' into sched-fixes-for-linus

1 files changed, 5 insertions, 4 deletions

diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index b25707fee2cc..0fa95b198e6e 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -256,7 +256,7 @@ create_elf_tables(struct linux_binprm *bprm, struct elfhdr *exec,
                         return -EFAULT;
                 len = strnlen_user((void __user *)p, MAX_ARG_STRLEN);
                 if (!len || len > MAX_ARG_STRLEN)
-                        return 0;
+                        return -EINVAL;
                 p += len;
         }
         if (__put_user(0, argv))
@@ -268,7 +268,7 @@ create_elf_tables(struct linux_binprm *bprm, struct elfhdr *exec,
                         return -EFAULT;
                 len = strnlen_user((void __user *)p, MAX_ARG_STRLEN);
                 if (!len || len > MAX_ARG_STRLEN)
-                        return 0;
+                        return -EINVAL;
                 p += len;
         }
         if (__put_user(0, envp))
@@ -1900,7 +1900,7 @@ static int elf_core_dump(long signr, struct pt_regs *regs, struct file *file, un
         /* alloc memory for large data structures: too large to be on stack */
         elf = kmalloc(sizeof(*elf), GFP_KERNEL);
         if (!elf)
-                goto cleanup;
+                goto out;
         
         segs = current->mm->map_count;
 #ifdef ELF_CORE_EXTRA_PHDRS
@@ -2034,8 +2034,9 @@ end_coredump:
         set_fs(fs);
 
 cleanup:
-        kfree(elf);
         free_note_info(&info);
+        kfree(elf);
+out:
         return has_dumped;
 }