aboutsummaryrefslogtreecommitdiffstats
path: root/fs/afs
diff options
context:
space:
mode:
authorPali Rohár <pali.rohar@gmail.com>2014-01-28 15:26:44 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2014-02-01 13:59:39 -0500
commit1bda2ac071cdfad217856126859bc0dc88ee6f83 (patch)
treef935d6bb989736011ccbf173e1322bd57c3afc4d /fs/afs
parent5a5e75f4714a592f31e57f248b8f5c866f278b8d (diff)
afs: proc cells and rootcell are writeable
Both proc files are writeable and used for configuring cells. But there is missing correct mode flag for writeable files. Without this patch both proc files are read only. [ It turns out they aren't really read-only, since root can write to them even if the write bit isn't set due to CAP_DAC_OVERRIDE ] Signed-off-by: Pali Rohár <pali.rohar@gmail.com> Signed-off-by: David Howells <dhowells@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/afs')
-rw-r--r--fs/afs/proc.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/afs/proc.c b/fs/afs/proc.c
index bddc5120ed40..24a905b076fd 100644
--- a/fs/afs/proc.c
+++ b/fs/afs/proc.c
@@ -130,8 +130,8 @@ int afs_proc_init(void)
130 if (!proc_afs) 130 if (!proc_afs)
131 goto error_dir; 131 goto error_dir;
132 132
133 if (!proc_create("cells", 0, proc_afs, &afs_proc_cells_fops) || 133 if (!proc_create("cells", 0644, proc_afs, &afs_proc_cells_fops) ||
134 !proc_create("rootcell", 0, proc_afs, &afs_proc_rootcell_fops)) 134 !proc_create("rootcell", 0644, proc_afs, &afs_proc_rootcell_fops))
135 goto error_tree; 135 goto error_tree;
136 136
137 _leave(" = 0"); 137 _leave(" = 0");