diff options
author | Fabian Frederick <fabf@skynet.be> | 2014-06-06 17:37:23 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-06 19:08:13 -0400 |
commit | 0c89d67016081ac40109c5ed8ca7a698805203c2 (patch) | |
tree | 4394e833d647c891281b2680da17a9378af5b33f /fs/affs | |
parent | d55875f5d52c067e2eff7536368596b4a96b3ade (diff) |
fs/affs/file.c: remove unnecessary function parameters
- affs_do_readpage_ofs is always called with from = 0 ie reading from
page->index
- File parameter is never used
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/affs')
-rw-r--r-- | fs/affs/file.c | 24 |
1 files changed, 13 insertions, 11 deletions
diff --git a/fs/affs/file.c b/fs/affs/file.c index 8669b6ecddee..fd168ef18516 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c | |||
@@ -498,34 +498,36 @@ affs_getemptyblk_ino(struct inode *inode, int block) | |||
498 | } | 498 | } |
499 | 499 | ||
500 | static int | 500 | static int |
501 | affs_do_readpage_ofs(struct file *file, struct page *page, unsigned from, unsigned to) | 501 | affs_do_readpage_ofs(struct page *page, unsigned to) |
502 | { | 502 | { |
503 | struct inode *inode = page->mapping->host; | 503 | struct inode *inode = page->mapping->host; |
504 | struct super_block *sb = inode->i_sb; | 504 | struct super_block *sb = inode->i_sb; |
505 | struct buffer_head *bh; | 505 | struct buffer_head *bh; |
506 | char *data; | 506 | char *data; |
507 | unsigned pos = 0; | ||
507 | u32 bidx, boff, bsize; | 508 | u32 bidx, boff, bsize; |
508 | u32 tmp; | 509 | u32 tmp; |
509 | 510 | ||
510 | pr_debug("AFFS: read_page(%u, %ld, %d, %d)\n", (u32)inode->i_ino, page->index, from, to); | 511 | pr_debug("AFFS: read_page(%u, %ld, 0, %d)\n", (u32)inode->i_ino, |
511 | BUG_ON(from > to || to > PAGE_CACHE_SIZE); | 512 | page->index, to); |
513 | BUG_ON(to > PAGE_CACHE_SIZE); | ||
512 | kmap(page); | 514 | kmap(page); |
513 | data = page_address(page); | 515 | data = page_address(page); |
514 | bsize = AFFS_SB(sb)->s_data_blksize; | 516 | bsize = AFFS_SB(sb)->s_data_blksize; |
515 | tmp = (page->index << PAGE_CACHE_SHIFT) + from; | 517 | tmp = page->index << PAGE_CACHE_SHIFT; |
516 | bidx = tmp / bsize; | 518 | bidx = tmp / bsize; |
517 | boff = tmp % bsize; | 519 | boff = tmp % bsize; |
518 | 520 | ||
519 | while (from < to) { | 521 | while (pos < to) { |
520 | bh = affs_bread_ino(inode, bidx, 0); | 522 | bh = affs_bread_ino(inode, bidx, 0); |
521 | if (IS_ERR(bh)) | 523 | if (IS_ERR(bh)) |
522 | return PTR_ERR(bh); | 524 | return PTR_ERR(bh); |
523 | tmp = min(bsize - boff, to - from); | 525 | tmp = min(bsize - boff, to - pos); |
524 | BUG_ON(from + tmp > to || tmp > bsize); | 526 | BUG_ON(pos + tmp > to || tmp > bsize); |
525 | memcpy(data + from, AFFS_DATA(bh) + boff, tmp); | 527 | memcpy(data + pos, AFFS_DATA(bh) + boff, tmp); |
526 | affs_brelse(bh); | 528 | affs_brelse(bh); |
527 | bidx++; | 529 | bidx++; |
528 | from += tmp; | 530 | pos += tmp; |
529 | boff = 0; | 531 | boff = 0; |
530 | } | 532 | } |
531 | flush_dcache_page(page); | 533 | flush_dcache_page(page); |
@@ -615,7 +617,7 @@ affs_readpage_ofs(struct file *file, struct page *page) | |||
615 | memset(page_address(page) + to, 0, PAGE_CACHE_SIZE - to); | 617 | memset(page_address(page) + to, 0, PAGE_CACHE_SIZE - to); |
616 | } | 618 | } |
617 | 619 | ||
618 | err = affs_do_readpage_ofs(file, page, 0, to); | 620 | err = affs_do_readpage_ofs(page, to); |
619 | if (!err) | 621 | if (!err) |
620 | SetPageUptodate(page); | 622 | SetPageUptodate(page); |
621 | unlock_page(page); | 623 | unlock_page(page); |
@@ -651,7 +653,7 @@ static int affs_write_begin_ofs(struct file *file, struct address_space *mapping | |||
651 | return 0; | 653 | return 0; |
652 | 654 | ||
653 | /* XXX: inefficient but safe in the face of short writes */ | 655 | /* XXX: inefficient but safe in the face of short writes */ |
654 | err = affs_do_readpage_ofs(file, page, 0, PAGE_CACHE_SIZE); | 656 | err = affs_do_readpage_ofs(page, PAGE_CACHE_SIZE); |
655 | if (err) { | 657 | if (err) { |
656 | unlock_page(page); | 658 | unlock_page(page); |
657 | page_cache_release(page); | 659 | page_cache_release(page); |