diff options
| author | Chris Ruffin <cmruffin@gmail.com> | 2011-01-12 19:59:38 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-01-13 11:03:08 -0500 |
| commit | b8cb464e4a8abc60ad5a43e0375fec8a3c728167 (patch) | |
| tree | 963814e8a73c5ead81be22863d880f151b991eab /firmware | |
| parent | 8369744fc4418743d3d84a8490d576e3dbf01594 (diff) | |
ihex: fix unused return value compiler warning
Fix unusued return value compiler warnings due to unchecked write() calls.
[akpm@linux-foundation.org: correctly handle short writes]
Signed-off-by: Chris Ruffin <cmruffin@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'firmware')
| -rw-r--r-- | firmware/ihex2fw.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/firmware/ihex2fw.c b/firmware/ihex2fw.c index ba0cf0b601bb..cf38e159131a 100644 --- a/firmware/ihex2fw.c +++ b/firmware/ihex2fw.c | |||
| @@ -124,8 +124,7 @@ int main(int argc, char **argv) | |||
| 124 | if (process_ihex(data, st.st_size)) | 124 | if (process_ihex(data, st.st_size)) |
| 125 | return 1; | 125 | return 1; |
| 126 | 126 | ||
| 127 | output_records(outfd); | 127 | return output_records(outfd); |
| 128 | return 0; | ||
| 129 | } | 128 | } |
| 130 | 129 | ||
| 131 | static int process_ihex(uint8_t *data, ssize_t size) | 130 | static int process_ihex(uint8_t *data, ssize_t size) |
| @@ -269,11 +268,13 @@ static int output_records(int outfd) | |||
| 269 | 268 | ||
| 270 | p->addr = htonl(p->addr); | 269 | p->addr = htonl(p->addr); |
| 271 | p->len = htons(p->len); | 270 | p->len = htons(p->len); |
| 272 | write(outfd, &p->addr, writelen); | 271 | if (write(outfd, &p->addr, writelen) != writelen) |
| 272 | return 1; | ||
| 273 | p = p->next; | 273 | p = p->next; |
| 274 | } | 274 | } |
| 275 | /* EOF record is zero length, since we don't bother to represent | 275 | /* EOF record is zero length, since we don't bother to represent |
| 276 | the type field in the binary version */ | 276 | the type field in the binary version */ |
| 277 | write(outfd, zeroes, 6); | 277 | if (write(outfd, zeroes, 6) != 6) |
| 278 | return 1; | ||
| 278 | return 0; | 279 | return 0; |
| 279 | } | 280 | } |
