diff options
| author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-06-20 19:24:02 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-06-20 19:24:02 -0400 |
| commit | ff446f2001cf9b5ed97c6256c4ee3549d3b7abed (patch) | |
| tree | ec5fd60a8b9c21ae85eaa99003f26e6c342e2234 /drivers | |
| parent | 78091dc2f6f04b03131218df590c877cadcd9379 (diff) | |
| parent | 485802a6c524e62b5924849dd727ddbb1497cc71 (diff) | |
Merge 3.5-rc3 into usb-next
This lets us catch the USB fixes that went into 3.5-rc3 into this branch,
as we want them here as well.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
115 files changed, 2821 insertions, 535 deletions
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 0bcda488f11c..c89aa01fb1de 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c | |||
| @@ -246,11 +246,11 @@ struct regmap *regmap_init(struct device *dev, | |||
| 246 | map->lock = regmap_lock_mutex; | 246 | map->lock = regmap_lock_mutex; |
| 247 | map->unlock = regmap_unlock_mutex; | 247 | map->unlock = regmap_unlock_mutex; |
| 248 | } | 248 | } |
| 249 | map->format.buf_size = (config->reg_bits + config->val_bits) / 8; | ||
| 250 | map->format.reg_bytes = DIV_ROUND_UP(config->reg_bits, 8); | 249 | map->format.reg_bytes = DIV_ROUND_UP(config->reg_bits, 8); |
| 251 | map->format.pad_bytes = config->pad_bits / 8; | 250 | map->format.pad_bytes = config->pad_bits / 8; |
| 252 | map->format.val_bytes = DIV_ROUND_UP(config->val_bits, 8); | 251 | map->format.val_bytes = DIV_ROUND_UP(config->val_bits, 8); |
| 253 | map->format.buf_size += map->format.pad_bytes; | 252 | map->format.buf_size = DIV_ROUND_UP(config->reg_bits + |
| 253 | config->val_bits + config->pad_bits, 8); | ||
| 254 | map->reg_shift = config->pad_bits % 8; | 254 | map->reg_shift = config->pad_bits % 8; |
| 255 | if (config->reg_stride) | 255 | if (config->reg_stride) |
| 256 | map->reg_stride = config->reg_stride; | 256 | map->reg_stride = config->reg_stride; |
| @@ -368,7 +368,7 @@ struct regmap *regmap_init(struct device *dev, | |||
| 368 | 368 | ||
| 369 | ret = regcache_init(map, config); | 369 | ret = regcache_init(map, config); |
| 370 | if (ret < 0) | 370 | if (ret < 0) |
| 371 | goto err_free_workbuf; | 371 | goto err_debugfs; |
| 372 | 372 | ||
| 373 | /* Add a devres resource for dev_get_regmap() */ | 373 | /* Add a devres resource for dev_get_regmap() */ |
| 374 | m = devres_alloc(dev_get_regmap_release, sizeof(*m), GFP_KERNEL); | 374 | m = devres_alloc(dev_get_regmap_release, sizeof(*m), GFP_KERNEL); |
| @@ -383,7 +383,8 @@ struct regmap *regmap_init(struct device *dev, | |||
| 383 | 383 | ||
| 384 | err_cache: | 384 | err_cache: |
| 385 | regcache_exit(map); | 385 | regcache_exit(map); |
| 386 | err_free_workbuf: | 386 | err_debugfs: |
| 387 | regmap_debugfs_exit(map); | ||
| 387 | kfree(map->work_buf); | 388 | kfree(map->work_buf); |
| 388 | err_map: | 389 | err_map: |
| 389 | kfree(map); | 390 | kfree(map); |
| @@ -471,6 +472,7 @@ int regmap_reinit_cache(struct regmap *map, const struct regmap_config *config) | |||
| 471 | 472 | ||
| 472 | return ret; | 473 | return ret; |
| 473 | } | 474 | } |
| 475 | EXPORT_SYMBOL_GPL(regmap_reinit_cache); | ||
| 474 | 476 | ||
| 475 | /** | 477 | /** |
| 476 | * regmap_exit(): Free a previously allocated register map | 478 | * regmap_exit(): Free a previously allocated register map |
diff --git a/drivers/bcma/driver_chipcommon_pmu.c b/drivers/bcma/driver_chipcommon_pmu.c index a058842f14fd..61ce4054b3c3 100644 --- a/drivers/bcma/driver_chipcommon_pmu.c +++ b/drivers/bcma/driver_chipcommon_pmu.c | |||
| @@ -139,7 +139,9 @@ void bcma_pmu_workarounds(struct bcma_drv_cc *cc) | |||
| 139 | bcma_chipco_chipctl_maskset(cc, 0, ~0, 0x7); | 139 | bcma_chipco_chipctl_maskset(cc, 0, ~0, 0x7); |
| 140 | break; | 140 | break; |
| 141 | case 0x4331: | 141 | case 0x4331: |
| 142 | /* BCM4331 workaround is SPROM-related, we put it in sprom.c */ | 142 | case 43431: |
| 143 | /* Ext PA lines must be enabled for tx on BCM4331 */ | ||
| 144 | bcma_chipco_bcm4331_ext_pa_lines_ctl(cc, true); | ||
| 143 | break; | 145 | break; |
| 144 | case 43224: | 146 | case 43224: |
| 145 | if (bus->chipinfo.rev == 0) { | 147 | if (bus->chipinfo.rev == 0) { |
diff --git a/drivers/bcma/driver_pci.c b/drivers/bcma/driver_pci.c index 9a96f14c8f47..c32ebd537abe 100644 --- a/drivers/bcma/driver_pci.c +++ b/drivers/bcma/driver_pci.c | |||
| @@ -232,17 +232,19 @@ void __devinit bcma_core_pci_init(struct bcma_drv_pci *pc) | |||
| 232 | int bcma_core_pci_irq_ctl(struct bcma_drv_pci *pc, struct bcma_device *core, | 232 | int bcma_core_pci_irq_ctl(struct bcma_drv_pci *pc, struct bcma_device *core, |
| 233 | bool enable) | 233 | bool enable) |
| 234 | { | 234 | { |
| 235 | struct pci_dev *pdev = pc->core->bus->host_pci; | 235 | struct pci_dev *pdev; |
| 236 | u32 coremask, tmp; | 236 | u32 coremask, tmp; |
| 237 | int err = 0; | 237 | int err = 0; |
| 238 | 238 | ||
| 239 | if (core->bus->hosttype != BCMA_HOSTTYPE_PCI) { | 239 | if (!pc || core->bus->hosttype != BCMA_HOSTTYPE_PCI) { |
| 240 | /* This bcma device is not on a PCI host-bus. So the IRQs are | 240 | /* This bcma device is not on a PCI host-bus. So the IRQs are |
| 241 | * not routed through the PCI core. | 241 | * not routed through the PCI core. |
| 242 | * So we must not enable routing through the PCI core. */ | 242 | * So we must not enable routing through the PCI core. */ |
| 243 | goto out; | 243 | goto out; |
| 244 | } | 244 | } |
| 245 | 245 | ||
| 246 | pdev = pc->core->bus->host_pci; | ||
| 247 | |||
| 246 | err = pci_read_config_dword(pdev, BCMA_PCI_IRQMASK, &tmp); | 248 | err = pci_read_config_dword(pdev, BCMA_PCI_IRQMASK, &tmp); |
| 247 | if (err) | 249 | if (err) |
| 248 | goto out; | 250 | goto out; |
diff --git a/drivers/bcma/sprom.c b/drivers/bcma/sprom.c index c7f93359acb0..f16f42d36071 100644 --- a/drivers/bcma/sprom.c +++ b/drivers/bcma/sprom.c | |||
| @@ -579,13 +579,13 @@ int bcma_sprom_get(struct bcma_bus *bus) | |||
| 579 | if (!sprom) | 579 | if (!sprom) |
| 580 | return -ENOMEM; | 580 | return -ENOMEM; |
| 581 | 581 | ||
| 582 | if (bus->chipinfo.id == 0x4331) | 582 | if (bus->chipinfo.id == 0x4331 || bus->chipinfo.id == 43431) |
| 583 | bcma_chipco_bcm4331_ext_pa_lines_ctl(&bus->drv_cc, false); | 583 | bcma_chipco_bcm4331_ext_pa_lines_ctl(&bus->drv_cc, false); |
| 584 | 584 | ||
| 585 | pr_debug("SPROM offset 0x%x\n", offset); | 585 | pr_debug("SPROM offset 0x%x\n", offset); |
| 586 | bcma_sprom_read(bus, offset, sprom); | 586 | bcma_sprom_read(bus, offset, sprom); |
| 587 | 587 | ||
| 588 | if (bus->chipinfo.id == 0x4331) | 588 | if (bus->chipinfo.id == 0x4331 || bus->chipinfo.id == 43431) |
| 589 | bcma_chipco_bcm4331_ext_pa_lines_ctl(&bus->drv_cc, true); | 589 | bcma_chipco_bcm4331_ext_pa_lines_ctl(&bus->drv_cc, true); |
| 590 | 590 | ||
| 591 | err = bcma_sprom_valid(sprom); | 591 | err = bcma_sprom_valid(sprom); |
diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c index f518b99f53f5..6289f0eee24c 100644 --- a/drivers/char/hw_random/atmel-rng.c +++ b/drivers/char/hw_random/atmel-rng.c | |||
| @@ -36,6 +36,13 @@ static int atmel_trng_read(struct hwrng *rng, void *buf, size_t max, | |||
| 36 | /* data ready? */ | 36 | /* data ready? */ |
| 37 | if (readl(trng->base + TRNG_ODATA) & 1) { | 37 | if (readl(trng->base + TRNG_ODATA) & 1) { |
| 38 | *data = readl(trng->base + TRNG_ODATA); | 38 | *data = readl(trng->base + TRNG_ODATA); |
| 39 | /* | ||
| 40 | ensure data ready is only set again AFTER the next data | ||
| 41 | word is ready in case it got set between checking ISR | ||
| 42 | and reading ODATA, so we don't risk re-reading the | ||
| 43 | same word | ||
| 44 | */ | ||
| 45 | readl(trng->base + TRNG_ISR); | ||
| 39 | return 4; | 46 | return 4; |
| 40 | } else | 47 | } else |
| 41 | return 0; | 48 | return 0; |
diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c index 32fe9ef5cc5c..98b06baafcc6 100644 --- a/drivers/clocksource/sh_cmt.c +++ b/drivers/clocksource/sh_cmt.c | |||
| @@ -48,13 +48,13 @@ struct sh_cmt_priv { | |||
| 48 | unsigned long next_match_value; | 48 | unsigned long next_match_value; |
| 49 | unsigned long max_match_value; | 49 | unsigned long max_match_value; |
| 50 | unsigned long rate; | 50 | unsigned long rate; |
| 51 | spinlock_t lock; | 51 | raw_spinlock_t lock; |
| 52 | struct clock_event_device ced; | 52 | struct clock_event_device ced; |
| 53 | struct clocksource cs; | 53 | struct clocksource cs; |
| 54 | unsigned long total_cycles; | 54 | unsigned long total_cycles; |
| 55 | }; | 55 | }; |
| 56 | 56 | ||
| 57 | static DEFINE_SPINLOCK(sh_cmt_lock); | 57 | static DEFINE_RAW_SPINLOCK(sh_cmt_lock); |
| 58 | 58 | ||
| 59 | #define CMSTR -1 /* shared register */ | 59 | #define CMSTR -1 /* shared register */ |
| 60 | #define CMCSR 0 /* channel register */ | 60 | #define CMCSR 0 /* channel register */ |
| @@ -139,7 +139,7 @@ static void sh_cmt_start_stop_ch(struct sh_cmt_priv *p, int start) | |||
| 139 | unsigned long flags, value; | 139 | unsigned long flags, value; |
| 140 | 140 | ||
| 141 | /* start stop register shared by multiple timer channels */ | 141 | /* start stop register shared by multiple timer channels */ |
| 142 | spin_lock_irqsave(&sh_cmt_lock, flags); | 142 | raw_spin_lock_irqsave(&sh_cmt_lock, flags); |
| 143 | value = sh_cmt_read(p, CMSTR); | 143 | value = sh_cmt_read(p, CMSTR); |
| 144 | 144 | ||
| 145 | if (start) | 145 | if (start) |
| @@ -148,7 +148,7 @@ static void sh_cmt_start_stop_ch(struct sh_cmt_priv *p, int start) | |||
| 148 | value &= ~(1 << cfg->timer_bit); | 148 | value &= ~(1 << cfg->timer_bit); |
| 149 | 149 | ||
| 150 | sh_cmt_write(p, CMSTR, value); | 150 | sh_cmt_write(p, CMSTR, value); |
| 151 | spin_unlock_irqrestore(&sh_cmt_lock, flags); | 151 | raw_spin_unlock_irqrestore(&sh_cmt_lock, flags); |
| 152 | } | 152 | } |
| 153 | 153 | ||
| 154 | static int sh_cmt_enable(struct sh_cmt_priv *p, unsigned long *rate) | 154 | static int sh_cmt_enable(struct sh_cmt_priv *p, unsigned long *rate) |
| @@ -328,9 +328,9 @@ static void sh_cmt_set_next(struct sh_cmt_priv *p, unsigned long delta) | |||
| 328 | { | 328 | { |
| 329 | unsigned long flags; | 329 | unsigned long flags; |
| 330 | 330 | ||
| 331 | spin_lock_irqsave(&p->lock, flags); | 331 | raw_spin_lock_irqsave(&p->lock, flags); |
| 332 | __sh_cmt_set_next(p, delta); | 332 | __sh_cmt_set_next(p, delta); |
| 333 | spin_unlock_irqrestore(&p->lock, flags); | 333 | raw_spin_unlock_irqrestore(&p->lock, flags); |
| 334 | } | 334 | } |
| 335 | 335 | ||
| 336 | static irqreturn_t sh_cmt_interrupt(int irq, void *dev_id) | 336 | static irqreturn_t sh_cmt_interrupt(int irq, void *dev_id) |
| @@ -385,7 +385,7 @@ static int sh_cmt_start(struct sh_cmt_priv *p, unsigned long flag) | |||
| 385 | int ret = 0; | 385 | int ret = 0; |
| 386 | unsigned long flags; | 386 | unsigned long flags; |
| 387 | 387 | ||
| 388 | spin_lock_irqsave(&p->lock, flags); | 388 | raw_spin_lock_irqsave(&p->lock, flags); |
| 389 | 389 | ||
| 390 | if (!(p->flags & (FLAG_CLOCKEVENT | FLAG_CLOCKSOURCE))) | 390 | if (!(p->flags & (FLAG_CLOCKEVENT | FLAG_CLOCKSOURCE))) |
| 391 | ret = sh_cmt_enable(p, &p->rate); | 391 | ret = sh_cmt_enable(p, &p->rate); |
| @@ -398,7 +398,7 @@ static int sh_cmt_start(struct sh_cmt_priv *p, unsigned long flag) | |||
| 398 | if ((flag == FLAG_CLOCKSOURCE) && (!(p->flags & FLAG_CLOCKEVENT))) | 398 | if ((flag == FLAG_CLOCKSOURCE) && (!(p->flags & FLAG_CLOCKEVENT))) |
| 399 | __sh_cmt_set_next(p, p->max_match_value); | 399 | __sh_cmt_set_next(p, p->max_match_value); |
| 400 | out: | 400 | out: |
| 401 | spin_unlock_irqrestore(&p->lock, flags); | 401 | raw_spin_unlock_irqrestore(&p->lock, flags); |
| 402 | 402 | ||
| 403 | return ret; | 403 | return ret; |
| 404 | } | 404 | } |
| @@ -408,7 +408,7 @@ static void sh_cmt_stop(struct sh_cmt_priv *p, unsigned long flag) | |||
| 408 | unsigned long flags; | 408 | unsigned long flags; |
| 409 | unsigned long f; | 409 | unsigned long f; |
| 410 | 410 | ||
| 411 | spin_lock_irqsave(&p->lock, flags); | 411 | raw_spin_lock_irqsave(&p->lock, flags); |
| 412 | 412 | ||
| 413 | f = p->flags & (FLAG_CLOCKEVENT | FLAG_CLOCKSOURCE); | 413 | f = p->flags & (FLAG_CLOCKEVENT | FLAG_CLOCKSOURCE); |
| 414 | p->flags &= ~flag; | 414 | p->flags &= ~flag; |
| @@ -420,7 +420,7 @@ static void sh_cmt_stop(struct sh_cmt_priv *p, unsigned long flag) | |||
| 420 | if ((flag == FLAG_CLOCKEVENT) && (p->flags & FLAG_CLOCKSOURCE)) | 420 | if ((flag == FLAG_CLOCKEVENT) && (p->flags & FLAG_CLOCKSOURCE)) |
| 421 | __sh_cmt_set_next(p, p->max_match_value); | 421 | __sh_cmt_set_next(p, p->max_match_value); |
| 422 | 422 | ||
| 423 | spin_unlock_irqrestore(&p->lock, flags); | 423 | raw_spin_unlock_irqrestore(&p->lock, flags); |
| 424 | } | 424 | } |
| 425 | 425 | ||
| 426 | static struct sh_cmt_priv *cs_to_sh_cmt(struct clocksource *cs) | 426 | static struct sh_cmt_priv *cs_to_sh_cmt(struct clocksource *cs) |
| @@ -435,13 +435,13 @@ static cycle_t sh_cmt_clocksource_read(struct clocksource *cs) | |||
| 435 | unsigned long value; | 435 | unsigned long value; |
| 436 | int has_wrapped; | 436 | int has_wrapped; |
| 437 | 437 | ||
| 438 | spin_lock_irqsave(&p->lock, flags); | 438 | raw_spin_lock_irqsave(&p->lock, flags); |
| 439 | value = p->total_cycles; | 439 | value = p->total_cycles; |
| 440 | raw = sh_cmt_get_counter(p, &has_wrapped); | 440 | raw = sh_cmt_get_counter(p, &has_wrapped); |
| 441 | 441 | ||
| 442 | if (unlikely(has_wrapped)) | 442 | if (unlikely(has_wrapped)) |
| 443 | raw += p->match_value + 1; | 443 | raw += p->match_value + 1; |
| 444 | spin_unlock_irqrestore(&p->lock, flags); | 444 | raw_spin_unlock_irqrestore(&p->lock, flags); |
| 445 | 445 | ||
| 446 | return value + raw; | 446 | return value + raw; |
| 447 | } | 447 | } |
| @@ -591,7 +591,7 @@ static int sh_cmt_register(struct sh_cmt_priv *p, char *name, | |||
| 591 | p->max_match_value = (1 << p->width) - 1; | 591 | p->max_match_value = (1 << p->width) - 1; |
| 592 | 592 | ||
| 593 | p->match_value = p->max_match_value; | 593 | p->match_value = p->max_match_value; |
| 594 | spin_lock_init(&p->lock); | 594 | raw_spin_lock_init(&p->lock); |
| 595 | 595 | ||
| 596 | if (clockevent_rating) | 596 | if (clockevent_rating) |
| 597 | sh_cmt_register_clockevent(p, name, clockevent_rating); | 597 | sh_cmt_register_clockevent(p, name, clockevent_rating); |
diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c index a2172f690418..d9b76ca64a61 100644 --- a/drivers/clocksource/sh_mtu2.c +++ b/drivers/clocksource/sh_mtu2.c | |||
| @@ -43,7 +43,7 @@ struct sh_mtu2_priv { | |||
| 43 | struct clock_event_device ced; | 43 | struct clock_event_device ced; |
| 44 | }; | 44 | }; |
| 45 | 45 | ||
| 46 | static DEFINE_SPINLOCK(sh_mtu2_lock); | 46 | static DEFINE_RAW_SPINLOCK(sh_mtu2_lock); |
| 47 | 47 | ||
| 48 | #define TSTR -1 /* shared register */ | 48 | #define TSTR -1 /* shared register */ |
| 49 | #define TCR 0 /* channel register */ | 49 | #define TCR 0 /* channel register */ |
| @@ -107,7 +107,7 @@ static void sh_mtu2_start_stop_ch(struct sh_mtu2_priv *p, int start) | |||
| 107 | unsigned long flags, value; | 107 | unsigned long flags, value; |
| 108 | 108 | ||
| 109 | /* start stop register shared by multiple timer channels */ | 109 | /* start stop register shared by multiple timer channels */ |
| 110 | spin_lock_irqsave(&sh_mtu2_lock, flags); | 110 | raw_spin_lock_irqsave(&sh_mtu2_lock, flags); |
| 111 | value = sh_mtu2_read(p, TSTR); | 111 | value = sh_mtu2_read(p, TSTR); |
| 112 | 112 | ||
| 113 | if (start) | 113 | if (start) |
| @@ -116,7 +116,7 @@ static void sh_mtu2_start_stop_ch(struct sh_mtu2_priv *p, int start) | |||
| 116 | value &= ~(1 << cfg->timer_bit); | 116 | value &= ~(1 << cfg->timer_bit); |
| 117 | 117 | ||
| 118 | sh_mtu2_write(p, TSTR, value); | 118 | sh_mtu2_write(p, TSTR, value); |
| 119 | spin_unlock_irqrestore(&sh_mtu2_lock, flags); | 119 | raw_spin_unlock_irqrestore(&sh_mtu2_lock, flags); |
| 120 | } | 120 | } |
| 121 | 121 | ||
| 122 | static int sh_mtu2_enable(struct sh_mtu2_priv *p) | 122 | static int sh_mtu2_enable(struct sh_mtu2_priv *p) |
diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c index 97f54b634be4..c1b51d49d106 100644 --- a/drivers/clocksource/sh_tmu.c +++ b/drivers/clocksource/sh_tmu.c | |||
| @@ -45,7 +45,7 @@ struct sh_tmu_priv { | |||
| 45 | struct clocksource cs; | 45 | struct clocksource cs; |
| 46 | }; | 46 | }; |
| 47 | 47 | ||
| 48 | static DEFINE_SPINLOCK(sh_tmu_lock); | 48 | static DEFINE_RAW_SPINLOCK(sh_tmu_lock); |
| 49 | 49 | ||
| 50 | #define TSTR -1 /* shared register */ | 50 | #define TSTR -1 /* shared register */ |
| 51 | #define TCOR 0 /* channel register */ | 51 | #define TCOR 0 /* channel register */ |
| @@ -95,7 +95,7 @@ static void sh_tmu_start_stop_ch(struct sh_tmu_priv *p, int start) | |||
| 95 | unsigned long flags, value; | 95 | unsigned long flags, value; |
| 96 | 96 | ||
| 97 | /* start stop register shared by multiple timer channels */ | 97 | /* start stop register shared by multiple timer channels */ |
| 98 | spin_lock_irqsave(&sh_tmu_lock, flags); | 98 | raw_spin_lock_irqsave(&sh_tmu_lock, flags); |
| 99 | value = sh_tmu_read(p, TSTR); | 99 | value = sh_tmu_read(p, TSTR); |
| 100 | 100 | ||
| 101 | if (start) | 101 | if (start) |
| @@ -104,7 +104,7 @@ static void sh_tmu_start_stop_ch(struct sh_tmu_priv *p, int start) | |||
| 104 | value &= ~(1 << cfg->timer_bit); | 104 | value &= ~(1 << cfg->timer_bit); |
| 105 | 105 | ||
| 106 | sh_tmu_write(p, TSTR, value); | 106 | sh_tmu_write(p, TSTR, value); |
| 107 | spin_unlock_irqrestore(&sh_tmu_lock, flags); | 107 | raw_spin_unlock_irqrestore(&sh_tmu_lock, flags); |
| 108 | } | 108 | } |
| 109 | 109 | ||
| 110 | static int sh_tmu_enable(struct sh_tmu_priv *p) | 110 | static int sh_tmu_enable(struct sh_tmu_priv *p) |
| @@ -245,12 +245,7 @@ static void sh_tmu_clock_event_start(struct sh_tmu_priv *p, int periodic) | |||
| 245 | 245 | ||
| 246 | sh_tmu_enable(p); | 246 | sh_tmu_enable(p); |
| 247 | 247 | ||
| 248 | /* TODO: calculate good shift from rate and counter bit width */ | 248 | clockevents_config(ced, p->rate); |
| 249 | |||
| 250 | ced->shift = 32; | ||
| 251 | ced->mult = div_sc(p->rate, NSEC_PER_SEC, ced->shift); | ||
| 252 | ced->max_delta_ns = clockevent_delta2ns(0xffffffff, ced); | ||
| 253 | ced->min_delta_ns = 5000; | ||
| 254 | 249 | ||
| 255 | if (periodic) { | 250 | if (periodic) { |
| 256 | p->periodic = (p->rate + HZ/2) / HZ; | 251 | p->periodic = (p->rate + HZ/2) / HZ; |
| @@ -323,7 +318,8 @@ static void sh_tmu_register_clockevent(struct sh_tmu_priv *p, | |||
| 323 | ced->set_mode = sh_tmu_clock_event_mode; | 318 | ced->set_mode = sh_tmu_clock_event_mode; |
| 324 | 319 | ||
| 325 | dev_info(&p->pdev->dev, "used for clock events\n"); | 320 | dev_info(&p->pdev->dev, "used for clock events\n"); |
| 326 | clockevents_register_device(ced); | 321 | |
| 322 | clockevents_config_and_register(ced, 1, 0x300, 0xffffffff); | ||
| 327 | 323 | ||
| 328 | ret = setup_irq(p->irqaction.irq, &p->irqaction); | 324 | ret = setup_irq(p->irqaction.irq, &p->irqaction); |
| 329 | if (ret) { | 325 | if (ret) { |
diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c index 4e7dd2b4843d..c16554122ccd 100644 --- a/drivers/gpu/drm/radeon/evergreen_cs.c +++ b/drivers/gpu/drm/radeon/evergreen_cs.c | |||
| @@ -52,6 +52,7 @@ struct evergreen_cs_track { | |||
| 52 | u32 cb_color_view[12]; | 52 | u32 cb_color_view[12]; |
| 53 | u32 cb_color_pitch[12]; | 53 | u32 cb_color_pitch[12]; |
| 54 | u32 cb_color_slice[12]; | 54 | u32 cb_color_slice[12]; |
| 55 | u32 cb_color_slice_idx[12]; | ||
| 55 | u32 cb_color_attrib[12]; | 56 | u32 cb_color_attrib[12]; |
| 56 | u32 cb_color_cmask_slice[8];/* unused */ | 57 | u32 cb_color_cmask_slice[8];/* unused */ |
| 57 | u32 cb_color_fmask_slice[8];/* unused */ | 58 | u32 cb_color_fmask_slice[8];/* unused */ |
| @@ -127,12 +128,14 @@ static void evergreen_cs_track_init(struct evergreen_cs_track *track) | |||
| 127 | track->cb_color_info[i] = 0; | 128 | track->cb_color_info[i] = 0; |
| 128 | track->cb_color_view[i] = 0xFFFFFFFF; | 129 | track->cb_color_view[i] = 0xFFFFFFFF; |
| 129 | track->cb_color_pitch[i] = 0; | 130 | track->cb_color_pitch[i] = 0; |
| 130 | track->cb_color_slice[i] = 0; | 131 | track->cb_color_slice[i] = 0xfffffff; |
| 132 | track->cb_color_slice_idx[i] = 0; | ||
| 131 | } | 133 | } |
| 132 | track->cb_target_mask = 0xFFFFFFFF; | 134 | track->cb_target_mask = 0xFFFFFFFF; |
| 133 | track->cb_shader_mask = 0xFFFFFFFF; | 135 | track->cb_shader_mask = 0xFFFFFFFF; |
| 134 | track->cb_dirty = true; | 136 | track->cb_dirty = true; |
| 135 | 137 | ||
| 138 | track->db_depth_slice = 0xffffffff; | ||
| 136 | track->db_depth_view = 0xFFFFC000; | 139 | track->db_depth_view = 0xFFFFC000; |
| 137 | track->db_depth_size = 0xFFFFFFFF; | 140 | track->db_depth_size = 0xFFFFFFFF; |
| 138 | track->db_depth_control = 0xFFFFFFFF; | 141 | track->db_depth_control = 0xFFFFFFFF; |
| @@ -250,10 +253,9 @@ static int evergreen_surface_check_2d(struct radeon_cs_parser *p, | |||
| 250 | { | 253 | { |
| 251 | struct evergreen_cs_track *track = p->track; | 254 | struct evergreen_cs_track *track = p->track; |
| 252 | unsigned palign, halign, tileb, slice_pt; | 255 | unsigned palign, halign, tileb, slice_pt; |
| 256 | unsigned mtile_pr, mtile_ps, mtileb; | ||
| 253 | 257 | ||
| 254 | tileb = 64 * surf->bpe * surf->nsamples; | 258 | tileb = 64 * surf->bpe * surf->nsamples; |
| 255 | palign = track->group_size / (8 * surf->bpe * surf->nsamples); | ||
| 256 | palign = MAX(8, palign); | ||
| 257 | slice_pt = 1; | 259 | slice_pt = 1; |
| 258 | if (tileb > surf->tsplit) { | 260 | if (tileb > surf->tsplit) { |
| 259 | slice_pt = tileb / surf->tsplit; | 261 | slice_pt = tileb / surf->tsplit; |
| @@ -262,7 +264,10 @@ static int evergreen_surface_check_2d(struct radeon_cs_parser *p, | |||
| 262 | /* macro tile width & height */ | 264 | /* macro tile width & height */ |
| 263 | palign = (8 * surf->bankw * track->npipes) * surf->mtilea; | 265 | palign = (8 * surf->bankw * track->npipes) * surf->mtilea; |
| 264 | halign = (8 * surf->bankh * surf->nbanks) / surf->mtilea; | 266 | halign = (8 * surf->bankh * surf->nbanks) / surf->mtilea; |
| 265 | surf->layer_size = surf->nbx * surf->nby * surf->bpe * slice_pt; | 267 | mtileb = (palign / 8) * (halign / 8) * tileb;; |
| 268 | mtile_pr = surf->nbx / palign; | ||
| 269 | mtile_ps = (mtile_pr * surf->nby) / halign; | ||
| 270 | surf->layer_size = mtile_ps * mtileb * slice_pt; | ||
| 266 | surf->base_align = (palign / 8) * (halign / 8) * tileb; | 271 | surf->base_align = (palign / 8) * (halign / 8) * tileb; |
| 267 | surf->palign = palign; | 272 | surf->palign = palign; |
| 268 | surf->halign = halign; | 273 | surf->halign = halign; |
| @@ -434,6 +439,39 @@ static int evergreen_cs_track_validate_cb(struct radeon_cs_parser *p, unsigned i | |||
| 434 | 439 | ||
| 435 | offset += surf.layer_size * mslice; | 440 | offset += surf.layer_size * mslice; |
| 436 | if (offset > radeon_bo_size(track->cb_color_bo[id])) { | 441 | if (offset > radeon_bo_size(track->cb_color_bo[id])) { |
| 442 | /* old ddx are broken they allocate bo with w*h*bpp but | ||
| 443 | * program slice with ALIGN(h, 8), catch this and patch | ||
| 444 | * command stream. | ||
| 445 | */ | ||
| 446 | if (!surf.mode) { | ||
| 447 | volatile u32 *ib = p->ib.ptr; | ||
| 448 | unsigned long tmp, nby, bsize, size, min = 0; | ||
| 449 | |||
| 450 | /* find the height the ddx wants */ | ||
| 451 | if (surf.nby > 8) { | ||
| 452 | min = surf.nby - 8; | ||
| 453 | } | ||
| 454 | bsize = radeon_bo_size(track->cb_color_bo[id]); | ||
| 455 | tmp = track->cb_color_bo_offset[id] << 8; | ||
| 456 | for (nby = surf.nby; nby > min; nby--) { | ||
| 457 | size = nby * surf.nbx * surf.bpe * surf.nsamples; | ||
| 458 | if ((tmp + size * mslice) <= bsize) { | ||
| 459 | break; | ||
| 460 | } | ||
| 461 | } | ||
| 462 | if (nby > min) { | ||
| 463 | surf.nby = nby; | ||
| 464 | slice = ((nby * surf.nbx) / 64) - 1; | ||
| 465 | if (!evergreen_surface_check(p, &surf, "cb")) { | ||
| 466 | /* check if this one works */ | ||
| 467 | tmp += surf.layer_size * mslice; | ||
| 468 | if (tmp <= bsize) { | ||
| 469 | ib[track->cb_color_slice_idx[id]] = slice; | ||
| 470 | goto old_ddx_ok; | ||
| 471 | } | ||
| 472 | } | ||
| 473 | } | ||
| 474 | } | ||
| 437 | dev_warn(p->dev, "%s:%d cb[%d] bo too small (layer size %d, " | 475 | dev_warn(p->dev, "%s:%d cb[%d] bo too small (layer size %d, " |
| 438 | "offset %d, max layer %d, bo size %ld, slice %d)\n", | 476 | "offset %d, max layer %d, bo size %ld, slice %d)\n", |
| 439 | __func__, __LINE__, id, surf.layer_size, | 477 | __func__, __LINE__, id, surf.layer_size, |
| @@ -446,6 +484,7 @@ static int evergreen_cs_track_validate_cb(struct radeon_cs_parser *p, unsigned i | |||
| 446 | surf.tsplit, surf.mtilea); | 484 | surf.tsplit, surf.mtilea); |
| 447 | return -EINVAL; | 485 | return -EINVAL; |
| 448 | } | 486 | } |
| 487 | old_ddx_ok: | ||
| 449 | 488 | ||
| 450 | return 0; | 489 | return 0; |
| 451 | } | 490 | } |
| @@ -1532,6 +1571,7 @@ static int evergreen_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx) | |||
| 1532 | case CB_COLOR7_SLICE: | 1571 | case CB_COLOR7_SLICE: |
| 1533 | tmp = (reg - CB_COLOR0_SLICE) / 0x3c; | 1572 | tmp = (reg - CB_COLOR0_SLICE) / 0x3c; |
| 1534 | track->cb_color_slice[tmp] = radeon_get_ib_value(p, idx); | 1573 | track->cb_color_slice[tmp] = radeon_get_ib_value(p, idx); |
| 1574 | track->cb_color_slice_idx[tmp] = idx; | ||
| 1535 | track->cb_dirty = true; | 1575 | track->cb_dirty = true; |
| 1536 | break; | 1576 | break; |
| 1537 | case CB_COLOR8_SLICE: | 1577 | case CB_COLOR8_SLICE: |
| @@ -1540,6 +1580,7 @@ static int evergreen_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx) | |||
| 1540 | case CB_COLOR11_SLICE: | 1580 | case CB_COLOR11_SLICE: |
| 1541 | tmp = ((reg - CB_COLOR8_SLICE) / 0x1c) + 8; | 1581 | tmp = ((reg - CB_COLOR8_SLICE) / 0x1c) + 8; |
| 1542 | track->cb_color_slice[tmp] = radeon_get_ib_value(p, idx); | 1582 | track->cb_color_slice[tmp] = radeon_get_ib_value(p, idx); |
| 1583 | track->cb_color_slice_idx[tmp] = idx; | ||
| 1543 | track->cb_dirty = true; | 1584 | track->cb_dirty = true; |
| 1544 | break; | 1585 | break; |
| 1545 | case CB_COLOR0_ATTRIB: | 1586 | case CB_COLOR0_ATTRIB: |
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index f0bb2b543b13..03e5f5df40f1 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c | |||
| @@ -57,9 +57,10 @@ | |||
| 57 | * 2.13.0 - virtual memory support, streamout | 57 | * 2.13.0 - virtual memory support, streamout |
| 58 | * 2.14.0 - add evergreen tiling informations | 58 | * 2.14.0 - add evergreen tiling informations |
| 59 | * 2.15.0 - add max_pipes query | 59 | * 2.15.0 - add max_pipes query |
| 60 | * 2.16.0 - fix evergreen 2D tiled surface calculation | ||
| 60 | */ | 61 | */ |
| 61 | #define KMS_DRIVER_MAJOR 2 | 62 | #define KMS_DRIVER_MAJOR 2 |
| 62 | #define KMS_DRIVER_MINOR 15 | 63 | #define KMS_DRIVER_MINOR 16 |
| 63 | #define KMS_DRIVER_PATCHLEVEL 0 | 64 | #define KMS_DRIVER_PATCHLEVEL 0 |
| 64 | int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags); | 65 | int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags); |
| 65 | int radeon_driver_unload_kms(struct drm_device *dev); | 66 | int radeon_driver_unload_kms(struct drm_device *dev); |
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index b67cfcaa661f..36f4b28c1b90 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c | |||
| @@ -1204,6 +1204,7 @@ int ttm_bo_init(struct ttm_bo_device *bdev, | |||
| 1204 | (*destroy)(bo); | 1204 | (*destroy)(bo); |
| 1205 | else | 1205 | else |
| 1206 | kfree(bo); | 1206 | kfree(bo); |
| 1207 | ttm_mem_global_free(mem_glob, acc_size); | ||
| 1207 | return -EINVAL; | 1208 | return -EINVAL; |
| 1208 | } | 1209 | } |
| 1209 | bo->destroy = destroy; | 1210 | bo->destroy = destroy; |
| @@ -1307,22 +1308,14 @@ int ttm_bo_create(struct ttm_bo_device *bdev, | |||
| 1307 | struct ttm_buffer_object **p_bo) | 1308 | struct ttm_buffer_object **p_bo) |
| 1308 | { | 1309 | { |
| 1309 | struct ttm_buffer_object *bo; | 1310 | struct ttm_buffer_object *bo; |
| 1310 | struct ttm_mem_global *mem_glob = bdev->glob->mem_glob; | ||
| 1311 | size_t acc_size; | 1311 | size_t acc_size; |
| 1312 | int ret; | 1312 | int ret; |
| 1313 | 1313 | ||
| 1314 | acc_size = ttm_bo_acc_size(bdev, size, sizeof(struct ttm_buffer_object)); | ||
| 1315 | ret = ttm_mem_global_alloc(mem_glob, acc_size, false, false); | ||
| 1316 | if (unlikely(ret != 0)) | ||
| 1317 | return ret; | ||
| 1318 | |||
| 1319 | bo = kzalloc(sizeof(*bo), GFP_KERNEL); | 1314 | bo = kzalloc(sizeof(*bo), GFP_KERNEL); |
| 1320 | 1315 | if (unlikely(bo == NULL)) | |
| 1321 | if (unlikely(bo == NULL)) { | ||
| 1322 | ttm_mem_global_free(mem_glob, acc_size); | ||
| 1323 | return -ENOMEM; | 1316 | return -ENOMEM; |
| 1324 | } | ||
| 1325 | 1317 | ||
| 1318 | acc_size = ttm_bo_acc_size(bdev, size, sizeof(struct ttm_buffer_object)); | ||
| 1326 | ret = ttm_bo_init(bdev, bo, size, type, placement, page_alignment, | 1319 | ret = ttm_bo_init(bdev, bo, size, type, placement, page_alignment, |
| 1327 | buffer_start, interruptible, | 1320 | buffer_start, interruptible, |
| 1328 | persistent_swap_storage, acc_size, NULL, NULL); | 1321 | persistent_swap_storage, acc_size, NULL, NULL); |
diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga/vga_switcheroo.c index 38f9534ac513..5b3c7d135dc9 100644 --- a/drivers/gpu/vga/vga_switcheroo.c +++ b/drivers/gpu/vga/vga_switcheroo.c | |||
| @@ -190,6 +190,19 @@ find_active_client(struct list_head *head) | |||
| 190 | return NULL; | 190 | return NULL; |
| 191 | } | 191 | } |
| 192 | 192 | ||
| 193 | int vga_switcheroo_get_client_state(struct pci_dev *pdev) | ||
| 194 | { | ||
| 195 | struct vga_switcheroo_client *client; | ||
| 196 | |||
| 197 | client = find_client_from_pci(&vgasr_priv.clients, pdev); | ||
| 198 | if (!client) | ||
| 199 | return VGA_SWITCHEROO_NOT_FOUND; | ||
| 200 | if (!vgasr_priv.active) | ||
| 201 | return VGA_SWITCHEROO_INIT; | ||
| 202 | return client->pwr_state; | ||
| 203 | } | ||
| 204 | EXPORT_SYMBOL(vga_switcheroo_get_client_state); | ||
| 205 | |||
| 193 | void vga_switcheroo_unregister_client(struct pci_dev *pdev) | 206 | void vga_switcheroo_unregister_client(struct pci_dev *pdev) |
| 194 | { | 207 | { |
| 195 | struct vga_switcheroo_client *client; | 208 | struct vga_switcheroo_client *client; |
| @@ -291,8 +304,6 @@ static int vga_switchto_stage1(struct vga_switcheroo_client *new_client) | |||
| 291 | vga_switchon(new_client); | 304 | vga_switchon(new_client); |
| 292 | 305 | ||
| 293 | vga_set_default_device(new_client->pdev); | 306 | vga_set_default_device(new_client->pdev); |
| 294 | set_audio_state(new_client->id, VGA_SWITCHEROO_ON); | ||
| 295 | |||
| 296 | return 0; | 307 | return 0; |
| 297 | } | 308 | } |
| 298 | 309 | ||
| @@ -308,6 +319,8 @@ static int vga_switchto_stage2(struct vga_switcheroo_client *new_client) | |||
| 308 | 319 | ||
| 309 | active->active = false; | 320 | active->active = false; |
| 310 | 321 | ||
| 322 | set_audio_state(active->id, VGA_SWITCHEROO_OFF); | ||
| 323 | |||
| 311 | if (new_client->fb_info) { | 324 | if (new_client->fb_info) { |
| 312 | struct fb_event event; | 325 | struct fb_event event; |
| 313 | event.info = new_client->fb_info; | 326 | event.info = new_client->fb_info; |
| @@ -321,11 +334,11 @@ static int vga_switchto_stage2(struct vga_switcheroo_client *new_client) | |||
| 321 | if (new_client->ops->reprobe) | 334 | if (new_client->ops->reprobe) |
| 322 | new_client->ops->reprobe(new_client->pdev); | 335 | new_client->ops->reprobe(new_client->pdev); |
| 323 | 336 | ||
| 324 | set_audio_state(active->id, VGA_SWITCHEROO_OFF); | ||
| 325 | |||
| 326 | if (active->pwr_state == VGA_SWITCHEROO_ON) | 337 | if (active->pwr_state == VGA_SWITCHEROO_ON) |
| 327 | vga_switchoff(active); | 338 | vga_switchoff(active); |
| 328 | 339 | ||
| 340 | set_audio_state(new_client->id, VGA_SWITCHEROO_ON); | ||
| 341 | |||
| 329 | new_client->active = true; | 342 | new_client->active = true; |
| 330 | return 0; | 343 | return 0; |
| 331 | } | 344 | } |
| @@ -371,8 +384,9 @@ vga_switcheroo_debugfs_write(struct file *filp, const char __user *ubuf, | |||
| 371 | /* pwr off the device not in use */ | 384 | /* pwr off the device not in use */ |
| 372 | if (strncmp(usercmd, "OFF", 3) == 0) { | 385 | if (strncmp(usercmd, "OFF", 3) == 0) { |
| 373 | list_for_each_entry(client, &vgasr_priv.clients, list) { | 386 | list_for_each_entry(client, &vgasr_priv.clients, list) { |
| 374 | if (client->active) | 387 | if (client->active || client_is_audio(client)) |
| 375 | continue; | 388 | continue; |
| 389 | set_audio_state(client->id, VGA_SWITCHEROO_OFF); | ||
| 376 | if (client->pwr_state == VGA_SWITCHEROO_ON) | 390 | if (client->pwr_state == VGA_SWITCHEROO_ON) |
| 377 | vga_switchoff(client); | 391 | vga_switchoff(client); |
| 378 | } | 392 | } |
| @@ -381,10 +395,11 @@ vga_switcheroo_debugfs_write(struct file *filp, const char __user *ubuf, | |||
| 381 | /* pwr on the device not in use */ | 395 | /* pwr on the device not in use */ |
| 382 | if (strncmp(usercmd, "ON", 2) == 0) { | 396 | if (strncmp(usercmd, "ON", 2) == 0) { |
| 383 | list_for_each_entry(client, &vgasr_priv.clients, list) { | 397 | list_for_each_entry(client, &vgasr_priv.clients, list) { |
| 384 | if (client->active) | 398 | if (client->active || client_is_audio(client)) |
| 385 | continue; | 399 | continue; |
| 386 | if (client->pwr_state == VGA_SWITCHEROO_OFF) | 400 | if (client->pwr_state == VGA_SWITCHEROO_OFF) |
| 387 | vga_switchon(client); | 401 | vga_switchon(client); |
| 402 | set_audio_state(client->id, VGA_SWITCHEROO_ON); | ||
| 388 | } | 403 | } |
| 389 | goto out; | 404 | goto out; |
| 390 | } | 405 | } |
diff --git a/drivers/ide/icside.c b/drivers/ide/icside.c index 8716066a2f2b..bcb507b0cfd4 100644 --- a/drivers/ide/icside.c +++ b/drivers/ide/icside.c | |||
| @@ -236,7 +236,7 @@ static const struct ide_port_ops icside_v6_no_dma_port_ops = { | |||
| 236 | */ | 236 | */ |
| 237 | static void icside_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive) | 237 | static void icside_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive) |
| 238 | { | 238 | { |
| 239 | unsigned long cycle_time; | 239 | unsigned long cycle_time = 0; |
| 240 | int use_dma_info = 0; | 240 | int use_dma_info = 0; |
| 241 | const u8 xfer_mode = drive->dma_mode; | 241 | const u8 xfer_mode = drive->dma_mode; |
| 242 | 242 | ||
| @@ -271,9 +271,9 @@ static void icside_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive) | |||
| 271 | 271 | ||
| 272 | ide_set_drivedata(drive, (void *)cycle_time); | 272 | ide_set_drivedata(drive, (void *)cycle_time); |
| 273 | 273 | ||
| 274 | printk("%s: %s selected (peak %dMB/s)\n", drive->name, | 274 | printk(KERN_INFO "%s: %s selected (peak %luMB/s)\n", |
| 275 | ide_xfer_verbose(xfer_mode), | 275 | drive->name, ide_xfer_verbose(xfer_mode), |
| 276 | 2000 / (unsigned long)ide_get_drivedata(drive)); | 276 | 2000 / (cycle_time ? cycle_time : (unsigned long) -1)); |
| 277 | } | 277 | } |
| 278 | 278 | ||
| 279 | static const struct ide_port_ops icside_v6_port_ops = { | 279 | static const struct ide_port_ops icside_v6_port_ops = { |
| @@ -375,8 +375,6 @@ static const struct ide_dma_ops icside_v6_dma_ops = { | |||
| 375 | .dma_test_irq = icside_dma_test_irq, | 375 | .dma_test_irq = icside_dma_test_irq, |
| 376 | .dma_lost_irq = ide_dma_lost_irq, | 376 | .dma_lost_irq = ide_dma_lost_irq, |
| 377 | }; | 377 | }; |
| 378 | #else | ||
| 379 | #define icside_v6_dma_ops NULL | ||
| 380 | #endif | 378 | #endif |
| 381 | 379 | ||
| 382 | static int icside_dma_off_init(ide_hwif_t *hwif, const struct ide_port_info *d) | 380 | static int icside_dma_off_init(ide_hwif_t *hwif, const struct ide_port_info *d) |
| @@ -456,7 +454,6 @@ err_free: | |||
| 456 | static const struct ide_port_info icside_v6_port_info __initdata = { | 454 | static const struct ide_port_info icside_v6_port_info __initdata = { |
| 457 | .init_dma = icside_dma_off_init, | 455 | .init_dma = icside_dma_off_init, |
| 458 | .port_ops = &icside_v6_no_dma_port_ops, | 456 | .port_ops = &icside_v6_no_dma_port_ops, |
| 459 | .dma_ops = &icside_v6_dma_ops, | ||
| 460 | .host_flags = IDE_HFLAG_SERIALIZE | IDE_HFLAG_MMIO, | 457 | .host_flags = IDE_HFLAG_SERIALIZE | IDE_HFLAG_MMIO, |
| 461 | .mwdma_mask = ATA_MWDMA2, | 458 | .mwdma_mask = ATA_MWDMA2, |
| 462 | .swdma_mask = ATA_SWDMA2, | 459 | .swdma_mask = ATA_SWDMA2, |
| @@ -518,11 +515,13 @@ icside_register_v6(struct icside_state *state, struct expansion_card *ec) | |||
| 518 | 515 | ||
| 519 | ecard_set_drvdata(ec, state); | 516 | ecard_set_drvdata(ec, state); |
| 520 | 517 | ||
| 518 | #ifdef CONFIG_BLK_DEV_IDEDMA_ICS | ||
| 521 | if (ec->dma != NO_DMA && !request_dma(ec->dma, DRV_NAME)) { | 519 | if (ec->dma != NO_DMA && !request_dma(ec->dma, DRV_NAME)) { |
| 522 | d.init_dma = icside_dma_init; | 520 | d.init_dma = icside_dma_init; |
| 523 | d.port_ops = &icside_v6_port_ops; | 521 | d.port_ops = &icside_v6_port_ops; |
| 524 | } else | 522 | d.dma_ops = &icside_v6_dma_ops; |
| 525 | d.dma_ops = NULL; | 523 | } |
| 524 | #endif | ||
| 526 | 525 | ||
| 527 | ret = ide_host_register(host, &d, hws); | 526 | ret = ide_host_register(host, &d, hws); |
| 528 | if (ret) | 527 | if (ret) |
diff --git a/drivers/ide/ide-cs.c b/drivers/ide/ide-cs.c index 28e344ea514c..f1e922e2479a 100644 --- a/drivers/ide/ide-cs.c +++ b/drivers/ide/ide-cs.c | |||
| @@ -167,7 +167,8 @@ static int pcmcia_check_one_config(struct pcmcia_device *pdev, void *priv_data) | |||
| 167 | { | 167 | { |
| 168 | int *is_kme = priv_data; | 168 | int *is_kme = priv_data; |
| 169 | 169 | ||
| 170 | if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) { | 170 | if ((pdev->resource[0]->flags & IO_DATA_PATH_WIDTH) |
| 171 | != IO_DATA_PATH_WIDTH_8) { | ||
| 171 | pdev->resource[0]->flags &= ~IO_DATA_PATH_WIDTH; | 172 | pdev->resource[0]->flags &= ~IO_DATA_PATH_WIDTH; |
| 172 | pdev->resource[0]->flags |= IO_DATA_PATH_WIDTH_AUTO; | 173 | pdev->resource[0]->flags |= IO_DATA_PATH_WIDTH_AUTO; |
| 173 | } | 174 | } |
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 04cb8c88d74b..12b2b55c519e 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig | |||
| @@ -379,7 +379,7 @@ config LEDS_NETXBIG | |||
| 379 | 379 | ||
| 380 | config LEDS_ASIC3 | 380 | config LEDS_ASIC3 |
| 381 | bool "LED support for the HTC ASIC3" | 381 | bool "LED support for the HTC ASIC3" |
| 382 | depends on LEDS_CLASS | 382 | depends on LEDS_CLASS=y |
| 383 | depends on MFD_ASIC3 | 383 | depends on MFD_ASIC3 |
| 384 | default y | 384 | default y |
| 385 | help | 385 | help |
| @@ -390,7 +390,7 @@ config LEDS_ASIC3 | |||
| 390 | 390 | ||
| 391 | config LEDS_RENESAS_TPU | 391 | config LEDS_RENESAS_TPU |
| 392 | bool "LED support for Renesas TPU" | 392 | bool "LED support for Renesas TPU" |
| 393 | depends on LEDS_CLASS && HAVE_CLK && GENERIC_GPIO | 393 | depends on LEDS_CLASS=y && HAVE_CLK && GENERIC_GPIO |
| 394 | help | 394 | help |
| 395 | This option enables build of the LED TPU platform driver, | 395 | This option enables build of the LED TPU platform driver, |
| 396 | suitable to drive any TPU channel on newer Renesas SoCs. | 396 | suitable to drive any TPU channel on newer Renesas SoCs. |
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 8ee92c81aec2..e663e6f413e9 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c | |||
| @@ -29,7 +29,7 @@ static void led_update_brightness(struct led_classdev *led_cdev) | |||
| 29 | led_cdev->brightness = led_cdev->brightness_get(led_cdev); | 29 | led_cdev->brightness = led_cdev->brightness_get(led_cdev); |
| 30 | } | 30 | } |
| 31 | 31 | ||
| 32 | static ssize_t led_brightness_show(struct device *dev, | 32 | static ssize_t led_brightness_show(struct device *dev, |
| 33 | struct device_attribute *attr, char *buf) | 33 | struct device_attribute *attr, char *buf) |
| 34 | { | 34 | { |
| 35 | struct led_classdev *led_cdev = dev_get_drvdata(dev); | 35 | struct led_classdev *led_cdev = dev_get_drvdata(dev); |
diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index d6860043f6f9..d65353d8d3fc 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c | |||
| @@ -44,13 +44,6 @@ static void led_set_software_blink(struct led_classdev *led_cdev, | |||
| 44 | if (!led_cdev->blink_brightness) | 44 | if (!led_cdev->blink_brightness) |
| 45 | led_cdev->blink_brightness = led_cdev->max_brightness; | 45 | led_cdev->blink_brightness = led_cdev->max_brightness; |
| 46 | 46 | ||
| 47 | if (led_get_trigger_data(led_cdev) && | ||
| 48 | delay_on == led_cdev->blink_delay_on && | ||
| 49 | delay_off == led_cdev->blink_delay_off) | ||
| 50 | return; | ||
| 51 | |||
| 52 | led_stop_software_blink(led_cdev); | ||
| 53 | |||
| 54 | led_cdev->blink_delay_on = delay_on; | 47 | led_cdev->blink_delay_on = delay_on; |
| 55 | led_cdev->blink_delay_off = delay_off; | 48 | led_cdev->blink_delay_off = delay_off; |
| 56 | 49 | ||
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 2ee8cf9e8a3b..b9c2ae62166d 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c | |||
| @@ -76,6 +76,7 @@ | |||
| 76 | #include <net/route.h> | 76 | #include <net/route.h> |
| 77 | #include <net/net_namespace.h> | 77 | #include <net/net_namespace.h> |
| 78 | #include <net/netns/generic.h> | 78 | #include <net/netns/generic.h> |
| 79 | #include <net/pkt_sched.h> | ||
| 79 | #include "bonding.h" | 80 | #include "bonding.h" |
| 80 | #include "bond_3ad.h" | 81 | #include "bond_3ad.h" |
| 81 | #include "bond_alb.h" | 82 | #include "bond_alb.h" |
| @@ -381,8 +382,6 @@ struct vlan_entry *bond_next_vlan(struct bonding *bond, struct vlan_entry *curr) | |||
| 381 | return next; | 382 | return next; |
| 382 | } | 383 | } |
| 383 | 384 | ||
| 384 | #define bond_queue_mapping(skb) (*(u16 *)((skb)->cb)) | ||
| 385 | |||
| 386 | /** | 385 | /** |
| 387 | * bond_dev_queue_xmit - Prepare skb for xmit. | 386 | * bond_dev_queue_xmit - Prepare skb for xmit. |
| 388 | * | 387 | * |
| @@ -395,7 +394,9 @@ int bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb, | |||
| 395 | { | 394 | { |
| 396 | skb->dev = slave_dev; | 395 | skb->dev = slave_dev; |
| 397 | 396 | ||
| 398 | skb->queue_mapping = bond_queue_mapping(skb); | 397 | BUILD_BUG_ON(sizeof(skb->queue_mapping) != |
| 398 | sizeof(qdisc_skb_cb(skb)->bond_queue_mapping)); | ||
| 399 | skb->queue_mapping = qdisc_skb_cb(skb)->bond_queue_mapping; | ||
| 399 | 400 | ||
| 400 | if (unlikely(netpoll_tx_running(slave_dev))) | 401 | if (unlikely(netpoll_tx_running(slave_dev))) |
| 401 | bond_netpoll_send_skb(bond_get_slave_by_dev(bond, slave_dev), skb); | 402 | bond_netpoll_send_skb(bond_get_slave_by_dev(bond, slave_dev), skb); |
| @@ -4171,7 +4172,7 @@ static u16 bond_select_queue(struct net_device *dev, struct sk_buff *skb) | |||
| 4171 | /* | 4172 | /* |
| 4172 | * Save the original txq to restore before passing to the driver | 4173 | * Save the original txq to restore before passing to the driver |
| 4173 | */ | 4174 | */ |
| 4174 | bond_queue_mapping(skb) = skb->queue_mapping; | 4175 | qdisc_skb_cb(skb)->bond_queue_mapping = skb->queue_mapping; |
| 4175 | 4176 | ||
| 4176 | if (unlikely(txq >= dev->real_num_tx_queues)) { | 4177 | if (unlikely(txq >= dev->real_num_tx_queues)) { |
| 4177 | do { | 4178 | do { |
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c index aef42f045320..485bedb8278c 100644 --- a/drivers/net/bonding/bond_sysfs.c +++ b/drivers/net/bonding/bond_sysfs.c | |||
| @@ -1082,8 +1082,12 @@ static ssize_t bonding_store_primary(struct device *d, | |||
| 1082 | } | 1082 | } |
| 1083 | } | 1083 | } |
| 1084 | 1084 | ||
| 1085 | pr_info("%s: Unable to set %.*s as primary slave.\n", | 1085 | strncpy(bond->params.primary, ifname, IFNAMSIZ); |
| 1086 | bond->dev->name, (int)strlen(buf) - 1, buf); | 1086 | bond->params.primary[IFNAMSIZ - 1] = 0; |
| 1087 | |||
| 1088 | pr_info("%s: Recording %s as primary, " | ||
| 1089 | "but it has not been enslaved to %s yet.\n", | ||
| 1090 | bond->dev->name, ifname, bond->dev->name); | ||
| 1087 | out: | 1091 | out: |
| 1088 | write_unlock_bh(&bond->curr_slave_lock); | 1092 | write_unlock_bh(&bond->curr_slave_lock); |
| 1089 | read_unlock(&bond->lock); | 1093 | read_unlock(&bond->lock); |
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c index 536bda072a16..8dc84d66eea1 100644 --- a/drivers/net/can/c_can/c_can.c +++ b/drivers/net/can/c_can/c_can.c | |||
| @@ -686,7 +686,7 @@ static int c_can_get_berr_counter(const struct net_device *dev, | |||
| 686 | * | 686 | * |
| 687 | * We iterate from priv->tx_echo to priv->tx_next and check if the | 687 | * We iterate from priv->tx_echo to priv->tx_next and check if the |
| 688 | * packet has been transmitted, echo it back to the CAN framework. | 688 | * packet has been transmitted, echo it back to the CAN framework. |
| 689 | * If we discover a not yet transmitted package, stop looking for more. | 689 | * If we discover a not yet transmitted packet, stop looking for more. |
| 690 | */ | 690 | */ |
| 691 | static void c_can_do_tx(struct net_device *dev) | 691 | static void c_can_do_tx(struct net_device *dev) |
| 692 | { | 692 | { |
| @@ -698,7 +698,7 @@ static void c_can_do_tx(struct net_device *dev) | |||
| 698 | for (/* nix */; (priv->tx_next - priv->tx_echo) > 0; priv->tx_echo++) { | 698 | for (/* nix */; (priv->tx_next - priv->tx_echo) > 0; priv->tx_echo++) { |
| 699 | msg_obj_no = get_tx_echo_msg_obj(priv); | 699 | msg_obj_no = get_tx_echo_msg_obj(priv); |
| 700 | val = c_can_read_reg32(priv, &priv->regs->txrqst1); | 700 | val = c_can_read_reg32(priv, &priv->regs->txrqst1); |
| 701 | if (!(val & (1 << msg_obj_no))) { | 701 | if (!(val & (1 << (msg_obj_no - 1)))) { |
| 702 | can_get_echo_skb(dev, | 702 | can_get_echo_skb(dev, |
| 703 | msg_obj_no - C_CAN_MSG_OBJ_TX_FIRST); | 703 | msg_obj_no - C_CAN_MSG_OBJ_TX_FIRST); |
| 704 | stats->tx_bytes += priv->read_reg(priv, | 704 | stats->tx_bytes += priv->read_reg(priv, |
| @@ -706,6 +706,8 @@ static void c_can_do_tx(struct net_device *dev) | |||
| 706 | & IF_MCONT_DLC_MASK; | 706 | & IF_MCONT_DLC_MASK; |
| 707 | stats->tx_packets++; | 707 | stats->tx_packets++; |
| 708 | c_can_inval_msg_object(dev, 0, msg_obj_no); | 708 | c_can_inval_msg_object(dev, 0, msg_obj_no); |
| 709 | } else { | ||
| 710 | break; | ||
| 709 | } | 711 | } |
| 710 | } | 712 | } |
| 711 | 713 | ||
| @@ -950,7 +952,7 @@ static int c_can_poll(struct napi_struct *napi, int quota) | |||
| 950 | struct net_device *dev = napi->dev; | 952 | struct net_device *dev = napi->dev; |
| 951 | struct c_can_priv *priv = netdev_priv(dev); | 953 | struct c_can_priv *priv = netdev_priv(dev); |
| 952 | 954 | ||
| 953 | irqstatus = priv->read_reg(priv, &priv->regs->interrupt); | 955 | irqstatus = priv->irqstatus; |
| 954 | if (!irqstatus) | 956 | if (!irqstatus) |
| 955 | goto end; | 957 | goto end; |
| 956 | 958 | ||
| @@ -1028,12 +1030,11 @@ end: | |||
| 1028 | 1030 | ||
| 1029 | static irqreturn_t c_can_isr(int irq, void *dev_id) | 1031 | static irqreturn_t c_can_isr(int irq, void *dev_id) |
| 1030 | { | 1032 | { |
| 1031 | u16 irqstatus; | ||
| 1032 | struct net_device *dev = (struct net_device *)dev_id; | 1033 | struct net_device *dev = (struct net_device *)dev_id; |
| 1033 | struct c_can_priv *priv = netdev_priv(dev); | 1034 | struct c_can_priv *priv = netdev_priv(dev); |
| 1034 | 1035 | ||
| 1035 | irqstatus = priv->read_reg(priv, &priv->regs->interrupt); | 1036 | priv->irqstatus = priv->read_reg(priv, &priv->regs->interrupt); |
| 1036 | if (!irqstatus) | 1037 | if (!priv->irqstatus) |
| 1037 | return IRQ_NONE; | 1038 | return IRQ_NONE; |
| 1038 | 1039 | ||
| 1039 | /* disable all interrupts and schedule the NAPI */ | 1040 | /* disable all interrupts and schedule the NAPI */ |
| @@ -1063,10 +1064,11 @@ static int c_can_open(struct net_device *dev) | |||
| 1063 | goto exit_irq_fail; | 1064 | goto exit_irq_fail; |
| 1064 | } | 1065 | } |
| 1065 | 1066 | ||
| 1067 | napi_enable(&priv->napi); | ||
| 1068 | |||
| 1066 | /* start the c_can controller */ | 1069 | /* start the c_can controller */ |
| 1067 | c_can_start(dev); | 1070 | c_can_start(dev); |
| 1068 | 1071 | ||
| 1069 | napi_enable(&priv->napi); | ||
| 1070 | netif_start_queue(dev); | 1072 | netif_start_queue(dev); |
| 1071 | 1073 | ||
| 1072 | return 0; | 1074 | return 0; |
diff --git a/drivers/net/can/c_can/c_can.h b/drivers/net/can/c_can/c_can.h index 9b7fbef3d09a..5f32d34af507 100644 --- a/drivers/net/can/c_can/c_can.h +++ b/drivers/net/can/c_can/c_can.h | |||
| @@ -76,6 +76,7 @@ struct c_can_priv { | |||
| 76 | unsigned int tx_next; | 76 | unsigned int tx_next; |
| 77 | unsigned int tx_echo; | 77 | unsigned int tx_echo; |
| 78 | void *priv; /* for board-specific data */ | 78 | void *priv; /* for board-specific data */ |
| 79 | u16 irqstatus; | ||
| 79 | }; | 80 | }; |
| 80 | 81 | ||
| 81 | struct net_device *alloc_c_can_dev(void); | 82 | struct net_device *alloc_c_can_dev(void); |
diff --git a/drivers/net/can/cc770/cc770_platform.c b/drivers/net/can/cc770/cc770_platform.c index 53115eee8075..688371cda37a 100644 --- a/drivers/net/can/cc770/cc770_platform.c +++ b/drivers/net/can/cc770/cc770_platform.c | |||
| @@ -154,7 +154,7 @@ static int __devinit cc770_get_platform_data(struct platform_device *pdev, | |||
| 154 | struct cc770_platform_data *pdata = pdev->dev.platform_data; | 154 | struct cc770_platform_data *pdata = pdev->dev.platform_data; |
| 155 | 155 | ||
| 156 | priv->can.clock.freq = pdata->osc_freq; | 156 | priv->can.clock.freq = pdata->osc_freq; |
| 157 | if (priv->cpu_interface | CPUIF_DSC) | 157 | if (priv->cpu_interface & CPUIF_DSC) |
| 158 | priv->can.clock.freq /= 2; | 158 | priv->can.clock.freq /= 2; |
| 159 | priv->clkout = pdata->cor; | 159 | priv->clkout = pdata->cor; |
| 160 | priv->bus_config = pdata->bcr; | 160 | priv->bus_config = pdata->bcr; |
diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c index 442d91a2747b..bab0158f1cc3 100644 --- a/drivers/net/dummy.c +++ b/drivers/net/dummy.c | |||
| @@ -187,8 +187,10 @@ static int __init dummy_init_module(void) | |||
| 187 | rtnl_lock(); | 187 | rtnl_lock(); |
| 188 | err = __rtnl_link_register(&dummy_link_ops); | 188 | err = __rtnl_link_register(&dummy_link_ops); |
| 189 | 189 | ||
| 190 | for (i = 0; i < numdummies && !err; i++) | 190 | for (i = 0; i < numdummies && !err; i++) { |
| 191 | err = dummy_init_one(); | 191 | err = dummy_init_one(); |
| 192 | cond_resched(); | ||
| 193 | } | ||
| 192 | if (err < 0) | 194 | if (err < 0) |
| 193 | __rtnl_link_unregister(&dummy_link_ops); | 195 | __rtnl_link_unregister(&dummy_link_ops); |
| 194 | rtnl_unlock(); | 196 | rtnl_unlock(); |
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h index e30e2a2f354c..7de824184979 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | |||
| @@ -747,21 +747,6 @@ struct bnx2x_fastpath { | |||
| 747 | 747 | ||
| 748 | #define ETH_RX_ERROR_FALGS ETH_FAST_PATH_RX_CQE_PHY_DECODE_ERR_FLG | 748 | #define ETH_RX_ERROR_FALGS ETH_FAST_PATH_RX_CQE_PHY_DECODE_ERR_FLG |
| 749 | 749 | ||
| 750 | #define BNX2X_IP_CSUM_ERR(cqe) \ | ||
| 751 | (!((cqe)->fast_path_cqe.status_flags & \ | ||
| 752 | ETH_FAST_PATH_RX_CQE_IP_XSUM_NO_VALIDATION_FLG) && \ | ||
| 753 | ((cqe)->fast_path_cqe.type_error_flags & \ | ||
| 754 | ETH_FAST_PATH_RX_CQE_IP_BAD_XSUM_FLG)) | ||
| 755 | |||
| 756 | #define BNX2X_L4_CSUM_ERR(cqe) \ | ||
| 757 | (!((cqe)->fast_path_cqe.status_flags & \ | ||
| 758 | ETH_FAST_PATH_RX_CQE_L4_XSUM_NO_VALIDATION_FLG) && \ | ||
| 759 | ((cqe)->fast_path_cqe.type_error_flags & \ | ||
| 760 | ETH_FAST_PATH_RX_CQE_L4_BAD_XSUM_FLG)) | ||
| 761 | |||
| 762 | #define BNX2X_RX_CSUM_OK(cqe) \ | ||
| 763 | (!(BNX2X_L4_CSUM_ERR(cqe) || BNX2X_IP_CSUM_ERR(cqe))) | ||
| 764 | |||
| 765 | #define BNX2X_PRS_FLAG_OVERETH_IPV4(flags) \ | 750 | #define BNX2X_PRS_FLAG_OVERETH_IPV4(flags) \ |
| 766 | (((le16_to_cpu(flags) & \ | 751 | (((le16_to_cpu(flags) & \ |
| 767 | PARSING_FLAGS_OVER_ETHERNET_PROTOCOL) >> \ | 752 | PARSING_FLAGS_OVER_ETHERNET_PROTOCOL) >> \ |
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index ad0743bf4bde..cbc56f274e0c 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | |||
| @@ -617,6 +617,25 @@ static int bnx2x_alloc_rx_data(struct bnx2x *bp, | |||
| 617 | return 0; | 617 | return 0; |
| 618 | } | 618 | } |
| 619 | 619 | ||
| 620 | static void bnx2x_csum_validate(struct sk_buff *skb, union eth_rx_cqe *cqe, | ||
| 621 | struct bnx2x_fastpath *fp) | ||
| 622 | { | ||
| 623 | /* Do nothing if no IP/L4 csum validation was done */ | ||
| 624 | |||
| 625 | if (cqe->fast_path_cqe.status_flags & | ||
| 626 | (ETH_FAST_PATH_RX_CQE_IP_XSUM_NO_VALIDATION_FLG | | ||
| 627 | ETH_FAST_PATH_RX_CQE_L4_XSUM_NO_VALIDATION_FLG)) | ||
| 628 | return; | ||
| 629 | |||
| 630 | /* If both IP/L4 validation were done, check if an error was found. */ | ||
| 631 | |||
| 632 | if (cqe->fast_path_cqe.type_error_flags & | ||
| 633 | (ETH_FAST_PATH_RX_CQE_IP_BAD_XSUM_FLG | | ||
| 634 | ETH_FAST_PATH_RX_CQE_L4_BAD_XSUM_FLG)) | ||
| 635 | fp->eth_q_stats.hw_csum_err++; | ||
| 636 | else | ||
| 637 | skb->ip_summed = CHECKSUM_UNNECESSARY; | ||
| 638 | } | ||
| 620 | 639 | ||
| 621 | int bnx2x_rx_int(struct bnx2x_fastpath *fp, int budget) | 640 | int bnx2x_rx_int(struct bnx2x_fastpath *fp, int budget) |
| 622 | { | 641 | { |
| @@ -806,13 +825,9 @@ reuse_rx: | |||
| 806 | 825 | ||
| 807 | skb_checksum_none_assert(skb); | 826 | skb_checksum_none_assert(skb); |
| 808 | 827 | ||
| 809 | if (bp->dev->features & NETIF_F_RXCSUM) { | 828 | if (bp->dev->features & NETIF_F_RXCSUM) |
| 829 | bnx2x_csum_validate(skb, cqe, fp); | ||
| 810 | 830 | ||
| 811 | if (likely(BNX2X_RX_CSUM_OK(cqe))) | ||
| 812 | skb->ip_summed = CHECKSUM_UNNECESSARY; | ||
| 813 | else | ||
| 814 | fp->eth_q_stats.hw_csum_err++; | ||
| 815 | } | ||
| 816 | 831 | ||
| 817 | skb_record_rx_queue(skb, fp->rx_queue); | 832 | skb_record_rx_queue(skb, fp->rx_queue); |
| 818 | 833 | ||
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index edeeb516807a..e47ff8be1d7b 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c | |||
| @@ -14275,7 +14275,8 @@ static int __devinit tg3_get_invariants(struct tg3 *tp) | |||
| 14275 | } | 14275 | } |
| 14276 | } | 14276 | } |
| 14277 | 14277 | ||
| 14278 | if (tg3_flag(tp, 5755_PLUS)) | 14278 | if (tg3_flag(tp, 5755_PLUS) || |
| 14279 | GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906) | ||
| 14279 | tg3_flag_set(tp, SHORT_DMA_BUG); | 14280 | tg3_flag_set(tp, SHORT_DMA_BUG); |
| 14280 | 14281 | ||
| 14281 | if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) | 14282 | if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5719) |
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 08efd308d78a..fdb50cec6b51 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c | |||
| @@ -736,6 +736,8 @@ static netdev_tx_t be_xmit(struct sk_buff *skb, | |||
| 736 | 736 | ||
| 737 | copied = make_tx_wrbs(adapter, txq, skb, wrb_cnt, dummy_wrb); | 737 | copied = make_tx_wrbs(adapter, txq, skb, wrb_cnt, dummy_wrb); |
| 738 | if (copied) { | 738 | if (copied) { |
| 739 | int gso_segs = skb_shinfo(skb)->gso_segs; | ||
| 740 | |||
| 739 | /* record the sent skb in the sent_skb table */ | 741 | /* record the sent skb in the sent_skb table */ |
| 740 | BUG_ON(txo->sent_skb_list[start]); | 742 | BUG_ON(txo->sent_skb_list[start]); |
| 741 | txo->sent_skb_list[start] = skb; | 743 | txo->sent_skb_list[start] = skb; |
| @@ -753,8 +755,7 @@ static netdev_tx_t be_xmit(struct sk_buff *skb, | |||
| 753 | 755 | ||
| 754 | be_txq_notify(adapter, txq->id, wrb_cnt); | 756 | be_txq_notify(adapter, txq->id, wrb_cnt); |
| 755 | 757 | ||
| 756 | be_tx_stats_update(txo, wrb_cnt, copied, | 758 | be_tx_stats_update(txo, wrb_cnt, copied, gso_segs, stopped); |
| 757 | skb_shinfo(skb)->gso_segs, stopped); | ||
| 758 | } else { | 759 | } else { |
| 759 | txq->head = start; | 760 | txq->head = start; |
| 760 | dev_kfree_skb_any(skb); | 761 | dev_kfree_skb_any(skb); |
diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index d863075df7a4..905e2147d918 100644 --- a/drivers/net/ethernet/intel/e1000e/ethtool.c +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c | |||
| @@ -258,7 +258,8 @@ static int e1000_set_settings(struct net_device *netdev, | |||
| 258 | * When SoL/IDER sessions are active, autoneg/speed/duplex | 258 | * When SoL/IDER sessions are active, autoneg/speed/duplex |
| 259 | * cannot be changed | 259 | * cannot be changed |
| 260 | */ | 260 | */ |
| 261 | if (hw->phy.ops.check_reset_block(hw)) { | 261 | if (hw->phy.ops.check_reset_block && |
| 262 | hw->phy.ops.check_reset_block(hw)) { | ||
| 262 | e_err("Cannot change link characteristics when SoL/IDER is active.\n"); | 263 | e_err("Cannot change link characteristics when SoL/IDER is active.\n"); |
| 263 | return -EINVAL; | 264 | return -EINVAL; |
| 264 | } | 265 | } |
| @@ -1615,7 +1616,8 @@ static int e1000_loopback_test(struct e1000_adapter *adapter, u64 *data) | |||
| 1615 | * PHY loopback cannot be performed if SoL/IDER | 1616 | * PHY loopback cannot be performed if SoL/IDER |
| 1616 | * sessions are active | 1617 | * sessions are active |
| 1617 | */ | 1618 | */ |
| 1618 | if (hw->phy.ops.check_reset_block(hw)) { | 1619 | if (hw->phy.ops.check_reset_block && |
| 1620 | hw->phy.ops.check_reset_block(hw)) { | ||
| 1619 | e_err("Cannot do PHY loopback test when SoL/IDER is active.\n"); | 1621 | e_err("Cannot do PHY loopback test when SoL/IDER is active.\n"); |
| 1620 | *data = 0; | 1622 | *data = 0; |
| 1621 | goto out; | 1623 | goto out; |
diff --git a/drivers/net/ethernet/intel/e1000e/mac.c b/drivers/net/ethernet/intel/e1000e/mac.c index 026e8b3ab52e..a13439928488 100644 --- a/drivers/net/ethernet/intel/e1000e/mac.c +++ b/drivers/net/ethernet/intel/e1000e/mac.c | |||
| @@ -709,7 +709,7 @@ s32 e1000e_setup_link_generic(struct e1000_hw *hw) | |||
| 709 | * In the case of the phy reset being blocked, we already have a link. | 709 | * In the case of the phy reset being blocked, we already have a link. |
| 710 | * We do not need to set it up again. | 710 | * We do not need to set it up again. |
| 711 | */ | 711 | */ |
| 712 | if (hw->phy.ops.check_reset_block(hw)) | 712 | if (hw->phy.ops.check_reset_block && hw->phy.ops.check_reset_block(hw)) |
| 713 | return 0; | 713 | return 0; |
| 714 | 714 | ||
| 715 | /* | 715 | /* |
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index a4b0435b00dc..31d37a2b5ba8 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c | |||
| @@ -6237,7 +6237,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev, | |||
| 6237 | adapter->hw.phy.ms_type = e1000_ms_hw_default; | 6237 | adapter->hw.phy.ms_type = e1000_ms_hw_default; |
| 6238 | } | 6238 | } |
| 6239 | 6239 | ||
| 6240 | if (hw->phy.ops.check_reset_block(hw)) | 6240 | if (hw->phy.ops.check_reset_block && hw->phy.ops.check_reset_block(hw)) |
| 6241 | e_info("PHY reset is blocked due to SOL/IDER session.\n"); | 6241 | e_info("PHY reset is blocked due to SOL/IDER session.\n"); |
| 6242 | 6242 | ||
| 6243 | /* Set initial default active device features */ | 6243 | /* Set initial default active device features */ |
| @@ -6404,7 +6404,7 @@ err_register: | |||
| 6404 | if (!(adapter->flags & FLAG_HAS_AMT)) | 6404 | if (!(adapter->flags & FLAG_HAS_AMT)) |
| 6405 | e1000e_release_hw_control(adapter); | 6405 | e1000e_release_hw_control(adapter); |
| 6406 | err_eeprom: | 6406 | err_eeprom: |
| 6407 | if (!hw->phy.ops.check_reset_block(hw)) | 6407 | if (hw->phy.ops.check_reset_block && !hw->phy.ops.check_reset_block(hw)) |
| 6408 | e1000_phy_hw_reset(&adapter->hw); | 6408 | e1000_phy_hw_reset(&adapter->hw); |
| 6409 | err_hw_init: | 6409 | err_hw_init: |
| 6410 | kfree(adapter->tx_ring); | 6410 | kfree(adapter->tx_ring); |
diff --git a/drivers/net/ethernet/intel/e1000e/phy.c b/drivers/net/ethernet/intel/e1000e/phy.c index 0334d013bc3c..b860d4f7ea2a 100644 --- a/drivers/net/ethernet/intel/e1000e/phy.c +++ b/drivers/net/ethernet/intel/e1000e/phy.c | |||
| @@ -2155,9 +2155,11 @@ s32 e1000e_phy_hw_reset_generic(struct e1000_hw *hw) | |||
| 2155 | s32 ret_val; | 2155 | s32 ret_val; |
| 2156 | u32 ctrl; | 2156 | u32 ctrl; |
| 2157 | 2157 | ||
| 2158 | ret_val = phy->ops.check_reset_block(hw); | 2158 | if (phy->ops.check_reset_block) { |
| 2159 | if (ret_val) | 2159 | ret_val = phy->ops.check_reset_block(hw); |
| 2160 | return 0; | 2160 | if (ret_val) |
| 2161 | return 0; | ||
| 2162 | } | ||
| 2161 | 2163 | ||
| 2162 | ret_val = phy->ops.acquire(hw); | 2164 | ret_val = phy->ops.acquire(hw); |
| 2163 | if (ret_val) | 2165 | if (ret_val) |
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index bf20457ea23a..17ad6a3c1be1 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | |||
| @@ -1390,6 +1390,8 @@ static void ixgbe_process_skb_fields(struct ixgbe_ring *rx_ring, | |||
| 1390 | union ixgbe_adv_rx_desc *rx_desc, | 1390 | union ixgbe_adv_rx_desc *rx_desc, |
| 1391 | struct sk_buff *skb) | 1391 | struct sk_buff *skb) |
| 1392 | { | 1392 | { |
| 1393 | struct net_device *dev = rx_ring->netdev; | ||
| 1394 | |||
| 1393 | ixgbe_update_rsc_stats(rx_ring, skb); | 1395 | ixgbe_update_rsc_stats(rx_ring, skb); |
| 1394 | 1396 | ||
| 1395 | ixgbe_rx_hash(rx_ring, rx_desc, skb); | 1397 | ixgbe_rx_hash(rx_ring, rx_desc, skb); |
| @@ -1401,14 +1403,15 @@ static void ixgbe_process_skb_fields(struct ixgbe_ring *rx_ring, | |||
| 1401 | ixgbe_ptp_rx_hwtstamp(rx_ring->q_vector, skb); | 1403 | ixgbe_ptp_rx_hwtstamp(rx_ring->q_vector, skb); |
| 1402 | #endif | 1404 | #endif |
| 1403 | 1405 | ||
| 1404 | if (ixgbe_test_staterr(rx_desc, IXGBE_RXD_STAT_VP)) { | 1406 | if ((dev->features & NETIF_F_HW_VLAN_RX) && |
| 1407 | ixgbe_test_staterr(rx_desc, IXGBE_RXD_STAT_VP)) { | ||
| 1405 | u16 vid = le16_to_cpu(rx_desc->wb.upper.vlan); | 1408 | u16 vid = le16_to_cpu(rx_desc->wb.upper.vlan); |
| 1406 | __vlan_hwaccel_put_tag(skb, vid); | 1409 | __vlan_hwaccel_put_tag(skb, vid); |
| 1407 | } | 1410 | } |
| 1408 | 1411 | ||
| 1409 | skb_record_rx_queue(skb, rx_ring->queue_index); | 1412 | skb_record_rx_queue(skb, rx_ring->queue_index); |
| 1410 | 1413 | ||
| 1411 | skb->protocol = eth_type_trans(skb, rx_ring->netdev); | 1414 | skb->protocol = eth_type_trans(skb, dev); |
| 1412 | } | 1415 | } |
| 1413 | 1416 | ||
| 1414 | static void ixgbe_rx_skb(struct ixgbe_q_vector *q_vector, | 1417 | static void ixgbe_rx_skb(struct ixgbe_q_vector *q_vector, |
| @@ -3607,10 +3610,6 @@ static void ixgbe_configure_dcb(struct ixgbe_adapter *adapter) | |||
| 3607 | if (hw->mac.type == ixgbe_mac_82598EB) | 3610 | if (hw->mac.type == ixgbe_mac_82598EB) |
| 3608 | netif_set_gso_max_size(adapter->netdev, 32768); | 3611 | netif_set_gso_max_size(adapter->netdev, 32768); |
| 3609 | 3612 | ||
| 3610 | |||
| 3611 | /* Enable VLAN tag insert/strip */ | ||
| 3612 | adapter->netdev->features |= NETIF_F_HW_VLAN_RX; | ||
| 3613 | |||
| 3614 | hw->mac.ops.set_vfta(&adapter->hw, 0, 0, true); | 3613 | hw->mac.ops.set_vfta(&adapter->hw, 0, 0, true); |
| 3615 | 3614 | ||
| 3616 | #ifdef IXGBE_FCOE | 3615 | #ifdef IXGBE_FCOE |
| @@ -6701,11 +6700,6 @@ static netdev_features_t ixgbe_fix_features(struct net_device *netdev, | |||
| 6701 | { | 6700 | { |
| 6702 | struct ixgbe_adapter *adapter = netdev_priv(netdev); | 6701 | struct ixgbe_adapter *adapter = netdev_priv(netdev); |
| 6703 | 6702 | ||
| 6704 | #ifdef CONFIG_DCB | ||
| 6705 | if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) | ||
| 6706 | features &= ~NETIF_F_HW_VLAN_RX; | ||
| 6707 | #endif | ||
| 6708 | |||
| 6709 | /* return error if RXHASH is being enabled when RSS is not supported */ | 6703 | /* return error if RXHASH is being enabled when RSS is not supported */ |
| 6710 | if (!(adapter->flags & IXGBE_FLAG_RSS_ENABLED)) | 6704 | if (!(adapter->flags & IXGBE_FLAG_RSS_ENABLED)) |
| 6711 | features &= ~NETIF_F_RXHASH; | 6705 | features &= ~NETIF_F_RXHASH; |
| @@ -6718,7 +6712,6 @@ static netdev_features_t ixgbe_fix_features(struct net_device *netdev, | |||
| 6718 | if (!(adapter->flags2 & IXGBE_FLAG2_RSC_CAPABLE)) | 6712 | if (!(adapter->flags2 & IXGBE_FLAG2_RSC_CAPABLE)) |
| 6719 | features &= ~NETIF_F_LRO; | 6713 | features &= ~NETIF_F_LRO; |
| 6720 | 6714 | ||
| 6721 | |||
| 6722 | return features; | 6715 | return features; |
| 6723 | } | 6716 | } |
| 6724 | 6717 | ||
| @@ -6766,6 +6759,11 @@ static int ixgbe_set_features(struct net_device *netdev, | |||
| 6766 | need_reset = true; | 6759 | need_reset = true; |
| 6767 | } | 6760 | } |
| 6768 | 6761 | ||
| 6762 | if (features & NETIF_F_HW_VLAN_RX) | ||
| 6763 | ixgbe_vlan_strip_enable(adapter); | ||
| 6764 | else | ||
| 6765 | ixgbe_vlan_strip_disable(adapter); | ||
| 6766 | |||
| 6769 | if (changed & NETIF_F_RXALL) | 6767 | if (changed & NETIF_F_RXALL) |
| 6770 | need_reset = true; | 6768 | need_reset = true; |
| 6771 | 6769 | ||
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index 04d901d0ff63..f0f06b2bc28b 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c | |||
| @@ -436,7 +436,9 @@ struct mv643xx_eth_private { | |||
| 436 | /* | 436 | /* |
| 437 | * Hardware-specific parameters. | 437 | * Hardware-specific parameters. |
| 438 | */ | 438 | */ |
| 439 | #if defined(CONFIG_HAVE_CLK) | ||
| 439 | struct clk *clk; | 440 | struct clk *clk; |
| 441 | #endif | ||
| 440 | unsigned int t_clk; | 442 | unsigned int t_clk; |
| 441 | }; | 443 | }; |
| 442 | 444 | ||
| @@ -2895,17 +2897,17 @@ static int mv643xx_eth_probe(struct platform_device *pdev) | |||
| 2895 | mp->dev = dev; | 2897 | mp->dev = dev; |
| 2896 | 2898 | ||
| 2897 | /* | 2899 | /* |
| 2898 | * Get the clk rate, if there is one, otherwise use the default. | 2900 | * Start with a default rate, and if there is a clock, allow |
| 2901 | * it to override the default. | ||
| 2899 | */ | 2902 | */ |
| 2903 | mp->t_clk = 133000000; | ||
| 2904 | #if defined(CONFIG_HAVE_CLK) | ||
| 2900 | mp->clk = clk_get(&pdev->dev, (pdev->id ? "1" : "0")); | 2905 | mp->clk = clk_get(&pdev->dev, (pdev->id ? "1" : "0")); |
| 2901 | if (!IS_ERR(mp->clk)) { | 2906 | if (!IS_ERR(mp->clk)) { |
| 2902 | clk_prepare_enable(mp->clk); | 2907 | clk_prepare_enable(mp->clk); |
| 2903 | mp->t_clk = clk_get_rate(mp->clk); | 2908 | mp->t_clk = clk_get_rate(mp->clk); |
| 2904 | } else { | ||
| 2905 | mp->t_clk = 133000000; | ||
| 2906 | printk(KERN_WARNING "Unable to get clock"); | ||
| 2907 | } | 2909 | } |
| 2908 | 2910 | #endif | |
| 2909 | set_params(mp, pd); | 2911 | set_params(mp, pd); |
| 2910 | netif_set_real_num_tx_queues(dev, mp->txq_count); | 2912 | netif_set_real_num_tx_queues(dev, mp->txq_count); |
| 2911 | netif_set_real_num_rx_queues(dev, mp->rxq_count); | 2913 | netif_set_real_num_rx_queues(dev, mp->rxq_count); |
| @@ -2995,10 +2997,13 @@ static int mv643xx_eth_remove(struct platform_device *pdev) | |||
| 2995 | phy_detach(mp->phy); | 2997 | phy_detach(mp->phy); |
| 2996 | cancel_work_sync(&mp->tx_timeout_task); | 2998 | cancel_work_sync(&mp->tx_timeout_task); |
| 2997 | 2999 | ||
| 3000 | #if defined(CONFIG_HAVE_CLK) | ||
| 2998 | if (!IS_ERR(mp->clk)) { | 3001 | if (!IS_ERR(mp->clk)) { |
| 2999 | clk_disable_unprepare(mp->clk); | 3002 | clk_disable_unprepare(mp->clk); |
| 3000 | clk_put(mp->clk); | 3003 | clk_put(mp->clk); |
| 3001 | } | 3004 | } |
| 3005 | #endif | ||
| 3006 | |||
| 3002 | free_netdev(mp->dev); | 3007 | free_netdev(mp->dev); |
| 3003 | 3008 | ||
| 3004 | platform_set_drvdata(pdev, NULL); | 3009 | platform_set_drvdata(pdev, NULL); |
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index cace36f2ab92..28a54451a3e5 100644 --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers/net/ethernet/marvell/sky2.c | |||
| @@ -4381,10 +4381,12 @@ static int sky2_set_features(struct net_device *dev, netdev_features_t features) | |||
| 4381 | struct sky2_port *sky2 = netdev_priv(dev); | 4381 | struct sky2_port *sky2 = netdev_priv(dev); |
| 4382 | netdev_features_t changed = dev->features ^ features; | 4382 | netdev_features_t changed = dev->features ^ features; |
| 4383 | 4383 | ||
| 4384 | if (changed & NETIF_F_RXCSUM) { | 4384 | if ((changed & NETIF_F_RXCSUM) && |
| 4385 | bool on = features & NETIF_F_RXCSUM; | 4385 | !(sky2->hw->flags & SKY2_HW_NEW_LE)) { |
| 4386 | sky2_write32(sky2->hw, Q_ADDR(rxqaddr[sky2->port], Q_CSR), | 4386 | sky2_write32(sky2->hw, |
| 4387 | on ? BMU_ENA_RX_CHKSUM : BMU_DIS_RX_CHKSUM); | 4387 | Q_ADDR(rxqaddr[sky2->port], Q_CSR), |
| 4388 | (features & NETIF_F_RXCSUM) | ||
| 4389 | ? BMU_ENA_RX_CHKSUM : BMU_DIS_RX_CHKSUM); | ||
| 4388 | } | 4390 | } |
| 4389 | 4391 | ||
| 4390 | if (changed & NETIF_F_RXHASH) | 4392 | if (changed & NETIF_F_RXHASH) |
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 8d2666fcffd7..083d6715335c 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c | |||
| @@ -946,16 +946,16 @@ static void __lpc_handle_xmit(struct net_device *ndev) | |||
| 946 | /* Update stats */ | 946 | /* Update stats */ |
| 947 | ndev->stats.tx_packets++; | 947 | ndev->stats.tx_packets++; |
| 948 | ndev->stats.tx_bytes += skb->len; | 948 | ndev->stats.tx_bytes += skb->len; |
| 949 | |||
| 950 | /* Free buffer */ | ||
| 951 | dev_kfree_skb_irq(skb); | ||
| 952 | } | 949 | } |
| 950 | dev_kfree_skb_irq(skb); | ||
| 953 | 951 | ||
| 954 | txcidx = readl(LPC_ENET_TXCONSUMEINDEX(pldat->net_base)); | 952 | txcidx = readl(LPC_ENET_TXCONSUMEINDEX(pldat->net_base)); |
| 955 | } | 953 | } |
| 956 | 954 | ||
| 957 | if (netif_queue_stopped(ndev)) | 955 | if (pldat->num_used_tx_buffs <= ENET_TX_DESC/2) { |
| 958 | netif_wake_queue(ndev); | 956 | if (netif_queue_stopped(ndev)) |
| 957 | netif_wake_queue(ndev); | ||
| 958 | } | ||
| 959 | } | 959 | } |
| 960 | 960 | ||
| 961 | static int __lpc_handle_recv(struct net_device *ndev, int budget) | 961 | static int __lpc_handle_recv(struct net_device *ndev, int budget) |
| @@ -1320,6 +1320,7 @@ static const struct net_device_ops lpc_netdev_ops = { | |||
| 1320 | .ndo_set_rx_mode = lpc_eth_set_multicast_list, | 1320 | .ndo_set_rx_mode = lpc_eth_set_multicast_list, |
| 1321 | .ndo_do_ioctl = lpc_eth_ioctl, | 1321 | .ndo_do_ioctl = lpc_eth_ioctl, |
| 1322 | .ndo_set_mac_address = lpc_set_mac_address, | 1322 | .ndo_set_mac_address = lpc_set_mac_address, |
| 1323 | .ndo_change_mtu = eth_change_mtu, | ||
| 1323 | }; | 1324 | }; |
| 1324 | 1325 | ||
| 1325 | static int lpc_eth_drv_probe(struct platform_device *pdev) | 1326 | static int lpc_eth_drv_probe(struct platform_device *pdev) |
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 9757ce3543a0..7260aa79466a 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c | |||
| @@ -5889,11 +5889,7 @@ static void rtl_slow_event_work(struct rtl8169_private *tp) | |||
| 5889 | if (status & LinkChg) | 5889 | if (status & LinkChg) |
| 5890 | __rtl8169_check_link_status(dev, tp, tp->mmio_addr, true); | 5890 | __rtl8169_check_link_status(dev, tp, tp->mmio_addr, true); |
| 5891 | 5891 | ||
| 5892 | napi_disable(&tp->napi); | 5892 | rtl_irq_enable_all(tp); |
| 5893 | rtl_irq_disable(tp); | ||
| 5894 | |||
| 5895 | napi_enable(&tp->napi); | ||
| 5896 | napi_schedule(&tp->napi); | ||
| 5897 | } | 5893 | } |
| 5898 | 5894 | ||
| 5899 | static void rtl_task(struct work_struct *work) | 5895 | static void rtl_task(struct work_struct *work) |
diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig index 036428348faa..9f448279e12a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig | |||
| @@ -13,7 +13,7 @@ config STMMAC_ETH | |||
| 13 | if STMMAC_ETH | 13 | if STMMAC_ETH |
| 14 | 14 | ||
| 15 | config STMMAC_PLATFORM | 15 | config STMMAC_PLATFORM |
| 16 | tristate "STMMAC platform bus support" | 16 | bool "STMMAC Platform bus support" |
| 17 | depends on STMMAC_ETH | 17 | depends on STMMAC_ETH |
| 18 | default y | 18 | default y |
| 19 | ---help--- | 19 | ---help--- |
| @@ -26,7 +26,7 @@ config STMMAC_PLATFORM | |||
| 26 | If unsure, say N. | 26 | If unsure, say N. |
| 27 | 27 | ||
| 28 | config STMMAC_PCI | 28 | config STMMAC_PCI |
| 29 | tristate "STMMAC support on PCI bus (EXPERIMENTAL)" | 29 | bool "STMMAC PCI bus support (EXPERIMENTAL)" |
| 30 | depends on STMMAC_ETH && PCI && EXPERIMENTAL | 30 | depends on STMMAC_ETH && PCI && EXPERIMENTAL |
| 31 | ---help--- | 31 | ---help--- |
| 32 | This is to select the Synopsys DWMAC available on PCI devices, | 32 | This is to select the Synopsys DWMAC available on PCI devices, |
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h index 6b5d060ee9de..dc20c56efc9d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h | |||
| @@ -26,6 +26,7 @@ | |||
| 26 | #include <linux/clk.h> | 26 | #include <linux/clk.h> |
| 27 | #include <linux/stmmac.h> | 27 | #include <linux/stmmac.h> |
| 28 | #include <linux/phy.h> | 28 | #include <linux/phy.h> |
| 29 | #include <linux/pci.h> | ||
| 29 | #include "common.h" | 30 | #include "common.h" |
| 30 | #ifdef CONFIG_STMMAC_TIMER | 31 | #ifdef CONFIG_STMMAC_TIMER |
| 31 | #include "stmmac_timer.h" | 32 | #include "stmmac_timer.h" |
| @@ -95,7 +96,6 @@ extern int stmmac_mdio_register(struct net_device *ndev); | |||
| 95 | extern void stmmac_set_ethtool_ops(struct net_device *netdev); | 96 | extern void stmmac_set_ethtool_ops(struct net_device *netdev); |
| 96 | extern const struct stmmac_desc_ops enh_desc_ops; | 97 | extern const struct stmmac_desc_ops enh_desc_ops; |
| 97 | extern const struct stmmac_desc_ops ndesc_ops; | 98 | extern const struct stmmac_desc_ops ndesc_ops; |
| 98 | |||
| 99 | int stmmac_freeze(struct net_device *ndev); | 99 | int stmmac_freeze(struct net_device *ndev); |
| 100 | int stmmac_restore(struct net_device *ndev); | 100 | int stmmac_restore(struct net_device *ndev); |
| 101 | int stmmac_resume(struct net_device *ndev); | 101 | int stmmac_resume(struct net_device *ndev); |
| @@ -109,7 +109,7 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device, | |||
| 109 | static inline int stmmac_clk_enable(struct stmmac_priv *priv) | 109 | static inline int stmmac_clk_enable(struct stmmac_priv *priv) |
| 110 | { | 110 | { |
| 111 | if (!IS_ERR(priv->stmmac_clk)) | 111 | if (!IS_ERR(priv->stmmac_clk)) |
| 112 | return clk_enable(priv->stmmac_clk); | 112 | return clk_prepare_enable(priv->stmmac_clk); |
| 113 | 113 | ||
| 114 | return 0; | 114 | return 0; |
| 115 | } | 115 | } |
| @@ -119,7 +119,7 @@ static inline void stmmac_clk_disable(struct stmmac_priv *priv) | |||
| 119 | if (IS_ERR(priv->stmmac_clk)) | 119 | if (IS_ERR(priv->stmmac_clk)) |
| 120 | return; | 120 | return; |
| 121 | 121 | ||
| 122 | clk_disable(priv->stmmac_clk); | 122 | clk_disable_unprepare(priv->stmmac_clk); |
| 123 | } | 123 | } |
| 124 | static inline int stmmac_clk_get(struct stmmac_priv *priv) | 124 | static inline int stmmac_clk_get(struct stmmac_priv *priv) |
| 125 | { | 125 | { |
| @@ -143,3 +143,60 @@ static inline int stmmac_clk_get(struct stmmac_priv *priv) | |||
| 143 | return 0; | 143 | return 0; |
| 144 | } | 144 | } |
| 145 | #endif /* CONFIG_HAVE_CLK */ | 145 | #endif /* CONFIG_HAVE_CLK */ |
| 146 | |||
| 147 | |||
| 148 | #ifdef CONFIG_STMMAC_PLATFORM | ||
| 149 | extern struct platform_driver stmmac_pltfr_driver; | ||
| 150 | static inline int stmmac_register_platform(void) | ||
| 151 | { | ||
| 152 | int err; | ||
| 153 | |||
| 154 | err = platform_driver_register(&stmmac_pltfr_driver); | ||
| 155 | if (err) | ||
| 156 | pr_err("stmmac: failed to register the platform driver\n"); | ||
| 157 | |||
| 158 | return err; | ||
| 159 | } | ||
| 160 | static inline void stmmac_unregister_platform(void) | ||
| 161 | { | ||
| 162 | platform_driver_register(&stmmac_pltfr_driver); | ||
| 163 | } | ||
| 164 | #else | ||
| 165 | static inline int stmmac_register_platform(void) | ||
| 166 | { | ||
| 167 | pr_debug("stmmac: do not register the platf driver\n"); | ||
| 168 | |||
| 169 | return -EINVAL; | ||
| 170 | } | ||
| 171 | static inline void stmmac_unregister_platform(void) | ||
| 172 | { | ||
| 173 | } | ||
| 174 | #endif /* CONFIG_STMMAC_PLATFORM */ | ||
| 175 | |||
| 176 | #ifdef CONFIG_STMMAC_PCI | ||
| 177 | extern struct pci_driver stmmac_pci_driver; | ||
| 178 | static inline int stmmac_register_pci(void) | ||
| 179 | { | ||
| 180 | int err; | ||
| 181 | |||
| 182 | err = pci_register_driver(&stmmac_pci_driver); | ||
| 183 | if (err) | ||
| 184 | pr_err("stmmac: failed to register the PCI driver\n"); | ||
| 185 | |||
| 186 | return err; | ||
| 187 | } | ||
| 188 | static inline void stmmac_unregister_pci(void) | ||
| 189 | { | ||
| 190 | pci_unregister_driver(&stmmac_pci_driver); | ||
| 191 | } | ||
| 192 | #else | ||
| 193 | static inline int stmmac_register_pci(void) | ||
| 194 | { | ||
| 195 | pr_debug("stmmac: do not register the PCI driver\n"); | ||
| 196 | |||
| 197 | return -EINVAL; | ||
| 198 | } | ||
| 199 | static inline void stmmac_unregister_pci(void) | ||
| 200 | { | ||
| 201 | } | ||
| 202 | #endif /* CONFIG_STMMAC_PCI */ | ||
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 70966330f44e..51b3b68528ee 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | |||
| @@ -833,8 +833,9 @@ static u32 stmmac_get_synopsys_id(struct stmmac_priv *priv) | |||
| 833 | 833 | ||
| 834 | /** | 834 | /** |
| 835 | * stmmac_selec_desc_mode | 835 | * stmmac_selec_desc_mode |
| 836 | * @dev : device pointer | 836 | * @priv : private structure |
| 837 | * Description: select the Enhanced/Alternate or Normal descriptors */ | 837 | * Description: select the Enhanced/Alternate or Normal descriptors |
| 838 | */ | ||
| 838 | static void stmmac_selec_desc_mode(struct stmmac_priv *priv) | 839 | static void stmmac_selec_desc_mode(struct stmmac_priv *priv) |
| 839 | { | 840 | { |
| 840 | if (priv->plat->enh_desc) { | 841 | if (priv->plat->enh_desc) { |
| @@ -1861,6 +1862,8 @@ static int stmmac_hw_init(struct stmmac_priv *priv) | |||
| 1861 | /** | 1862 | /** |
| 1862 | * stmmac_dvr_probe | 1863 | * stmmac_dvr_probe |
| 1863 | * @device: device pointer | 1864 | * @device: device pointer |
| 1865 | * @plat_dat: platform data pointer | ||
| 1866 | * @addr: iobase memory address | ||
| 1864 | * Description: this is the main probe function used to | 1867 | * Description: this is the main probe function used to |
| 1865 | * call the alloc_etherdev, allocate the priv structure. | 1868 | * call the alloc_etherdev, allocate the priv structure. |
| 1866 | */ | 1869 | */ |
| @@ -2090,6 +2093,34 @@ int stmmac_restore(struct net_device *ndev) | |||
| 2090 | } | 2093 | } |
| 2091 | #endif /* CONFIG_PM */ | 2094 | #endif /* CONFIG_PM */ |
| 2092 | 2095 | ||
| 2096 | /* Driver can be configured w/ and w/ both PCI and Platf drivers | ||
| 2097 | * depending on the configuration selected. | ||
| 2098 | */ | ||
| 2099 | static int __init stmmac_init(void) | ||
| 2100 | { | ||
| 2101 | int err_plt = 0; | ||
| 2102 | int err_pci = 0; | ||
| 2103 | |||
| 2104 | err_plt = stmmac_register_platform(); | ||
| 2105 | err_pci = stmmac_register_pci(); | ||
| 2106 | |||
| 2107 | if ((err_pci) && (err_plt)) { | ||
| 2108 | pr_err("stmmac: driver registration failed\n"); | ||
| 2109 | return -EINVAL; | ||
| 2110 | } | ||
| 2111 | |||
| 2112 | return 0; | ||
| 2113 | } | ||
| 2114 | |||
| 2115 | static void __exit stmmac_exit(void) | ||
| 2116 | { | ||
| 2117 | stmmac_unregister_platform(); | ||
| 2118 | stmmac_unregister_pci(); | ||
| 2119 | } | ||
| 2120 | |||
| 2121 | module_init(stmmac_init); | ||
| 2122 | module_exit(stmmac_exit); | ||
| 2123 | |||
| 2093 | #ifndef MODULE | 2124 | #ifndef MODULE |
| 2094 | static int __init stmmac_cmdline_opt(char *str) | 2125 | static int __init stmmac_cmdline_opt(char *str) |
| 2095 | { | 2126 | { |
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c index 58fab5303e9c..cf826e6b6aa1 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | |||
| @@ -179,7 +179,7 @@ static DEFINE_PCI_DEVICE_TABLE(stmmac_id_table) = { | |||
| 179 | 179 | ||
| 180 | MODULE_DEVICE_TABLE(pci, stmmac_id_table); | 180 | MODULE_DEVICE_TABLE(pci, stmmac_id_table); |
| 181 | 181 | ||
| 182 | static struct pci_driver stmmac_driver = { | 182 | struct pci_driver stmmac_pci_driver = { |
| 183 | .name = STMMAC_RESOURCE_NAME, | 183 | .name = STMMAC_RESOURCE_NAME, |
| 184 | .id_table = stmmac_id_table, | 184 | .id_table = stmmac_id_table, |
| 185 | .probe = stmmac_pci_probe, | 185 | .probe = stmmac_pci_probe, |
| @@ -190,33 +190,6 @@ static struct pci_driver stmmac_driver = { | |||
| 190 | #endif | 190 | #endif |
| 191 | }; | 191 | }; |
| 192 | 192 | ||
| 193 | /** | ||
| 194 | * stmmac_init_module - Entry point for the driver | ||
| 195 | * Description: This function is the entry point for the driver. | ||
| 196 | */ | ||
| 197 | static int __init stmmac_init_module(void) | ||
| 198 | { | ||
| 199 | int ret; | ||
| 200 | |||
| 201 | ret = pci_register_driver(&stmmac_driver); | ||
| 202 | if (ret < 0) | ||
| 203 | pr_err("%s: ERROR: driver registration failed\n", __func__); | ||
| 204 | |||
| 205 | return ret; | ||
| 206 | } | ||
| 207 | |||
| 208 | /** | ||
| 209 | * stmmac_cleanup_module - Cleanup routine for the driver | ||
| 210 | * Description: This function is the cleanup routine for the driver. | ||
| 211 | */ | ||
| 212 | static void __exit stmmac_cleanup_module(void) | ||
| 213 | { | ||
| 214 | pci_unregister_driver(&stmmac_driver); | ||
| 215 | } | ||
| 216 | |||
| 217 | module_init(stmmac_init_module); | ||
| 218 | module_exit(stmmac_cleanup_module); | ||
| 219 | |||
| 220 | MODULE_DESCRIPTION("STMMAC 10/100/1000 Ethernet PCI driver"); | 193 | MODULE_DESCRIPTION("STMMAC 10/100/1000 Ethernet PCI driver"); |
| 221 | MODULE_AUTHOR("Rayagond Kokatanur <rayagond.kokatanur@vayavyalabs.com>"); | 194 | MODULE_AUTHOR("Rayagond Kokatanur <rayagond.kokatanur@vayavyalabs.com>"); |
| 222 | MODULE_AUTHOR("Giuseppe Cavallaro <peppe.cavallaro@st.com>"); | 195 | MODULE_AUTHOR("Giuseppe Cavallaro <peppe.cavallaro@st.com>"); |
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 3dd8f0803808..680d2b8dfe27 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | |||
| @@ -255,7 +255,7 @@ static const struct of_device_id stmmac_dt_ids[] = { | |||
| 255 | }; | 255 | }; |
| 256 | MODULE_DEVICE_TABLE(of, stmmac_dt_ids); | 256 | MODULE_DEVICE_TABLE(of, stmmac_dt_ids); |
| 257 | 257 | ||
| 258 | static struct platform_driver stmmac_driver = { | 258 | struct platform_driver stmmac_pltfr_driver = { |
| 259 | .probe = stmmac_pltfr_probe, | 259 | .probe = stmmac_pltfr_probe, |
| 260 | .remove = stmmac_pltfr_remove, | 260 | .remove = stmmac_pltfr_remove, |
| 261 | .driver = { | 261 | .driver = { |
| @@ -266,8 +266,6 @@ static struct platform_driver stmmac_driver = { | |||
| 266 | }, | 266 | }, |
| 267 | }; | 267 | }; |
| 268 | 268 | ||
| 269 | module_platform_driver(stmmac_driver); | ||
| 270 | |||
| 271 | MODULE_DESCRIPTION("STMMAC 10/100/1000 Ethernet PLATFORM driver"); | 269 | MODULE_DESCRIPTION("STMMAC 10/100/1000 Ethernet PLATFORM driver"); |
| 272 | MODULE_AUTHOR("Giuseppe Cavallaro <peppe.cavallaro@st.com>"); | 270 | MODULE_AUTHOR("Giuseppe Cavallaro <peppe.cavallaro@st.com>"); |
| 273 | MODULE_LICENSE("GPL"); | 271 | MODULE_LICENSE("GPL"); |
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index 703c8cce2a2c..8c726b7004d3 100644 --- a/drivers/net/ethernet/sun/niu.c +++ b/drivers/net/ethernet/sun/niu.c | |||
| @@ -3598,7 +3598,6 @@ static int release_tx_packet(struct niu *np, struct tx_ring_info *rp, int idx) | |||
| 3598 | static void niu_tx_work(struct niu *np, struct tx_ring_info *rp) | 3598 | static void niu_tx_work(struct niu *np, struct tx_ring_info *rp) |
| 3599 | { | 3599 | { |
| 3600 | struct netdev_queue *txq; | 3600 | struct netdev_queue *txq; |
| 3601 | unsigned int tx_bytes; | ||
| 3602 | u16 pkt_cnt, tmp; | 3601 | u16 pkt_cnt, tmp; |
| 3603 | int cons, index; | 3602 | int cons, index; |
| 3604 | u64 cs; | 3603 | u64 cs; |
| @@ -3621,18 +3620,12 @@ static void niu_tx_work(struct niu *np, struct tx_ring_info *rp) | |||
| 3621 | netif_printk(np, tx_done, KERN_DEBUG, np->dev, | 3620 | netif_printk(np, tx_done, KERN_DEBUG, np->dev, |
| 3622 | "%s() pkt_cnt[%u] cons[%d]\n", __func__, pkt_cnt, cons); | 3621 | "%s() pkt_cnt[%u] cons[%d]\n", __func__, pkt_cnt, cons); |
| 3623 | 3622 | ||
| 3624 | tx_bytes = 0; | 3623 | while (pkt_cnt--) |
| 3625 | tmp = pkt_cnt; | ||
| 3626 | while (tmp--) { | ||
| 3627 | tx_bytes += rp->tx_buffs[cons].skb->len; | ||
| 3628 | cons = release_tx_packet(np, rp, cons); | 3624 | cons = release_tx_packet(np, rp, cons); |
| 3629 | } | ||
| 3630 | 3625 | ||
| 3631 | rp->cons = cons; | 3626 | rp->cons = cons; |
| 3632 | smp_mb(); | 3627 | smp_mb(); |
| 3633 | 3628 | ||
| 3634 | netdev_tx_completed_queue(txq, pkt_cnt, tx_bytes); | ||
| 3635 | |||
| 3636 | out: | 3629 | out: |
| 3637 | if (unlikely(netif_tx_queue_stopped(txq) && | 3630 | if (unlikely(netif_tx_queue_stopped(txq) && |
| 3638 | (niu_tx_avail(rp) > NIU_TX_WAKEUP_THRESH(rp)))) { | 3631 | (niu_tx_avail(rp) > NIU_TX_WAKEUP_THRESH(rp)))) { |
| @@ -4333,7 +4326,6 @@ static void niu_free_channels(struct niu *np) | |||
| 4333 | struct tx_ring_info *rp = &np->tx_rings[i]; | 4326 | struct tx_ring_info *rp = &np->tx_rings[i]; |
| 4334 | 4327 | ||
| 4335 | niu_free_tx_ring_info(np, rp); | 4328 | niu_free_tx_ring_info(np, rp); |
| 4336 | netdev_tx_reset_queue(netdev_get_tx_queue(np->dev, i)); | ||
| 4337 | } | 4329 | } |
| 4338 | kfree(np->tx_rings); | 4330 | kfree(np->tx_rings); |
| 4339 | np->tx_rings = NULL; | 4331 | np->tx_rings = NULL; |
| @@ -6739,8 +6731,6 @@ static netdev_tx_t niu_start_xmit(struct sk_buff *skb, | |||
| 6739 | prod = NEXT_TX(rp, prod); | 6731 | prod = NEXT_TX(rp, prod); |
| 6740 | } | 6732 | } |
| 6741 | 6733 | ||
| 6742 | netdev_tx_sent_queue(txq, skb->len); | ||
| 6743 | |||
| 6744 | if (prod < rp->prod) | 6734 | if (prod < rp->prod) |
| 6745 | rp->wrap_bit ^= TX_RING_KICK_WRAP; | 6735 | rp->wrap_bit ^= TX_RING_KICK_WRAP; |
| 6746 | rp->prod = prod; | 6736 | rp->prod = prod; |
diff --git a/drivers/net/ethernet/tile/Kconfig b/drivers/net/ethernet/tile/Kconfig index 2d9218f86bca..098b1c42b393 100644 --- a/drivers/net/ethernet/tile/Kconfig +++ b/drivers/net/ethernet/tile/Kconfig | |||
| @@ -7,6 +7,8 @@ config TILE_NET | |||
| 7 | depends on TILE | 7 | depends on TILE |
| 8 | default y | 8 | default y |
| 9 | select CRC32 | 9 | select CRC32 |
| 10 | select TILE_GXIO_MPIPE if TILEGX | ||
| 11 | select HIGH_RES_TIMERS if TILEGX | ||
| 10 | ---help--- | 12 | ---help--- |
| 11 | This is a standard Linux network device driver for the | 13 | This is a standard Linux network device driver for the |
| 12 | on-chip Tilera Gigabit Ethernet and XAUI interfaces. | 14 | on-chip Tilera Gigabit Ethernet and XAUI interfaces. |
diff --git a/drivers/net/ethernet/tile/Makefile b/drivers/net/ethernet/tile/Makefile index f634f142cab4..0ef9eefd3211 100644 --- a/drivers/net/ethernet/tile/Makefile +++ b/drivers/net/ethernet/tile/Makefile | |||
| @@ -4,7 +4,7 @@ | |||
| 4 | 4 | ||
| 5 | obj-$(CONFIG_TILE_NET) += tile_net.o | 5 | obj-$(CONFIG_TILE_NET) += tile_net.o |
| 6 | ifdef CONFIG_TILEGX | 6 | ifdef CONFIG_TILEGX |
| 7 | tile_net-objs := tilegx.o mpipe.o iorpc_mpipe.o dma_queue.o | 7 | tile_net-y := tilegx.o |
| 8 | else | 8 | else |
| 9 | tile_net-objs := tilepro.o | 9 | tile_net-y := tilepro.o |
| 10 | endif | 10 | endif |
diff --git a/drivers/net/ethernet/tile/tilegx.c b/drivers/net/ethernet/tile/tilegx.c new file mode 100644 index 000000000000..83b4b388ad49 --- /dev/null +++ b/drivers/net/ethernet/tile/tilegx.c | |||
| @@ -0,0 +1,1898 @@ | |||
| 1 | /* | ||
| 2 | * Copyright 2012 Tilera Corporation. All Rights Reserved. | ||
| 3 | * | ||
| 4 | * This program is free software; you can redistribute it and/or | ||
| 5 | * modify it under the terms of the GNU General Public License | ||
| 6 | * as published by the Free Software Foundation, version 2. | ||
| 7 | * | ||
| 8 | * This program is distributed in the hope that it will be useful, but | ||
| 9 | * WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| 10 | * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or | ||
| 11 | * NON INFRINGEMENT. See the GNU General Public License for | ||
| 12 | * more details. | ||
| 13 | */ | ||
| 14 | |||
| 15 | #include <linux/module.h> | ||
| 16 | #include <linux/init.h> | ||
| 17 | #include <linux/moduleparam.h> | ||
| 18 | #include <linux/sched.h> | ||
| 19 | #include <linux/kernel.h> /* printk() */ | ||
| 20 | #include <linux/slab.h> /* kmalloc() */ | ||
| 21 | #include <linux/errno.h> /* error codes */ | ||
| 22 | #include <linux/types.h> /* size_t */ | ||
| 23 | #include <linux/interrupt.h> | ||
| 24 | #include <linux/in.h> | ||
| 25 | #include <linux/irq.h> | ||
| 26 | #include <linux/netdevice.h> /* struct device, and other headers */ | ||
| 27 | #include <linux/etherdevice.h> /* eth_type_trans */ | ||
| 28 | #include <linux/skbuff.h> | ||
| 29 | #include <linux/ioctl.h> | ||
| 30 | #include <linux/cdev.h> | ||
| 31 | #include <linux/hugetlb.h> | ||
| 32 | #include <linux/in6.h> | ||
| 33 | #include <linux/timer.h> | ||
| 34 | #include <linux/hrtimer.h> | ||
| 35 | #include <linux/ktime.h> | ||
| 36 | #include <linux/io.h> | ||
| 37 | #include <linux/ctype.h> | ||
| 38 | #include <linux/ip.h> | ||
| 39 | #include <linux/tcp.h> | ||
| 40 | |||
| 41 | #include <asm/checksum.h> | ||
| 42 | #include <asm/homecache.h> | ||
| 43 | #include <gxio/mpipe.h> | ||
| 44 | #include <arch/sim.h> | ||
| 45 | |||
| 46 | /* Default transmit lockup timeout period, in jiffies. */ | ||
| 47 | #define TILE_NET_TIMEOUT (5 * HZ) | ||
| 48 | |||
| 49 | /* The maximum number of distinct channels (idesc.channel is 5 bits). */ | ||
| 50 | #define TILE_NET_CHANNELS 32 | ||
| 51 | |||
| 52 | /* Maximum number of idescs to handle per "poll". */ | ||
| 53 | #define TILE_NET_BATCH 128 | ||
| 54 | |||
| 55 | /* Maximum number of packets to handle per "poll". */ | ||
| 56 | #define TILE_NET_WEIGHT 64 | ||
| 57 | |||
| 58 | /* Number of entries in each iqueue. */ | ||
| 59 | #define IQUEUE_ENTRIES 512 | ||
| 60 | |||
| 61 | /* Number of entries in each equeue. */ | ||
| 62 | #define EQUEUE_ENTRIES 2048 | ||
| 63 | |||
| 64 | /* Total header bytes per equeue slot. Must be big enough for 2 bytes | ||
| 65 | * of NET_IP_ALIGN alignment, plus 14 bytes (?) of L2 header, plus up to | ||
| 66 | * 60 bytes of actual TCP header. We round up to align to cache lines. | ||
| 67 | */ | ||
| 68 | #define HEADER_BYTES 128 | ||
| 69 | |||
| 70 | /* Maximum completions per cpu per device (must be a power of two). | ||
| 71 | * ISSUE: What is the right number here? If this is too small, then | ||
| 72 | * egress might block waiting for free space in a completions array. | ||
| 73 | * ISSUE: At the least, allocate these only for initialized echannels. | ||
| 74 | */ | ||
| 75 | #define TILE_NET_MAX_COMPS 64 | ||
| 76 | |||
| 77 | #define MAX_FRAGS (MAX_SKB_FRAGS + 1) | ||
| 78 | |||
| 79 | /* Size of completions data to allocate. | ||
| 80 | * ISSUE: Probably more than needed since we don't use all the channels. | ||
| 81 | */ | ||
| 82 | #define COMPS_SIZE (TILE_NET_CHANNELS * sizeof(struct tile_net_comps)) | ||
| 83 | |||
| 84 | /* Size of NotifRing data to allocate. */ | ||
| 85 | #define NOTIF_RING_SIZE (IQUEUE_ENTRIES * sizeof(gxio_mpipe_idesc_t)) | ||
| 86 | |||
| 87 | /* Timeout to wake the per-device TX timer after we stop the queue. | ||
| 88 | * We don't want the timeout too short (adds overhead, and might end | ||
| 89 | * up causing stop/wake/stop/wake cycles) or too long (affects performance). | ||
| 90 | * For the 10 Gb NIC, 30 usec means roughly 30+ 1500-byte packets. | ||
| 91 | */ | ||
| 92 | #define TX_TIMER_DELAY_USEC 30 | ||
| 93 | |||
| 94 | /* Timeout to wake the per-cpu egress timer to free completions. */ | ||
| 95 | #define EGRESS_TIMER_DELAY_USEC 1000 | ||
| 96 | |||
| 97 | MODULE_AUTHOR("Tilera Corporation"); | ||
| 98 | MODULE_LICENSE("GPL"); | ||
| 99 | |||
| 100 | /* A "packet fragment" (a chunk of memory). */ | ||
| 101 | struct frag { | ||
| 102 | void *buf; | ||
| 103 | size_t length; | ||
| 104 | }; | ||
| 105 | |||
| 106 | /* A single completion. */ | ||
| 107 | struct tile_net_comp { | ||
| 108 | /* The "complete_count" when the completion will be complete. */ | ||
| 109 | s64 when; | ||
| 110 | /* The buffer to be freed when the completion is complete. */ | ||
| 111 | struct sk_buff *skb; | ||
| 112 | }; | ||
| 113 | |||
| 114 | /* The completions for a given cpu and echannel. */ | ||
| 115 | struct tile_net_comps { | ||
| 116 | /* The completions. */ | ||
| 117 | struct tile_net_comp comp_queue[TILE_NET_MAX_COMPS]; | ||
| 118 | /* The number of completions used. */ | ||
| 119 | unsigned long comp_next; | ||
| 120 | /* The number of completions freed. */ | ||
| 121 | unsigned long comp_last; | ||
| 122 | }; | ||
| 123 | |||
| 124 | /* The transmit wake timer for a given cpu and echannel. */ | ||
| 125 | struct tile_net_tx_wake { | ||
| 126 | struct hrtimer timer; | ||
| 127 | struct net_device *dev; | ||
| 128 | }; | ||
| 129 | |||
| 130 | /* Info for a specific cpu. */ | ||
| 131 | struct tile_net_info { | ||
| 132 | /* The NAPI struct. */ | ||
| 133 | struct napi_struct napi; | ||
| 134 | /* Packet queue. */ | ||
| 135 | gxio_mpipe_iqueue_t iqueue; | ||
| 136 | /* Our cpu. */ | ||
| 137 | int my_cpu; | ||
| 138 | /* True if iqueue is valid. */ | ||
| 139 | bool has_iqueue; | ||
| 140 | /* NAPI flags. */ | ||
| 141 | bool napi_added; | ||
| 142 | bool napi_enabled; | ||
| 143 | /* Number of small sk_buffs which must still be provided. */ | ||
| 144 | unsigned int num_needed_small_buffers; | ||
| 145 | /* Number of large sk_buffs which must still be provided. */ | ||
| 146 | unsigned int num_needed_large_buffers; | ||
| 147 | /* A timer for handling egress completions. */ | ||
| 148 | struct hrtimer egress_timer; | ||
| 149 | /* True if "egress_timer" is scheduled. */ | ||
| 150 | bool egress_timer_scheduled; | ||
| 151 | /* Comps for each egress channel. */ | ||
| 152 | struct tile_net_comps *comps_for_echannel[TILE_NET_CHANNELS]; | ||
| 153 | /* Transmit wake timer for each egress channel. */ | ||
| 154 | struct tile_net_tx_wake tx_wake[TILE_NET_CHANNELS]; | ||
| 155 | }; | ||
| 156 | |||
| 157 | /* Info for egress on a particular egress channel. */ | ||
| 158 | struct tile_net_egress { | ||
| 159 | /* The "equeue". */ | ||
| 160 | gxio_mpipe_equeue_t *equeue; | ||
| 161 | /* The headers for TSO. */ | ||
| 162 | unsigned char *headers; | ||
| 163 | }; | ||
| 164 | |||
| 165 | /* Info for a specific device. */ | ||
| 166 | struct tile_net_priv { | ||
| 167 | /* Our network device. */ | ||
| 168 | struct net_device *dev; | ||
| 169 | /* The primary link. */ | ||
| 170 | gxio_mpipe_link_t link; | ||
| 171 | /* The primary channel, if open, else -1. */ | ||
| 172 | int channel; | ||
| 173 | /* The "loopify" egress link, if needed. */ | ||
| 174 | gxio_mpipe_link_t loopify_link; | ||
| 175 | /* The "loopify" egress channel, if open, else -1. */ | ||
| 176 | int loopify_channel; | ||
| 177 | /* The egress channel (channel or loopify_channel). */ | ||
| 178 | int echannel; | ||
| 179 | /* Total stats. */ | ||
| 180 | struct net_device_stats stats; | ||
| 181 | }; | ||
| 182 | |||
| 183 | /* Egress info, indexed by "priv->echannel" (lazily created as needed). */ | ||
| 184 | static struct tile_net_egress egress_for_echannel[TILE_NET_CHANNELS]; | ||
| 185 | |||
| 186 | /* Devices currently associated with each channel. | ||
| 187 | * NOTE: The array entry can become NULL after ifconfig down, but | ||
| 188 | * we do not free the underlying net_device structures, so it is | ||
| 189 | * safe to use a pointer after reading it from this array. | ||
| 190 | */ | ||
| 191 | static struct net_device *tile_net_devs_for_channel[TILE_NET_CHANNELS]; | ||
| 192 | |||
| 193 | /* A mutex for "tile_net_devs_for_channel". */ | ||
| 194 | static DEFINE_MUTEX(tile_net_devs_for_channel_mutex); | ||
| 195 | |||
| 196 | /* The per-cpu info. */ | ||
| 197 | static DEFINE_PER_CPU(struct tile_net_info, per_cpu_info); | ||
| 198 | |||
| 199 | /* The "context" for all devices. */ | ||
| 200 | static gxio_mpipe_context_t context; | ||
| 201 | |||
| 202 | /* Buffer sizes and mpipe enum codes for buffer stacks. | ||
| 203 | * See arch/tile/include/gxio/mpipe.h for the set of possible values. | ||
| 204 | */ | ||
| 205 | #define BUFFER_SIZE_SMALL_ENUM GXIO_MPIPE_BUFFER_SIZE_128 | ||
| 206 | #define BUFFER_SIZE_SMALL 128 | ||
| 207 | #define BUFFER_SIZE_LARGE_ENUM GXIO_MPIPE_BUFFER_SIZE_1664 | ||
| 208 | #define BUFFER_SIZE_LARGE 1664 | ||
| 209 | |||
| 210 | /* The small/large "buffer stacks". */ | ||
| 211 | static int small_buffer_stack = -1; | ||
| 212 | static int large_buffer_stack = -1; | ||
| 213 | |||
| 214 | /* Amount of memory allocated for each buffer stack. */ | ||
| 215 | static size_t buffer_stack_size; | ||
| 216 | |||
| 217 | /* The actual memory allocated for the buffer stacks. */ | ||
| 218 | static void *small_buffer_stack_va; | ||
| 219 | static void *large_buffer_stack_va; | ||
| 220 | |||
| 221 | /* The buckets. */ | ||
| 222 | static int first_bucket = -1; | ||
| 223 | static int num_buckets = 1; | ||
| 224 | |||
| 225 | /* The ingress irq. */ | ||
| 226 | static int ingress_irq = -1; | ||
| 227 | |||
| 228 | /* Text value of tile_net.cpus if passed as a module parameter. */ | ||
| 229 | static char *network_cpus_string; | ||
| 230 | |||
| 231 | /* The actual cpus in "network_cpus". */ | ||
| 232 | static struct cpumask network_cpus_map; | ||
| 233 | |||
| 234 | /* If "loopify=LINK" was specified, this is "LINK". */ | ||
| 235 | static char *loopify_link_name; | ||
| 236 | |||
| 237 | /* If "tile_net.custom" was specified, this is non-NULL. */ | ||
| 238 | static char *custom_str; | ||
| 239 | |||
| 240 | /* The "tile_net.cpus" argument specifies the cpus that are dedicated | ||
| 241 | * to handle ingress packets. | ||
| 242 | * | ||
| 243 | * The parameter should be in the form "tile_net.cpus=m-n[,x-y]", where | ||
| 244 | * m, n, x, y are integer numbers that represent the cpus that can be | ||
| 245 | * neither a dedicated cpu nor a dataplane cpu. | ||
| 246 | */ | ||
| 247 | static bool network_cpus_init(void) | ||
| 248 | { | ||
| 249 | char buf[1024]; | ||
| 250 | int rc; | ||
| 251 | |||
| 252 | if (network_cpus_string == NULL) | ||
| 253 | return false; | ||
| 254 | |||
| 255 | rc = cpulist_parse_crop(network_cpus_string, &network_cpus_map); | ||
| 256 | if (rc != 0) { | ||
| 257 | pr_warn("tile_net.cpus=%s: malformed cpu list\n", | ||
| 258 | network_cpus_string); | ||
| 259 | return false; | ||
| 260 | } | ||
| 261 | |||
| 262 | /* Remove dedicated cpus. */ | ||
| 263 | cpumask_and(&network_cpus_map, &network_cpus_map, cpu_possible_mask); | ||
| 264 | |||
| 265 | if (cpumask_empty(&network_cpus_map)) { | ||
| 266 | pr_warn("Ignoring empty tile_net.cpus='%s'.\n", | ||
| 267 | network_cpus_string); | ||
| 268 | return false; | ||
| 269 | } | ||
| 270 | |||
| 271 | cpulist_scnprintf(buf, sizeof(buf), &network_cpus_map); | ||
| 272 | pr_info("Linux network CPUs: %s\n", buf); | ||
| 273 | return true; | ||
| 274 | } | ||
| 275 | |||
| 276 | module_param_named(cpus, network_cpus_string, charp, 0444); | ||
| 277 | MODULE_PARM_DESC(cpus, "cpulist of cores that handle network interrupts"); | ||
| 278 | |||
| 279 | /* The "tile_net.loopify=LINK" argument causes the named device to | ||
| 280 | * actually use "loop0" for ingress, and "loop1" for egress. This | ||
| 281 | * allows an app to sit between the actual link and linux, passing | ||
| 282 | * (some) packets along to linux, and forwarding (some) packets sent | ||
| 283 | * out by linux. | ||
| 284 | */ | ||
| 285 | module_param_named(loopify, loopify_link_name, charp, 0444); | ||
| 286 | MODULE_PARM_DESC(loopify, "name the device to use loop0/1 for ingress/egress"); | ||
| 287 | |||
| 288 | /* The "tile_net.custom" argument causes us to ignore the "conventional" | ||
| 289 | * classifier metadata, in particular, the "l2_offset". | ||
| 290 | */ | ||
| 291 | module_param_named(custom, custom_str, charp, 0444); | ||
| 292 | MODULE_PARM_DESC(custom, "indicates a (heavily) customized classifier"); | ||
| 293 | |||
| 294 | /* Atomically update a statistics field. | ||
| 295 | * Note that on TILE-Gx, this operation is fire-and-forget on the | ||
| 296 | * issuing core (single-cycle dispatch) and takes only a few cycles | ||
| 297 | * longer than a regular store when the request reaches the home cache. | ||
| 298 | * No expensive bus management overhead is required. | ||
| 299 | */ | ||
| 300 | static void tile_net_stats_add(unsigned long value, unsigned long *field) | ||
| 301 | { | ||
| 302 | BUILD_BUG_ON(sizeof(atomic_long_t) != sizeof(unsigned long)); | ||
| 303 | atomic_long_add(value, (atomic_long_t *)field); | ||
| 304 | } | ||
| 305 | |||
| 306 | /* Allocate and push a buffer. */ | ||
| 307 | static bool tile_net_provide_buffer(bool small) | ||
| 308 | { | ||
| 309 | int stack = small ? small_buffer_stack : large_buffer_stack; | ||
| 310 | const unsigned long buffer_alignment = 128; | ||
| 311 | struct sk_buff *skb; | ||
| 312 | int len; | ||
| 313 | |||
| 314 | len = sizeof(struct sk_buff **) + buffer_alignment; | ||
| 315 | len += (small ? BUFFER_SIZE_SMALL : BUFFER_SIZE_LARGE); | ||
| 316 | skb = dev_alloc_skb(len); | ||
| 317 | if (skb == NULL) | ||
| 318 | return false; | ||
| 319 | |||
| 320 | /* Make room for a back-pointer to 'skb' and guarantee alignment. */ | ||
| 321 | skb_reserve(skb, sizeof(struct sk_buff **)); | ||
| 322 | skb_reserve(skb, -(long)skb->data & (buffer_alignment - 1)); | ||
| 323 | |||
| 324 | /* Save a back-pointer to 'skb'. */ | ||
| 325 | *(struct sk_buff **)(skb->data - sizeof(struct sk_buff **)) = skb; | ||
| 326 | |||
| 327 | /* Make sure "skb" and the back-pointer have been flushed. */ | ||
| 328 | wmb(); | ||
| 329 | |||
| 330 | gxio_mpipe_push_buffer(&context, stack, | ||
| 331 | (void *)va_to_tile_io_addr(skb->data)); | ||
| 332 | |||
| 333 | return true; | ||
| 334 | } | ||
| 335 | |||
| 336 | /* Convert a raw mpipe buffer to its matching skb pointer. */ | ||
| 337 | static struct sk_buff *mpipe_buf_to_skb(void *va) | ||
| 338 | { | ||
| 339 | /* Acquire the associated "skb". */ | ||
| 340 | struct sk_buff **skb_ptr = va - sizeof(*skb_ptr); | ||
| 341 | struct sk_buff *skb = *skb_ptr; | ||
| 342 | |||
| 343 | /* Paranoia. */ | ||
| 344 | if (skb->data != va) { | ||
| 345 | /* Panic here since there's a reasonable chance | ||
| 346 | * that corrupt buffers means generic memory | ||
| 347 | * corruption, with unpredictable system effects. | ||
| 348 | */ | ||
| 349 | panic("Corrupt linux buffer! va=%p, skb=%p, skb->data=%p", | ||
| 350 | va, skb, skb->data); | ||
| 351 | } | ||
| 352 | |||
| 353 | return skb; | ||
| 354 | } | ||
| 355 | |||
| 356 | static void tile_net_pop_all_buffers(int stack) | ||
| 357 | { | ||
| 358 | for (;;) { | ||
| 359 | tile_io_addr_t addr = | ||
| 360 | (tile_io_addr_t)gxio_mpipe_pop_buffer(&context, stack); | ||
| 361 | if (addr == 0) | ||
| 362 | break; | ||
| 363 | dev_kfree_skb_irq(mpipe_buf_to_skb(tile_io_addr_to_va(addr))); | ||
| 364 | } | ||
| 365 | } | ||
| 366 | |||
| 367 | /* Provide linux buffers to mPIPE. */ | ||
| 368 | static void tile_net_provide_needed_buffers(void) | ||
| 369 | { | ||
| 370 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 371 | |||
| 372 | while (info->num_needed_small_buffers != 0) { | ||
| 373 | if (!tile_net_provide_buffer(true)) | ||
| 374 | goto oops; | ||
| 375 | info->num_needed_small_buffers--; | ||
| 376 | } | ||
| 377 | |||
| 378 | while (info->num_needed_large_buffers != 0) { | ||
| 379 | if (!tile_net_provide_buffer(false)) | ||
| 380 | goto oops; | ||
| 381 | info->num_needed_large_buffers--; | ||
| 382 | } | ||
| 383 | |||
| 384 | return; | ||
| 385 | |||
| 386 | oops: | ||
| 387 | /* Add a description to the page allocation failure dump. */ | ||
| 388 | pr_notice("Tile %d still needs some buffers\n", info->my_cpu); | ||
| 389 | } | ||
| 390 | |||
| 391 | static inline bool filter_packet(struct net_device *dev, void *buf) | ||
| 392 | { | ||
| 393 | /* Filter packets received before we're up. */ | ||
| 394 | if (dev == NULL || !(dev->flags & IFF_UP)) | ||
| 395 | return true; | ||
| 396 | |||
| 397 | /* Filter out packets that aren't for us. */ | ||
| 398 | if (!(dev->flags & IFF_PROMISC) && | ||
| 399 | !is_multicast_ether_addr(buf) && | ||
| 400 | compare_ether_addr(dev->dev_addr, buf) != 0) | ||
| 401 | return true; | ||
| 402 | |||
| 403 | return false; | ||
| 404 | } | ||
| 405 | |||
| 406 | static void tile_net_receive_skb(struct net_device *dev, struct sk_buff *skb, | ||
| 407 | gxio_mpipe_idesc_t *idesc, unsigned long len) | ||
| 408 | { | ||
| 409 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 410 | struct tile_net_priv *priv = netdev_priv(dev); | ||
| 411 | |||
| 412 | /* Encode the actual packet length. */ | ||
| 413 | skb_put(skb, len); | ||
| 414 | |||
| 415 | skb->protocol = eth_type_trans(skb, dev); | ||
| 416 | |||
| 417 | /* Acknowledge "good" hardware checksums. */ | ||
| 418 | if (idesc->cs && idesc->csum_seed_val == 0xFFFF) | ||
| 419 | skb->ip_summed = CHECKSUM_UNNECESSARY; | ||
| 420 | |||
| 421 | netif_receive_skb(skb); | ||
| 422 | |||
| 423 | /* Update stats. */ | ||
| 424 | tile_net_stats_add(1, &priv->stats.rx_packets); | ||
| 425 | tile_net_stats_add(len, &priv->stats.rx_bytes); | ||
| 426 | |||
| 427 | /* Need a new buffer. */ | ||
| 428 | if (idesc->size == BUFFER_SIZE_SMALL_ENUM) | ||
| 429 | info->num_needed_small_buffers++; | ||
| 430 | else | ||
| 431 | info->num_needed_large_buffers++; | ||
| 432 | } | ||
| 433 | |||
| 434 | /* Handle a packet. Return true if "processed", false if "filtered". */ | ||
| 435 | static bool tile_net_handle_packet(gxio_mpipe_idesc_t *idesc) | ||
| 436 | { | ||
| 437 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 438 | struct net_device *dev = tile_net_devs_for_channel[idesc->channel]; | ||
| 439 | uint8_t l2_offset; | ||
| 440 | void *va; | ||
| 441 | void *buf; | ||
| 442 | unsigned long len; | ||
| 443 | bool filter; | ||
| 444 | |||
| 445 | /* Drop packets for which no buffer was available. | ||
| 446 | * NOTE: This happens under heavy load. | ||
| 447 | */ | ||
| 448 | if (idesc->be) { | ||
| 449 | struct tile_net_priv *priv = netdev_priv(dev); | ||
| 450 | tile_net_stats_add(1, &priv->stats.rx_dropped); | ||
| 451 | gxio_mpipe_iqueue_consume(&info->iqueue, idesc); | ||
| 452 | if (net_ratelimit()) | ||
| 453 | pr_info("Dropping packet (insufficient buffers).\n"); | ||
| 454 | return false; | ||
| 455 | } | ||
| 456 | |||
| 457 | /* Get the "l2_offset", if allowed. */ | ||
| 458 | l2_offset = custom_str ? 0 : gxio_mpipe_idesc_get_l2_offset(idesc); | ||
| 459 | |||
| 460 | /* Get the raw buffer VA (includes "headroom"). */ | ||
| 461 | va = tile_io_addr_to_va((unsigned long)(long)idesc->va); | ||
| 462 | |||
| 463 | /* Get the actual packet start/length. */ | ||
| 464 | buf = va + l2_offset; | ||
| 465 | len = idesc->l2_size - l2_offset; | ||
| 466 | |||
| 467 | /* Point "va" at the raw buffer. */ | ||
| 468 | va -= NET_IP_ALIGN; | ||
| 469 | |||
| 470 | filter = filter_packet(dev, buf); | ||
| 471 | if (filter) { | ||
| 472 | gxio_mpipe_iqueue_drop(&info->iqueue, idesc); | ||
| 473 | } else { | ||
| 474 | struct sk_buff *skb = mpipe_buf_to_skb(va); | ||
| 475 | |||
| 476 | /* Skip headroom, and any custom header. */ | ||
| 477 | skb_reserve(skb, NET_IP_ALIGN + l2_offset); | ||
| 478 | |||
| 479 | tile_net_receive_skb(dev, skb, idesc, len); | ||
| 480 | } | ||
| 481 | |||
| 482 | gxio_mpipe_iqueue_consume(&info->iqueue, idesc); | ||
| 483 | return !filter; | ||
| 484 | } | ||
| 485 | |||
| 486 | /* Handle some packets for the current CPU. | ||
| 487 | * | ||
| 488 | * This function handles up to TILE_NET_BATCH idescs per call. | ||
| 489 | * | ||
| 490 | * ISSUE: Since we do not provide new buffers until this function is | ||
| 491 | * complete, we must initially provide enough buffers for each network | ||
| 492 | * cpu to fill its iqueue and also its batched idescs. | ||
| 493 | * | ||
| 494 | * ISSUE: The "rotting packet" race condition occurs if a packet | ||
| 495 | * arrives after the queue appears to be empty, and before the | ||
| 496 | * hypervisor interrupt is re-enabled. | ||
| 497 | */ | ||
| 498 | static int tile_net_poll(struct napi_struct *napi, int budget) | ||
| 499 | { | ||
| 500 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 501 | unsigned int work = 0; | ||
| 502 | gxio_mpipe_idesc_t *idesc; | ||
| 503 | int i, n; | ||
| 504 | |||
| 505 | /* Process packets. */ | ||
| 506 | while ((n = gxio_mpipe_iqueue_try_peek(&info->iqueue, &idesc)) > 0) { | ||
| 507 | for (i = 0; i < n; i++) { | ||
| 508 | if (i == TILE_NET_BATCH) | ||
| 509 | goto done; | ||
| 510 | if (tile_net_handle_packet(idesc + i)) { | ||
| 511 | if (++work >= budget) | ||
| 512 | goto done; | ||
| 513 | } | ||
| 514 | } | ||
| 515 | } | ||
| 516 | |||
| 517 | /* There are no packets left. */ | ||
| 518 | napi_complete(&info->napi); | ||
| 519 | |||
| 520 | /* Re-enable hypervisor interrupts. */ | ||
| 521 | gxio_mpipe_enable_notif_ring_interrupt(&context, info->iqueue.ring); | ||
| 522 | |||
| 523 | /* HACK: Avoid the "rotting packet" problem. */ | ||
| 524 | if (gxio_mpipe_iqueue_try_peek(&info->iqueue, &idesc) > 0) | ||
| 525 | napi_schedule(&info->napi); | ||
| 526 | |||
| 527 | /* ISSUE: Handle completions? */ | ||
| 528 | |||
| 529 | done: | ||
| 530 | tile_net_provide_needed_buffers(); | ||
| 531 | |||
| 532 | return work; | ||
| 533 | } | ||
| 534 | |||
| 535 | /* Handle an ingress interrupt on the current cpu. */ | ||
| 536 | static irqreturn_t tile_net_handle_ingress_irq(int irq, void *unused) | ||
| 537 | { | ||
| 538 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 539 | napi_schedule(&info->napi); | ||
| 540 | return IRQ_HANDLED; | ||
| 541 | } | ||
| 542 | |||
| 543 | /* Free some completions. This must be called with interrupts blocked. */ | ||
| 544 | static int tile_net_free_comps(gxio_mpipe_equeue_t *equeue, | ||
| 545 | struct tile_net_comps *comps, | ||
| 546 | int limit, bool force_update) | ||
| 547 | { | ||
| 548 | int n = 0; | ||
| 549 | while (comps->comp_last < comps->comp_next) { | ||
| 550 | unsigned int cid = comps->comp_last % TILE_NET_MAX_COMPS; | ||
| 551 | struct tile_net_comp *comp = &comps->comp_queue[cid]; | ||
| 552 | if (!gxio_mpipe_equeue_is_complete(equeue, comp->when, | ||
| 553 | force_update || n == 0)) | ||
| 554 | break; | ||
| 555 | dev_kfree_skb_irq(comp->skb); | ||
| 556 | comps->comp_last++; | ||
| 557 | if (++n == limit) | ||
| 558 | break; | ||
| 559 | } | ||
| 560 | return n; | ||
| 561 | } | ||
| 562 | |||
| 563 | /* Add a completion. This must be called with interrupts blocked. | ||
| 564 | * tile_net_equeue_try_reserve() will have ensured a free completion entry. | ||
| 565 | */ | ||
| 566 | static void add_comp(gxio_mpipe_equeue_t *equeue, | ||
| 567 | struct tile_net_comps *comps, | ||
| 568 | uint64_t when, struct sk_buff *skb) | ||
| 569 | { | ||
| 570 | int cid = comps->comp_next % TILE_NET_MAX_COMPS; | ||
| 571 | comps->comp_queue[cid].when = when; | ||
| 572 | comps->comp_queue[cid].skb = skb; | ||
| 573 | comps->comp_next++; | ||
| 574 | } | ||
| 575 | |||
| 576 | static void tile_net_schedule_tx_wake_timer(struct net_device *dev) | ||
| 577 | { | ||
| 578 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 579 | struct tile_net_priv *priv = netdev_priv(dev); | ||
| 580 | |||
| 581 | hrtimer_start(&info->tx_wake[priv->echannel].timer, | ||
| 582 | ktime_set(0, TX_TIMER_DELAY_USEC * 1000UL), | ||
| 583 | HRTIMER_MODE_REL_PINNED); | ||
| 584 | } | ||
| 585 | |||
| 586 | static enum hrtimer_restart tile_net_handle_tx_wake_timer(struct hrtimer *t) | ||
| 587 | { | ||
| 588 | struct tile_net_tx_wake *tx_wake = | ||
| 589 | container_of(t, struct tile_net_tx_wake, timer); | ||
| 590 | netif_wake_subqueue(tx_wake->dev, smp_processor_id()); | ||
| 591 | return HRTIMER_NORESTART; | ||
| 592 | } | ||
| 593 | |||
| 594 | /* Make sure the egress timer is scheduled. */ | ||
| 595 | static void tile_net_schedule_egress_timer(void) | ||
| 596 | { | ||
| 597 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 598 | |||
| 599 | if (!info->egress_timer_scheduled) { | ||
| 600 | hrtimer_start(&info->egress_timer, | ||
| 601 | ktime_set(0, EGRESS_TIMER_DELAY_USEC * 1000UL), | ||
| 602 | HRTIMER_MODE_REL_PINNED); | ||
| 603 | info->egress_timer_scheduled = true; | ||
| 604 | } | ||
| 605 | } | ||
| 606 | |||
| 607 | /* The "function" for "info->egress_timer". | ||
| 608 | * | ||
| 609 | * This timer will reschedule itself as long as there are any pending | ||
| 610 | * completions expected for this tile. | ||
| 611 | */ | ||
| 612 | static enum hrtimer_restart tile_net_handle_egress_timer(struct hrtimer *t) | ||
| 613 | { | ||
| 614 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 615 | unsigned long irqflags; | ||
| 616 | bool pending = false; | ||
| 617 | int i; | ||
| 618 | |||
| 619 | local_irq_save(irqflags); | ||
| 620 | |||
| 621 | /* The timer is no longer scheduled. */ | ||
| 622 | info->egress_timer_scheduled = false; | ||
| 623 | |||
| 624 | /* Free all possible comps for this tile. */ | ||
| 625 | for (i = 0; i < TILE_NET_CHANNELS; i++) { | ||
| 626 | struct tile_net_egress *egress = &egress_for_echannel[i]; | ||
| 627 | struct tile_net_comps *comps = info->comps_for_echannel[i]; | ||
| 628 | if (comps->comp_last >= comps->comp_next) | ||
| 629 | continue; | ||
| 630 | tile_net_free_comps(egress->equeue, comps, -1, true); | ||
| 631 | pending = pending || (comps->comp_last < comps->comp_next); | ||
| 632 | } | ||
| 633 | |||
| 634 | /* Reschedule timer if needed. */ | ||
| 635 | if (pending) | ||
| 636 | tile_net_schedule_egress_timer(); | ||
| 637 | |||
| 638 | local_irq_restore(irqflags); | ||
| 639 | |||
| 640 | return HRTIMER_NORESTART; | ||
| 641 | } | ||
| 642 | |||
| 643 | /* Helper function for "tile_net_update()". | ||
| 644 | * "dev" (i.e. arg) is the device being brought up or down, | ||
| 645 | * or NULL if all devices are now down. | ||
| 646 | */ | ||
| 647 | static void tile_net_update_cpu(void *arg) | ||
| 648 | { | ||
| 649 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 650 | struct net_device *dev = arg; | ||
| 651 | |||
| 652 | if (!info->has_iqueue) | ||
| 653 | return; | ||
| 654 | |||
| 655 | if (dev != NULL) { | ||
| 656 | if (!info->napi_added) { | ||
| 657 | netif_napi_add(dev, &info->napi, | ||
| 658 | tile_net_poll, TILE_NET_WEIGHT); | ||
| 659 | info->napi_added = true; | ||
| 660 | } | ||
| 661 | if (!info->napi_enabled) { | ||
| 662 | napi_enable(&info->napi); | ||
| 663 | info->napi_enabled = true; | ||
| 664 | } | ||
| 665 | enable_percpu_irq(ingress_irq, 0); | ||
| 666 | } else { | ||
| 667 | disable_percpu_irq(ingress_irq); | ||
| 668 | if (info->napi_enabled) { | ||
| 669 | napi_disable(&info->napi); | ||
| 670 | info->napi_enabled = false; | ||
| 671 | } | ||
| 672 | /* FIXME: Drain the iqueue. */ | ||
| 673 | } | ||
| 674 | } | ||
| 675 | |||
| 676 | /* Helper function for tile_net_open() and tile_net_stop(). | ||
| 677 | * Always called under tile_net_devs_for_channel_mutex. | ||
| 678 | */ | ||
| 679 | static int tile_net_update(struct net_device *dev) | ||
| 680 | { | ||
| 681 | static gxio_mpipe_rules_t rules; /* too big to fit on the stack */ | ||
| 682 | bool saw_channel = false; | ||
| 683 | int channel; | ||
| 684 | int rc; | ||
| 685 | int cpu; | ||
| 686 | |||
| 687 | gxio_mpipe_rules_init(&rules, &context); | ||
| 688 | |||
| 689 | for (channel = 0; channel < TILE_NET_CHANNELS; channel++) { | ||
| 690 | if (tile_net_devs_for_channel[channel] == NULL) | ||
| 691 | continue; | ||
| 692 | if (!saw_channel) { | ||
| 693 | saw_channel = true; | ||
| 694 | gxio_mpipe_rules_begin(&rules, first_bucket, | ||
| 695 | num_buckets, NULL); | ||
| 696 | gxio_mpipe_rules_set_headroom(&rules, NET_IP_ALIGN); | ||
| 697 | } | ||
| 698 | gxio_mpipe_rules_add_channel(&rules, channel); | ||
| 699 | } | ||
| 700 | |||
| 701 | /* NOTE: This can fail if there is no classifier. | ||
| 702 | * ISSUE: Can anything else cause it to fail? | ||
| 703 | */ | ||
| 704 | rc = gxio_mpipe_rules_commit(&rules); | ||
| 705 | if (rc != 0) { | ||
| 706 | netdev_warn(dev, "gxio_mpipe_rules_commit failed: %d\n", rc); | ||
| 707 | return -EIO; | ||
| 708 | } | ||
| 709 | |||
| 710 | /* Update all cpus, sequentially (to protect "netif_napi_add()"). */ | ||
| 711 | for_each_online_cpu(cpu) | ||
| 712 | smp_call_function_single(cpu, tile_net_update_cpu, | ||
| 713 | (saw_channel ? dev : NULL), 1); | ||
| 714 | |||
| 715 | /* HACK: Allow packets to flow in the simulator. */ | ||
| 716 | if (saw_channel) | ||
| 717 | sim_enable_mpipe_links(0, -1); | ||
| 718 | |||
| 719 | return 0; | ||
| 720 | } | ||
| 721 | |||
| 722 | /* Allocate and initialize mpipe buffer stacks, and register them in | ||
| 723 | * the mPIPE TLBs, for both small and large packet sizes. | ||
| 724 | * This routine supports tile_net_init_mpipe(), below. | ||
| 725 | */ | ||
| 726 | static int init_buffer_stacks(struct net_device *dev, int num_buffers) | ||
| 727 | { | ||
| 728 | pte_t hash_pte = pte_set_home((pte_t) { 0 }, PAGE_HOME_HASH); | ||
| 729 | int rc; | ||
| 730 | |||
| 731 | /* Compute stack bytes; we round up to 64KB and then use | ||
| 732 | * alloc_pages() so we get the required 64KB alignment as well. | ||
| 733 | */ | ||
| 734 | buffer_stack_size = | ||
| 735 | ALIGN(gxio_mpipe_calc_buffer_stack_bytes(num_buffers), | ||
| 736 | 64 * 1024); | ||
| 737 | |||
| 738 | /* Allocate two buffer stack indices. */ | ||
| 739 | rc = gxio_mpipe_alloc_buffer_stacks(&context, 2, 0, 0); | ||
| 740 | if (rc < 0) { | ||
| 741 | netdev_err(dev, "gxio_mpipe_alloc_buffer_stacks failed: %d\n", | ||
| 742 | rc); | ||
| 743 | return rc; | ||
| 744 | } | ||
| 745 | small_buffer_stack = rc; | ||
| 746 | large_buffer_stack = rc + 1; | ||
| 747 | |||
| 748 | /* Allocate the small memory stack. */ | ||
| 749 | small_buffer_stack_va = | ||
| 750 | alloc_pages_exact(buffer_stack_size, GFP_KERNEL); | ||
| 751 | if (small_buffer_stack_va == NULL) { | ||
| 752 | netdev_err(dev, | ||
| 753 | "Could not alloc %zd bytes for buffer stacks\n", | ||
| 754 | buffer_stack_size); | ||
| 755 | return -ENOMEM; | ||
| 756 | } | ||
| 757 | rc = gxio_mpipe_init_buffer_stack(&context, small_buffer_stack, | ||
| 758 | BUFFER_SIZE_SMALL_ENUM, | ||
| 759 | small_buffer_stack_va, | ||
| 760 | buffer_stack_size, 0); | ||
| 761 | if (rc != 0) { | ||
| 762 | netdev_err(dev, "gxio_mpipe_init_buffer_stack: %d\n", rc); | ||
| 763 | return rc; | ||
| 764 | } | ||
| 765 | rc = gxio_mpipe_register_client_memory(&context, small_buffer_stack, | ||
| 766 | hash_pte, 0); | ||
| 767 | if (rc != 0) { | ||
| 768 | netdev_err(dev, | ||
| 769 | "gxio_mpipe_register_buffer_memory failed: %d\n", | ||
| 770 | rc); | ||
| 771 | return rc; | ||
| 772 | } | ||
| 773 | |||
| 774 | /* Allocate the large buffer stack. */ | ||
| 775 | large_buffer_stack_va = | ||
| 776 | alloc_pages_exact(buffer_stack_size, GFP_KERNEL); | ||
| 777 | if (large_buffer_stack_va == NULL) { | ||
| 778 | netdev_err(dev, | ||
| 779 | "Could not alloc %zd bytes for buffer stacks\n", | ||
| 780 | buffer_stack_size); | ||
| 781 | return -ENOMEM; | ||
| 782 | } | ||
| 783 | rc = gxio_mpipe_init_buffer_stack(&context, large_buffer_stack, | ||
| 784 | BUFFER_SIZE_LARGE_ENUM, | ||
| 785 | large_buffer_stack_va, | ||
| 786 | buffer_stack_size, 0); | ||
| 787 | if (rc != 0) { | ||
| 788 | netdev_err(dev, "gxio_mpipe_init_buffer_stack failed: %d\n", | ||
| 789 | rc); | ||
| 790 | return rc; | ||
| 791 | } | ||
| 792 | rc = gxio_mpipe_register_client_memory(&context, large_buffer_stack, | ||
| 793 | hash_pte, 0); | ||
| 794 | if (rc != 0) { | ||
| 795 | netdev_err(dev, | ||
| 796 | "gxio_mpipe_register_buffer_memory failed: %d\n", | ||
| 797 | rc); | ||
| 798 | return rc; | ||
| 799 | } | ||
| 800 | |||
| 801 | return 0; | ||
| 802 | } | ||
| 803 | |||
| 804 | /* Allocate per-cpu resources (memory for completions and idescs). | ||
| 805 | * This routine supports tile_net_init_mpipe(), below. | ||
| 806 | */ | ||
| 807 | static int alloc_percpu_mpipe_resources(struct net_device *dev, | ||
| 808 | int cpu, int ring) | ||
| 809 | { | ||
| 810 | struct tile_net_info *info = &per_cpu(per_cpu_info, cpu); | ||
| 811 | int order, i, rc; | ||
| 812 | struct page *page; | ||
| 813 | void *addr; | ||
| 814 | |||
| 815 | /* Allocate the "comps". */ | ||
| 816 | order = get_order(COMPS_SIZE); | ||
| 817 | page = homecache_alloc_pages(GFP_KERNEL, order, cpu); | ||
| 818 | if (page == NULL) { | ||
| 819 | netdev_err(dev, "Failed to alloc %zd bytes comps memory\n", | ||
| 820 | COMPS_SIZE); | ||
| 821 | return -ENOMEM; | ||
| 822 | } | ||
| 823 | addr = pfn_to_kaddr(page_to_pfn(page)); | ||
| 824 | memset(addr, 0, COMPS_SIZE); | ||
| 825 | for (i = 0; i < TILE_NET_CHANNELS; i++) | ||
| 826 | info->comps_for_echannel[i] = | ||
| 827 | addr + i * sizeof(struct tile_net_comps); | ||
| 828 | |||
| 829 | /* If this is a network cpu, create an iqueue. */ | ||
| 830 | if (cpu_isset(cpu, network_cpus_map)) { | ||
| 831 | order = get_order(NOTIF_RING_SIZE); | ||
| 832 | page = homecache_alloc_pages(GFP_KERNEL, order, cpu); | ||
| 833 | if (page == NULL) { | ||
| 834 | netdev_err(dev, | ||
| 835 | "Failed to alloc %zd bytes iqueue memory\n", | ||
| 836 | NOTIF_RING_SIZE); | ||
| 837 | return -ENOMEM; | ||
| 838 | } | ||
| 839 | addr = pfn_to_kaddr(page_to_pfn(page)); | ||
| 840 | rc = gxio_mpipe_iqueue_init(&info->iqueue, &context, ring++, | ||
| 841 | addr, NOTIF_RING_SIZE, 0); | ||
| 842 | if (rc < 0) { | ||
| 843 | netdev_err(dev, | ||
| 844 | "gxio_mpipe_iqueue_init failed: %d\n", rc); | ||
| 845 | return rc; | ||
| 846 | } | ||
| 847 | info->has_iqueue = true; | ||
| 848 | } | ||
| 849 | |||
| 850 | return ring; | ||
| 851 | } | ||
| 852 | |||
| 853 | /* Initialize NotifGroup and buckets. | ||
| 854 | * This routine supports tile_net_init_mpipe(), below. | ||
| 855 | */ | ||
| 856 | static int init_notif_group_and_buckets(struct net_device *dev, | ||
| 857 | int ring, int network_cpus_count) | ||
| 858 | { | ||
| 859 | int group, rc; | ||
| 860 | |||
| 861 | /* Allocate one NotifGroup. */ | ||
| 862 | rc = gxio_mpipe_alloc_notif_groups(&context, 1, 0, 0); | ||
| 863 | if (rc < 0) { | ||
| 864 | netdev_err(dev, "gxio_mpipe_alloc_notif_groups failed: %d\n", | ||
| 865 | rc); | ||
| 866 | return rc; | ||
| 867 | } | ||
| 868 | group = rc; | ||
| 869 | |||
| 870 | /* Initialize global num_buckets value. */ | ||
| 871 | if (network_cpus_count > 4) | ||
| 872 | num_buckets = 256; | ||
| 873 | else if (network_cpus_count > 1) | ||
| 874 | num_buckets = 16; | ||
| 875 | |||
| 876 | /* Allocate some buckets, and set global first_bucket value. */ | ||
| 877 | rc = gxio_mpipe_alloc_buckets(&context, num_buckets, 0, 0); | ||
| 878 | if (rc < 0) { | ||
| 879 | netdev_err(dev, "gxio_mpipe_alloc_buckets failed: %d\n", rc); | ||
| 880 | return rc; | ||
| 881 | } | ||
| 882 | first_bucket = rc; | ||
| 883 | |||
| 884 | /* Init group and buckets. */ | ||
| 885 | rc = gxio_mpipe_init_notif_group_and_buckets( | ||
| 886 | &context, group, ring, network_cpus_count, | ||
| 887 | first_bucket, num_buckets, | ||
| 888 | GXIO_MPIPE_BUCKET_STICKY_FLOW_LOCALITY); | ||
| 889 | if (rc != 0) { | ||
| 890 | netdev_err( | ||
| 891 | dev, | ||
| 892 | "gxio_mpipe_init_notif_group_and_buckets failed: %d\n", | ||
| 893 | rc); | ||
| 894 | return rc; | ||
| 895 | } | ||
| 896 | |||
| 897 | return 0; | ||
| 898 | } | ||
| 899 | |||
| 900 | /* Create an irq and register it, then activate the irq and request | ||
| 901 | * interrupts on all cores. Note that "ingress_irq" being initialized | ||
| 902 | * is how we know not to call tile_net_init_mpipe() again. | ||
| 903 | * This routine supports tile_net_init_mpipe(), below. | ||
| 904 | */ | ||
| 905 | static int tile_net_setup_interrupts(struct net_device *dev) | ||
| 906 | { | ||
| 907 | int cpu, rc; | ||
| 908 | |||
| 909 | rc = create_irq(); | ||
| 910 | if (rc < 0) { | ||
| 911 | netdev_err(dev, "create_irq failed: %d\n", rc); | ||
| 912 | return rc; | ||
| 913 | } | ||
| 914 | ingress_irq = rc; | ||
| 915 | tile_irq_activate(ingress_irq, TILE_IRQ_PERCPU); | ||
| 916 | rc = request_irq(ingress_irq, tile_net_handle_ingress_irq, | ||
| 917 | 0, NULL, NULL); | ||
| 918 | if (rc != 0) { | ||
| 919 | netdev_err(dev, "request_irq failed: %d\n", rc); | ||
| 920 | destroy_irq(ingress_irq); | ||
| 921 | ingress_irq = -1; | ||
| 922 | return rc; | ||
| 923 | } | ||
| 924 | |||
| 925 | for_each_online_cpu(cpu) { | ||
| 926 | struct tile_net_info *info = &per_cpu(per_cpu_info, cpu); | ||
| 927 | if (info->has_iqueue) { | ||
| 928 | gxio_mpipe_request_notif_ring_interrupt( | ||
| 929 | &context, cpu_x(cpu), cpu_y(cpu), | ||
| 930 | 1, ingress_irq, info->iqueue.ring); | ||
| 931 | } | ||
| 932 | } | ||
| 933 | |||
| 934 | return 0; | ||
| 935 | } | ||
| 936 | |||
| 937 | /* Undo any state set up partially by a failed call to tile_net_init_mpipe. */ | ||
| 938 | static void tile_net_init_mpipe_fail(void) | ||
| 939 | { | ||
| 940 | int cpu; | ||
| 941 | |||
| 942 | /* Do cleanups that require the mpipe context first. */ | ||
| 943 | if (small_buffer_stack >= 0) | ||
| 944 | tile_net_pop_all_buffers(small_buffer_stack); | ||
| 945 | if (large_buffer_stack >= 0) | ||
| 946 | tile_net_pop_all_buffers(large_buffer_stack); | ||
| 947 | |||
| 948 | /* Destroy mpipe context so the hardware no longer owns any memory. */ | ||
| 949 | gxio_mpipe_destroy(&context); | ||
| 950 | |||
| 951 | for_each_online_cpu(cpu) { | ||
| 952 | struct tile_net_info *info = &per_cpu(per_cpu_info, cpu); | ||
| 953 | free_pages((unsigned long)(info->comps_for_echannel[0]), | ||
| 954 | get_order(COMPS_SIZE)); | ||
| 955 | info->comps_for_echannel[0] = NULL; | ||
| 956 | free_pages((unsigned long)(info->iqueue.idescs), | ||
| 957 | get_order(NOTIF_RING_SIZE)); | ||
| 958 | info->iqueue.idescs = NULL; | ||
| 959 | } | ||
| 960 | |||
| 961 | if (small_buffer_stack_va) | ||
| 962 | free_pages_exact(small_buffer_stack_va, buffer_stack_size); | ||
| 963 | if (large_buffer_stack_va) | ||
| 964 | free_pages_exact(large_buffer_stack_va, buffer_stack_size); | ||
| 965 | |||
| 966 | small_buffer_stack_va = NULL; | ||
| 967 | large_buffer_stack_va = NULL; | ||
| 968 | large_buffer_stack = -1; | ||
| 969 | small_buffer_stack = -1; | ||
| 970 | first_bucket = -1; | ||
| 971 | } | ||
| 972 | |||
| 973 | /* The first time any tilegx network device is opened, we initialize | ||
| 974 | * the global mpipe state. If this step fails, we fail to open the | ||
| 975 | * device, but if it succeeds, we never need to do it again, and since | ||
| 976 | * tile_net can't be unloaded, we never undo it. | ||
| 977 | * | ||
| 978 | * Note that some resources in this path (buffer stack indices, | ||
| 979 | * bindings from init_buffer_stack, etc.) are hypervisor resources | ||
| 980 | * that are freed implicitly by gxio_mpipe_destroy(). | ||
| 981 | */ | ||
| 982 | static int tile_net_init_mpipe(struct net_device *dev) | ||
| 983 | { | ||
| 984 | int i, num_buffers, rc; | ||
| 985 | int cpu; | ||
| 986 | int first_ring, ring; | ||
| 987 | int network_cpus_count = cpus_weight(network_cpus_map); | ||
| 988 | |||
| 989 | if (!hash_default) { | ||
| 990 | netdev_err(dev, "Networking requires hash_default!\n"); | ||
| 991 | return -EIO; | ||
| 992 | } | ||
| 993 | |||
| 994 | rc = gxio_mpipe_init(&context, 0); | ||
| 995 | if (rc != 0) { | ||
| 996 | netdev_err(dev, "gxio_mpipe_init failed: %d\n", rc); | ||
| 997 | return -EIO; | ||
| 998 | } | ||
| 999 | |||
| 1000 | /* Set up the buffer stacks. */ | ||
| 1001 | num_buffers = | ||
| 1002 | network_cpus_count * (IQUEUE_ENTRIES + TILE_NET_BATCH); | ||
| 1003 | rc = init_buffer_stacks(dev, num_buffers); | ||
| 1004 | if (rc != 0) | ||
| 1005 | goto fail; | ||
| 1006 | |||
| 1007 | /* Provide initial buffers. */ | ||
| 1008 | rc = -ENOMEM; | ||
| 1009 | for (i = 0; i < num_buffers; i++) { | ||
| 1010 | if (!tile_net_provide_buffer(true)) { | ||
| 1011 | netdev_err(dev, "Cannot allocate initial sk_bufs!\n"); | ||
| 1012 | goto fail; | ||
| 1013 | } | ||
| 1014 | } | ||
| 1015 | for (i = 0; i < num_buffers; i++) { | ||
| 1016 | if (!tile_net_provide_buffer(false)) { | ||
| 1017 | netdev_err(dev, "Cannot allocate initial sk_bufs!\n"); | ||
| 1018 | goto fail; | ||
| 1019 | } | ||
| 1020 | } | ||
| 1021 | |||
| 1022 | /* Allocate one NotifRing for each network cpu. */ | ||
| 1023 | rc = gxio_mpipe_alloc_notif_rings(&context, network_cpus_count, 0, 0); | ||
| 1024 | if (rc < 0) { | ||
| 1025 | netdev_err(dev, "gxio_mpipe_alloc_notif_rings failed %d\n", | ||
| 1026 | rc); | ||
| 1027 | goto fail; | ||
| 1028 | } | ||
| 1029 | |||
| 1030 | /* Init NotifRings per-cpu. */ | ||
| 1031 | first_ring = rc; | ||
| 1032 | ring = first_ring; | ||
| 1033 | for_each_online_cpu(cpu) { | ||
| 1034 | rc = alloc_percpu_mpipe_resources(dev, cpu, ring); | ||
| 1035 | if (rc < 0) | ||
| 1036 | goto fail; | ||
| 1037 | ring = rc; | ||
| 1038 | } | ||
| 1039 | |||
| 1040 | /* Initialize NotifGroup and buckets. */ | ||
| 1041 | rc = init_notif_group_and_buckets(dev, first_ring, network_cpus_count); | ||
| 1042 | if (rc != 0) | ||
| 1043 | goto fail; | ||
| 1044 | |||
| 1045 | /* Create and enable interrupts. */ | ||
| 1046 | rc = tile_net_setup_interrupts(dev); | ||
| 1047 | if (rc != 0) | ||
| 1048 | goto fail; | ||
| 1049 | |||
| 1050 | return 0; | ||
| 1051 | |||
| 1052 | fail: | ||
| 1053 | tile_net_init_mpipe_fail(); | ||
| 1054 | return rc; | ||
| 1055 | } | ||
| 1056 | |||
| 1057 | /* Create persistent egress info for a given egress channel. | ||
| 1058 | * Note that this may be shared between, say, "gbe0" and "xgbe0". | ||
| 1059 | * ISSUE: Defer header allocation until TSO is actually needed? | ||
| 1060 | */ | ||
| 1061 | static int tile_net_init_egress(struct net_device *dev, int echannel) | ||
| 1062 | { | ||
| 1063 | struct page *headers_page, *edescs_page, *equeue_page; | ||
| 1064 | gxio_mpipe_edesc_t *edescs; | ||
| 1065 | gxio_mpipe_equeue_t *equeue; | ||
| 1066 | unsigned char *headers; | ||
| 1067 | int headers_order, edescs_order, equeue_order; | ||
| 1068 | size_t edescs_size; | ||
| 1069 | int edma; | ||
| 1070 | int rc = -ENOMEM; | ||
| 1071 | |||
| 1072 | /* Only initialize once. */ | ||
| 1073 | if (egress_for_echannel[echannel].equeue != NULL) | ||
| 1074 | return 0; | ||
| 1075 | |||
| 1076 | /* Allocate memory for the "headers". */ | ||
| 1077 | headers_order = get_order(EQUEUE_ENTRIES * HEADER_BYTES); | ||
| 1078 | headers_page = alloc_pages(GFP_KERNEL, headers_order); | ||
| 1079 | if (headers_page == NULL) { | ||
| 1080 | netdev_warn(dev, | ||
| 1081 | "Could not alloc %zd bytes for TSO headers.\n", | ||
| 1082 | PAGE_SIZE << headers_order); | ||
| 1083 | goto fail; | ||
| 1084 | } | ||
| 1085 | headers = pfn_to_kaddr(page_to_pfn(headers_page)); | ||
| 1086 | |||
| 1087 | /* Allocate memory for the "edescs". */ | ||
| 1088 | edescs_size = EQUEUE_ENTRIES * sizeof(*edescs); | ||
| 1089 | edescs_order = get_order(edescs_size); | ||
| 1090 | edescs_page = alloc_pages(GFP_KERNEL, edescs_order); | ||
| 1091 | if (edescs_page == NULL) { | ||
| 1092 | netdev_warn(dev, | ||
| 1093 | "Could not alloc %zd bytes for eDMA ring.\n", | ||
| 1094 | edescs_size); | ||
| 1095 | goto fail_headers; | ||
| 1096 | } | ||
| 1097 | edescs = pfn_to_kaddr(page_to_pfn(edescs_page)); | ||
| 1098 | |||
| 1099 | /* Allocate memory for the "equeue". */ | ||
| 1100 | equeue_order = get_order(sizeof(*equeue)); | ||
| 1101 | equeue_page = alloc_pages(GFP_KERNEL, equeue_order); | ||
| 1102 | if (equeue_page == NULL) { | ||
| 1103 | netdev_warn(dev, | ||
| 1104 | "Could not alloc %zd bytes for equeue info.\n", | ||
| 1105 | PAGE_SIZE << equeue_order); | ||
| 1106 | goto fail_edescs; | ||
| 1107 | } | ||
| 1108 | equeue = pfn_to_kaddr(page_to_pfn(equeue_page)); | ||
| 1109 | |||
| 1110 | /* Allocate an edma ring. Note that in practice this can't | ||
| 1111 | * fail, which is good, because we will leak an edma ring if so. | ||
| 1112 | */ | ||
| 1113 | rc = gxio_mpipe_alloc_edma_rings(&context, 1, 0, 0); | ||
| 1114 | if (rc < 0) { | ||
| 1115 | netdev_warn(dev, "gxio_mpipe_alloc_edma_rings failed: %d\n", | ||
| 1116 | rc); | ||
| 1117 | goto fail_equeue; | ||
| 1118 | } | ||
| 1119 | edma = rc; | ||
| 1120 | |||
| 1121 | /* Initialize the equeue. */ | ||
| 1122 | rc = gxio_mpipe_equeue_init(equeue, &context, edma, echannel, | ||
| 1123 | edescs, edescs_size, 0); | ||
| 1124 | if (rc != 0) { | ||
| 1125 | netdev_err(dev, "gxio_mpipe_equeue_init failed: %d\n", rc); | ||
| 1126 | goto fail_equeue; | ||
| 1127 | } | ||
| 1128 | |||
| 1129 | /* Done. */ | ||
| 1130 | egress_for_echannel[echannel].equeue = equeue; | ||
| 1131 | egress_for_echannel[echannel].headers = headers; | ||
| 1132 | return 0; | ||
| 1133 | |||
| 1134 | fail_equeue: | ||
| 1135 | __free_pages(equeue_page, equeue_order); | ||
| 1136 | |||
| 1137 | fail_edescs: | ||
| 1138 | __free_pages(edescs_page, edescs_order); | ||
| 1139 | |||
| 1140 | fail_headers: | ||
| 1141 | __free_pages(headers_page, headers_order); | ||
| 1142 | |||
| 1143 | fail: | ||
| 1144 | return rc; | ||
| 1145 | } | ||
| 1146 | |||
| 1147 | /* Return channel number for a newly-opened link. */ | ||
| 1148 | static int tile_net_link_open(struct net_device *dev, gxio_mpipe_link_t *link, | ||
| 1149 | const char *link_name) | ||
| 1150 | { | ||
| 1151 | int rc = gxio_mpipe_link_open(link, &context, link_name, 0); | ||
| 1152 | if (rc < 0) { | ||
| 1153 | netdev_err(dev, "Failed to open '%s'\n", link_name); | ||
| 1154 | return rc; | ||
| 1155 | } | ||
| 1156 | rc = gxio_mpipe_link_channel(link); | ||
| 1157 | if (rc < 0 || rc >= TILE_NET_CHANNELS) { | ||
| 1158 | netdev_err(dev, "gxio_mpipe_link_channel bad value: %d\n", rc); | ||
| 1159 | gxio_mpipe_link_close(link); | ||
| 1160 | return -EINVAL; | ||
| 1161 | } | ||
| 1162 | return rc; | ||
| 1163 | } | ||
| 1164 | |||
| 1165 | /* Help the kernel activate the given network interface. */ | ||
| 1166 | static int tile_net_open(struct net_device *dev) | ||
| 1167 | { | ||
| 1168 | struct tile_net_priv *priv = netdev_priv(dev); | ||
| 1169 | int cpu, rc; | ||
| 1170 | |||
| 1171 | mutex_lock(&tile_net_devs_for_channel_mutex); | ||
| 1172 | |||
| 1173 | /* Do one-time initialization the first time any device is opened. */ | ||
| 1174 | if (ingress_irq < 0) { | ||
| 1175 | rc = tile_net_init_mpipe(dev); | ||
| 1176 | if (rc != 0) | ||
| 1177 | goto fail; | ||
| 1178 | } | ||
| 1179 | |||
| 1180 | /* Determine if this is the "loopify" device. */ | ||
| 1181 | if (unlikely((loopify_link_name != NULL) && | ||
| 1182 | !strcmp(dev->name, loopify_link_name))) { | ||
| 1183 | rc = tile_net_link_open(dev, &priv->link, "loop0"); | ||
| 1184 | if (rc < 0) | ||
| 1185 | goto fail; | ||
| 1186 | priv->channel = rc; | ||
| 1187 | rc = tile_net_link_open(dev, &priv->loopify_link, "loop1"); | ||
| 1188 | if (rc < 0) | ||
| 1189 | goto fail; | ||
| 1190 | priv->loopify_channel = rc; | ||
| 1191 | priv->echannel = rc; | ||
| 1192 | } else { | ||
| 1193 | rc = tile_net_link_open(dev, &priv->link, dev->name); | ||
| 1194 | if (rc < 0) | ||
| 1195 | goto fail; | ||
| 1196 | priv->channel = rc; | ||
| 1197 | priv->echannel = rc; | ||
| 1198 | } | ||
| 1199 | |||
| 1200 | /* Initialize egress info (if needed). Once ever, per echannel. */ | ||
| 1201 | rc = tile_net_init_egress(dev, priv->echannel); | ||
| 1202 | if (rc != 0) | ||
| 1203 | goto fail; | ||
| 1204 | |||
| 1205 | tile_net_devs_for_channel[priv->channel] = dev; | ||
| 1206 | |||
| 1207 | rc = tile_net_update(dev); | ||
| 1208 | if (rc != 0) | ||
| 1209 | goto fail; | ||
| 1210 | |||
| 1211 | mutex_unlock(&tile_net_devs_for_channel_mutex); | ||
| 1212 | |||
| 1213 | /* Initialize the transmit wake timer for this device for each cpu. */ | ||
| 1214 | for_each_online_cpu(cpu) { | ||
| 1215 | struct tile_net_info *info = &per_cpu(per_cpu_info, cpu); | ||
| 1216 | struct tile_net_tx_wake *tx_wake = | ||
| 1217 | &info->tx_wake[priv->echannel]; | ||
| 1218 | |||
| 1219 | hrtimer_init(&tx_wake->timer, CLOCK_MONOTONIC, | ||
| 1220 | HRTIMER_MODE_REL); | ||
| 1221 | tx_wake->timer.function = tile_net_handle_tx_wake_timer; | ||
| 1222 | tx_wake->dev = dev; | ||
| 1223 | } | ||
| 1224 | |||
| 1225 | for_each_online_cpu(cpu) | ||
| 1226 | netif_start_subqueue(dev, cpu); | ||
| 1227 | netif_carrier_on(dev); | ||
| 1228 | return 0; | ||
| 1229 | |||
| 1230 | fail: | ||
| 1231 | if (priv->loopify_channel >= 0) { | ||
| 1232 | if (gxio_mpipe_link_close(&priv->loopify_link) != 0) | ||
| 1233 | netdev_warn(dev, "Failed to close loopify link!\n"); | ||
| 1234 | priv->loopify_channel = -1; | ||
| 1235 | } | ||
| 1236 | if (priv->channel >= 0) { | ||
| 1237 | if (gxio_mpipe_link_close(&priv->link) != 0) | ||
| 1238 | netdev_warn(dev, "Failed to close link!\n"); | ||
| 1239 | priv->channel = -1; | ||
| 1240 | } | ||
| 1241 | priv->echannel = -1; | ||
| 1242 | tile_net_devs_for_channel[priv->channel] = NULL; | ||
| 1243 | mutex_unlock(&tile_net_devs_for_channel_mutex); | ||
| 1244 | |||
| 1245 | /* Don't return raw gxio error codes to generic Linux. */ | ||
| 1246 | return (rc > -512) ? rc : -EIO; | ||
| 1247 | } | ||
| 1248 | |||
| 1249 | /* Help the kernel deactivate the given network interface. */ | ||
| 1250 | static int tile_net_stop(struct net_device *dev) | ||
| 1251 | { | ||
| 1252 | struct tile_net_priv *priv = netdev_priv(dev); | ||
| 1253 | int cpu; | ||
| 1254 | |||
| 1255 | for_each_online_cpu(cpu) { | ||
| 1256 | struct tile_net_info *info = &per_cpu(per_cpu_info, cpu); | ||
| 1257 | struct tile_net_tx_wake *tx_wake = | ||
| 1258 | &info->tx_wake[priv->echannel]; | ||
| 1259 | |||
| 1260 | hrtimer_cancel(&tx_wake->timer); | ||
| 1261 | netif_stop_subqueue(dev, cpu); | ||
| 1262 | } | ||
| 1263 | |||
| 1264 | mutex_lock(&tile_net_devs_for_channel_mutex); | ||
| 1265 | tile_net_devs_for_channel[priv->channel] = NULL; | ||
| 1266 | (void)tile_net_update(dev); | ||
| 1267 | if (priv->loopify_channel >= 0) { | ||
| 1268 | if (gxio_mpipe_link_close(&priv->loopify_link) != 0) | ||
| 1269 | netdev_warn(dev, "Failed to close loopify link!\n"); | ||
| 1270 | priv->loopify_channel = -1; | ||
| 1271 | } | ||
| 1272 | if (priv->channel >= 0) { | ||
| 1273 | if (gxio_mpipe_link_close(&priv->link) != 0) | ||
| 1274 | netdev_warn(dev, "Failed to close link!\n"); | ||
| 1275 | priv->channel = -1; | ||
| 1276 | } | ||
| 1277 | priv->echannel = -1; | ||
| 1278 | mutex_unlock(&tile_net_devs_for_channel_mutex); | ||
| 1279 | |||
| 1280 | return 0; | ||
| 1281 | } | ||
| 1282 | |||
| 1283 | /* Determine the VA for a fragment. */ | ||
| 1284 | static inline void *tile_net_frag_buf(skb_frag_t *f) | ||
| 1285 | { | ||
| 1286 | unsigned long pfn = page_to_pfn(skb_frag_page(f)); | ||
| 1287 | return pfn_to_kaddr(pfn) + f->page_offset; | ||
| 1288 | } | ||
| 1289 | |||
| 1290 | /* Acquire a completion entry and an egress slot, or if we can't, | ||
| 1291 | * stop the queue and schedule the tx_wake timer. | ||
| 1292 | */ | ||
| 1293 | static s64 tile_net_equeue_try_reserve(struct net_device *dev, | ||
| 1294 | struct tile_net_comps *comps, | ||
| 1295 | gxio_mpipe_equeue_t *equeue, | ||
| 1296 | int num_edescs) | ||
| 1297 | { | ||
| 1298 | /* Try to acquire a completion entry. */ | ||
| 1299 | if (comps->comp_next - comps->comp_last < TILE_NET_MAX_COMPS - 1 || | ||
| 1300 | tile_net_free_comps(equeue, comps, 32, false) != 0) { | ||
| 1301 | |||
| 1302 | /* Try to acquire an egress slot. */ | ||
| 1303 | s64 slot = gxio_mpipe_equeue_try_reserve(equeue, num_edescs); | ||
| 1304 | if (slot >= 0) | ||
| 1305 | return slot; | ||
| 1306 | |||
| 1307 | /* Freeing some completions gives the equeue time to drain. */ | ||
| 1308 | tile_net_free_comps(equeue, comps, TILE_NET_MAX_COMPS, false); | ||
| 1309 | |||
| 1310 | slot = gxio_mpipe_equeue_try_reserve(equeue, num_edescs); | ||
| 1311 | if (slot >= 0) | ||
| 1312 | return slot; | ||
| 1313 | } | ||
| 1314 | |||
| 1315 | /* Still nothing; give up and stop the queue for a short while. */ | ||
| 1316 | netif_stop_subqueue(dev, smp_processor_id()); | ||
| 1317 | tile_net_schedule_tx_wake_timer(dev); | ||
| 1318 | return -1; | ||
| 1319 | } | ||
| 1320 | |||
| 1321 | /* Determine how many edesc's are needed for TSO. | ||
| 1322 | * | ||
| 1323 | * Sometimes, if "sendfile()" requires copying, we will be called with | ||
| 1324 | * "data" containing the header and payload, with "frags" being empty. | ||
| 1325 | * Sometimes, for example when using NFS over TCP, a single segment can | ||
| 1326 | * span 3 fragments. This requires special care. | ||
| 1327 | */ | ||
| 1328 | static int tso_count_edescs(struct sk_buff *skb) | ||
| 1329 | { | ||
| 1330 | struct skb_shared_info *sh = skb_shinfo(skb); | ||
| 1331 | unsigned int data_len = skb->data_len; | ||
| 1332 | unsigned int p_len = sh->gso_size; | ||
| 1333 | long f_id = -1; /* id of the current fragment */ | ||
| 1334 | long f_size = -1; /* size of the current fragment */ | ||
| 1335 | long f_used = -1; /* bytes used from the current fragment */ | ||
| 1336 | long n; /* size of the current piece of payload */ | ||
| 1337 | int num_edescs = 0; | ||
| 1338 | int segment; | ||
| 1339 | |||
| 1340 | for (segment = 0; segment < sh->gso_segs; segment++) { | ||
| 1341 | |||
| 1342 | unsigned int p_used = 0; | ||
| 1343 | |||
| 1344 | /* One edesc for header and for each piece of the payload. */ | ||
| 1345 | for (num_edescs++; p_used < p_len; num_edescs++) { | ||
| 1346 | |||
| 1347 | /* Advance as needed. */ | ||
| 1348 | while (f_used >= f_size) { | ||
| 1349 | f_id++; | ||
| 1350 | f_size = sh->frags[f_id].size; | ||
| 1351 | f_used = 0; | ||
| 1352 | } | ||
| 1353 | |||
| 1354 | /* Use bytes from the current fragment. */ | ||
| 1355 | n = p_len - p_used; | ||
| 1356 | if (n > f_size - f_used) | ||
| 1357 | n = f_size - f_used; | ||
| 1358 | f_used += n; | ||
| 1359 | p_used += n; | ||
| 1360 | } | ||
| 1361 | |||
| 1362 | /* The last segment may be less than gso_size. */ | ||
| 1363 | data_len -= p_len; | ||
| 1364 | if (data_len < p_len) | ||
| 1365 | p_len = data_len; | ||
| 1366 | } | ||
| 1367 | |||
| 1368 | return num_edescs; | ||
| 1369 | } | ||
| 1370 | |||
| 1371 | /* Prepare modified copies of the skbuff headers. | ||
| 1372 | * FIXME: add support for IPv6. | ||
| 1373 | */ | ||
| 1374 | static void tso_headers_prepare(struct sk_buff *skb, unsigned char *headers, | ||
| 1375 | s64 slot) | ||
| 1376 | { | ||
| 1377 | struct skb_shared_info *sh = skb_shinfo(skb); | ||
| 1378 | struct iphdr *ih; | ||
| 1379 | struct tcphdr *th; | ||
| 1380 | unsigned int data_len = skb->data_len; | ||
| 1381 | unsigned char *data = skb->data; | ||
| 1382 | unsigned int ih_off, th_off, sh_len, p_len; | ||
| 1383 | unsigned int isum_seed, tsum_seed, id, seq; | ||
| 1384 | long f_id = -1; /* id of the current fragment */ | ||
| 1385 | long f_size = -1; /* size of the current fragment */ | ||
| 1386 | long f_used = -1; /* bytes used from the current fragment */ | ||
| 1387 | long n; /* size of the current piece of payload */ | ||
| 1388 | int segment; | ||
| 1389 | |||
| 1390 | /* Locate original headers and compute various lengths. */ | ||
| 1391 | ih = ip_hdr(skb); | ||
| 1392 | th = tcp_hdr(skb); | ||
| 1393 | ih_off = skb_network_offset(skb); | ||
| 1394 | th_off = skb_transport_offset(skb); | ||
| 1395 | sh_len = th_off + tcp_hdrlen(skb); | ||
| 1396 | p_len = sh->gso_size; | ||
| 1397 | |||
| 1398 | /* Set up seed values for IP and TCP csum and initialize id and seq. */ | ||
| 1399 | isum_seed = ((0xFFFF - ih->check) + | ||
| 1400 | (0xFFFF - ih->tot_len) + | ||
| 1401 | (0xFFFF - ih->id)); | ||
| 1402 | tsum_seed = th->check + (0xFFFF ^ htons(skb->len)); | ||
| 1403 | id = ntohs(ih->id); | ||
| 1404 | seq = ntohl(th->seq); | ||
| 1405 | |||
| 1406 | /* Prepare all the headers. */ | ||
| 1407 | for (segment = 0; segment < sh->gso_segs; segment++) { | ||
| 1408 | unsigned char *buf; | ||
| 1409 | unsigned int p_used = 0; | ||
| 1410 | |||
| 1411 | /* Copy to the header memory for this segment. */ | ||
| 1412 | buf = headers + (slot % EQUEUE_ENTRIES) * HEADER_BYTES + | ||
| 1413 | NET_IP_ALIGN; | ||
| 1414 | memcpy(buf, data, sh_len); | ||
| 1415 | |||
| 1416 | /* Update copied ip header. */ | ||
| 1417 | ih = (struct iphdr *)(buf + ih_off); | ||
| 1418 | ih->tot_len = htons(sh_len + p_len - ih_off); | ||
| 1419 | ih->id = htons(id); | ||
| 1420 | ih->check = csum_long(isum_seed + ih->tot_len + | ||
| 1421 | ih->id) ^ 0xffff; | ||
| 1422 | |||
| 1423 | /* Update copied tcp header. */ | ||
| 1424 | th = (struct tcphdr *)(buf + th_off); | ||
| 1425 | th->seq = htonl(seq); | ||
| 1426 | th->check = csum_long(tsum_seed + htons(sh_len + p_len)); | ||
| 1427 | if (segment != sh->gso_segs - 1) { | ||
| 1428 | th->fin = 0; | ||
| 1429 | th->psh = 0; | ||
| 1430 | } | ||
| 1431 | |||
| 1432 | /* Skip past the header. */ | ||
| 1433 | slot++; | ||
| 1434 | |||
| 1435 | /* Skip past the payload. */ | ||
| 1436 | while (p_used < p_len) { | ||
| 1437 | |||
| 1438 | /* Advance as needed. */ | ||
| 1439 | while (f_used >= f_size) { | ||
| 1440 | f_id++; | ||
| 1441 | f_size = sh->frags[f_id].size; | ||
| 1442 | f_used = 0; | ||
| 1443 | } | ||
| 1444 | |||
| 1445 | /* Use bytes from the current fragment. */ | ||
| 1446 | n = p_len - p_used; | ||
| 1447 | if (n > f_size - f_used) | ||
| 1448 | n = f_size - f_used; | ||
| 1449 | f_used += n; | ||
| 1450 | p_used += n; | ||
| 1451 | |||
| 1452 | slot++; | ||
| 1453 | } | ||
| 1454 | |||
| 1455 | id++; | ||
| 1456 | seq += p_len; | ||
| 1457 | |||
| 1458 | /* The last segment may be less than gso_size. */ | ||
| 1459 | data_len -= p_len; | ||
| 1460 | if (data_len < p_len) | ||
| 1461 | p_len = data_len; | ||
| 1462 | } | ||
| 1463 | |||
| 1464 | /* Flush the headers so they are ready for hardware DMA. */ | ||
| 1465 | wmb(); | ||
| 1466 | } | ||
| 1467 | |||
| 1468 | /* Pass all the data to mpipe for egress. */ | ||
| 1469 | static void tso_egress(struct net_device *dev, gxio_mpipe_equeue_t *equeue, | ||
| 1470 | struct sk_buff *skb, unsigned char *headers, s64 slot) | ||
| 1471 | { | ||
| 1472 | struct tile_net_priv *priv = netdev_priv(dev); | ||
| 1473 | struct skb_shared_info *sh = skb_shinfo(skb); | ||
| 1474 | unsigned int data_len = skb->data_len; | ||
| 1475 | unsigned int p_len = sh->gso_size; | ||
| 1476 | gxio_mpipe_edesc_t edesc_head = { { 0 } }; | ||
| 1477 | gxio_mpipe_edesc_t edesc_body = { { 0 } }; | ||
| 1478 | long f_id = -1; /* id of the current fragment */ | ||
| 1479 | long f_size = -1; /* size of the current fragment */ | ||
| 1480 | long f_used = -1; /* bytes used from the current fragment */ | ||
| 1481 | long n; /* size of the current piece of payload */ | ||
| 1482 | unsigned long tx_packets = 0, tx_bytes = 0; | ||
| 1483 | unsigned int csum_start, sh_len; | ||
| 1484 | int segment; | ||
| 1485 | |||
| 1486 | /* Prepare to egress the headers: set up header edesc. */ | ||
| 1487 | csum_start = skb_checksum_start_offset(skb); | ||
| 1488 | sh_len = skb_transport_offset(skb) + tcp_hdrlen(skb); | ||
| 1489 | edesc_head.csum = 1; | ||
| 1490 | edesc_head.csum_start = csum_start; | ||
| 1491 | edesc_head.csum_dest = csum_start + skb->csum_offset; | ||
| 1492 | edesc_head.xfer_size = sh_len; | ||
| 1493 | |||
| 1494 | /* This is only used to specify the TLB. */ | ||
| 1495 | edesc_head.stack_idx = large_buffer_stack; | ||
| 1496 | edesc_body.stack_idx = large_buffer_stack; | ||
| 1497 | |||
| 1498 | /* Egress all the edescs. */ | ||
| 1499 | for (segment = 0; segment < sh->gso_segs; segment++) { | ||
| 1500 | void *va; | ||
| 1501 | unsigned char *buf; | ||
| 1502 | unsigned int p_used = 0; | ||
| 1503 | |||
| 1504 | /* Egress the header. */ | ||
| 1505 | buf = headers + (slot % EQUEUE_ENTRIES) * HEADER_BYTES + | ||
| 1506 | NET_IP_ALIGN; | ||
| 1507 | edesc_head.va = va_to_tile_io_addr(buf); | ||
| 1508 | gxio_mpipe_equeue_put_at(equeue, edesc_head, slot); | ||
| 1509 | slot++; | ||
| 1510 | |||
| 1511 | /* Egress the payload. */ | ||
| 1512 | while (p_used < p_len) { | ||
| 1513 | |||
| 1514 | /* Advance as needed. */ | ||
| 1515 | while (f_used >= f_size) { | ||
| 1516 | f_id++; | ||
| 1517 | f_size = sh->frags[f_id].size; | ||
| 1518 | f_used = 0; | ||
| 1519 | } | ||
| 1520 | |||
| 1521 | va = tile_net_frag_buf(&sh->frags[f_id]) + f_used; | ||
| 1522 | |||
| 1523 | /* Use bytes from the current fragment. */ | ||
| 1524 | n = p_len - p_used; | ||
| 1525 | if (n > f_size - f_used) | ||
| 1526 | n = f_size - f_used; | ||
| 1527 | f_used += n; | ||
| 1528 | p_used += n; | ||
| 1529 | |||
| 1530 | /* Egress a piece of the payload. */ | ||
| 1531 | edesc_body.va = va_to_tile_io_addr(va); | ||
| 1532 | edesc_body.xfer_size = n; | ||
| 1533 | edesc_body.bound = !(p_used < p_len); | ||
| 1534 | gxio_mpipe_equeue_put_at(equeue, edesc_body, slot); | ||
| 1535 | slot++; | ||
| 1536 | } | ||
| 1537 | |||
| 1538 | tx_packets++; | ||
| 1539 | tx_bytes += sh_len + p_len; | ||
| 1540 | |||
| 1541 | /* The last segment may be less than gso_size. */ | ||
| 1542 | data_len -= p_len; | ||
| 1543 | if (data_len < p_len) | ||
| 1544 | p_len = data_len; | ||
| 1545 | } | ||
| 1546 | |||
| 1547 | /* Update stats. */ | ||
| 1548 | tile_net_stats_add(tx_packets, &priv->stats.tx_packets); | ||
| 1549 | tile_net_stats_add(tx_bytes, &priv->stats.tx_bytes); | ||
| 1550 | } | ||
| 1551 | |||
| 1552 | /* Do "TSO" handling for egress. | ||
| 1553 | * | ||
| 1554 | * Normally drivers set NETIF_F_TSO only to support hardware TSO; | ||
| 1555 | * otherwise the stack uses scatter-gather to implement GSO in software. | ||
| 1556 | * On our testing, enabling GSO support (via NETIF_F_SG) drops network | ||
| 1557 | * performance down to around 7.5 Gbps on the 10G interfaces, although | ||
| 1558 | * also dropping cpu utilization way down, to under 8%. But | ||
| 1559 | * implementing "TSO" in the driver brings performance back up to line | ||
| 1560 | * rate, while dropping cpu usage even further, to less than 4%. In | ||
| 1561 | * practice, profiling of GSO shows that skb_segment() is what causes | ||
| 1562 | * the performance overheads; we benefit in the driver from using | ||
| 1563 | * preallocated memory to duplicate the TCP/IP headers. | ||
| 1564 | */ | ||
| 1565 | static int tile_net_tx_tso(struct sk_buff *skb, struct net_device *dev) | ||
| 1566 | { | ||
| 1567 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 1568 | struct tile_net_priv *priv = netdev_priv(dev); | ||
| 1569 | int channel = priv->echannel; | ||
| 1570 | struct tile_net_egress *egress = &egress_for_echannel[channel]; | ||
| 1571 | struct tile_net_comps *comps = info->comps_for_echannel[channel]; | ||
| 1572 | gxio_mpipe_equeue_t *equeue = egress->equeue; | ||
| 1573 | unsigned long irqflags; | ||
| 1574 | int num_edescs; | ||
| 1575 | s64 slot; | ||
| 1576 | |||
| 1577 | /* Determine how many mpipe edesc's are needed. */ | ||
| 1578 | num_edescs = tso_count_edescs(skb); | ||
| 1579 | |||
| 1580 | local_irq_save(irqflags); | ||
| 1581 | |||
| 1582 | /* Try to acquire a completion entry and an egress slot. */ | ||
| 1583 | slot = tile_net_equeue_try_reserve(dev, comps, equeue, num_edescs); | ||
| 1584 | if (slot < 0) { | ||
| 1585 | local_irq_restore(irqflags); | ||
| 1586 | return NETDEV_TX_BUSY; | ||
| 1587 | } | ||
| 1588 | |||
| 1589 | /* Set up copies of header data properly. */ | ||
| 1590 | tso_headers_prepare(skb, egress->headers, slot); | ||
| 1591 | |||
| 1592 | /* Actually pass the data to the network hardware. */ | ||
| 1593 | tso_egress(dev, equeue, skb, egress->headers, slot); | ||
| 1594 | |||
| 1595 | /* Add a completion record. */ | ||
| 1596 | add_comp(equeue, comps, slot + num_edescs - 1, skb); | ||
| 1597 | |||
| 1598 | local_irq_restore(irqflags); | ||
| 1599 | |||
| 1600 | /* Make sure the egress timer is scheduled. */ | ||
| 1601 | tile_net_schedule_egress_timer(); | ||
| 1602 | |||
| 1603 | return NETDEV_TX_OK; | ||
| 1604 | } | ||
| 1605 | |||
| 1606 | /* Analyze the body and frags for a transmit request. */ | ||
| 1607 | static unsigned int tile_net_tx_frags(struct frag *frags, | ||
| 1608 | struct sk_buff *skb, | ||
| 1609 | void *b_data, unsigned int b_len) | ||
| 1610 | { | ||
| 1611 | unsigned int i, n = 0; | ||
| 1612 | |||
| 1613 | struct skb_shared_info *sh = skb_shinfo(skb); | ||
| 1614 | |||
| 1615 | if (b_len != 0) { | ||
| 1616 | frags[n].buf = b_data; | ||
| 1617 | frags[n++].length = b_len; | ||
| 1618 | } | ||
| 1619 | |||
| 1620 | for (i = 0; i < sh->nr_frags; i++) { | ||
| 1621 | skb_frag_t *f = &sh->frags[i]; | ||
| 1622 | frags[n].buf = tile_net_frag_buf(f); | ||
| 1623 | frags[n++].length = skb_frag_size(f); | ||
| 1624 | } | ||
| 1625 | |||
| 1626 | return n; | ||
| 1627 | } | ||
| 1628 | |||
| 1629 | /* Help the kernel transmit a packet. */ | ||
| 1630 | static int tile_net_tx(struct sk_buff *skb, struct net_device *dev) | ||
| 1631 | { | ||
| 1632 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 1633 | struct tile_net_priv *priv = netdev_priv(dev); | ||
| 1634 | struct tile_net_egress *egress = &egress_for_echannel[priv->echannel]; | ||
| 1635 | gxio_mpipe_equeue_t *equeue = egress->equeue; | ||
| 1636 | struct tile_net_comps *comps = | ||
| 1637 | info->comps_for_echannel[priv->echannel]; | ||
| 1638 | unsigned int len = skb->len; | ||
| 1639 | unsigned char *data = skb->data; | ||
| 1640 | unsigned int num_edescs; | ||
| 1641 | struct frag frags[MAX_FRAGS]; | ||
| 1642 | gxio_mpipe_edesc_t edescs[MAX_FRAGS]; | ||
| 1643 | unsigned long irqflags; | ||
| 1644 | gxio_mpipe_edesc_t edesc = { { 0 } }; | ||
| 1645 | unsigned int i; | ||
| 1646 | s64 slot; | ||
| 1647 | |||
| 1648 | if (skb_is_gso(skb)) | ||
| 1649 | return tile_net_tx_tso(skb, dev); | ||
| 1650 | |||
| 1651 | num_edescs = tile_net_tx_frags(frags, skb, data, skb_headlen(skb)); | ||
| 1652 | |||
| 1653 | /* This is only used to specify the TLB. */ | ||
| 1654 | edesc.stack_idx = large_buffer_stack; | ||
| 1655 | |||
| 1656 | /* Prepare the edescs. */ | ||
| 1657 | for (i = 0; i < num_edescs; i++) { | ||
| 1658 | edesc.xfer_size = frags[i].length; | ||
| 1659 | edesc.va = va_to_tile_io_addr(frags[i].buf); | ||
| 1660 | edescs[i] = edesc; | ||
| 1661 | } | ||
| 1662 | |||
| 1663 | /* Mark the final edesc. */ | ||
| 1664 | edescs[num_edescs - 1].bound = 1; | ||
| 1665 | |||
| 1666 | /* Add checksum info to the initial edesc, if needed. */ | ||
| 1667 | if (skb->ip_summed == CHECKSUM_PARTIAL) { | ||
| 1668 | unsigned int csum_start = skb_checksum_start_offset(skb); | ||
| 1669 | edescs[0].csum = 1; | ||
| 1670 | edescs[0].csum_start = csum_start; | ||
| 1671 | edescs[0].csum_dest = csum_start + skb->csum_offset; | ||
| 1672 | } | ||
| 1673 | |||
| 1674 | local_irq_save(irqflags); | ||
| 1675 | |||
| 1676 | /* Try to acquire a completion entry and an egress slot. */ | ||
| 1677 | slot = tile_net_equeue_try_reserve(dev, comps, equeue, num_edescs); | ||
| 1678 | if (slot < 0) { | ||
| 1679 | local_irq_restore(irqflags); | ||
| 1680 | return NETDEV_TX_BUSY; | ||
| 1681 | } | ||
| 1682 | |||
| 1683 | for (i = 0; i < num_edescs; i++) | ||
| 1684 | gxio_mpipe_equeue_put_at(equeue, edescs[i], slot++); | ||
| 1685 | |||
| 1686 | /* Add a completion record. */ | ||
| 1687 | add_comp(equeue, comps, slot - 1, skb); | ||
| 1688 | |||
| 1689 | /* NOTE: Use ETH_ZLEN for short packets (e.g. 42 < 60). */ | ||
| 1690 | tile_net_stats_add(1, &priv->stats.tx_packets); | ||
| 1691 | tile_net_stats_add(max_t(unsigned int, len, ETH_ZLEN), | ||
| 1692 | &priv->stats.tx_bytes); | ||
| 1693 | |||
| 1694 | local_irq_restore(irqflags); | ||
| 1695 | |||
| 1696 | /* Make sure the egress timer is scheduled. */ | ||
| 1697 | tile_net_schedule_egress_timer(); | ||
| 1698 | |||
| 1699 | return NETDEV_TX_OK; | ||
| 1700 | } | ||
| 1701 | |||
| 1702 | /* Return subqueue id on this core (one per core). */ | ||
| 1703 | static u16 tile_net_select_queue(struct net_device *dev, struct sk_buff *skb) | ||
| 1704 | { | ||
| 1705 | return smp_processor_id(); | ||
| 1706 | } | ||
| 1707 | |||
| 1708 | /* Deal with a transmit timeout. */ | ||
| 1709 | static void tile_net_tx_timeout(struct net_device *dev) | ||
| 1710 | { | ||
| 1711 | int cpu; | ||
| 1712 | |||
| 1713 | for_each_online_cpu(cpu) | ||
| 1714 | netif_wake_subqueue(dev, cpu); | ||
| 1715 | } | ||
| 1716 | |||
| 1717 | /* Ioctl commands. */ | ||
| 1718 | static int tile_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) | ||
| 1719 | { | ||
| 1720 | return -EOPNOTSUPP; | ||
| 1721 | } | ||
| 1722 | |||
| 1723 | /* Get system network statistics for device. */ | ||
| 1724 | static struct net_device_stats *tile_net_get_stats(struct net_device *dev) | ||
| 1725 | { | ||
| 1726 | struct tile_net_priv *priv = netdev_priv(dev); | ||
| 1727 | return &priv->stats; | ||
| 1728 | } | ||
| 1729 | |||
| 1730 | /* Change the MTU. */ | ||
| 1731 | static int tile_net_change_mtu(struct net_device *dev, int new_mtu) | ||
| 1732 | { | ||
| 1733 | if ((new_mtu < 68) || (new_mtu > 1500)) | ||
| 1734 | return -EINVAL; | ||
| 1735 | dev->mtu = new_mtu; | ||
| 1736 | return 0; | ||
| 1737 | } | ||
| 1738 | |||
| 1739 | /* Change the Ethernet address of the NIC. | ||
| 1740 | * | ||
| 1741 | * The hypervisor driver does not support changing MAC address. However, | ||
| 1742 | * the hardware does not do anything with the MAC address, so the address | ||
| 1743 | * which gets used on outgoing packets, and which is accepted on incoming | ||
| 1744 | * packets, is completely up to us. | ||
| 1745 | * | ||
| 1746 | * Returns 0 on success, negative on failure. | ||
| 1747 | */ | ||
| 1748 | static int tile_net_set_mac_address(struct net_device *dev, void *p) | ||
| 1749 | { | ||
| 1750 | struct sockaddr *addr = p; | ||
| 1751 | |||
| 1752 | if (!is_valid_ether_addr(addr->sa_data)) | ||
| 1753 | return -EINVAL; | ||
| 1754 | memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); | ||
| 1755 | return 0; | ||
| 1756 | } | ||
| 1757 | |||
| 1758 | #ifdef CONFIG_NET_POLL_CONTROLLER | ||
| 1759 | /* Polling 'interrupt' - used by things like netconsole to send skbs | ||
| 1760 | * without having to re-enable interrupts. It's not called while | ||
| 1761 | * the interrupt routine is executing. | ||
| 1762 | */ | ||
| 1763 | static void tile_net_netpoll(struct net_device *dev) | ||
| 1764 | { | ||
| 1765 | disable_percpu_irq(ingress_irq); | ||
| 1766 | tile_net_handle_ingress_irq(ingress_irq, NULL); | ||
| 1767 | enable_percpu_irq(ingress_irq, 0); | ||
| 1768 | } | ||
| 1769 | #endif | ||
| 1770 | |||
| 1771 | static const struct net_device_ops tile_net_ops = { | ||
| 1772 | .ndo_open = tile_net_open, | ||
| 1773 | .ndo_stop = tile_net_stop, | ||
| 1774 | .ndo_start_xmit = tile_net_tx, | ||
| 1775 | .ndo_select_queue = tile_net_select_queue, | ||
| 1776 | .ndo_do_ioctl = tile_net_ioctl, | ||
| 1777 | .ndo_get_stats = tile_net_get_stats, | ||
| 1778 | .ndo_change_mtu = tile_net_change_mtu, | ||
| 1779 | .ndo_tx_timeout = tile_net_tx_timeout, | ||
| 1780 | .ndo_set_mac_address = tile_net_set_mac_address, | ||
| 1781 | #ifdef CONFIG_NET_POLL_CONTROLLER | ||
| 1782 | .ndo_poll_controller = tile_net_netpoll, | ||
| 1783 | #endif | ||
| 1784 | }; | ||
| 1785 | |||
| 1786 | /* The setup function. | ||
| 1787 | * | ||
| 1788 | * This uses ether_setup() to assign various fields in dev, including | ||
| 1789 | * setting IFF_BROADCAST and IFF_MULTICAST, then sets some extra fields. | ||
| 1790 | */ | ||
| 1791 | static void tile_net_setup(struct net_device *dev) | ||
| 1792 | { | ||
| 1793 | ether_setup(dev); | ||
| 1794 | dev->netdev_ops = &tile_net_ops; | ||
| 1795 | dev->watchdog_timeo = TILE_NET_TIMEOUT; | ||
| 1796 | dev->features |= NETIF_F_LLTX; | ||
| 1797 | dev->features |= NETIF_F_HW_CSUM; | ||
| 1798 | dev->features |= NETIF_F_SG; | ||
| 1799 | dev->features |= NETIF_F_TSO; | ||
| 1800 | dev->mtu = 1500; | ||
| 1801 | } | ||
| 1802 | |||
| 1803 | /* Allocate the device structure, register the device, and obtain the | ||
| 1804 | * MAC address from the hypervisor. | ||
| 1805 | */ | ||
| 1806 | static void tile_net_dev_init(const char *name, const uint8_t *mac) | ||
| 1807 | { | ||
| 1808 | int ret; | ||
| 1809 | int i; | ||
| 1810 | int nz_addr = 0; | ||
| 1811 | struct net_device *dev; | ||
| 1812 | struct tile_net_priv *priv; | ||
| 1813 | |||
| 1814 | /* HACK: Ignore "loop" links. */ | ||
| 1815 | if (strncmp(name, "loop", 4) == 0) | ||
| 1816 | return; | ||
| 1817 | |||
| 1818 | /* Allocate the device structure. Normally, "name" is a | ||
| 1819 | * template, instantiated by register_netdev(), but not for us. | ||
| 1820 | */ | ||
| 1821 | dev = alloc_netdev_mqs(sizeof(*priv), name, tile_net_setup, | ||
| 1822 | NR_CPUS, 1); | ||
| 1823 | if (!dev) { | ||
| 1824 | pr_err("alloc_netdev_mqs(%s) failed\n", name); | ||
| 1825 | return; | ||
| 1826 | } | ||
| 1827 | |||
| 1828 | /* Initialize "priv". */ | ||
| 1829 | priv = netdev_priv(dev); | ||
| 1830 | memset(priv, 0, sizeof(*priv)); | ||
| 1831 | priv->dev = dev; | ||
| 1832 | priv->channel = -1; | ||
| 1833 | priv->loopify_channel = -1; | ||
| 1834 | priv->echannel = -1; | ||
| 1835 | |||
| 1836 | /* Get the MAC address and set it in the device struct; this must | ||
| 1837 | * be done before the device is opened. If the MAC is all zeroes, | ||
| 1838 | * we use a random address, since we're probably on the simulator. | ||
| 1839 | */ | ||
| 1840 | for (i = 0; i < 6; i++) | ||
| 1841 | nz_addr |= mac[i]; | ||
| 1842 | |||
| 1843 | if (nz_addr) { | ||
| 1844 | memcpy(dev->dev_addr, mac, 6); | ||
| 1845 | dev->addr_len = 6; | ||
| 1846 | } else { | ||
| 1847 | random_ether_addr(dev->dev_addr); | ||
| 1848 | } | ||
| 1849 | |||
| 1850 | /* Register the network device. */ | ||
| 1851 | ret = register_netdev(dev); | ||
| 1852 | if (ret) { | ||
| 1853 | netdev_err(dev, "register_netdev failed %d\n", ret); | ||
| 1854 | free_netdev(dev); | ||
| 1855 | return; | ||
| 1856 | } | ||
| 1857 | } | ||
| 1858 | |||
| 1859 | /* Per-cpu module initialization. */ | ||
| 1860 | static void tile_net_init_module_percpu(void *unused) | ||
| 1861 | { | ||
| 1862 | struct tile_net_info *info = &__get_cpu_var(per_cpu_info); | ||
| 1863 | int my_cpu = smp_processor_id(); | ||
| 1864 | |||
| 1865 | info->has_iqueue = false; | ||
| 1866 | |||
| 1867 | info->my_cpu = my_cpu; | ||
| 1868 | |||
| 1869 | /* Initialize the egress timer. */ | ||
| 1870 | hrtimer_init(&info->egress_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); | ||
| 1871 | info->egress_timer.function = tile_net_handle_egress_timer; | ||
| 1872 | } | ||
| 1873 | |||
| 1874 | /* Module initialization. */ | ||
| 1875 | static int __init tile_net_init_module(void) | ||
| 1876 | { | ||
| 1877 | int i; | ||
| 1878 | char name[GXIO_MPIPE_LINK_NAME_LEN]; | ||
| 1879 | uint8_t mac[6]; | ||
| 1880 | |||
| 1881 | pr_info("Tilera Network Driver\n"); | ||
| 1882 | |||
| 1883 | mutex_init(&tile_net_devs_for_channel_mutex); | ||
| 1884 | |||
| 1885 | /* Initialize each CPU. */ | ||
| 1886 | on_each_cpu(tile_net_init_module_percpu, NULL, 1); | ||
| 1887 | |||
| 1888 | /* Find out what devices we have, and initialize them. */ | ||
| 1889 | for (i = 0; gxio_mpipe_link_enumerate_mac(i, name, mac) >= 0; i++) | ||
| 1890 | tile_net_dev_init(name, mac); | ||
| 1891 | |||
| 1892 | if (!network_cpus_init()) | ||
| 1893 | network_cpus_map = *cpu_online_mask; | ||
| 1894 | |||
| 1895 | return 0; | ||
| 1896 | } | ||
| 1897 | |||
| 1898 | module_init(tile_net_init_module); | ||
diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h index 4ffcd57b011b..2857ab078aac 100644 --- a/drivers/net/hyperv/hyperv_net.h +++ b/drivers/net/hyperv/hyperv_net.h | |||
| @@ -478,6 +478,7 @@ struct netvsc_device { | |||
| 478 | u32 nvsp_version; | 478 | u32 nvsp_version; |
| 479 | 479 | ||
| 480 | atomic_t num_outstanding_sends; | 480 | atomic_t num_outstanding_sends; |
| 481 | wait_queue_head_t wait_drain; | ||
| 481 | bool start_remove; | 482 | bool start_remove; |
| 482 | bool destroy; | 483 | bool destroy; |
| 483 | /* | 484 | /* |
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index 8b919471472f..0c569831db5a 100644 --- a/drivers/net/hyperv/netvsc.c +++ b/drivers/net/hyperv/netvsc.c | |||
| @@ -42,6 +42,7 @@ static struct netvsc_device *alloc_net_device(struct hv_device *device) | |||
| 42 | if (!net_device) | 42 | if (!net_device) |
| 43 | return NULL; | 43 | return NULL; |
| 44 | 44 | ||
| 45 | init_waitqueue_head(&net_device->wait_drain); | ||
| 45 | net_device->start_remove = false; | 46 | net_device->start_remove = false; |
| 46 | net_device->destroy = false; | 47 | net_device->destroy = false; |
| 47 | net_device->dev = device; | 48 | net_device->dev = device; |
| @@ -387,12 +388,8 @@ int netvsc_device_remove(struct hv_device *device) | |||
| 387 | spin_unlock_irqrestore(&device->channel->inbound_lock, flags); | 388 | spin_unlock_irqrestore(&device->channel->inbound_lock, flags); |
| 388 | 389 | ||
| 389 | /* Wait for all send completions */ | 390 | /* Wait for all send completions */ |
| 390 | while (atomic_read(&net_device->num_outstanding_sends)) { | 391 | wait_event(net_device->wait_drain, |
| 391 | dev_info(&device->device, | 392 | atomic_read(&net_device->num_outstanding_sends) == 0); |
| 392 | "waiting for %d requests to complete...\n", | ||
| 393 | atomic_read(&net_device->num_outstanding_sends)); | ||
| 394 | udelay(100); | ||
| 395 | } | ||
| 396 | 393 | ||
| 397 | netvsc_disconnect_vsp(net_device); | 394 | netvsc_disconnect_vsp(net_device); |
| 398 | 395 | ||
| @@ -486,6 +483,9 @@ static void netvsc_send_completion(struct hv_device *device, | |||
| 486 | num_outstanding_sends = | 483 | num_outstanding_sends = |
| 487 | atomic_dec_return(&net_device->num_outstanding_sends); | 484 | atomic_dec_return(&net_device->num_outstanding_sends); |
| 488 | 485 | ||
| 486 | if (net_device->destroy && num_outstanding_sends == 0) | ||
| 487 | wake_up(&net_device->wait_drain); | ||
| 488 | |||
| 489 | if (netif_queue_stopped(ndev) && !net_device->start_remove && | 489 | if (netif_queue_stopped(ndev) && !net_device->start_remove && |
| 490 | (hv_ringbuf_avail_percent(&device->channel->outbound) | 490 | (hv_ringbuf_avail_percent(&device->channel->outbound) |
| 491 | > RING_AVAIL_PERCENT_HIWATER || | 491 | > RING_AVAIL_PERCENT_HIWATER || |
diff --git a/drivers/net/phy/icplus.c b/drivers/net/phy/icplus.c index 5ac46f5226f3..47f8e8939266 100644 --- a/drivers/net/phy/icplus.c +++ b/drivers/net/phy/icplus.c | |||
| @@ -41,6 +41,8 @@ MODULE_LICENSE("GPL"); | |||
| 41 | #define IP1001_APS_ON 11 /* IP1001 APS Mode bit */ | 41 | #define IP1001_APS_ON 11 /* IP1001 APS Mode bit */ |
| 42 | #define IP101A_G_APS_ON 2 /* IP101A/G APS Mode bit */ | 42 | #define IP101A_G_APS_ON 2 /* IP101A/G APS Mode bit */ |
| 43 | #define IP101A_G_IRQ_CONF_STATUS 0x11 /* Conf Info IRQ & Status Reg */ | 43 | #define IP101A_G_IRQ_CONF_STATUS 0x11 /* Conf Info IRQ & Status Reg */ |
| 44 | #define IP101A_G_IRQ_PIN_USED (1<<15) /* INTR pin used */ | ||
| 45 | #define IP101A_G_IRQ_DEFAULT IP101A_G_IRQ_PIN_USED | ||
| 44 | 46 | ||
| 45 | static int ip175c_config_init(struct phy_device *phydev) | 47 | static int ip175c_config_init(struct phy_device *phydev) |
| 46 | { | 48 | { |
| @@ -136,6 +138,11 @@ static int ip1001_config_init(struct phy_device *phydev) | |||
| 136 | if (c < 0) | 138 | if (c < 0) |
| 137 | return c; | 139 | return c; |
| 138 | 140 | ||
| 141 | /* INTR pin used: speed/link/duplex will cause an interrupt */ | ||
| 142 | c = phy_write(phydev, IP101A_G_IRQ_CONF_STATUS, IP101A_G_IRQ_DEFAULT); | ||
| 143 | if (c < 0) | ||
| 144 | return c; | ||
| 145 | |||
| 139 | if (phydev->interface == PHY_INTERFACE_MODE_RGMII) { | 146 | if (phydev->interface == PHY_INTERFACE_MODE_RGMII) { |
| 140 | /* Additional delay (2ns) used to adjust RX clock phase | 147 | /* Additional delay (2ns) used to adjust RX clock phase |
| 141 | * at RGMII interface */ | 148 | * at RGMII interface */ |
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 683ef1ce5519..5061608f408c 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c | |||
| @@ -96,7 +96,7 @@ static int of_mdio_bus_match(struct device *dev, void *mdio_bus_np) | |||
| 96 | } | 96 | } |
| 97 | /** | 97 | /** |
| 98 | * of_mdio_find_bus - Given an mii_bus node, find the mii_bus. | 98 | * of_mdio_find_bus - Given an mii_bus node, find the mii_bus. |
| 99 | * @mdio_np: Pointer to the mii_bus. | 99 | * @mdio_bus_np: Pointer to the mii_bus. |
| 100 | * | 100 | * |
| 101 | * Returns a pointer to the mii_bus, or NULL if none found. | 101 | * Returns a pointer to the mii_bus, or NULL if none found. |
| 102 | * | 102 | * |
diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c index 3faef5670d1f..d75d1f56becf 100644 --- a/drivers/net/usb/sierra_net.c +++ b/drivers/net/usb/sierra_net.c | |||
| @@ -946,7 +946,7 @@ struct sk_buff *sierra_net_tx_fixup(struct usbnet *dev, struct sk_buff *skb, | |||
| 946 | } | 946 | } |
| 947 | 947 | ||
| 948 | static const u8 sierra_net_ifnum_list[] = { 7, 10, 11 }; | 948 | static const u8 sierra_net_ifnum_list[] = { 7, 10, 11 }; |
| 949 | static const struct sierra_net_info_data sierra_net_info_data_68A3 = { | 949 | static const struct sierra_net_info_data sierra_net_info_data_direct_ip = { |
| 950 | .rx_urb_size = 8 * 1024, | 950 | .rx_urb_size = 8 * 1024, |
| 951 | .whitelist = { | 951 | .whitelist = { |
| 952 | .infolen = ARRAY_SIZE(sierra_net_ifnum_list), | 952 | .infolen = ARRAY_SIZE(sierra_net_ifnum_list), |
| @@ -954,7 +954,7 @@ static const struct sierra_net_info_data sierra_net_info_data_68A3 = { | |||
| 954 | } | 954 | } |
| 955 | }; | 955 | }; |
| 956 | 956 | ||
| 957 | static const struct driver_info sierra_net_info_68A3 = { | 957 | static const struct driver_info sierra_net_info_direct_ip = { |
| 958 | .description = "Sierra Wireless USB-to-WWAN Modem", | 958 | .description = "Sierra Wireless USB-to-WWAN Modem", |
| 959 | .flags = FLAG_WWAN | FLAG_SEND_ZLP, | 959 | .flags = FLAG_WWAN | FLAG_SEND_ZLP, |
| 960 | .bind = sierra_net_bind, | 960 | .bind = sierra_net_bind, |
| @@ -962,12 +962,18 @@ static const struct driver_info sierra_net_info_68A3 = { | |||
| 962 | .status = sierra_net_status, | 962 | .status = sierra_net_status, |
| 963 | .rx_fixup = sierra_net_rx_fixup, | 963 | .rx_fixup = sierra_net_rx_fixup, |
| 964 | .tx_fixup = sierra_net_tx_fixup, | 964 | .tx_fixup = sierra_net_tx_fixup, |
| 965 | .data = (unsigned long)&sierra_net_info_data_68A3, | 965 | .data = (unsigned long)&sierra_net_info_data_direct_ip, |
| 966 | }; | 966 | }; |
| 967 | 967 | ||
| 968 | static const struct usb_device_id products[] = { | 968 | static const struct usb_device_id products[] = { |
| 969 | {USB_DEVICE(0x1199, 0x68A3), /* Sierra Wireless USB-to-WWAN modem */ | 969 | {USB_DEVICE(0x1199, 0x68A3), /* Sierra Wireless USB-to-WWAN modem */ |
| 970 | .driver_info = (unsigned long) &sierra_net_info_68A3}, | 970 | .driver_info = (unsigned long) &sierra_net_info_direct_ip}, |
| 971 | {USB_DEVICE(0x0F3D, 0x68A3), /* AT&T Direct IP modem */ | ||
| 972 | .driver_info = (unsigned long) &sierra_net_info_direct_ip}, | ||
| 973 | {USB_DEVICE(0x1199, 0x68AA), /* Sierra Wireless Direct IP LTE modem */ | ||
| 974 | .driver_info = (unsigned long) &sierra_net_info_direct_ip}, | ||
| 975 | {USB_DEVICE(0x0F3D, 0x68AA), /* AT&T Direct IP LTE modem */ | ||
| 976 | .driver_info = (unsigned long) &sierra_net_info_direct_ip}, | ||
| 971 | 977 | ||
| 972 | {}, /* last item */ | 978 | {}, /* last item */ |
| 973 | }; | 979 | }; |
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 5214b1eceb95..f18149ae2588 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c | |||
| @@ -42,7 +42,8 @@ module_param(gso, bool, 0444); | |||
| 42 | #define VIRTNET_DRIVER_VERSION "1.0.0" | 42 | #define VIRTNET_DRIVER_VERSION "1.0.0" |
| 43 | 43 | ||
| 44 | struct virtnet_stats { | 44 | struct virtnet_stats { |
| 45 | struct u64_stats_sync syncp; | 45 | struct u64_stats_sync tx_syncp; |
| 46 | struct u64_stats_sync rx_syncp; | ||
| 46 | u64 tx_bytes; | 47 | u64 tx_bytes; |
| 47 | u64 tx_packets; | 48 | u64 tx_packets; |
| 48 | 49 | ||
| @@ -300,10 +301,10 @@ static void receive_buf(struct net_device *dev, void *buf, unsigned int len) | |||
| 300 | 301 | ||
| 301 | hdr = skb_vnet_hdr(skb); | 302 | hdr = skb_vnet_hdr(skb); |
| 302 | 303 | ||
| 303 | u64_stats_update_begin(&stats->syncp); | 304 | u64_stats_update_begin(&stats->rx_syncp); |
| 304 | stats->rx_bytes += skb->len; | 305 | stats->rx_bytes += skb->len; |
| 305 | stats->rx_packets++; | 306 | stats->rx_packets++; |
| 306 | u64_stats_update_end(&stats->syncp); | 307 | u64_stats_update_end(&stats->rx_syncp); |
| 307 | 308 | ||
| 308 | if (hdr->hdr.flags & VIRTIO_NET_HDR_F_NEEDS_CSUM) { | 309 | if (hdr->hdr.flags & VIRTIO_NET_HDR_F_NEEDS_CSUM) { |
| 309 | pr_debug("Needs csum!\n"); | 310 | pr_debug("Needs csum!\n"); |
| @@ -565,10 +566,10 @@ static unsigned int free_old_xmit_skbs(struct virtnet_info *vi) | |||
| 565 | while ((skb = virtqueue_get_buf(vi->svq, &len)) != NULL) { | 566 | while ((skb = virtqueue_get_buf(vi->svq, &len)) != NULL) { |
| 566 | pr_debug("Sent skb %p\n", skb); | 567 | pr_debug("Sent skb %p\n", skb); |
| 567 | 568 | ||
| 568 | u64_stats_update_begin(&stats->syncp); | 569 | u64_stats_update_begin(&stats->tx_syncp); |
| 569 | stats->tx_bytes += skb->len; | 570 | stats->tx_bytes += skb->len; |
| 570 | stats->tx_packets++; | 571 | stats->tx_packets++; |
| 571 | u64_stats_update_end(&stats->syncp); | 572 | u64_stats_update_end(&stats->tx_syncp); |
| 572 | 573 | ||
| 573 | tot_sgs += skb_vnet_hdr(skb)->num_sg; | 574 | tot_sgs += skb_vnet_hdr(skb)->num_sg; |
| 574 | dev_kfree_skb_any(skb); | 575 | dev_kfree_skb_any(skb); |
| @@ -703,12 +704,16 @@ static struct rtnl_link_stats64 *virtnet_stats(struct net_device *dev, | |||
| 703 | u64 tpackets, tbytes, rpackets, rbytes; | 704 | u64 tpackets, tbytes, rpackets, rbytes; |
| 704 | 705 | ||
| 705 | do { | 706 | do { |
| 706 | start = u64_stats_fetch_begin(&stats->syncp); | 707 | start = u64_stats_fetch_begin(&stats->tx_syncp); |
| 707 | tpackets = stats->tx_packets; | 708 | tpackets = stats->tx_packets; |
| 708 | tbytes = stats->tx_bytes; | 709 | tbytes = stats->tx_bytes; |
| 710 | } while (u64_stats_fetch_retry(&stats->tx_syncp, start)); | ||
| 711 | |||
| 712 | do { | ||
| 713 | start = u64_stats_fetch_begin(&stats->rx_syncp); | ||
| 709 | rpackets = stats->rx_packets; | 714 | rpackets = stats->rx_packets; |
| 710 | rbytes = stats->rx_bytes; | 715 | rbytes = stats->rx_bytes; |
| 711 | } while (u64_stats_fetch_retry(&stats->syncp, start)); | 716 | } while (u64_stats_fetch_retry(&stats->rx_syncp, start)); |
| 712 | 717 | ||
| 713 | tot->rx_packets += rpackets; | 718 | tot->rx_packets += rpackets; |
| 714 | tot->tx_packets += tpackets; | 719 | tot->tx_packets += tpackets; |
diff --git a/drivers/net/wireless/b43/b43.h b/drivers/net/wireless/b43/b43.h index 67c13af6f206..c06b6cb5c91e 100644 --- a/drivers/net/wireless/b43/b43.h +++ b/drivers/net/wireless/b43/b43.h | |||
| @@ -877,6 +877,10 @@ struct b43_wl { | |||
| 877 | * from the mac80211 subsystem. */ | 877 | * from the mac80211 subsystem. */ |
| 878 | u16 mac80211_initially_registered_queues; | 878 | u16 mac80211_initially_registered_queues; |
| 879 | 879 | ||
| 880 | /* Set this if we call ieee80211_register_hw() and check if we call | ||
| 881 | * ieee80211_unregister_hw(). */ | ||
| 882 | bool hw_registred; | ||
| 883 | |||
| 880 | /* We can only have one operating interface (802.11 core) | 884 | /* We can only have one operating interface (802.11 core) |
| 881 | * at a time. General information about this interface follows. | 885 | * at a time. General information about this interface follows. |
| 882 | */ | 886 | */ |
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c index 5a39b226b2e3..acd03a4f9730 100644 --- a/drivers/net/wireless/b43/main.c +++ b/drivers/net/wireless/b43/main.c | |||
| @@ -2437,6 +2437,7 @@ start_ieee80211: | |||
| 2437 | err = ieee80211_register_hw(wl->hw); | 2437 | err = ieee80211_register_hw(wl->hw); |
| 2438 | if (err) | 2438 | if (err) |
| 2439 | goto err_one_core_detach; | 2439 | goto err_one_core_detach; |
| 2440 | wl->hw_registred = true; | ||
| 2440 | b43_leds_register(wl->current_dev); | 2441 | b43_leds_register(wl->current_dev); |
| 2441 | goto out; | 2442 | goto out; |
| 2442 | 2443 | ||
| @@ -5299,6 +5300,7 @@ static struct b43_wl *b43_wireless_init(struct b43_bus_dev *dev) | |||
| 5299 | 5300 | ||
| 5300 | hw->queues = modparam_qos ? B43_QOS_QUEUE_NUM : 1; | 5301 | hw->queues = modparam_qos ? B43_QOS_QUEUE_NUM : 1; |
| 5301 | wl->mac80211_initially_registered_queues = hw->queues; | 5302 | wl->mac80211_initially_registered_queues = hw->queues; |
| 5303 | wl->hw_registred = false; | ||
| 5302 | hw->max_rates = 2; | 5304 | hw->max_rates = 2; |
| 5303 | SET_IEEE80211_DEV(hw, dev->dev); | 5305 | SET_IEEE80211_DEV(hw, dev->dev); |
| 5304 | if (is_valid_ether_addr(sprom->et1mac)) | 5306 | if (is_valid_ether_addr(sprom->et1mac)) |
| @@ -5370,12 +5372,15 @@ static void b43_bcma_remove(struct bcma_device *core) | |||
| 5370 | * as the ieee80211 unreg will destroy the workqueue. */ | 5372 | * as the ieee80211 unreg will destroy the workqueue. */ |
| 5371 | cancel_work_sync(&wldev->restart_work); | 5373 | cancel_work_sync(&wldev->restart_work); |
| 5372 | 5374 | ||
| 5373 | /* Restore the queues count before unregistering, because firmware detect | 5375 | B43_WARN_ON(!wl); |
| 5374 | * might have modified it. Restoring is important, so the networking | 5376 | if (wl->current_dev == wldev && wl->hw_registred) { |
| 5375 | * stack can properly free resources. */ | 5377 | /* Restore the queues count before unregistering, because firmware detect |
| 5376 | wl->hw->queues = wl->mac80211_initially_registered_queues; | 5378 | * might have modified it. Restoring is important, so the networking |
| 5377 | b43_leds_stop(wldev); | 5379 | * stack can properly free resources. */ |
| 5378 | ieee80211_unregister_hw(wl->hw); | 5380 | wl->hw->queues = wl->mac80211_initially_registered_queues; |
| 5381 | b43_leds_stop(wldev); | ||
| 5382 | ieee80211_unregister_hw(wl->hw); | ||
| 5383 | } | ||
| 5379 | 5384 | ||
| 5380 | b43_one_core_detach(wldev->dev); | 5385 | b43_one_core_detach(wldev->dev); |
| 5381 | 5386 | ||
| @@ -5446,7 +5451,7 @@ static void b43_ssb_remove(struct ssb_device *sdev) | |||
| 5446 | cancel_work_sync(&wldev->restart_work); | 5451 | cancel_work_sync(&wldev->restart_work); |
| 5447 | 5452 | ||
| 5448 | B43_WARN_ON(!wl); | 5453 | B43_WARN_ON(!wl); |
| 5449 | if (wl->current_dev == wldev) { | 5454 | if (wl->current_dev == wldev && wl->hw_registred) { |
| 5450 | /* Restore the queues count before unregistering, because firmware detect | 5455 | /* Restore the queues count before unregistering, because firmware detect |
| 5451 | * might have modified it. Restoring is important, so the networking | 5456 | * might have modified it. Restoring is important, so the networking |
| 5452 | * stack can properly free resources. */ | 5457 | * stack can properly free resources. */ |
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c index e2480d196276..8e7e6928c936 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | |||
| @@ -89,9 +89,9 @@ int brcmf_sdio_intr_register(struct brcmf_sdio_dev *sdiodev) | |||
| 89 | data |= 1 << SDIO_FUNC_1 | 1 << SDIO_FUNC_2 | 1; | 89 | data |= 1 << SDIO_FUNC_1 | 1 << SDIO_FUNC_2 | 1; |
| 90 | brcmf_sdio_regwb(sdiodev, SDIO_CCCR_IENx, data, &ret); | 90 | brcmf_sdio_regwb(sdiodev, SDIO_CCCR_IENx, data, &ret); |
| 91 | 91 | ||
| 92 | /* redirect, configure ane enable io for interrupt signal */ | 92 | /* redirect, configure and enable io for interrupt signal */ |
| 93 | data = SDIO_SEPINT_MASK | SDIO_SEPINT_OE; | 93 | data = SDIO_SEPINT_MASK | SDIO_SEPINT_OE; |
| 94 | if (sdiodev->irq_flags | IRQF_TRIGGER_HIGH) | 94 | if (sdiodev->irq_flags & IRQF_TRIGGER_HIGH) |
| 95 | data |= SDIO_SEPINT_ACT_HI; | 95 | data |= SDIO_SEPINT_ACT_HI; |
| 96 | brcmf_sdio_regwb(sdiodev, SDIO_CCCR_BRCM_SEPINT, data, &ret); | 96 | brcmf_sdio_regwb(sdiodev, SDIO_CCCR_BRCM_SEPINT, data, &ret); |
| 97 | 97 | ||
diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c index 9cfae0c08707..95aa8e1683ec 100644 --- a/drivers/net/wireless/ipw2x00/ipw2100.c +++ b/drivers/net/wireless/ipw2x00/ipw2100.c | |||
| @@ -1903,14 +1903,6 @@ static void ipw2100_down(struct ipw2100_priv *priv) | |||
| 1903 | netif_stop_queue(priv->net_dev); | 1903 | netif_stop_queue(priv->net_dev); |
| 1904 | } | 1904 | } |
| 1905 | 1905 | ||
| 1906 | /* Called by register_netdev() */ | ||
| 1907 | static int ipw2100_net_init(struct net_device *dev) | ||
| 1908 | { | ||
| 1909 | struct ipw2100_priv *priv = libipw_priv(dev); | ||
| 1910 | |||
| 1911 | return ipw2100_up(priv, 1); | ||
| 1912 | } | ||
| 1913 | |||
| 1914 | static int ipw2100_wdev_init(struct net_device *dev) | 1906 | static int ipw2100_wdev_init(struct net_device *dev) |
| 1915 | { | 1907 | { |
| 1916 | struct ipw2100_priv *priv = libipw_priv(dev); | 1908 | struct ipw2100_priv *priv = libipw_priv(dev); |
| @@ -6087,7 +6079,6 @@ static const struct net_device_ops ipw2100_netdev_ops = { | |||
| 6087 | .ndo_stop = ipw2100_close, | 6079 | .ndo_stop = ipw2100_close, |
| 6088 | .ndo_start_xmit = libipw_xmit, | 6080 | .ndo_start_xmit = libipw_xmit, |
| 6089 | .ndo_change_mtu = libipw_change_mtu, | 6081 | .ndo_change_mtu = libipw_change_mtu, |
| 6090 | .ndo_init = ipw2100_net_init, | ||
| 6091 | .ndo_tx_timeout = ipw2100_tx_timeout, | 6082 | .ndo_tx_timeout = ipw2100_tx_timeout, |
| 6092 | .ndo_set_mac_address = ipw2100_set_address, | 6083 | .ndo_set_mac_address = ipw2100_set_address, |
| 6093 | .ndo_validate_addr = eth_validate_addr, | 6084 | .ndo_validate_addr = eth_validate_addr, |
| @@ -6329,6 +6320,10 @@ static int ipw2100_pci_init_one(struct pci_dev *pci_dev, | |||
| 6329 | printk(KERN_INFO DRV_NAME | 6320 | printk(KERN_INFO DRV_NAME |
| 6330 | ": Detected Intel PRO/Wireless 2100 Network Connection\n"); | 6321 | ": Detected Intel PRO/Wireless 2100 Network Connection\n"); |
| 6331 | 6322 | ||
| 6323 | err = ipw2100_up(priv, 1); | ||
| 6324 | if (err) | ||
| 6325 | goto fail; | ||
| 6326 | |||
| 6332 | err = ipw2100_wdev_init(dev); | 6327 | err = ipw2100_wdev_init(dev); |
| 6333 | if (err) | 6328 | if (err) |
| 6334 | goto fail; | 6329 | goto fail; |
| @@ -6338,12 +6333,7 @@ static int ipw2100_pci_init_one(struct pci_dev *pci_dev, | |||
| 6338 | * network device we would call ipw2100_up. This introduced a race | 6333 | * network device we would call ipw2100_up. This introduced a race |
| 6339 | * condition with newer hotplug configurations (network was coming | 6334 | * condition with newer hotplug configurations (network was coming |
| 6340 | * up and making calls before the device was initialized). | 6335 | * up and making calls before the device was initialized). |
| 6341 | * | 6336 | */ |
| 6342 | * If we called ipw2100_up before we registered the device, then the | ||
| 6343 | * device name wasn't registered. So, we instead use the net_dev->init | ||
| 6344 | * member to call a function that then just turns and calls ipw2100_up. | ||
| 6345 | * net_dev->init is called after name allocation but before the | ||
| 6346 | * notifier chain is called */ | ||
| 6347 | err = register_netdev(dev); | 6337 | err = register_netdev(dev); |
| 6348 | if (err) { | 6338 | if (err) { |
| 6349 | printk(KERN_WARNING DRV_NAME | 6339 | printk(KERN_WARNING DRV_NAME |
diff --git a/drivers/net/wireless/iwlwifi/iwl-6000.c b/drivers/net/wireless/iwlwifi/iwl-6000.c index 19f7ee84ae89..e5e8ada4aaf6 100644 --- a/drivers/net/wireless/iwlwifi/iwl-6000.c +++ b/drivers/net/wireless/iwlwifi/iwl-6000.c | |||
| @@ -35,17 +35,20 @@ | |||
| 35 | #define IWL6000_UCODE_API_MAX 6 | 35 | #define IWL6000_UCODE_API_MAX 6 |
| 36 | #define IWL6050_UCODE_API_MAX 5 | 36 | #define IWL6050_UCODE_API_MAX 5 |
| 37 | #define IWL6000G2_UCODE_API_MAX 6 | 37 | #define IWL6000G2_UCODE_API_MAX 6 |
| 38 | #define IWL6035_UCODE_API_MAX 6 | ||
| 38 | 39 | ||
| 39 | /* Oldest version we won't warn about */ | 40 | /* Oldest version we won't warn about */ |
| 40 | #define IWL6000_UCODE_API_OK 4 | 41 | #define IWL6000_UCODE_API_OK 4 |
| 41 | #define IWL6000G2_UCODE_API_OK 5 | 42 | #define IWL6000G2_UCODE_API_OK 5 |
| 42 | #define IWL6050_UCODE_API_OK 5 | 43 | #define IWL6050_UCODE_API_OK 5 |
| 43 | #define IWL6000G2B_UCODE_API_OK 6 | 44 | #define IWL6000G2B_UCODE_API_OK 6 |
| 45 | #define IWL6035_UCODE_API_OK 6 | ||
| 44 | 46 | ||
| 45 | /* Lowest firmware API version supported */ | 47 | /* Lowest firmware API version supported */ |
| 46 | #define IWL6000_UCODE_API_MIN 4 | 48 | #define IWL6000_UCODE_API_MIN 4 |
| 47 | #define IWL6050_UCODE_API_MIN 4 | 49 | #define IWL6050_UCODE_API_MIN 4 |
| 48 | #define IWL6000G2_UCODE_API_MIN 4 | 50 | #define IWL6000G2_UCODE_API_MIN 5 |
| 51 | #define IWL6035_UCODE_API_MIN 6 | ||
| 49 | 52 | ||
| 50 | /* EEPROM versions */ | 53 | /* EEPROM versions */ |
| 51 | #define EEPROM_6000_TX_POWER_VERSION (4) | 54 | #define EEPROM_6000_TX_POWER_VERSION (4) |
| @@ -227,9 +230,25 @@ const struct iwl_cfg iwl6030_2bg_cfg = { | |||
| 227 | IWL_DEVICE_6030, | 230 | IWL_DEVICE_6030, |
| 228 | }; | 231 | }; |
| 229 | 232 | ||
| 233 | #define IWL_DEVICE_6035 \ | ||
| 234 | .fw_name_pre = IWL6030_FW_PRE, \ | ||
| 235 | .ucode_api_max = IWL6035_UCODE_API_MAX, \ | ||
| 236 | .ucode_api_ok = IWL6035_UCODE_API_OK, \ | ||
| 237 | .ucode_api_min = IWL6035_UCODE_API_MIN, \ | ||
| 238 | .device_family = IWL_DEVICE_FAMILY_6030, \ | ||
| 239 | .max_inst_size = IWL60_RTC_INST_SIZE, \ | ||
| 240 | .max_data_size = IWL60_RTC_DATA_SIZE, \ | ||
| 241 | .eeprom_ver = EEPROM_6030_EEPROM_VERSION, \ | ||
| 242 | .eeprom_calib_ver = EEPROM_6030_TX_POWER_VERSION, \ | ||
| 243 | .base_params = &iwl6000_g2_base_params, \ | ||
| 244 | .bt_params = &iwl6000_bt_params, \ | ||
| 245 | .need_temp_offset_calib = true, \ | ||
| 246 | .led_mode = IWL_LED_RF_STATE, \ | ||
| 247 | .adv_pm = true | ||
| 248 | |||
| 230 | const struct iwl_cfg iwl6035_2agn_cfg = { | 249 | const struct iwl_cfg iwl6035_2agn_cfg = { |
| 231 | .name = "Intel(R) Centrino(R) Advanced-N 6235 AGN", | 250 | .name = "Intel(R) Centrino(R) Advanced-N 6235 AGN", |
| 232 | IWL_DEVICE_6030, | 251 | IWL_DEVICE_6035, |
| 233 | .ht_params = &iwl6000_ht_params, | 252 | .ht_params = &iwl6000_ht_params, |
| 234 | }; | 253 | }; |
| 235 | 254 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-sta.c b/drivers/net/wireless/iwlwifi/iwl-agn-sta.c index aea07aab3c9e..eb6a8eaf42fc 100644 --- a/drivers/net/wireless/iwlwifi/iwl-agn-sta.c +++ b/drivers/net/wireless/iwlwifi/iwl-agn-sta.c | |||
| @@ -1267,7 +1267,7 @@ int iwl_remove_dynamic_key(struct iwl_priv *priv, | |||
| 1267 | key_flags |= STA_KEY_MULTICAST_MSK; | 1267 | key_flags |= STA_KEY_MULTICAST_MSK; |
| 1268 | 1268 | ||
| 1269 | sta_cmd.key.key_flags = key_flags; | 1269 | sta_cmd.key.key_flags = key_flags; |
| 1270 | sta_cmd.key.key_offset = WEP_INVALID_OFFSET; | 1270 | sta_cmd.key.key_offset = keyconf->hw_key_idx; |
| 1271 | sta_cmd.sta.modify_mask = STA_MODIFY_KEY_MASK; | 1271 | sta_cmd.sta.modify_mask = STA_MODIFY_KEY_MASK; |
| 1272 | sta_cmd.mode = STA_CONTROL_MODIFY_MSK; | 1272 | sta_cmd.mode = STA_CONTROL_MODIFY_MSK; |
| 1273 | 1273 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-drv.c b/drivers/net/wireless/iwlwifi/iwl-drv.c index d742900969ea..fac67a526a30 100644 --- a/drivers/net/wireless/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/iwlwifi/iwl-drv.c | |||
| @@ -861,13 +861,18 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context) | |||
| 861 | 861 | ||
| 862 | /* We have our copies now, allow OS release its copies */ | 862 | /* We have our copies now, allow OS release its copies */ |
| 863 | release_firmware(ucode_raw); | 863 | release_firmware(ucode_raw); |
| 864 | complete(&drv->request_firmware_complete); | ||
| 865 | 864 | ||
| 866 | drv->op_mode = iwl_dvm_ops.start(drv->trans, drv->cfg, &drv->fw); | 865 | drv->op_mode = iwl_dvm_ops.start(drv->trans, drv->cfg, &drv->fw); |
| 867 | 866 | ||
| 868 | if (!drv->op_mode) | 867 | if (!drv->op_mode) |
| 869 | goto out_free_fw; | 868 | goto out_unbind; |
| 870 | 869 | ||
| 870 | /* | ||
| 871 | * Complete the firmware request last so that | ||
| 872 | * a driver unbind (stop) doesn't run while we | ||
| 873 | * are doing the start() above. | ||
| 874 | */ | ||
| 875 | complete(&drv->request_firmware_complete); | ||
| 871 | return; | 876 | return; |
| 872 | 877 | ||
| 873 | try_again: | 878 | try_again: |
diff --git a/drivers/net/wireless/iwlwifi/iwl-eeprom.c b/drivers/net/wireless/iwlwifi/iwl-eeprom.c index 50c58911e718..b8e2b223ac36 100644 --- a/drivers/net/wireless/iwlwifi/iwl-eeprom.c +++ b/drivers/net/wireless/iwlwifi/iwl-eeprom.c | |||
| @@ -568,28 +568,28 @@ static int iwl_find_otp_image(struct iwl_trans *trans, | |||
| 568 | * iwl_get_max_txpower_avg - get the highest tx power from all chains. | 568 | * iwl_get_max_txpower_avg - get the highest tx power from all chains. |
| 569 | * find the highest tx power from all chains for the channel | 569 | * find the highest tx power from all chains for the channel |
| 570 | */ | 570 | */ |
| 571 | static s8 iwl_get_max_txpower_avg(const struct iwl_cfg *cfg, | 571 | static s8 iwl_get_max_txpower_avg(struct iwl_priv *priv, |
| 572 | struct iwl_eeprom_enhanced_txpwr *enhanced_txpower, | 572 | struct iwl_eeprom_enhanced_txpwr *enhanced_txpower, |
| 573 | int element, s8 *max_txpower_in_half_dbm) | 573 | int element, s8 *max_txpower_in_half_dbm) |
| 574 | { | 574 | { |
| 575 | s8 max_txpower_avg = 0; /* (dBm) */ | 575 | s8 max_txpower_avg = 0; /* (dBm) */ |
| 576 | 576 | ||
| 577 | /* Take the highest tx power from any valid chains */ | 577 | /* Take the highest tx power from any valid chains */ |
| 578 | if ((cfg->valid_tx_ant & ANT_A) && | 578 | if ((priv->hw_params.valid_tx_ant & ANT_A) && |
| 579 | (enhanced_txpower[element].chain_a_max > max_txpower_avg)) | 579 | (enhanced_txpower[element].chain_a_max > max_txpower_avg)) |
| 580 | max_txpower_avg = enhanced_txpower[element].chain_a_max; | 580 | max_txpower_avg = enhanced_txpower[element].chain_a_max; |
| 581 | if ((cfg->valid_tx_ant & ANT_B) && | 581 | if ((priv->hw_params.valid_tx_ant & ANT_B) && |
| 582 | (enhanced_txpower[element].chain_b_max > max_txpower_avg)) | 582 | (enhanced_txpower[element].chain_b_max > max_txpower_avg)) |
| 583 | max_txpower_avg = enhanced_txpower[element].chain_b_max; | 583 | max_txpower_avg = enhanced_txpower[element].chain_b_max; |
| 584 | if ((cfg->valid_tx_ant & ANT_C) && | 584 | if ((priv->hw_params.valid_tx_ant & ANT_C) && |
| 585 | (enhanced_txpower[element].chain_c_max > max_txpower_avg)) | 585 | (enhanced_txpower[element].chain_c_max > max_txpower_avg)) |
| 586 | max_txpower_avg = enhanced_txpower[element].chain_c_max; | 586 | max_txpower_avg = enhanced_txpower[element].chain_c_max; |
| 587 | if (((cfg->valid_tx_ant == ANT_AB) | | 587 | if (((priv->hw_params.valid_tx_ant == ANT_AB) | |
| 588 | (cfg->valid_tx_ant == ANT_BC) | | 588 | (priv->hw_params.valid_tx_ant == ANT_BC) | |
| 589 | (cfg->valid_tx_ant == ANT_AC)) && | 589 | (priv->hw_params.valid_tx_ant == ANT_AC)) && |
| 590 | (enhanced_txpower[element].mimo2_max > max_txpower_avg)) | 590 | (enhanced_txpower[element].mimo2_max > max_txpower_avg)) |
| 591 | max_txpower_avg = enhanced_txpower[element].mimo2_max; | 591 | max_txpower_avg = enhanced_txpower[element].mimo2_max; |
| 592 | if ((cfg->valid_tx_ant == ANT_ABC) && | 592 | if ((priv->hw_params.valid_tx_ant == ANT_ABC) && |
| 593 | (enhanced_txpower[element].mimo3_max > max_txpower_avg)) | 593 | (enhanced_txpower[element].mimo3_max > max_txpower_avg)) |
| 594 | max_txpower_avg = enhanced_txpower[element].mimo3_max; | 594 | max_txpower_avg = enhanced_txpower[element].mimo3_max; |
| 595 | 595 | ||
| @@ -691,7 +691,7 @@ static void iwl_eeprom_enhanced_txpower(struct iwl_priv *priv) | |||
| 691 | ((txp->delta_20_in_40 & 0xf0) >> 4), | 691 | ((txp->delta_20_in_40 & 0xf0) >> 4), |
| 692 | (txp->delta_20_in_40 & 0x0f)); | 692 | (txp->delta_20_in_40 & 0x0f)); |
| 693 | 693 | ||
| 694 | max_txp_avg = iwl_get_max_txpower_avg(priv->cfg, txp_array, idx, | 694 | max_txp_avg = iwl_get_max_txpower_avg(priv, txp_array, idx, |
| 695 | &max_txp_avg_halfdbm); | 695 | &max_txp_avg_halfdbm); |
| 696 | 696 | ||
| 697 | /* | 697 | /* |
diff --git a/drivers/net/wireless/iwlwifi/iwl-mac80211.c b/drivers/net/wireless/iwlwifi/iwl-mac80211.c index ab2f4d7500a4..3ee23134c02b 100644 --- a/drivers/net/wireless/iwlwifi/iwl-mac80211.c +++ b/drivers/net/wireless/iwlwifi/iwl-mac80211.c | |||
| @@ -199,6 +199,7 @@ int iwlagn_mac_setup_register(struct iwl_priv *priv, | |||
| 199 | WIPHY_FLAG_DISABLE_BEACON_HINTS | | 199 | WIPHY_FLAG_DISABLE_BEACON_HINTS | |
| 200 | WIPHY_FLAG_IBSS_RSN; | 200 | WIPHY_FLAG_IBSS_RSN; |
| 201 | 201 | ||
| 202 | #ifdef CONFIG_PM_SLEEP | ||
| 202 | if (priv->fw->img[IWL_UCODE_WOWLAN].sec[0].len && | 203 | if (priv->fw->img[IWL_UCODE_WOWLAN].sec[0].len && |
| 203 | priv->trans->ops->wowlan_suspend && | 204 | priv->trans->ops->wowlan_suspend && |
| 204 | device_can_wakeup(priv->trans->dev)) { | 205 | device_can_wakeup(priv->trans->dev)) { |
| @@ -217,6 +218,7 @@ int iwlagn_mac_setup_register(struct iwl_priv *priv, | |||
| 217 | hw->wiphy->wowlan.pattern_max_len = | 218 | hw->wiphy->wowlan.pattern_max_len = |
| 218 | IWLAGN_WOWLAN_MAX_PATTERN_LEN; | 219 | IWLAGN_WOWLAN_MAX_PATTERN_LEN; |
| 219 | } | 220 | } |
| 221 | #endif | ||
| 220 | 222 | ||
| 221 | if (iwlwifi_mod_params.power_save) | 223 | if (iwlwifi_mod_params.power_save) |
| 222 | hw->wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT; | 224 | hw->wiphy->flags |= WIPHY_FLAG_PS_ON_BY_DEFAULT; |
| @@ -249,6 +251,7 @@ int iwlagn_mac_setup_register(struct iwl_priv *priv, | |||
| 249 | ret = ieee80211_register_hw(priv->hw); | 251 | ret = ieee80211_register_hw(priv->hw); |
| 250 | if (ret) { | 252 | if (ret) { |
| 251 | IWL_ERR(priv, "Failed to register hw (error %d)\n", ret); | 253 | IWL_ERR(priv, "Failed to register hw (error %d)\n", ret); |
| 254 | iwl_leds_exit(priv); | ||
| 252 | return ret; | 255 | return ret; |
| 253 | } | 256 | } |
| 254 | priv->mac80211_registered = 1; | 257 | priv->mac80211_registered = 1; |
diff --git a/drivers/net/wireless/iwlwifi/iwl-prph.h b/drivers/net/wireless/iwlwifi/iwl-prph.h index 3b1069290fa9..dfd54662e3e6 100644 --- a/drivers/net/wireless/iwlwifi/iwl-prph.h +++ b/drivers/net/wireless/iwlwifi/iwl-prph.h | |||
| @@ -224,6 +224,7 @@ | |||
| 224 | #define SCD_TXFACT (SCD_BASE + 0x10) | 224 | #define SCD_TXFACT (SCD_BASE + 0x10) |
| 225 | #define SCD_ACTIVE (SCD_BASE + 0x14) | 225 | #define SCD_ACTIVE (SCD_BASE + 0x14) |
| 226 | #define SCD_QUEUECHAIN_SEL (SCD_BASE + 0xe8) | 226 | #define SCD_QUEUECHAIN_SEL (SCD_BASE + 0xe8) |
| 227 | #define SCD_CHAINEXT_EN (SCD_BASE + 0x244) | ||
| 227 | #define SCD_AGGR_SEL (SCD_BASE + 0x248) | 228 | #define SCD_AGGR_SEL (SCD_BASE + 0x248) |
| 228 | #define SCD_INTERRUPT_MASK (SCD_BASE + 0x108) | 229 | #define SCD_INTERRUPT_MASK (SCD_BASE + 0x108) |
| 229 | 230 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c b/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c index ec6fb395b84d..79c6b91417f9 100644 --- a/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c +++ b/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c | |||
| @@ -1058,6 +1058,11 @@ static void iwl_tx_start(struct iwl_trans *trans) | |||
| 1058 | iwl_write_prph(trans, SCD_DRAM_BASE_ADDR, | 1058 | iwl_write_prph(trans, SCD_DRAM_BASE_ADDR, |
| 1059 | trans_pcie->scd_bc_tbls.dma >> 10); | 1059 | trans_pcie->scd_bc_tbls.dma >> 10); |
| 1060 | 1060 | ||
| 1061 | /* The chain extension of the SCD doesn't work well. This feature is | ||
| 1062 | * enabled by default by the HW, so we need to disable it manually. | ||
| 1063 | */ | ||
| 1064 | iwl_write_prph(trans, SCD_CHAINEXT_EN, 0); | ||
| 1065 | |||
| 1061 | /* Enable DMA channel */ | 1066 | /* Enable DMA channel */ |
| 1062 | for (chan = 0; chan < FH_TCSR_CHNL_NUM ; chan++) | 1067 | for (chan = 0; chan < FH_TCSR_CHNL_NUM ; chan++) |
| 1063 | iwl_write_direct32(trans, FH_TCSR_CHNL_TX_CONFIG_REG(chan), | 1068 | iwl_write_direct32(trans, FH_TCSR_CHNL_TX_CONFIG_REG(chan), |
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index fb787df01666..a0b7cfd34685 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c | |||
| @@ -1555,6 +1555,7 @@ static int hwsim_tx_info_frame_received_nl(struct sk_buff *skb_2, | |||
| 1555 | hdr = (struct ieee80211_hdr *) skb->data; | 1555 | hdr = (struct ieee80211_hdr *) skb->data; |
| 1556 | mac80211_hwsim_monitor_ack(data2->hw, hdr->addr2); | 1556 | mac80211_hwsim_monitor_ack(data2->hw, hdr->addr2); |
| 1557 | } | 1557 | } |
| 1558 | txi->flags |= IEEE80211_TX_STAT_ACK; | ||
| 1558 | } | 1559 | } |
| 1559 | ieee80211_tx_status_irqsafe(data2->hw, skb); | 1560 | ieee80211_tx_status_irqsafe(data2->hw, skb); |
| 1560 | return 0; | 1561 | return 0; |
| @@ -1721,6 +1722,24 @@ static void hwsim_exit_netlink(void) | |||
| 1721 | "unregister family %i\n", ret); | 1722 | "unregister family %i\n", ret); |
| 1722 | } | 1723 | } |
| 1723 | 1724 | ||
| 1725 | static const struct ieee80211_iface_limit hwsim_if_limits[] = { | ||
| 1726 | { .max = 1, .types = BIT(NL80211_IFTYPE_ADHOC) }, | ||
| 1727 | { .max = 2048, .types = BIT(NL80211_IFTYPE_STATION) | | ||
| 1728 | BIT(NL80211_IFTYPE_P2P_CLIENT) | | ||
| 1729 | #ifdef CONFIG_MAC80211_MESH | ||
| 1730 | BIT(NL80211_IFTYPE_MESH_POINT) | | ||
| 1731 | #endif | ||
| 1732 | BIT(NL80211_IFTYPE_AP) | | ||
| 1733 | BIT(NL80211_IFTYPE_P2P_GO) }, | ||
| 1734 | }; | ||
| 1735 | |||
| 1736 | static const struct ieee80211_iface_combination hwsim_if_comb = { | ||
| 1737 | .limits = hwsim_if_limits, | ||
| 1738 | .n_limits = ARRAY_SIZE(hwsim_if_limits), | ||
| 1739 | .max_interfaces = 2048, | ||
| 1740 | .num_different_channels = 1, | ||
| 1741 | }; | ||
| 1742 | |||
| 1724 | static int __init init_mac80211_hwsim(void) | 1743 | static int __init init_mac80211_hwsim(void) |
| 1725 | { | 1744 | { |
| 1726 | int i, err = 0; | 1745 | int i, err = 0; |
| @@ -1782,6 +1801,9 @@ static int __init init_mac80211_hwsim(void) | |||
| 1782 | hw->wiphy->n_addresses = 2; | 1801 | hw->wiphy->n_addresses = 2; |
| 1783 | hw->wiphy->addresses = data->addresses; | 1802 | hw->wiphy->addresses = data->addresses; |
| 1784 | 1803 | ||
| 1804 | hw->wiphy->iface_combinations = &hwsim_if_comb; | ||
| 1805 | hw->wiphy->n_iface_combinations = 1; | ||
| 1806 | |||
| 1785 | if (fake_hw_scan) { | 1807 | if (fake_hw_scan) { |
| 1786 | hw->wiphy->max_scan_ssids = 255; | 1808 | hw->wiphy->max_scan_ssids = 255; |
| 1787 | hw->wiphy->max_scan_ie_len = IEEE80211_MAX_DATA_LEN; | 1809 | hw->wiphy->max_scan_ie_len = IEEE80211_MAX_DATA_LEN; |
diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c index 87671446e24b..015fec3371a0 100644 --- a/drivers/net/wireless/mwifiex/cfg80211.c +++ b/drivers/net/wireless/mwifiex/cfg80211.c | |||
| @@ -948,6 +948,19 @@ static int mwifiex_cfg80211_start_ap(struct wiphy *wiphy, | |||
| 948 | bss_cfg->ssid.ssid_len = params->ssid_len; | 948 | bss_cfg->ssid.ssid_len = params->ssid_len; |
| 949 | } | 949 | } |
| 950 | 950 | ||
| 951 | switch (params->hidden_ssid) { | ||
| 952 | case NL80211_HIDDEN_SSID_NOT_IN_USE: | ||
| 953 | bss_cfg->bcast_ssid_ctl = 1; | ||
| 954 | break; | ||
| 955 | case NL80211_HIDDEN_SSID_ZERO_LEN: | ||
| 956 | bss_cfg->bcast_ssid_ctl = 0; | ||
| 957 | break; | ||
| 958 | case NL80211_HIDDEN_SSID_ZERO_CONTENTS: | ||
| 959 | /* firmware doesn't support this type of hidden SSID */ | ||
| 960 | default: | ||
| 961 | return -EINVAL; | ||
| 962 | } | ||
| 963 | |||
| 951 | if (mwifiex_set_secure_params(priv, bss_cfg, params)) { | 964 | if (mwifiex_set_secure_params(priv, bss_cfg, params)) { |
| 952 | kfree(bss_cfg); | 965 | kfree(bss_cfg); |
| 953 | wiphy_err(wiphy, "Failed to parse secuirty parameters!\n"); | 966 | wiphy_err(wiphy, "Failed to parse secuirty parameters!\n"); |
diff --git a/drivers/net/wireless/mwifiex/fw.h b/drivers/net/wireless/mwifiex/fw.h index 9f674bbebe65..561452a5c818 100644 --- a/drivers/net/wireless/mwifiex/fw.h +++ b/drivers/net/wireless/mwifiex/fw.h | |||
| @@ -122,6 +122,7 @@ enum MWIFIEX_802_11_PRIVACY_FILTER { | |||
| 122 | #define TLV_TYPE_CHANNELBANDLIST (PROPRIETARY_TLV_BASE_ID + 42) | 122 | #define TLV_TYPE_CHANNELBANDLIST (PROPRIETARY_TLV_BASE_ID + 42) |
| 123 | #define TLV_TYPE_UAP_BEACON_PERIOD (PROPRIETARY_TLV_BASE_ID + 44) | 123 | #define TLV_TYPE_UAP_BEACON_PERIOD (PROPRIETARY_TLV_BASE_ID + 44) |
| 124 | #define TLV_TYPE_UAP_DTIM_PERIOD (PROPRIETARY_TLV_BASE_ID + 45) | 124 | #define TLV_TYPE_UAP_DTIM_PERIOD (PROPRIETARY_TLV_BASE_ID + 45) |
| 125 | #define TLV_TYPE_UAP_BCAST_SSID (PROPRIETARY_TLV_BASE_ID + 48) | ||
| 125 | #define TLV_TYPE_UAP_RTS_THRESHOLD (PROPRIETARY_TLV_BASE_ID + 51) | 126 | #define TLV_TYPE_UAP_RTS_THRESHOLD (PROPRIETARY_TLV_BASE_ID + 51) |
| 126 | #define TLV_TYPE_UAP_WPA_PASSPHRASE (PROPRIETARY_TLV_BASE_ID + 60) | 127 | #define TLV_TYPE_UAP_WPA_PASSPHRASE (PROPRIETARY_TLV_BASE_ID + 60) |
| 127 | #define TLV_TYPE_UAP_ENCRY_PROTOCOL (PROPRIETARY_TLV_BASE_ID + 64) | 128 | #define TLV_TYPE_UAP_ENCRY_PROTOCOL (PROPRIETARY_TLV_BASE_ID + 64) |
| @@ -1209,6 +1210,11 @@ struct host_cmd_tlv_ssid { | |||
| 1209 | u8 ssid[0]; | 1210 | u8 ssid[0]; |
| 1210 | } __packed; | 1211 | } __packed; |
| 1211 | 1212 | ||
| 1213 | struct host_cmd_tlv_bcast_ssid { | ||
| 1214 | struct host_cmd_tlv tlv; | ||
| 1215 | u8 bcast_ctl; | ||
| 1216 | } __packed; | ||
| 1217 | |||
| 1212 | struct host_cmd_tlv_beacon_period { | 1218 | struct host_cmd_tlv_beacon_period { |
| 1213 | struct host_cmd_tlv tlv; | 1219 | struct host_cmd_tlv tlv; |
| 1214 | __le16 period; | 1220 | __le16 period; |
diff --git a/drivers/net/wireless/mwifiex/uap_cmd.c b/drivers/net/wireless/mwifiex/uap_cmd.c index 76dfbc42a732..8173ab66066d 100644 --- a/drivers/net/wireless/mwifiex/uap_cmd.c +++ b/drivers/net/wireless/mwifiex/uap_cmd.c | |||
| @@ -132,6 +132,7 @@ mwifiex_uap_bss_param_prepare(u8 *tlv, void *cmd_buf, u16 *param_size) | |||
| 132 | struct host_cmd_tlv_dtim_period *dtim_period; | 132 | struct host_cmd_tlv_dtim_period *dtim_period; |
| 133 | struct host_cmd_tlv_beacon_period *beacon_period; | 133 | struct host_cmd_tlv_beacon_period *beacon_period; |
| 134 | struct host_cmd_tlv_ssid *ssid; | 134 | struct host_cmd_tlv_ssid *ssid; |
| 135 | struct host_cmd_tlv_bcast_ssid *bcast_ssid; | ||
| 135 | struct host_cmd_tlv_channel_band *chan_band; | 136 | struct host_cmd_tlv_channel_band *chan_band; |
| 136 | struct host_cmd_tlv_frag_threshold *frag_threshold; | 137 | struct host_cmd_tlv_frag_threshold *frag_threshold; |
| 137 | struct host_cmd_tlv_rts_threshold *rts_threshold; | 138 | struct host_cmd_tlv_rts_threshold *rts_threshold; |
| @@ -153,6 +154,14 @@ mwifiex_uap_bss_param_prepare(u8 *tlv, void *cmd_buf, u16 *param_size) | |||
| 153 | cmd_size += sizeof(struct host_cmd_tlv) + | 154 | cmd_size += sizeof(struct host_cmd_tlv) + |
| 154 | bss_cfg->ssid.ssid_len; | 155 | bss_cfg->ssid.ssid_len; |
| 155 | tlv += sizeof(struct host_cmd_tlv) + bss_cfg->ssid.ssid_len; | 156 | tlv += sizeof(struct host_cmd_tlv) + bss_cfg->ssid.ssid_len; |
| 157 | |||
| 158 | bcast_ssid = (struct host_cmd_tlv_bcast_ssid *)tlv; | ||
| 159 | bcast_ssid->tlv.type = cpu_to_le16(TLV_TYPE_UAP_BCAST_SSID); | ||
| 160 | bcast_ssid->tlv.len = | ||
| 161 | cpu_to_le16(sizeof(bcast_ssid->bcast_ctl)); | ||
| 162 | bcast_ssid->bcast_ctl = bss_cfg->bcast_ssid_ctl; | ||
| 163 | cmd_size += sizeof(struct host_cmd_tlv_bcast_ssid); | ||
| 164 | tlv += sizeof(struct host_cmd_tlv_bcast_ssid); | ||
| 156 | } | 165 | } |
| 157 | if (bss_cfg->channel && bss_cfg->channel <= MAX_CHANNEL_BAND_BG) { | 166 | if (bss_cfg->channel && bss_cfg->channel <= MAX_CHANNEL_BAND_BG) { |
| 158 | chan_band = (struct host_cmd_tlv_channel_band *)tlv; | 167 | chan_band = (struct host_cmd_tlv_channel_band *)tlv; |
| @@ -416,6 +425,7 @@ int mwifiex_uap_set_channel(struct mwifiex_private *priv, int channel) | |||
| 416 | if (!bss_cfg) | 425 | if (!bss_cfg) |
| 417 | return -ENOMEM; | 426 | return -ENOMEM; |
| 418 | 427 | ||
| 428 | mwifiex_set_sys_config_invalid_data(bss_cfg); | ||
| 419 | bss_cfg->band_cfg = BAND_CONFIG_MANUAL; | 429 | bss_cfg->band_cfg = BAND_CONFIG_MANUAL; |
| 420 | bss_cfg->channel = channel; | 430 | bss_cfg->channel = channel; |
| 421 | 431 | ||
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h index ca36cccaba31..8f754025b06e 100644 --- a/drivers/net/wireless/rt2x00/rt2x00.h +++ b/drivers/net/wireless/rt2x00/rt2x00.h | |||
| @@ -396,8 +396,7 @@ struct rt2x00_intf { | |||
| 396 | * for hardware which doesn't support hardware | 396 | * for hardware which doesn't support hardware |
| 397 | * sequence counting. | 397 | * sequence counting. |
| 398 | */ | 398 | */ |
| 399 | spinlock_t seqlock; | 399 | atomic_t seqno; |
| 400 | u16 seqno; | ||
| 401 | }; | 400 | }; |
| 402 | 401 | ||
| 403 | static inline struct rt2x00_intf* vif_to_intf(struct ieee80211_vif *vif) | 402 | static inline struct rt2x00_intf* vif_to_intf(struct ieee80211_vif *vif) |
diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c index b49773ef72f2..dd24b2663b5e 100644 --- a/drivers/net/wireless/rt2x00/rt2x00mac.c +++ b/drivers/net/wireless/rt2x00/rt2x00mac.c | |||
| @@ -277,7 +277,6 @@ int rt2x00mac_add_interface(struct ieee80211_hw *hw, | |||
| 277 | else | 277 | else |
| 278 | rt2x00dev->intf_sta_count++; | 278 | rt2x00dev->intf_sta_count++; |
| 279 | 279 | ||
| 280 | spin_lock_init(&intf->seqlock); | ||
| 281 | mutex_init(&intf->beacon_skb_mutex); | 280 | mutex_init(&intf->beacon_skb_mutex); |
| 282 | intf->beacon = entry; | 281 | intf->beacon = entry; |
| 283 | 282 | ||
diff --git a/drivers/net/wireless/rt2x00/rt2x00queue.c b/drivers/net/wireless/rt2x00/rt2x00queue.c index 4c662eccf53c..2fd830103415 100644 --- a/drivers/net/wireless/rt2x00/rt2x00queue.c +++ b/drivers/net/wireless/rt2x00/rt2x00queue.c | |||
| @@ -207,6 +207,7 @@ static void rt2x00queue_create_tx_descriptor_seq(struct rt2x00_dev *rt2x00dev, | |||
| 207 | struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb); | 207 | struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb); |
| 208 | struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; | 208 | struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; |
| 209 | struct rt2x00_intf *intf = vif_to_intf(tx_info->control.vif); | 209 | struct rt2x00_intf *intf = vif_to_intf(tx_info->control.vif); |
| 210 | u16 seqno; | ||
| 210 | 211 | ||
| 211 | if (!(tx_info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ)) | 212 | if (!(tx_info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ)) |
| 212 | return; | 213 | return; |
| @@ -238,15 +239,13 @@ static void rt2x00queue_create_tx_descriptor_seq(struct rt2x00_dev *rt2x00dev, | |||
| 238 | * sequence counting per-frame, since those will override the | 239 | * sequence counting per-frame, since those will override the |
| 239 | * sequence counter given by mac80211. | 240 | * sequence counter given by mac80211. |
| 240 | */ | 241 | */ |
| 241 | spin_lock(&intf->seqlock); | ||
| 242 | |||
| 243 | if (test_bit(ENTRY_TXD_FIRST_FRAGMENT, &txdesc->flags)) | 242 | if (test_bit(ENTRY_TXD_FIRST_FRAGMENT, &txdesc->flags)) |
| 244 | intf->seqno += 0x10; | 243 | seqno = atomic_add_return(0x10, &intf->seqno); |
| 245 | hdr->seq_ctrl &= cpu_to_le16(IEEE80211_SCTL_FRAG); | 244 | else |
| 246 | hdr->seq_ctrl |= cpu_to_le16(intf->seqno); | 245 | seqno = atomic_read(&intf->seqno); |
| 247 | |||
| 248 | spin_unlock(&intf->seqlock); | ||
| 249 | 246 | ||
| 247 | hdr->seq_ctrl &= cpu_to_le16(IEEE80211_SCTL_FRAG); | ||
| 248 | hdr->seq_ctrl |= cpu_to_le16(seqno); | ||
| 250 | } | 249 | } |
| 251 | 250 | ||
| 252 | static void rt2x00queue_create_tx_descriptor_plcp(struct rt2x00_dev *rt2x00dev, | 251 | static void rt2x00queue_create_tx_descriptor_plcp(struct rt2x00_dev *rt2x00dev, |
diff --git a/drivers/net/wireless/rtl818x/rtl8187/leds.c b/drivers/net/wireless/rtl818x/rtl8187/leds.c index 2e0de2f5f0f9..c2d5b495c179 100644 --- a/drivers/net/wireless/rtl818x/rtl8187/leds.c +++ b/drivers/net/wireless/rtl818x/rtl8187/leds.c | |||
| @@ -117,7 +117,7 @@ static void rtl8187_led_brightness_set(struct led_classdev *led_dev, | |||
| 117 | radio_on = true; | 117 | radio_on = true; |
| 118 | } else if (radio_on) { | 118 | } else if (radio_on) { |
| 119 | radio_on = false; | 119 | radio_on = false; |
| 120 | cancel_delayed_work_sync(&priv->led_on); | 120 | cancel_delayed_work(&priv->led_on); |
| 121 | ieee80211_queue_delayed_work(hw, &priv->led_off, 0); | 121 | ieee80211_queue_delayed_work(hw, &priv->led_off, 0); |
| 122 | } | 122 | } |
| 123 | } else if (radio_on) { | 123 | } else if (radio_on) { |
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index c3b331b74fa0..0cc053af70bd 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c | |||
| @@ -61,7 +61,7 @@ static LIST_HEAD(pinctrl_maps); | |||
| 61 | list_for_each_entry(_maps_node_, &pinctrl_maps, node) \ | 61 | list_for_each_entry(_maps_node_, &pinctrl_maps, node) \ |
| 62 | for (_i_ = 0, _map_ = &_maps_node_->maps[_i_]; \ | 62 | for (_i_ = 0, _map_ = &_maps_node_->maps[_i_]; \ |
| 63 | _i_ < _maps_node_->num_maps; \ | 63 | _i_ < _maps_node_->num_maps; \ |
| 64 | i++, _map_ = &_maps_node_->maps[_i_]) | 64 | _i_++, _map_ = &_maps_node_->maps[_i_]) |
| 65 | 65 | ||
| 66 | /** | 66 | /** |
| 67 | * pinctrl_provide_dummies() - indicate if pinctrl provides dummy state support | 67 | * pinctrl_provide_dummies() - indicate if pinctrl provides dummy state support |
diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c index f6e7c670906c..dd6d93aa5334 100644 --- a/drivers/pinctrl/pinctrl-imx.c +++ b/drivers/pinctrl/pinctrl-imx.c | |||
| @@ -27,16 +27,16 @@ | |||
| 27 | #include "core.h" | 27 | #include "core.h" |
| 28 | #include "pinctrl-imx.h" | 28 | #include "pinctrl-imx.h" |
| 29 | 29 | ||
| 30 | #define IMX_PMX_DUMP(info, p, m, c, n) \ | 30 | #define IMX_PMX_DUMP(info, p, m, c, n) \ |
| 31 | { \ | 31 | { \ |
| 32 | int i, j; \ | 32 | int i, j; \ |
| 33 | printk("Format: Pin Mux Config\n"); \ | 33 | printk(KERN_DEBUG "Format: Pin Mux Config\n"); \ |
| 34 | for (i = 0; i < n; i++) { \ | 34 | for (i = 0; i < n; i++) { \ |
| 35 | j = p[i]; \ | 35 | j = p[i]; \ |
| 36 | printk("%s %d 0x%lx\n", \ | 36 | printk(KERN_DEBUG "%s %d 0x%lx\n", \ |
| 37 | info->pins[j].name, \ | 37 | info->pins[j].name, \ |
| 38 | m[i], c[i]); \ | 38 | m[i], c[i]); \ |
| 39 | } \ | 39 | } \ |
| 40 | } | 40 | } |
| 41 | 41 | ||
| 42 | /* The bits in CONFIG cell defined in binding doc*/ | 42 | /* The bits in CONFIG cell defined in binding doc*/ |
| @@ -173,8 +173,10 @@ static int imx_dt_node_to_map(struct pinctrl_dev *pctldev, | |||
| 173 | 173 | ||
| 174 | /* create mux map */ | 174 | /* create mux map */ |
| 175 | parent = of_get_parent(np); | 175 | parent = of_get_parent(np); |
| 176 | if (!parent) | 176 | if (!parent) { |
| 177 | kfree(new_map); | ||
| 177 | return -EINVAL; | 178 | return -EINVAL; |
| 179 | } | ||
| 178 | new_map[0].type = PIN_MAP_TYPE_MUX_GROUP; | 180 | new_map[0].type = PIN_MAP_TYPE_MUX_GROUP; |
| 179 | new_map[0].data.mux.function = parent->name; | 181 | new_map[0].data.mux.function = parent->name; |
| 180 | new_map[0].data.mux.group = np->name; | 182 | new_map[0].data.mux.group = np->name; |
| @@ -193,7 +195,7 @@ static int imx_dt_node_to_map(struct pinctrl_dev *pctldev, | |||
| 193 | } | 195 | } |
| 194 | 196 | ||
| 195 | dev_dbg(pctldev->dev, "maps: function %s group %s num %d\n", | 197 | dev_dbg(pctldev->dev, "maps: function %s group %s num %d\n", |
| 196 | new_map->data.mux.function, new_map->data.mux.group, map_num); | 198 | (*map)->data.mux.function, (*map)->data.mux.group, map_num); |
| 197 | 199 | ||
| 198 | return 0; | 200 | return 0; |
| 199 | } | 201 | } |
| @@ -201,10 +203,7 @@ static int imx_dt_node_to_map(struct pinctrl_dev *pctldev, | |||
| 201 | static void imx_dt_free_map(struct pinctrl_dev *pctldev, | 203 | static void imx_dt_free_map(struct pinctrl_dev *pctldev, |
| 202 | struct pinctrl_map *map, unsigned num_maps) | 204 | struct pinctrl_map *map, unsigned num_maps) |
| 203 | { | 205 | { |
| 204 | int i; | 206 | kfree(map); |
| 205 | |||
| 206 | for (i = 0; i < num_maps; i++) | ||
| 207 | kfree(map); | ||
| 208 | } | 207 | } |
| 209 | 208 | ||
| 210 | static struct pinctrl_ops imx_pctrl_ops = { | 209 | static struct pinctrl_ops imx_pctrl_ops = { |
| @@ -475,9 +474,8 @@ static int __devinit imx_pinctrl_parse_groups(struct device_node *np, | |||
| 475 | grp->configs[j] = config & ~IMX_PAD_SION; | 474 | grp->configs[j] = config & ~IMX_PAD_SION; |
| 476 | } | 475 | } |
| 477 | 476 | ||
| 478 | #ifdef DEBUG | ||
| 479 | IMX_PMX_DUMP(info, grp->pins, grp->mux_mode, grp->configs, grp->npins); | 477 | IMX_PMX_DUMP(info, grp->pins, grp->mux_mode, grp->configs, grp->npins); |
| 480 | #endif | 478 | |
| 481 | return 0; | 479 | return 0; |
| 482 | } | 480 | } |
| 483 | 481 | ||
diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c index 556e45a213eb..afb50ee64598 100644 --- a/drivers/pinctrl/pinctrl-mxs.c +++ b/drivers/pinctrl/pinctrl-mxs.c | |||
| @@ -107,8 +107,10 @@ static int mxs_dt_node_to_map(struct pinctrl_dev *pctldev, | |||
| 107 | 107 | ||
| 108 | /* Compose group name */ | 108 | /* Compose group name */ |
| 109 | group = kzalloc(length, GFP_KERNEL); | 109 | group = kzalloc(length, GFP_KERNEL); |
| 110 | if (!group) | 110 | if (!group) { |
| 111 | return -ENOMEM; | 111 | ret = -ENOMEM; |
| 112 | goto free; | ||
| 113 | } | ||
| 112 | snprintf(group, length, "%s.%d", np->name, reg); | 114 | snprintf(group, length, "%s.%d", np->name, reg); |
| 113 | new_map[i].data.mux.group = group; | 115 | new_map[i].data.mux.group = group; |
| 114 | i++; | 116 | i++; |
| @@ -118,7 +120,7 @@ static int mxs_dt_node_to_map(struct pinctrl_dev *pctldev, | |||
| 118 | pconfig = kmemdup(&config, sizeof(config), GFP_KERNEL); | 120 | pconfig = kmemdup(&config, sizeof(config), GFP_KERNEL); |
| 119 | if (!pconfig) { | 121 | if (!pconfig) { |
| 120 | ret = -ENOMEM; | 122 | ret = -ENOMEM; |
| 121 | goto free; | 123 | goto free_group; |
| 122 | } | 124 | } |
| 123 | 125 | ||
| 124 | new_map[i].type = PIN_MAP_TYPE_CONFIGS_GROUP; | 126 | new_map[i].type = PIN_MAP_TYPE_CONFIGS_GROUP; |
| @@ -133,6 +135,9 @@ static int mxs_dt_node_to_map(struct pinctrl_dev *pctldev, | |||
| 133 | 135 | ||
| 134 | return 0; | 136 | return 0; |
| 135 | 137 | ||
| 138 | free_group: | ||
| 139 | if (!purecfg) | ||
| 140 | free(group); | ||
| 136 | free: | 141 | free: |
| 137 | kfree(new_map); | 142 | kfree(new_map); |
| 138 | return ret; | 143 | return ret; |
| @@ -511,6 +516,7 @@ int __devinit mxs_pinctrl_probe(struct platform_device *pdev, | |||
| 511 | return 0; | 516 | return 0; |
| 512 | 517 | ||
| 513 | err: | 518 | err: |
| 519 | platform_set_drvdata(pdev, NULL); | ||
| 514 | iounmap(d->base); | 520 | iounmap(d->base); |
| 515 | return ret; | 521 | return ret; |
| 516 | } | 522 | } |
| @@ -520,6 +526,7 @@ int __devexit mxs_pinctrl_remove(struct platform_device *pdev) | |||
| 520 | { | 526 | { |
| 521 | struct mxs_pinctrl_data *d = platform_get_drvdata(pdev); | 527 | struct mxs_pinctrl_data *d = platform_get_drvdata(pdev); |
| 522 | 528 | ||
| 529 | platform_set_drvdata(pdev, NULL); | ||
| 523 | pinctrl_unregister(d->pctl); | 530 | pinctrl_unregister(d->pctl); |
| 524 | iounmap(d->base); | 531 | iounmap(d->base); |
| 525 | 532 | ||
diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c index b26395d16347..e8937e7e4999 100644 --- a/drivers/pinctrl/pinctrl-nomadik.c +++ b/drivers/pinctrl/pinctrl-nomadik.c | |||
| @@ -673,7 +673,7 @@ static void __nmk_gpio_set_wake(struct nmk_gpio_chip *nmk_chip, | |||
| 673 | * wakeup is anyhow controlled by the RIMSC and FIMSC registers. | 673 | * wakeup is anyhow controlled by the RIMSC and FIMSC registers. |
| 674 | */ | 674 | */ |
| 675 | if (nmk_chip->sleepmode && on) { | 675 | if (nmk_chip->sleepmode && on) { |
| 676 | __nmk_gpio_set_slpm(nmk_chip, gpio % nmk_chip->chip.base, | 676 | __nmk_gpio_set_slpm(nmk_chip, gpio % NMK_GPIO_PER_CHIP, |
| 677 | NMK_GPIO_SLPM_WAKEUP_ENABLE); | 677 | NMK_GPIO_SLPM_WAKEUP_ENABLE); |
| 678 | } | 678 | } |
| 679 | 679 | ||
| @@ -1246,6 +1246,7 @@ static int __devinit nmk_gpio_probe(struct platform_device *dev) | |||
| 1246 | ret = PTR_ERR(clk); | 1246 | ret = PTR_ERR(clk); |
| 1247 | goto out_unmap; | 1247 | goto out_unmap; |
| 1248 | } | 1248 | } |
| 1249 | clk_prepare(clk); | ||
| 1249 | 1250 | ||
| 1250 | nmk_chip = kzalloc(sizeof(*nmk_chip), GFP_KERNEL); | 1251 | nmk_chip = kzalloc(sizeof(*nmk_chip), GFP_KERNEL); |
| 1251 | if (!nmk_chip) { | 1252 | if (!nmk_chip) { |
diff --git a/drivers/pinctrl/pinctrl-sirf.c b/drivers/pinctrl/pinctrl-sirf.c index ba15b1a29e52..e9f8e7d11001 100644 --- a/drivers/pinctrl/pinctrl-sirf.c +++ b/drivers/pinctrl/pinctrl-sirf.c | |||
| @@ -1184,7 +1184,7 @@ out_no_gpio_remap: | |||
| 1184 | return ret; | 1184 | return ret; |
| 1185 | } | 1185 | } |
| 1186 | 1186 | ||
| 1187 | static const struct of_device_id pinmux_ids[] = { | 1187 | static const struct of_device_id pinmux_ids[] __devinitconst = { |
| 1188 | { .compatible = "sirf,prima2-gpio-pinmux" }, | 1188 | { .compatible = "sirf,prima2-gpio-pinmux" }, |
| 1189 | {} | 1189 | {} |
| 1190 | }; | 1190 | }; |
diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c index 3660bace123c..e82e7eaac0f1 100644 --- a/drivers/regulator/anatop-regulator.c +++ b/drivers/regulator/anatop-regulator.c | |||
| @@ -224,7 +224,7 @@ static struct platform_driver anatop_regulator_driver = { | |||
| 224 | .of_match_table = of_anatop_regulator_match_tbl, | 224 | .of_match_table = of_anatop_regulator_match_tbl, |
| 225 | }, | 225 | }, |
| 226 | .probe = anatop_regulator_probe, | 226 | .probe = anatop_regulator_probe, |
| 227 | .remove = anatop_regulator_remove, | 227 | .remove = __devexit_p(anatop_regulator_remove), |
| 228 | }; | 228 | }; |
| 229 | 229 | ||
| 230 | static int __init anatop_regulator_init(void) | 230 | static int __init anatop_regulator_init(void) |
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 7584a74eec8a..09a737c868b5 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c | |||
| @@ -2050,6 +2050,9 @@ int regulator_map_voltage_linear(struct regulator_dev *rdev, | |||
| 2050 | return -EINVAL; | 2050 | return -EINVAL; |
| 2051 | } | 2051 | } |
| 2052 | 2052 | ||
| 2053 | if (min_uV < rdev->desc->min_uV) | ||
| 2054 | min_uV = rdev->desc->min_uV; | ||
| 2055 | |||
| 2053 | ret = DIV_ROUND_UP(min_uV - rdev->desc->min_uV, rdev->desc->uV_step); | 2056 | ret = DIV_ROUND_UP(min_uV - rdev->desc->min_uV, rdev->desc->uV_step); |
| 2054 | if (ret < 0) | 2057 | if (ret < 0) |
| 2055 | return ret; | 2058 | return ret; |
diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c index 9997d7aaca84..242851a4c1a6 100644 --- a/drivers/regulator/gpio-regulator.c +++ b/drivers/regulator/gpio-regulator.c | |||
| @@ -101,16 +101,20 @@ static int gpio_regulator_get_value(struct regulator_dev *dev) | |||
| 101 | } | 101 | } |
| 102 | 102 | ||
| 103 | static int gpio_regulator_set_value(struct regulator_dev *dev, | 103 | static int gpio_regulator_set_value(struct regulator_dev *dev, |
| 104 | int min, int max) | 104 | int min, int max, unsigned *selector) |
| 105 | { | 105 | { |
| 106 | struct gpio_regulator_data *data = rdev_get_drvdata(dev); | 106 | struct gpio_regulator_data *data = rdev_get_drvdata(dev); |
| 107 | int ptr, target, state, best_val = INT_MAX; | 107 | int ptr, target = 0, state, best_val = INT_MAX; |
| 108 | 108 | ||
| 109 | for (ptr = 0; ptr < data->nr_states; ptr++) | 109 | for (ptr = 0; ptr < data->nr_states; ptr++) |
| 110 | if (data->states[ptr].value < best_val && | 110 | if (data->states[ptr].value < best_val && |
| 111 | data->states[ptr].value >= min && | 111 | data->states[ptr].value >= min && |
| 112 | data->states[ptr].value <= max) | 112 | data->states[ptr].value <= max) { |
| 113 | target = data->states[ptr].gpios; | 113 | target = data->states[ptr].gpios; |
| 114 | best_val = data->states[ptr].value; | ||
| 115 | if (selector) | ||
| 116 | *selector = ptr; | ||
| 117 | } | ||
| 114 | 118 | ||
| 115 | if (best_val == INT_MAX) | 119 | if (best_val == INT_MAX) |
| 116 | return -EINVAL; | 120 | return -EINVAL; |
| @@ -128,7 +132,7 @@ static int gpio_regulator_set_voltage(struct regulator_dev *dev, | |||
| 128 | int min_uV, int max_uV, | 132 | int min_uV, int max_uV, |
| 129 | unsigned *selector) | 133 | unsigned *selector) |
| 130 | { | 134 | { |
| 131 | return gpio_regulator_set_value(dev, min_uV, max_uV); | 135 | return gpio_regulator_set_value(dev, min_uV, max_uV, selector); |
| 132 | } | 136 | } |
| 133 | 137 | ||
| 134 | static int gpio_regulator_list_voltage(struct regulator_dev *dev, | 138 | static int gpio_regulator_list_voltage(struct regulator_dev *dev, |
| @@ -145,7 +149,7 @@ static int gpio_regulator_list_voltage(struct regulator_dev *dev, | |||
| 145 | static int gpio_regulator_set_current_limit(struct regulator_dev *dev, | 149 | static int gpio_regulator_set_current_limit(struct regulator_dev *dev, |
| 146 | int min_uA, int max_uA) | 150 | int min_uA, int max_uA) |
| 147 | { | 151 | { |
| 148 | return gpio_regulator_set_value(dev, min_uA, max_uA); | 152 | return gpio_regulator_set_value(dev, min_uA, max_uA, NULL); |
| 149 | } | 153 | } |
| 150 | 154 | ||
| 151 | static struct regulator_ops gpio_regulator_voltage_ops = { | 155 | static struct regulator_ops gpio_regulator_voltage_ops = { |
| @@ -286,7 +290,7 @@ static int __devinit gpio_regulator_probe(struct platform_device *pdev) | |||
| 286 | 290 | ||
| 287 | cfg.dev = &pdev->dev; | 291 | cfg.dev = &pdev->dev; |
| 288 | cfg.init_data = config->init_data; | 292 | cfg.init_data = config->init_data; |
| 289 | cfg.driver_data = &drvdata; | 293 | cfg.driver_data = drvdata; |
| 290 | 294 | ||
| 291 | drvdata->dev = regulator_register(&drvdata->desc, &cfg); | 295 | drvdata->dev = regulator_register(&drvdata->desc, &cfg); |
| 292 | if (IS_ERR(drvdata->dev)) { | 296 | if (IS_ERR(drvdata->dev)) { |
diff --git a/drivers/regulator/max8649.c b/drivers/regulator/max8649.c index 1f4bb80457b3..9d540cd02dab 100644 --- a/drivers/regulator/max8649.c +++ b/drivers/regulator/max8649.c | |||
| @@ -259,6 +259,7 @@ static int __devinit max8649_regulator_probe(struct i2c_client *client, | |||
| 259 | config.dev = &client->dev; | 259 | config.dev = &client->dev; |
| 260 | config.init_data = pdata->regulator; | 260 | config.init_data = pdata->regulator; |
| 261 | config.driver_data = info; | 261 | config.driver_data = info; |
| 262 | config.regmap = info->regmap; | ||
| 262 | 263 | ||
| 263 | info->regulator = regulator_register(&dcdc_desc, &config); | 264 | info->regulator = regulator_register(&dcdc_desc, &config); |
| 264 | if (IS_ERR(info->regulator)) { | 265 | if (IS_ERR(info->regulator)) { |
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index c4435f608df7..9b7ca90057d5 100644 --- a/drivers/regulator/palmas-regulator.c +++ b/drivers/regulator/palmas-regulator.c | |||
| @@ -775,9 +775,6 @@ static __devinit int palmas_probe(struct platform_device *pdev) | |||
| 775 | err_unregister_regulator: | 775 | err_unregister_regulator: |
| 776 | while (--id >= 0) | 776 | while (--id >= 0) |
| 777 | regulator_unregister(pmic->rdev[id]); | 777 | regulator_unregister(pmic->rdev[id]); |
| 778 | kfree(pmic->rdev); | ||
| 779 | kfree(pmic->desc); | ||
| 780 | kfree(pmic); | ||
| 781 | return ret; | 778 | return ret; |
| 782 | } | 779 | } |
| 783 | 780 | ||
| @@ -788,10 +785,6 @@ static int __devexit palmas_remove(struct platform_device *pdev) | |||
| 788 | 785 | ||
| 789 | for (id = 0; id < PALMAS_NUM_REGS; id++) | 786 | for (id = 0; id < PALMAS_NUM_REGS; id++) |
| 790 | regulator_unregister(pmic->rdev[id]); | 787 | regulator_unregister(pmic->rdev[id]); |
| 791 | |||
| 792 | kfree(pmic->rdev); | ||
| 793 | kfree(pmic->desc); | ||
| 794 | kfree(pmic); | ||
| 795 | return 0; | 788 | return 0; |
| 796 | } | 789 | } |
| 797 | 790 | ||
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c index 6102ef2cb2d8..9d46fcbe7755 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_base.c +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c | |||
| @@ -1792,7 +1792,7 @@ static inline void _base_writeq(__u64 b, volatile void __iomem *addr, | |||
| 1792 | static inline u8 | 1792 | static inline u8 |
| 1793 | _base_get_msix_index(struct MPT2SAS_ADAPTER *ioc) | 1793 | _base_get_msix_index(struct MPT2SAS_ADAPTER *ioc) |
| 1794 | { | 1794 | { |
| 1795 | return ioc->cpu_msix_table[smp_processor_id()]; | 1795 | return ioc->cpu_msix_table[raw_smp_processor_id()]; |
| 1796 | } | 1796 | } |
| 1797 | 1797 | ||
| 1798 | /** | 1798 | /** |
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 04f80ebf09eb..6986552b47e6 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c | |||
| @@ -26,7 +26,6 @@ | |||
| 26 | #include <linux/module.h> | 26 | #include <linux/module.h> |
| 27 | #include <linux/init.h> | 27 | #include <linux/init.h> |
| 28 | #include <linux/types.h> | 28 | #include <linux/types.h> |
| 29 | #include <linux/version.h> | ||
| 30 | #include <linux/blkdev.h> | 29 | #include <linux/blkdev.h> |
| 31 | #include <linux/interrupt.h> | 30 | #include <linux/interrupt.h> |
| 32 | #include <linux/pci.h> | 31 | #include <linux/pci.h> |
| @@ -2477,11 +2476,9 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle, | |||
| 2477 | } | 2476 | } |
| 2478 | 2477 | ||
| 2479 | cmd = qlt_ctio_to_cmd(vha, handle, ctio); | 2478 | cmd = qlt_ctio_to_cmd(vha, handle, ctio); |
| 2480 | if (cmd == NULL) { | 2479 | if (cmd == NULL) |
| 2481 | if (status != CTIO_SUCCESS) | ||
| 2482 | qlt_term_ctio_exchange(vha, ctio, NULL, status); | ||
| 2483 | return; | 2480 | return; |
| 2484 | } | 2481 | |
| 2485 | se_cmd = &cmd->se_cmd; | 2482 | se_cmd = &cmd->se_cmd; |
| 2486 | tfo = se_cmd->se_tfo; | 2483 | tfo = se_cmd->se_tfo; |
| 2487 | 2484 | ||
| @@ -2727,10 +2724,12 @@ static void qlt_do_work(struct work_struct *work) | |||
| 2727 | out_term: | 2724 | out_term: |
| 2728 | ql_dbg(ql_dbg_tgt_mgt, vha, 0xf020, "Terminating work cmd %p", cmd); | 2725 | ql_dbg(ql_dbg_tgt_mgt, vha, 0xf020, "Terminating work cmd %p", cmd); |
| 2729 | /* | 2726 | /* |
| 2730 | * cmd has not sent to target yet, so pass NULL as the second argument | 2727 | * cmd has not sent to target yet, so pass NULL as the second |
| 2728 | * argument to qlt_send_term_exchange() and free the memory here. | ||
| 2731 | */ | 2729 | */ |
| 2732 | spin_lock_irqsave(&ha->hardware_lock, flags); | 2730 | spin_lock_irqsave(&ha->hardware_lock, flags); |
| 2733 | qlt_send_term_exchange(vha, NULL, &cmd->atio, 1); | 2731 | qlt_send_term_exchange(vha, NULL, &cmd->atio, 1); |
| 2732 | kmem_cache_free(qla_tgt_cmd_cachep, cmd); | ||
| 2734 | spin_unlock_irqrestore(&ha->hardware_lock, flags); | 2733 | spin_unlock_irqrestore(&ha->hardware_lock, flags); |
| 2735 | if (sess) | 2734 | if (sess) |
| 2736 | ha->tgt.tgt_ops->put_sess(sess); | 2735 | ha->tgt.tgt_ops->put_sess(sess); |
diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h index 9ec19bc2f0fe..9f9ef1644fd9 100644 --- a/drivers/scsi/qla2xxx/qla_target.h +++ b/drivers/scsi/qla2xxx/qla_target.h | |||
| @@ -919,7 +919,6 @@ struct qla_tgt_srr_ctio { | |||
| 919 | #define QLA_TGT_XMIT_STATUS 2 | 919 | #define QLA_TGT_XMIT_STATUS 2 |
| 920 | #define QLA_TGT_XMIT_ALL (QLA_TGT_XMIT_STATUS|QLA_TGT_XMIT_DATA) | 920 | #define QLA_TGT_XMIT_ALL (QLA_TGT_XMIT_STATUS|QLA_TGT_XMIT_DATA) |
| 921 | 921 | ||
| 922 | #include <linux/version.h> | ||
| 923 | 922 | ||
| 924 | extern struct qla_tgt_data qla_target; | 923 | extern struct qla_tgt_data qla_target; |
| 925 | /* | 924 | /* |
diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index 436598f57404..6e64314dbbb3 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c | |||
| @@ -137,13 +137,15 @@ static char *tcm_qla2xxx_get_fabric_name(void) | |||
| 137 | */ | 137 | */ |
| 138 | static int tcm_qla2xxx_npiv_extract_wwn(const char *ns, u64 *nm) | 138 | static int tcm_qla2xxx_npiv_extract_wwn(const char *ns, u64 *nm) |
| 139 | { | 139 | { |
| 140 | unsigned int i, j, value; | 140 | unsigned int i, j; |
| 141 | u8 wwn[8]; | 141 | u8 wwn[8]; |
| 142 | 142 | ||
| 143 | memset(wwn, 0, sizeof(wwn)); | 143 | memset(wwn, 0, sizeof(wwn)); |
| 144 | 144 | ||
| 145 | /* Validate and store the new name */ | 145 | /* Validate and store the new name */ |
| 146 | for (i = 0, j = 0; i < 16; i++) { | 146 | for (i = 0, j = 0; i < 16; i++) { |
| 147 | int value; | ||
| 148 | |||
| 147 | value = hex_to_bin(*ns++); | 149 | value = hex_to_bin(*ns++); |
| 148 | if (value >= 0) | 150 | if (value >= 0) |
| 149 | j = (j << 4) | value; | 151 | j = (j << 4) | value; |
| @@ -652,8 +654,8 @@ static int tcm_qla2xxx_handle_data(struct qla_tgt_cmd *cmd) | |||
| 652 | /* | 654 | /* |
| 653 | * Called from qla_target.c:qlt_issue_task_mgmt() | 655 | * Called from qla_target.c:qlt_issue_task_mgmt() |
| 654 | */ | 656 | */ |
| 655 | int tcm_qla2xxx_handle_tmr(struct qla_tgt_mgmt_cmd *mcmd, uint32_t lun, | 657 | static int tcm_qla2xxx_handle_tmr(struct qla_tgt_mgmt_cmd *mcmd, uint32_t lun, |
| 656 | uint8_t tmr_func, uint32_t tag) | 658 | uint8_t tmr_func, uint32_t tag) |
| 657 | { | 659 | { |
| 658 | struct qla_tgt_sess *sess = mcmd->sess; | 660 | struct qla_tgt_sess *sess = mcmd->sess; |
| 659 | struct se_cmd *se_cmd = &mcmd->se_cmd; | 661 | struct se_cmd *se_cmd = &mcmd->se_cmd; |
| @@ -762,65 +764,8 @@ static u16 tcm_qla2xxx_set_fabric_sense_len(struct se_cmd *se_cmd, | |||
| 762 | struct target_fabric_configfs *tcm_qla2xxx_fabric_configfs; | 764 | struct target_fabric_configfs *tcm_qla2xxx_fabric_configfs; |
| 763 | struct target_fabric_configfs *tcm_qla2xxx_npiv_fabric_configfs; | 765 | struct target_fabric_configfs *tcm_qla2xxx_npiv_fabric_configfs; |
| 764 | 766 | ||
| 765 | static int tcm_qla2xxx_setup_nacl_from_rport( | 767 | static void tcm_qla2xxx_clear_sess_lookup(struct tcm_qla2xxx_lport *, |
| 766 | struct se_portal_group *se_tpg, | 768 | struct tcm_qla2xxx_nacl *, struct qla_tgt_sess *); |
| 767 | struct se_node_acl *se_nacl, | ||
| 768 | struct tcm_qla2xxx_lport *lport, | ||
| 769 | struct tcm_qla2xxx_nacl *nacl, | ||
| 770 | u64 rport_wwnn) | ||
| 771 | { | ||
| 772 | struct scsi_qla_host *vha = lport->qla_vha; | ||
| 773 | struct Scsi_Host *sh = vha->host; | ||
| 774 | struct fc_host_attrs *fc_host = shost_to_fc_host(sh); | ||
| 775 | struct fc_rport *rport; | ||
| 776 | unsigned long flags; | ||
| 777 | void *node; | ||
| 778 | int rc; | ||
| 779 | |||
| 780 | /* | ||
| 781 | * Scan the existing rports, and create a session for the | ||
| 782 | * explict NodeACL is an matching rport->node_name already | ||
| 783 | * exists. | ||
| 784 | */ | ||
| 785 | spin_lock_irqsave(sh->host_lock, flags); | ||
| 786 | list_for_each_entry(rport, &fc_host->rports, peers) { | ||
| 787 | if (rport_wwnn != rport->node_name) | ||
| 788 | continue; | ||
| 789 | |||
| 790 | pr_debug("Located existing rport_wwpn and rport->node_name: 0x%016LX, port_id: 0x%04x\n", | ||
| 791 | rport->node_name, rport->port_id); | ||
| 792 | nacl->nport_id = rport->port_id; | ||
| 793 | |||
| 794 | spin_unlock_irqrestore(sh->host_lock, flags); | ||
| 795 | |||
| 796 | spin_lock_irqsave(&vha->hw->hardware_lock, flags); | ||
| 797 | node = btree_lookup32(&lport->lport_fcport_map, rport->port_id); | ||
| 798 | if (node) { | ||
| 799 | rc = btree_update32(&lport->lport_fcport_map, | ||
| 800 | rport->port_id, se_nacl); | ||
| 801 | } else { | ||
| 802 | rc = btree_insert32(&lport->lport_fcport_map, | ||
| 803 | rport->port_id, se_nacl, | ||
| 804 | GFP_ATOMIC); | ||
| 805 | } | ||
| 806 | spin_unlock_irqrestore(&vha->hw->hardware_lock, flags); | ||
| 807 | |||
| 808 | if (rc) { | ||
| 809 | pr_err("Unable to insert se_nacl into fcport_map"); | ||
| 810 | WARN_ON(rc > 0); | ||
| 811 | return rc; | ||
| 812 | } | ||
| 813 | |||
| 814 | pr_debug("Inserted into fcport_map: %p for WWNN: 0x%016LX, port_id: 0x%08x\n", | ||
| 815 | se_nacl, rport_wwnn, nacl->nport_id); | ||
| 816 | |||
| 817 | return 1; | ||
| 818 | } | ||
| 819 | spin_unlock_irqrestore(sh->host_lock, flags); | ||
| 820 | |||
| 821 | return 0; | ||
| 822 | } | ||
| 823 | |||
| 824 | /* | 769 | /* |
| 825 | * Expected to be called with struct qla_hw_data->hardware_lock held | 770 | * Expected to be called with struct qla_hw_data->hardware_lock held |
| 826 | */ | 771 | */ |
| @@ -842,11 +787,40 @@ static void tcm_qla2xxx_clear_nacl_from_fcport_map(struct qla_tgt_sess *sess) | |||
| 842 | 787 | ||
| 843 | pr_debug("Removed from fcport_map: %p for WWNN: 0x%016LX, port_id: 0x%06x\n", | 788 | pr_debug("Removed from fcport_map: %p for WWNN: 0x%016LX, port_id: 0x%06x\n", |
| 844 | se_nacl, nacl->nport_wwnn, nacl->nport_id); | 789 | se_nacl, nacl->nport_wwnn, nacl->nport_id); |
| 790 | /* | ||
| 791 | * Now clear the se_nacl and session pointers from our HW lport lookup | ||
| 792 | * table mapping for this initiator's fabric S_ID and LOOP_ID entries. | ||
| 793 | * | ||
| 794 | * This is done ahead of callbacks into tcm_qla2xxx_free_session() -> | ||
| 795 | * target_wait_for_sess_cmds() before the session waits for outstanding | ||
| 796 | * I/O to complete, to avoid a race between session shutdown execution | ||
| 797 | * and incoming ATIOs or TMRs picking up a stale se_node_act reference. | ||
| 798 | */ | ||
| 799 | tcm_qla2xxx_clear_sess_lookup(lport, nacl, sess); | ||
| 800 | } | ||
| 801 | |||
| 802 | static void tcm_qla2xxx_release_session(struct kref *kref) | ||
| 803 | { | ||
| 804 | struct se_session *se_sess = container_of(kref, | ||
| 805 | struct se_session, sess_kref); | ||
| 806 | |||
| 807 | qlt_unreg_sess(se_sess->fabric_sess_ptr); | ||
| 808 | } | ||
| 809 | |||
| 810 | static void tcm_qla2xxx_put_session(struct se_session *se_sess) | ||
| 811 | { | ||
| 812 | struct qla_tgt_sess *sess = se_sess->fabric_sess_ptr; | ||
| 813 | struct qla_hw_data *ha = sess->vha->hw; | ||
| 814 | unsigned long flags; | ||
| 815 | |||
| 816 | spin_lock_irqsave(&ha->hardware_lock, flags); | ||
| 817 | kref_put(&se_sess->sess_kref, tcm_qla2xxx_release_session); | ||
| 818 | spin_unlock_irqrestore(&ha->hardware_lock, flags); | ||
| 845 | } | 819 | } |
| 846 | 820 | ||
| 847 | static void tcm_qla2xxx_put_sess(struct qla_tgt_sess *sess) | 821 | static void tcm_qla2xxx_put_sess(struct qla_tgt_sess *sess) |
| 848 | { | 822 | { |
| 849 | target_put_session(sess->se_sess); | 823 | tcm_qla2xxx_put_session(sess->se_sess); |
| 850 | } | 824 | } |
| 851 | 825 | ||
| 852 | static void tcm_qla2xxx_shutdown_sess(struct qla_tgt_sess *sess) | 826 | static void tcm_qla2xxx_shutdown_sess(struct qla_tgt_sess *sess) |
| @@ -859,14 +833,10 @@ static struct se_node_acl *tcm_qla2xxx_make_nodeacl( | |||
| 859 | struct config_group *group, | 833 | struct config_group *group, |
| 860 | const char *name) | 834 | const char *name) |
| 861 | { | 835 | { |
| 862 | struct se_wwn *se_wwn = se_tpg->se_tpg_wwn; | ||
| 863 | struct tcm_qla2xxx_lport *lport = container_of(se_wwn, | ||
| 864 | struct tcm_qla2xxx_lport, lport_wwn); | ||
| 865 | struct se_node_acl *se_nacl, *se_nacl_new; | 836 | struct se_node_acl *se_nacl, *se_nacl_new; |
| 866 | struct tcm_qla2xxx_nacl *nacl; | 837 | struct tcm_qla2xxx_nacl *nacl; |
| 867 | u64 wwnn; | 838 | u64 wwnn; |
| 868 | u32 qla2xxx_nexus_depth; | 839 | u32 qla2xxx_nexus_depth; |
| 869 | int rc; | ||
| 870 | 840 | ||
| 871 | if (tcm_qla2xxx_parse_wwn(name, &wwnn, 1) < 0) | 841 | if (tcm_qla2xxx_parse_wwn(name, &wwnn, 1) < 0) |
| 872 | return ERR_PTR(-EINVAL); | 842 | return ERR_PTR(-EINVAL); |
| @@ -893,16 +863,6 @@ static struct se_node_acl *tcm_qla2xxx_make_nodeacl( | |||
| 893 | nacl = container_of(se_nacl, struct tcm_qla2xxx_nacl, se_node_acl); | 863 | nacl = container_of(se_nacl, struct tcm_qla2xxx_nacl, se_node_acl); |
| 894 | nacl->nport_wwnn = wwnn; | 864 | nacl->nport_wwnn = wwnn; |
| 895 | tcm_qla2xxx_format_wwn(&nacl->nport_name[0], TCM_QLA2XXX_NAMELEN, wwnn); | 865 | tcm_qla2xxx_format_wwn(&nacl->nport_name[0], TCM_QLA2XXX_NAMELEN, wwnn); |
| 896 | /* | ||
| 897 | * Setup a se_nacl handle based on an a matching struct fc_rport setup | ||
| 898 | * via drivers/scsi/qla2xxx/qla_init.c:qla2x00_reg_remote_port() | ||
| 899 | */ | ||
| 900 | rc = tcm_qla2xxx_setup_nacl_from_rport(se_tpg, se_nacl, lport, | ||
| 901 | nacl, wwnn); | ||
| 902 | if (rc < 0) { | ||
| 903 | tcm_qla2xxx_release_fabric_acl(se_tpg, se_nacl_new); | ||
| 904 | return ERR_PTR(rc); | ||
| 905 | } | ||
| 906 | 866 | ||
| 907 | return se_nacl; | 867 | return se_nacl; |
| 908 | } | 868 | } |
| @@ -1390,6 +1350,25 @@ static void tcm_qla2xxx_set_sess_by_loop_id( | |||
| 1390 | nacl->qla_tgt_sess, new_se_nacl, new_se_nacl->initiatorname); | 1350 | nacl->qla_tgt_sess, new_se_nacl, new_se_nacl->initiatorname); |
| 1391 | } | 1351 | } |
| 1392 | 1352 | ||
| 1353 | /* | ||
| 1354 | * Should always be called with qla_hw_data->hardware_lock held. | ||
| 1355 | */ | ||
| 1356 | static void tcm_qla2xxx_clear_sess_lookup(struct tcm_qla2xxx_lport *lport, | ||
| 1357 | struct tcm_qla2xxx_nacl *nacl, struct qla_tgt_sess *sess) | ||
| 1358 | { | ||
| 1359 | struct se_session *se_sess = sess->se_sess; | ||
| 1360 | unsigned char be_sid[3]; | ||
| 1361 | |||
| 1362 | be_sid[0] = sess->s_id.b.domain; | ||
| 1363 | be_sid[1] = sess->s_id.b.area; | ||
| 1364 | be_sid[2] = sess->s_id.b.al_pa; | ||
| 1365 | |||
| 1366 | tcm_qla2xxx_set_sess_by_s_id(lport, NULL, nacl, se_sess, | ||
| 1367 | sess, be_sid); | ||
| 1368 | tcm_qla2xxx_set_sess_by_loop_id(lport, NULL, nacl, se_sess, | ||
| 1369 | sess, sess->loop_id); | ||
| 1370 | } | ||
| 1371 | |||
| 1393 | static void tcm_qla2xxx_free_session(struct qla_tgt_sess *sess) | 1372 | static void tcm_qla2xxx_free_session(struct qla_tgt_sess *sess) |
| 1394 | { | 1373 | { |
| 1395 | struct qla_tgt *tgt = sess->tgt; | 1374 | struct qla_tgt *tgt = sess->tgt; |
| @@ -1398,8 +1377,6 @@ static void tcm_qla2xxx_free_session(struct qla_tgt_sess *sess) | |||
| 1398 | struct se_node_acl *se_nacl; | 1377 | struct se_node_acl *se_nacl; |
| 1399 | struct tcm_qla2xxx_lport *lport; | 1378 | struct tcm_qla2xxx_lport *lport; |
| 1400 | struct tcm_qla2xxx_nacl *nacl; | 1379 | struct tcm_qla2xxx_nacl *nacl; |
| 1401 | unsigned char be_sid[3]; | ||
| 1402 | unsigned long flags; | ||
| 1403 | 1380 | ||
| 1404 | BUG_ON(in_interrupt()); | 1381 | BUG_ON(in_interrupt()); |
| 1405 | 1382 | ||
| @@ -1419,21 +1396,6 @@ static void tcm_qla2xxx_free_session(struct qla_tgt_sess *sess) | |||
| 1419 | return; | 1396 | return; |
| 1420 | } | 1397 | } |
| 1421 | target_wait_for_sess_cmds(se_sess, 0); | 1398 | target_wait_for_sess_cmds(se_sess, 0); |
| 1422 | /* | ||
| 1423 | * And now clear the se_nacl and session pointers from our HW lport | ||
| 1424 | * mappings for fabric S_ID and LOOP_ID. | ||
| 1425 | */ | ||
| 1426 | memset(&be_sid, 0, 3); | ||
| 1427 | be_sid[0] = sess->s_id.b.domain; | ||
| 1428 | be_sid[1] = sess->s_id.b.area; | ||
| 1429 | be_sid[2] = sess->s_id.b.al_pa; | ||
| 1430 | |||
| 1431 | spin_lock_irqsave(&ha->hardware_lock, flags); | ||
| 1432 | tcm_qla2xxx_set_sess_by_s_id(lport, NULL, nacl, se_sess, | ||
| 1433 | sess, be_sid); | ||
| 1434 | tcm_qla2xxx_set_sess_by_loop_id(lport, NULL, nacl, se_sess, | ||
| 1435 | sess, sess->loop_id); | ||
| 1436 | spin_unlock_irqrestore(&ha->hardware_lock, flags); | ||
| 1437 | 1399 | ||
| 1438 | transport_deregister_session_configfs(sess->se_sess); | 1400 | transport_deregister_session_configfs(sess->se_sess); |
| 1439 | transport_deregister_session(sess->se_sess); | 1401 | transport_deregister_session(sess->se_sess); |
| @@ -1731,6 +1693,7 @@ static struct target_core_fabric_ops tcm_qla2xxx_ops = { | |||
| 1731 | .new_cmd_map = NULL, | 1693 | .new_cmd_map = NULL, |
| 1732 | .check_stop_free = tcm_qla2xxx_check_stop_free, | 1694 | .check_stop_free = tcm_qla2xxx_check_stop_free, |
| 1733 | .release_cmd = tcm_qla2xxx_release_cmd, | 1695 | .release_cmd = tcm_qla2xxx_release_cmd, |
| 1696 | .put_session = tcm_qla2xxx_put_session, | ||
| 1734 | .shutdown_session = tcm_qla2xxx_shutdown_session, | 1697 | .shutdown_session = tcm_qla2xxx_shutdown_session, |
| 1735 | .close_session = tcm_qla2xxx_close_session, | 1698 | .close_session = tcm_qla2xxx_close_session, |
| 1736 | .sess_get_index = tcm_qla2xxx_sess_get_index, | 1699 | .sess_get_index = tcm_qla2xxx_sess_get_index, |
| @@ -1779,6 +1742,7 @@ static struct target_core_fabric_ops tcm_qla2xxx_npiv_ops = { | |||
| 1779 | .tpg_release_fabric_acl = tcm_qla2xxx_release_fabric_acl, | 1742 | .tpg_release_fabric_acl = tcm_qla2xxx_release_fabric_acl, |
| 1780 | .tpg_get_inst_index = tcm_qla2xxx_tpg_get_inst_index, | 1743 | .tpg_get_inst_index = tcm_qla2xxx_tpg_get_inst_index, |
| 1781 | .release_cmd = tcm_qla2xxx_release_cmd, | 1744 | .release_cmd = tcm_qla2xxx_release_cmd, |
| 1745 | .put_session = tcm_qla2xxx_put_session, | ||
| 1782 | .shutdown_session = tcm_qla2xxx_shutdown_session, | 1746 | .shutdown_session = tcm_qla2xxx_shutdown_session, |
| 1783 | .close_session = tcm_qla2xxx_close_session, | 1747 | .close_session = tcm_qla2xxx_close_session, |
| 1784 | .sess_get_index = tcm_qla2xxx_sess_get_index, | 1748 | .sess_get_index = tcm_qla2xxx_sess_get_index, |
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 61c82a345f82..bbbc9c918d4c 100644 --- a/drivers/scsi/scsi.c +++ b/drivers/scsi/scsi.c | |||
| @@ -90,11 +90,9 @@ unsigned int scsi_logging_level; | |||
| 90 | EXPORT_SYMBOL(scsi_logging_level); | 90 | EXPORT_SYMBOL(scsi_logging_level); |
| 91 | #endif | 91 | #endif |
| 92 | 92 | ||
| 93 | #if IS_ENABLED(CONFIG_PM) || IS_ENABLED(CONFIG_BLK_DEV_SD) | 93 | /* sd, scsi core and power management need to coordinate flushing async actions */ |
| 94 | /* sd and scsi_pm need to coordinate flushing async actions */ | ||
| 95 | LIST_HEAD(scsi_sd_probe_domain); | 94 | LIST_HEAD(scsi_sd_probe_domain); |
| 96 | EXPORT_SYMBOL(scsi_sd_probe_domain); | 95 | EXPORT_SYMBOL(scsi_sd_probe_domain); |
| 97 | #endif | ||
| 98 | 96 | ||
| 99 | /* NB: These are exposed through /proc/scsi/scsi and form part of the ABI. | 97 | /* NB: These are exposed through /proc/scsi/scsi and form part of the ABI. |
| 100 | * You may not alter any existing entry (although adding new ones is | 98 | * You may not alter any existing entry (although adding new ones is |
diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c index e624b836469c..91799973081a 100644 --- a/drivers/target/target_core_alua.c +++ b/drivers/target/target_core_alua.c | |||
| @@ -374,8 +374,9 @@ int target_emulate_set_target_port_groups(struct se_cmd *cmd) | |||
| 374 | 374 | ||
| 375 | out: | 375 | out: |
| 376 | transport_kunmap_data_sg(cmd); | 376 | transport_kunmap_data_sg(cmd); |
| 377 | target_complete_cmd(cmd, GOOD); | 377 | if (!rc) |
| 378 | return 0; | 378 | target_complete_cmd(cmd, GOOD); |
| 379 | return rc; | ||
| 379 | } | 380 | } |
| 380 | 381 | ||
| 381 | static inline int core_alua_state_nonoptimized( | 382 | static inline int core_alua_state_nonoptimized( |
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index b05fdc0c05d3..634d0f31a28c 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c | |||
| @@ -315,7 +315,7 @@ void transport_register_session( | |||
| 315 | } | 315 | } |
| 316 | EXPORT_SYMBOL(transport_register_session); | 316 | EXPORT_SYMBOL(transport_register_session); |
| 317 | 317 | ||
| 318 | static void target_release_session(struct kref *kref) | 318 | void target_release_session(struct kref *kref) |
| 319 | { | 319 | { |
| 320 | struct se_session *se_sess = container_of(kref, | 320 | struct se_session *se_sess = container_of(kref, |
| 321 | struct se_session, sess_kref); | 321 | struct se_session, sess_kref); |
| @@ -332,6 +332,12 @@ EXPORT_SYMBOL(target_get_session); | |||
| 332 | 332 | ||
| 333 | void target_put_session(struct se_session *se_sess) | 333 | void target_put_session(struct se_session *se_sess) |
| 334 | { | 334 | { |
| 335 | struct se_portal_group *tpg = se_sess->se_tpg; | ||
| 336 | |||
| 337 | if (tpg->se_tpg_tfo->put_session != NULL) { | ||
| 338 | tpg->se_tpg_tfo->put_session(se_sess); | ||
| 339 | return; | ||
| 340 | } | ||
| 335 | kref_put(&se_sess->sess_kref, target_release_session); | 341 | kref_put(&se_sess->sess_kref, target_release_session); |
| 336 | } | 342 | } |
| 337 | EXPORT_SYMBOL(target_put_session); | 343 | EXPORT_SYMBOL(target_put_session); |
diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index d3d91dae065c..944eaeb8e0cf 100644 --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c | |||
| @@ -214,24 +214,24 @@ static int xen_hvm_console_init(void) | |||
| 214 | /* already configured */ | 214 | /* already configured */ |
| 215 | if (info->intf != NULL) | 215 | if (info->intf != NULL) |
| 216 | return 0; | 216 | return 0; |
| 217 | 217 | /* | |
| 218 | * If the toolstack (or the hypervisor) hasn't set these values, the | ||
| 219 | * default value is 0. Even though mfn = 0 and evtchn = 0 are | ||
| 220 | * theoretically correct values, in practice they never are and they | ||
| 221 | * mean that a legacy toolstack hasn't initialized the pv console correctly. | ||
| 222 | */ | ||
| 218 | r = hvm_get_parameter(HVM_PARAM_CONSOLE_EVTCHN, &v); | 223 | r = hvm_get_parameter(HVM_PARAM_CONSOLE_EVTCHN, &v); |
| 219 | if (r < 0) { | 224 | if (r < 0 || v == 0) |
| 220 | kfree(info); | 225 | goto err; |
| 221 | return -ENODEV; | ||
| 222 | } | ||
| 223 | info->evtchn = v; | 226 | info->evtchn = v; |
| 224 | hvm_get_parameter(HVM_PARAM_CONSOLE_PFN, &v); | 227 | v = 0; |
| 225 | if (r < 0) { | 228 | r = hvm_get_parameter(HVM_PARAM_CONSOLE_PFN, &v); |
| 226 | kfree(info); | 229 | if (r < 0 || v == 0) |
| 227 | return -ENODEV; | 230 | goto err; |
| 228 | } | ||
| 229 | mfn = v; | 231 | mfn = v; |
| 230 | info->intf = ioremap(mfn << PAGE_SHIFT, PAGE_SIZE); | 232 | info->intf = ioremap(mfn << PAGE_SHIFT, PAGE_SIZE); |
| 231 | if (info->intf == NULL) { | 233 | if (info->intf == NULL) |
| 232 | kfree(info); | 234 | goto err; |
| 233 | return -ENODEV; | ||
| 234 | } | ||
| 235 | info->vtermno = HVC_COOKIE; | 235 | info->vtermno = HVC_COOKIE; |
| 236 | 236 | ||
| 237 | spin_lock(&xencons_lock); | 237 | spin_lock(&xencons_lock); |
| @@ -239,6 +239,9 @@ static int xen_hvm_console_init(void) | |||
| 239 | spin_unlock(&xencons_lock); | 239 | spin_unlock(&xencons_lock); |
| 240 | 240 | ||
| 241 | return 0; | 241 | return 0; |
| 242 | err: | ||
| 243 | kfree(info); | ||
| 244 | return -ENODEV; | ||
| 242 | } | 245 | } |
| 243 | 246 | ||
| 244 | static int xen_pv_console_init(void) | 247 | static int xen_pv_console_init(void) |
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 4604153b7954..1bd9163bc118 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c | |||
| @@ -2179,6 +2179,16 @@ static int __devinit sci_init_single(struct platform_device *dev, | |||
| 2179 | return 0; | 2179 | return 0; |
| 2180 | } | 2180 | } |
| 2181 | 2181 | ||
| 2182 | static void sci_cleanup_single(struct sci_port *port) | ||
| 2183 | { | ||
| 2184 | sci_free_gpios(port); | ||
| 2185 | |||
| 2186 | clk_put(port->iclk); | ||
| 2187 | clk_put(port->fclk); | ||
| 2188 | |||
| 2189 | pm_runtime_disable(port->port.dev); | ||
| 2190 | } | ||
| 2191 | |||
| 2182 | #ifdef CONFIG_SERIAL_SH_SCI_CONSOLE | 2192 | #ifdef CONFIG_SERIAL_SH_SCI_CONSOLE |
| 2183 | static void serial_console_putchar(struct uart_port *port, int ch) | 2193 | static void serial_console_putchar(struct uart_port *port, int ch) |
| 2184 | { | 2194 | { |
| @@ -2360,14 +2370,10 @@ static int sci_remove(struct platform_device *dev) | |||
| 2360 | cpufreq_unregister_notifier(&port->freq_transition, | 2370 | cpufreq_unregister_notifier(&port->freq_transition, |
| 2361 | CPUFREQ_TRANSITION_NOTIFIER); | 2371 | CPUFREQ_TRANSITION_NOTIFIER); |
| 2362 | 2372 | ||
| 2363 | sci_free_gpios(port); | ||
| 2364 | |||
| 2365 | uart_remove_one_port(&sci_uart_driver, &port->port); | 2373 | uart_remove_one_port(&sci_uart_driver, &port->port); |
| 2366 | 2374 | ||
| 2367 | clk_put(port->iclk); | 2375 | sci_cleanup_single(port); |
| 2368 | clk_put(port->fclk); | ||
| 2369 | 2376 | ||
| 2370 | pm_runtime_disable(&dev->dev); | ||
| 2371 | return 0; | 2377 | return 0; |
| 2372 | } | 2378 | } |
| 2373 | 2379 | ||
| @@ -2385,14 +2391,20 @@ static int __devinit sci_probe_single(struct platform_device *dev, | |||
| 2385 | index+1, SCI_NPORTS); | 2391 | index+1, SCI_NPORTS); |
| 2386 | dev_notice(&dev->dev, "Consider bumping " | 2392 | dev_notice(&dev->dev, "Consider bumping " |
| 2387 | "CONFIG_SERIAL_SH_SCI_NR_UARTS!\n"); | 2393 | "CONFIG_SERIAL_SH_SCI_NR_UARTS!\n"); |
| 2388 | return 0; | 2394 | return -EINVAL; |
| 2389 | } | 2395 | } |
| 2390 | 2396 | ||
| 2391 | ret = sci_init_single(dev, sciport, index, p); | 2397 | ret = sci_init_single(dev, sciport, index, p); |
| 2392 | if (ret) | 2398 | if (ret) |
| 2393 | return ret; | 2399 | return ret; |
| 2394 | 2400 | ||
| 2395 | return uart_add_one_port(&sci_uart_driver, &sciport->port); | 2401 | ret = uart_add_one_port(&sci_uart_driver, &sciport->port); |
| 2402 | if (ret) { | ||
| 2403 | sci_cleanup_single(sciport); | ||
| 2404 | return ret; | ||
| 2405 | } | ||
| 2406 | |||
| 2407 | return 0; | ||
| 2396 | } | 2408 | } |
| 2397 | 2409 | ||
| 2398 | static int __devinit sci_probe(struct platform_device *dev) | 2410 | static int __devinit sci_probe(struct platform_device *dev) |
| @@ -2413,24 +2425,22 @@ static int __devinit sci_probe(struct platform_device *dev) | |||
| 2413 | 2425 | ||
| 2414 | ret = sci_probe_single(dev, dev->id, p, sp); | 2426 | ret = sci_probe_single(dev, dev->id, p, sp); |
| 2415 | if (ret) | 2427 | if (ret) |
| 2416 | goto err_unreg; | 2428 | return ret; |
| 2417 | 2429 | ||
| 2418 | sp->freq_transition.notifier_call = sci_notifier; | 2430 | sp->freq_transition.notifier_call = sci_notifier; |
| 2419 | 2431 | ||
| 2420 | ret = cpufreq_register_notifier(&sp->freq_transition, | 2432 | ret = cpufreq_register_notifier(&sp->freq_transition, |
| 2421 | CPUFREQ_TRANSITION_NOTIFIER); | 2433 | CPUFREQ_TRANSITION_NOTIFIER); |
| 2422 | if (unlikely(ret < 0)) | 2434 | if (unlikely(ret < 0)) { |
| 2423 | goto err_unreg; | 2435 | sci_cleanup_single(sp); |
| 2436 | return ret; | ||
| 2437 | } | ||
| 2424 | 2438 | ||
| 2425 | #ifdef CONFIG_SH_STANDARD_BIOS | 2439 | #ifdef CONFIG_SH_STANDARD_BIOS |
| 2426 | sh_bios_gdb_detach(); | 2440 | sh_bios_gdb_detach(); |
| 2427 | #endif | 2441 | #endif |
| 2428 | 2442 | ||
| 2429 | return 0; | 2443 | return 0; |
| 2430 | |||
| 2431 | err_unreg: | ||
| 2432 | sci_remove(dev); | ||
| 2433 | return ret; | ||
| 2434 | } | 2444 | } |
| 2435 | 2445 | ||
| 2436 | static int sci_suspend(struct device *dev) | 2446 | static int sci_suspend(struct device *dev) |
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index f2a120eea9d4..36a2a0b7b82c 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c | |||
| @@ -567,6 +567,14 @@ static int acm_port_activate(struct tty_port *port, struct tty_struct *tty) | |||
| 567 | 567 | ||
| 568 | usb_autopm_put_interface(acm->control); | 568 | usb_autopm_put_interface(acm->control); |
| 569 | 569 | ||
| 570 | /* | ||
| 571 | * Unthrottle device in case the TTY was closed while throttled. | ||
| 572 | */ | ||
| 573 | spin_lock_irq(&acm->read_lock); | ||
| 574 | acm->throttled = 0; | ||
| 575 | acm->throttle_req = 0; | ||
| 576 | spin_unlock_irq(&acm->read_lock); | ||
| 577 | |||
| 570 | if (acm_submit_read_urbs(acm, GFP_KERNEL)) | 578 | if (acm_submit_read_urbs(acm, GFP_KERNEL)) |
| 571 | goto error_submit_read_urbs; | 579 | goto error_submit_read_urbs; |
| 572 | 580 | ||
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 04fb834c3fa1..25a7422ee657 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c | |||
| @@ -3379,7 +3379,7 @@ int usb_disable_lpm(struct usb_device *udev) | |||
| 3379 | return 0; | 3379 | return 0; |
| 3380 | 3380 | ||
| 3381 | udev->lpm_disable_count++; | 3381 | udev->lpm_disable_count++; |
| 3382 | if ((udev->u1_params.timeout == 0 && udev->u1_params.timeout == 0)) | 3382 | if ((udev->u1_params.timeout == 0 && udev->u2_params.timeout == 0)) |
| 3383 | return 0; | 3383 | return 0; |
| 3384 | 3384 | ||
| 3385 | /* If LPM is enabled, attempt to disable it. */ | 3385 | /* If LPM is enabled, attempt to disable it. */ |
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index ca7fc392fd9e..8b9d669e3784 100644 --- a/drivers/usb/core/message.c +++ b/drivers/usb/core/message.c | |||
| @@ -1839,7 +1839,6 @@ free_interfaces: | |||
| 1839 | intfc = cp->intf_cache[i]; | 1839 | intfc = cp->intf_cache[i]; |
| 1840 | intf->altsetting = intfc->altsetting; | 1840 | intf->altsetting = intfc->altsetting; |
| 1841 | intf->num_altsetting = intfc->num_altsetting; | 1841 | intf->num_altsetting = intfc->num_altsetting; |
| 1842 | intf->intf_assoc = find_iad(dev, cp, i); | ||
| 1843 | kref_get(&intfc->ref); | 1842 | kref_get(&intfc->ref); |
| 1844 | 1843 | ||
| 1845 | alt = usb_altnum_to_altsetting(intf, 0); | 1844 | alt = usb_altnum_to_altsetting(intf, 0); |
| @@ -1852,6 +1851,8 @@ free_interfaces: | |||
| 1852 | if (!alt) | 1851 | if (!alt) |
| 1853 | alt = &intf->altsetting[0]; | 1852 | alt = &intf->altsetting[0]; |
| 1854 | 1853 | ||
| 1854 | intf->intf_assoc = | ||
| 1855 | find_iad(dev, cp, alt->desc.bInterfaceNumber); | ||
| 1855 | intf->cur_altsetting = alt; | 1856 | intf->cur_altsetting = alt; |
| 1856 | usb_enable_interface(dev, intf, true); | 1857 | usb_enable_interface(dev, intf, true); |
| 1857 | intf->dev.parent = &dev->dev; | 1858 | intf->dev.parent = &dev->dev; |
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index b100f5f9f4b6..800be38c78b4 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c | |||
| @@ -671,7 +671,9 @@ static int ehci_init(struct usb_hcd *hcd) | |||
| 671 | hw = ehci->async->hw; | 671 | hw = ehci->async->hw; |
| 672 | hw->hw_next = QH_NEXT(ehci, ehci->async->qh_dma); | 672 | hw->hw_next = QH_NEXT(ehci, ehci->async->qh_dma); |
| 673 | hw->hw_info1 = cpu_to_hc32(ehci, QH_HEAD); | 673 | hw->hw_info1 = cpu_to_hc32(ehci, QH_HEAD); |
| 674 | #if defined(CONFIG_PPC_PS3) | ||
| 674 | hw->hw_info1 |= cpu_to_hc32(ehci, (1 << 7)); /* I = 1 */ | 675 | hw->hw_info1 |= cpu_to_hc32(ehci, (1 << 7)); /* I = 1 */ |
| 676 | #endif | ||
| 675 | hw->hw_token = cpu_to_hc32(ehci, QTD_STS_HALT); | 677 | hw->hw_token = cpu_to_hc32(ehci, QTD_STS_HALT); |
| 676 | hw->hw_qtd_next = EHCI_LIST_END(ehci); | 678 | hw->hw_qtd_next = EHCI_LIST_END(ehci); |
| 677 | ehci->async->qh_state = QH_STATE_LINKED; | 679 | ehci->async->qh_state = QH_STATE_LINKED; |
diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index a44294d13494..17cfb8a1131c 100644 --- a/drivers/usb/host/ehci-omap.c +++ b/drivers/usb/host/ehci-omap.c | |||
| @@ -43,6 +43,7 @@ | |||
| 43 | #include <linux/regulator/consumer.h> | 43 | #include <linux/regulator/consumer.h> |
| 44 | #include <linux/pm_runtime.h> | 44 | #include <linux/pm_runtime.h> |
| 45 | #include <linux/gpio.h> | 45 | #include <linux/gpio.h> |
| 46 | #include <linux/clk.h> | ||
| 46 | 47 | ||
| 47 | /* EHCI Register Set */ | 48 | /* EHCI Register Set */ |
| 48 | #define EHCI_INSNREG04 (0xA0) | 49 | #define EHCI_INSNREG04 (0xA0) |
| @@ -55,6 +56,15 @@ | |||
| 55 | #define EHCI_INSNREG05_ULPI_EXTREGADD_SHIFT 8 | 56 | #define EHCI_INSNREG05_ULPI_EXTREGADD_SHIFT 8 |
| 56 | #define EHCI_INSNREG05_ULPI_WRDATA_SHIFT 0 | 57 | #define EHCI_INSNREG05_ULPI_WRDATA_SHIFT 0 |
| 57 | 58 | ||
| 59 | /* Errata i693 */ | ||
| 60 | static struct clk *utmi_p1_fck; | ||
| 61 | static struct clk *utmi_p2_fck; | ||
| 62 | static struct clk *xclk60mhsp1_ck; | ||
| 63 | static struct clk *xclk60mhsp2_ck; | ||
| 64 | static struct clk *usbhost_p1_fck; | ||
| 65 | static struct clk *usbhost_p2_fck; | ||
| 66 | static struct clk *init_60m_fclk; | ||
| 67 | |||
| 58 | /*-------------------------------------------------------------------------*/ | 68 | /*-------------------------------------------------------------------------*/ |
| 59 | 69 | ||
| 60 | static const struct hc_driver ehci_omap_hc_driver; | 70 | static const struct hc_driver ehci_omap_hc_driver; |
| @@ -70,6 +80,41 @@ static inline u32 ehci_read(void __iomem *base, u32 reg) | |||
| 70 | return __raw_readl(base + reg); | 80 | return __raw_readl(base + reg); |
| 71 | } | 81 | } |
| 72 | 82 | ||
| 83 | /* Erratum i693 workaround sequence */ | ||
| 84 | static void omap_ehci_erratum_i693(struct ehci_hcd *ehci) | ||
| 85 | { | ||
| 86 | int ret = 0; | ||
| 87 | |||
| 88 | /* Switch to the internal 60 MHz clock */ | ||
| 89 | ret = clk_set_parent(utmi_p1_fck, init_60m_fclk); | ||
| 90 | if (ret != 0) | ||
| 91 | ehci_err(ehci, "init_60m_fclk set parent" | ||
| 92 | "failed error:%d\n", ret); | ||
| 93 | |||
| 94 | ret = clk_set_parent(utmi_p2_fck, init_60m_fclk); | ||
| 95 | if (ret != 0) | ||
| 96 | ehci_err(ehci, "init_60m_fclk set parent" | ||
| 97 | "failed error:%d\n", ret); | ||
| 98 | |||
| 99 | clk_enable(usbhost_p1_fck); | ||
| 100 | clk_enable(usbhost_p2_fck); | ||
| 101 | |||
| 102 | /* Wait 1ms and switch back to the external clock */ | ||
| 103 | mdelay(1); | ||
| 104 | ret = clk_set_parent(utmi_p1_fck, xclk60mhsp1_ck); | ||
| 105 | if (ret != 0) | ||
| 106 | ehci_err(ehci, "xclk60mhsp1_ck set parent" | ||
| 107 | "failed error:%d\n", ret); | ||
| 108 | |||
| 109 | ret = clk_set_parent(utmi_p2_fck, xclk60mhsp2_ck); | ||
| 110 | if (ret != 0) | ||
| 111 | ehci_err(ehci, "xclk60mhsp2_ck set parent" | ||
| 112 | "failed error:%d\n", ret); | ||
| 113 | |||
| 114 | clk_disable(usbhost_p1_fck); | ||
| 115 | clk_disable(usbhost_p2_fck); | ||
| 116 | } | ||
| 117 | |||
| 73 | static void omap_ehci_soft_phy_reset(struct platform_device *pdev, u8 port) | 118 | static void omap_ehci_soft_phy_reset(struct platform_device *pdev, u8 port) |
| 74 | { | 119 | { |
| 75 | struct usb_hcd *hcd = dev_get_drvdata(&pdev->dev); | 120 | struct usb_hcd *hcd = dev_get_drvdata(&pdev->dev); |
| @@ -100,6 +145,50 @@ static void omap_ehci_soft_phy_reset(struct platform_device *pdev, u8 port) | |||
| 100 | } | 145 | } |
| 101 | } | 146 | } |
| 102 | 147 | ||
| 148 | static int omap_ehci_hub_control( | ||
| 149 | struct usb_hcd *hcd, | ||
| 150 | u16 typeReq, | ||
| 151 | u16 wValue, | ||
| 152 | u16 wIndex, | ||
| 153 | char *buf, | ||
| 154 | u16 wLength | ||
| 155 | ) | ||
| 156 | { | ||
| 157 | struct ehci_hcd *ehci = hcd_to_ehci(hcd); | ||
| 158 | u32 __iomem *status_reg = &ehci->regs->port_status[ | ||
| 159 | (wIndex & 0xff) - 1]; | ||
| 160 | u32 temp; | ||
| 161 | unsigned long flags; | ||
| 162 | int retval = 0; | ||
| 163 | |||
| 164 | spin_lock_irqsave(&ehci->lock, flags); | ||
| 165 | |||
| 166 | if (typeReq == SetPortFeature && wValue == USB_PORT_FEAT_SUSPEND) { | ||
| 167 | temp = ehci_readl(ehci, status_reg); | ||
| 168 | if ((temp & PORT_PE) == 0 || (temp & PORT_RESET) != 0) { | ||
| 169 | retval = -EPIPE; | ||
| 170 | goto done; | ||
| 171 | } | ||
| 172 | |||
| 173 | temp &= ~PORT_WKCONN_E; | ||
| 174 | temp |= PORT_WKDISC_E | PORT_WKOC_E; | ||
| 175 | ehci_writel(ehci, temp | PORT_SUSPEND, status_reg); | ||
| 176 | |||
| 177 | omap_ehci_erratum_i693(ehci); | ||
| 178 | |||
| 179 | set_bit((wIndex & 0xff) - 1, &ehci->suspended_ports); | ||
| 180 | goto done; | ||
| 181 | } | ||
| 182 | |||
| 183 | spin_unlock_irqrestore(&ehci->lock, flags); | ||
| 184 | |||
| 185 | /* Handle the hub control events here */ | ||
| 186 | return ehci_hub_control(hcd, typeReq, wValue, wIndex, buf, wLength); | ||
| 187 | done: | ||
| 188 | spin_unlock_irqrestore(&ehci->lock, flags); | ||
| 189 | return retval; | ||
| 190 | } | ||
| 191 | |||
| 103 | static void disable_put_regulator( | 192 | static void disable_put_regulator( |
| 104 | struct ehci_hcd_omap_platform_data *pdata) | 193 | struct ehci_hcd_omap_platform_data *pdata) |
| 105 | { | 194 | { |
| @@ -264,8 +353,76 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) | |||
| 264 | /* root ports should always stay powered */ | 353 | /* root ports should always stay powered */ |
| 265 | ehci_port_power(omap_ehci, 1); | 354 | ehci_port_power(omap_ehci, 1); |
| 266 | 355 | ||
| 356 | /* get clocks */ | ||
| 357 | utmi_p1_fck = clk_get(dev, "utmi_p1_gfclk"); | ||
| 358 | if (IS_ERR(utmi_p1_fck)) { | ||
| 359 | ret = PTR_ERR(utmi_p1_fck); | ||
| 360 | dev_err(dev, "utmi_p1_gfclk failed error:%d\n", ret); | ||
| 361 | goto err_add_hcd; | ||
| 362 | } | ||
| 363 | |||
| 364 | xclk60mhsp1_ck = clk_get(dev, "xclk60mhsp1_ck"); | ||
| 365 | if (IS_ERR(xclk60mhsp1_ck)) { | ||
| 366 | ret = PTR_ERR(xclk60mhsp1_ck); | ||
| 367 | dev_err(dev, "xclk60mhsp1_ck failed error:%d\n", ret); | ||
| 368 | goto err_utmi_p1_fck; | ||
| 369 | } | ||
| 370 | |||
| 371 | utmi_p2_fck = clk_get(dev, "utmi_p2_gfclk"); | ||
| 372 | if (IS_ERR(utmi_p2_fck)) { | ||
| 373 | ret = PTR_ERR(utmi_p2_fck); | ||
| 374 | dev_err(dev, "utmi_p2_gfclk failed error:%d\n", ret); | ||
| 375 | goto err_xclk60mhsp1_ck; | ||
| 376 | } | ||
| 377 | |||
| 378 | xclk60mhsp2_ck = clk_get(dev, "xclk60mhsp2_ck"); | ||
| 379 | if (IS_ERR(xclk60mhsp2_ck)) { | ||
| 380 | ret = PTR_ERR(xclk60mhsp2_ck); | ||
| 381 | dev_err(dev, "xclk60mhsp2_ck failed error:%d\n", ret); | ||
| 382 | goto err_utmi_p2_fck; | ||
| 383 | } | ||
| 384 | |||
| 385 | usbhost_p1_fck = clk_get(dev, "usb_host_hs_utmi_p1_clk"); | ||
| 386 | if (IS_ERR(usbhost_p1_fck)) { | ||
| 387 | ret = PTR_ERR(usbhost_p1_fck); | ||
| 388 | dev_err(dev, "usbhost_p1_fck failed error:%d\n", ret); | ||
| 389 | goto err_xclk60mhsp2_ck; | ||
| 390 | } | ||
| 391 | |||
| 392 | usbhost_p2_fck = clk_get(dev, "usb_host_hs_utmi_p2_clk"); | ||
| 393 | if (IS_ERR(usbhost_p2_fck)) { | ||
| 394 | ret = PTR_ERR(usbhost_p2_fck); | ||
| 395 | dev_err(dev, "usbhost_p2_fck failed error:%d\n", ret); | ||
| 396 | goto err_usbhost_p1_fck; | ||
| 397 | } | ||
| 398 | |||
| 399 | init_60m_fclk = clk_get(dev, "init_60m_fclk"); | ||
| 400 | if (IS_ERR(init_60m_fclk)) { | ||
| 401 | ret = PTR_ERR(init_60m_fclk); | ||
| 402 | dev_err(dev, "init_60m_fclk failed error:%d\n", ret); | ||
| 403 | goto err_usbhost_p2_fck; | ||
| 404 | } | ||
| 405 | |||
| 267 | return 0; | 406 | return 0; |
| 268 | 407 | ||
| 408 | err_usbhost_p2_fck: | ||
| 409 | clk_put(usbhost_p2_fck); | ||
| 410 | |||
| 411 | err_usbhost_p1_fck: | ||
| 412 | clk_put(usbhost_p1_fck); | ||
| 413 | |||
| 414 | err_xclk60mhsp2_ck: | ||
| 415 | clk_put(xclk60mhsp2_ck); | ||
| 416 | |||
| 417 | err_utmi_p2_fck: | ||
| 418 | clk_put(utmi_p2_fck); | ||
| 419 | |||
| 420 | err_xclk60mhsp1_ck: | ||
| 421 | clk_put(xclk60mhsp1_ck); | ||
| 422 | |||
| 423 | err_utmi_p1_fck: | ||
| 424 | clk_put(utmi_p1_fck); | ||
| 425 | |||
| 269 | err_add_hcd: | 426 | err_add_hcd: |
| 270 | disable_put_regulator(pdata); | 427 | disable_put_regulator(pdata); |
| 271 | pm_runtime_put_sync(dev); | 428 | pm_runtime_put_sync(dev); |
| @@ -294,6 +451,15 @@ static int ehci_hcd_omap_remove(struct platform_device *pdev) | |||
| 294 | disable_put_regulator(dev->platform_data); | 451 | disable_put_regulator(dev->platform_data); |
| 295 | iounmap(hcd->regs); | 452 | iounmap(hcd->regs); |
| 296 | usb_put_hcd(hcd); | 453 | usb_put_hcd(hcd); |
| 454 | |||
| 455 | clk_put(utmi_p1_fck); | ||
| 456 | clk_put(utmi_p2_fck); | ||
| 457 | clk_put(xclk60mhsp1_ck); | ||
| 458 | clk_put(xclk60mhsp2_ck); | ||
| 459 | clk_put(usbhost_p1_fck); | ||
| 460 | clk_put(usbhost_p2_fck); | ||
| 461 | clk_put(init_60m_fclk); | ||
| 462 | |||
| 297 | pm_runtime_put_sync(dev); | 463 | pm_runtime_put_sync(dev); |
| 298 | pm_runtime_disable(dev); | 464 | pm_runtime_disable(dev); |
| 299 | 465 | ||
| @@ -364,7 +530,7 @@ static const struct hc_driver ehci_omap_hc_driver = { | |||
| 364 | * root hub support | 530 | * root hub support |
| 365 | */ | 531 | */ |
| 366 | .hub_status_data = ehci_hub_status_data, | 532 | .hub_status_data = ehci_hub_status_data, |
| 367 | .hub_control = ehci_hub_control, | 533 | .hub_control = omap_ehci_hub_control, |
| 368 | .bus_suspend = ehci_bus_suspend, | 534 | .bus_suspend = ehci_bus_suspend, |
| 369 | .bus_resume = ehci_bus_resume, | 535 | .bus_resume = ehci_bus_resume, |
| 370 | 536 | ||
diff --git a/drivers/usb/host/ehci-sh.c b/drivers/usb/host/ehci-sh.c index ca819cdd0c5e..e7cb3925abf8 100644 --- a/drivers/usb/host/ehci-sh.c +++ b/drivers/usb/host/ehci-sh.c | |||
| @@ -126,8 +126,7 @@ static int ehci_hcd_sh_probe(struct platform_device *pdev) | |||
| 126 | goto fail_create_hcd; | 126 | goto fail_create_hcd; |
| 127 | } | 127 | } |
| 128 | 128 | ||
| 129 | if (pdev->dev.platform_data != NULL) | 129 | pdata = pdev->dev.platform_data; |
| 130 | pdata = pdev->dev.platform_data; | ||
| 131 | 130 | ||
| 132 | /* initialize hcd */ | 131 | /* initialize hcd */ |
| 133 | hcd = usb_create_hcd(&ehci_sh_hc_driver, &pdev->dev, | 132 | hcd = usb_create_hcd(&ehci_sh_hc_driver, &pdev->dev, |
diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c index 9c2cc4633894..e9713d589e30 100644 --- a/drivers/usb/host/ehci-xilinx-of.c +++ b/drivers/usb/host/ehci-xilinx-of.c | |||
| @@ -270,14 +270,12 @@ static int ehci_hcd_xilinx_of_remove(struct platform_device *op) | |||
| 270 | * | 270 | * |
| 271 | * Properly shutdown the hcd, call driver's shutdown routine. | 271 | * Properly shutdown the hcd, call driver's shutdown routine. |
| 272 | */ | 272 | */ |
| 273 | static int ehci_hcd_xilinx_of_shutdown(struct platform_device *op) | 273 | static void ehci_hcd_xilinx_of_shutdown(struct platform_device *op) |
| 274 | { | 274 | { |
| 275 | struct usb_hcd *hcd = dev_get_drvdata(&op->dev); | 275 | struct usb_hcd *hcd = dev_get_drvdata(&op->dev); |
| 276 | 276 | ||
| 277 | if (hcd->driver->shutdown) | 277 | if (hcd->driver->shutdown) |
| 278 | hcd->driver->shutdown(hcd); | 278 | hcd->driver->shutdown(hcd); |
| 279 | |||
| 280 | return 0; | ||
| 281 | } | 279 | } |
| 282 | 280 | ||
| 283 | 281 | ||
diff --git a/drivers/usb/host/ohci-hub.c b/drivers/usb/host/ohci-hub.c index 836772dfabd3..2f3619eefefa 100644 --- a/drivers/usb/host/ohci-hub.c +++ b/drivers/usb/host/ohci-hub.c | |||
| @@ -317,7 +317,7 @@ static int ohci_bus_resume (struct usb_hcd *hcd) | |||
| 317 | } | 317 | } |
| 318 | 318 | ||
| 319 | /* Carry out the final steps of resuming the controller device */ | 319 | /* Carry out the final steps of resuming the controller device */ |
| 320 | static void ohci_finish_controller_resume(struct usb_hcd *hcd) | 320 | static void __maybe_unused ohci_finish_controller_resume(struct usb_hcd *hcd) |
| 321 | { | 321 | { |
| 322 | struct ohci_hcd *ohci = hcd_to_ohci(hcd); | 322 | struct ohci_hcd *ohci = hcd_to_ohci(hcd); |
| 323 | int port; | 323 | int port; |
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index ec4338eec826..77689bd64cac 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c | |||
| @@ -793,10 +793,9 @@ static void xhci_free_tt_info(struct xhci_hcd *xhci, | |||
| 793 | struct xhci_virt_device *virt_dev, | 793 | struct xhci_virt_device *virt_dev, |
| 794 | int slot_id) | 794 | int slot_id) |
| 795 | { | 795 | { |
| 796 | struct list_head *tt; | ||
| 797 | struct list_head *tt_list_head; | 796 | struct list_head *tt_list_head; |
| 798 | struct list_head *tt_next; | 797 | struct xhci_tt_bw_info *tt_info, *next; |
| 799 | struct xhci_tt_bw_info *tt_info; | 798 | bool slot_found = false; |
| 800 | 799 | ||
| 801 | /* If the device never made it past the Set Address stage, | 800 | /* If the device never made it past the Set Address stage, |
| 802 | * it may not have the real_port set correctly. | 801 | * it may not have the real_port set correctly. |
| @@ -808,34 +807,16 @@ static void xhci_free_tt_info(struct xhci_hcd *xhci, | |||
| 808 | } | 807 | } |
| 809 | 808 | ||
| 810 | tt_list_head = &(xhci->rh_bw[virt_dev->real_port - 1].tts); | 809 | tt_list_head = &(xhci->rh_bw[virt_dev->real_port - 1].tts); |
| 811 | if (list_empty(tt_list_head)) | 810 | list_for_each_entry_safe(tt_info, next, tt_list_head, tt_list) { |
| 812 | return; | 811 | /* Multi-TT hubs will have more than one entry */ |
| 813 | 812 | if (tt_info->slot_id == slot_id) { | |
| 814 | list_for_each(tt, tt_list_head) { | 813 | slot_found = true; |
| 815 | tt_info = list_entry(tt, struct xhci_tt_bw_info, tt_list); | 814 | list_del(&tt_info->tt_list); |
| 816 | if (tt_info->slot_id == slot_id) | 815 | kfree(tt_info); |
| 816 | } else if (slot_found) { | ||
| 817 | break; | 817 | break; |
| 818 | } | ||
| 818 | } | 819 | } |
| 819 | /* Cautionary measure in case the hub was disconnected before we | ||
| 820 | * stored the TT information. | ||
| 821 | */ | ||
| 822 | if (tt_info->slot_id != slot_id) | ||
| 823 | return; | ||
| 824 | |||
| 825 | tt_next = tt->next; | ||
| 826 | tt_info = list_entry(tt, struct xhci_tt_bw_info, | ||
| 827 | tt_list); | ||
| 828 | /* Multi-TT hubs will have more than one entry */ | ||
| 829 | do { | ||
| 830 | list_del(tt); | ||
| 831 | kfree(tt_info); | ||
| 832 | tt = tt_next; | ||
| 833 | if (list_empty(tt_list_head)) | ||
| 834 | break; | ||
| 835 | tt_next = tt->next; | ||
| 836 | tt_info = list_entry(tt, struct xhci_tt_bw_info, | ||
| 837 | tt_list); | ||
| 838 | } while (tt_info->slot_id == slot_id); | ||
| 839 | } | 820 | } |
| 840 | 821 | ||
| 841 | int xhci_alloc_tt_info(struct xhci_hcd *xhci, | 822 | int xhci_alloc_tt_info(struct xhci_hcd *xhci, |
| @@ -1791,17 +1772,9 @@ void xhci_mem_cleanup(struct xhci_hcd *xhci) | |||
| 1791 | { | 1772 | { |
| 1792 | struct pci_dev *pdev = to_pci_dev(xhci_to_hcd(xhci)->self.controller); | 1773 | struct pci_dev *pdev = to_pci_dev(xhci_to_hcd(xhci)->self.controller); |
| 1793 | struct dev_info *dev_info, *next; | 1774 | struct dev_info *dev_info, *next; |
| 1794 | struct list_head *tt_list_head; | ||
| 1795 | struct list_head *tt; | ||
| 1796 | struct list_head *endpoints; | ||
| 1797 | struct list_head *ep, *q; | ||
| 1798 | struct xhci_tt_bw_info *tt_info; | ||
| 1799 | struct xhci_interval_bw_table *bwt; | ||
| 1800 | struct xhci_virt_ep *virt_ep; | ||
| 1801 | |||
| 1802 | unsigned long flags; | 1775 | unsigned long flags; |
| 1803 | int size; | 1776 | int size; |
| 1804 | int i; | 1777 | int i, j, num_ports; |
| 1805 | 1778 | ||
| 1806 | /* Free the Event Ring Segment Table and the actual Event Ring */ | 1779 | /* Free the Event Ring Segment Table and the actual Event Ring */ |
| 1807 | size = sizeof(struct xhci_erst_entry)*(xhci->erst.num_entries); | 1780 | size = sizeof(struct xhci_erst_entry)*(xhci->erst.num_entries); |
| @@ -1860,21 +1833,22 @@ void xhci_mem_cleanup(struct xhci_hcd *xhci) | |||
| 1860 | } | 1833 | } |
| 1861 | spin_unlock_irqrestore(&xhci->lock, flags); | 1834 | spin_unlock_irqrestore(&xhci->lock, flags); |
| 1862 | 1835 | ||
| 1863 | bwt = &xhci->rh_bw->bw_table; | 1836 | num_ports = HCS_MAX_PORTS(xhci->hcs_params1); |
| 1864 | for (i = 0; i < XHCI_MAX_INTERVAL; i++) { | 1837 | for (i = 0; i < num_ports; i++) { |
| 1865 | endpoints = &bwt->interval_bw[i].endpoints; | 1838 | struct xhci_interval_bw_table *bwt = &xhci->rh_bw[i].bw_table; |
| 1866 | list_for_each_safe(ep, q, endpoints) { | 1839 | for (j = 0; j < XHCI_MAX_INTERVAL; j++) { |
| 1867 | virt_ep = list_entry(ep, struct xhci_virt_ep, bw_endpoint_list); | 1840 | struct list_head *ep = &bwt->interval_bw[j].endpoints; |
| 1868 | list_del(&virt_ep->bw_endpoint_list); | 1841 | while (!list_empty(ep)) |
| 1869 | kfree(virt_ep); | 1842 | list_del_init(ep->next); |
| 1870 | } | 1843 | } |
| 1871 | } | 1844 | } |
| 1872 | 1845 | ||
| 1873 | tt_list_head = &xhci->rh_bw->tts; | 1846 | for (i = 0; i < num_ports; i++) { |
| 1874 | list_for_each_safe(tt, q, tt_list_head) { | 1847 | struct xhci_tt_bw_info *tt, *n; |
| 1875 | tt_info = list_entry(tt, struct xhci_tt_bw_info, tt_list); | 1848 | list_for_each_entry_safe(tt, n, &xhci->rh_bw[i].tts, tt_list) { |
| 1876 | list_del(tt); | 1849 | list_del(&tt->tt_list); |
| 1877 | kfree(tt_info); | 1850 | kfree(tt); |
| 1851 | } | ||
| 1878 | } | 1852 | } |
| 1879 | 1853 | ||
| 1880 | xhci->num_usb2_ports = 0; | 1854 | xhci->num_usb2_ports = 0; |
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index afdc73ee84a6..a979cd0dbe0f 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c | |||
| @@ -795,8 +795,8 @@ int xhci_suspend(struct xhci_hcd *xhci) | |||
| 795 | command = xhci_readl(xhci, &xhci->op_regs->command); | 795 | command = xhci_readl(xhci, &xhci->op_regs->command); |
| 796 | command |= CMD_CSS; | 796 | command |= CMD_CSS; |
| 797 | xhci_writel(xhci, command, &xhci->op_regs->command); | 797 | xhci_writel(xhci, command, &xhci->op_regs->command); |
| 798 | if (handshake(xhci, &xhci->op_regs->status, STS_SAVE, 0, 10*100)) { | 798 | if (handshake(xhci, &xhci->op_regs->status, STS_SAVE, 0, 10 * 1000)) { |
| 799 | xhci_warn(xhci, "WARN: xHC CMD_CSS timeout\n"); | 799 | xhci_warn(xhci, "WARN: xHC save state timeout\n"); |
| 800 | spin_unlock_irq(&xhci->lock); | 800 | spin_unlock_irq(&xhci->lock); |
| 801 | return -ETIMEDOUT; | 801 | return -ETIMEDOUT; |
| 802 | } | 802 | } |
| @@ -848,8 +848,8 @@ int xhci_resume(struct xhci_hcd *xhci, bool hibernated) | |||
| 848 | command |= CMD_CRS; | 848 | command |= CMD_CRS; |
| 849 | xhci_writel(xhci, command, &xhci->op_regs->command); | 849 | xhci_writel(xhci, command, &xhci->op_regs->command); |
| 850 | if (handshake(xhci, &xhci->op_regs->status, | 850 | if (handshake(xhci, &xhci->op_regs->status, |
| 851 | STS_RESTORE, 0, 10*100)) { | 851 | STS_RESTORE, 0, 10 * 1000)) { |
| 852 | xhci_dbg(xhci, "WARN: xHC CMD_CSS timeout\n"); | 852 | xhci_warn(xhci, "WARN: xHC restore state timeout\n"); |
| 853 | spin_unlock_irq(&xhci->lock); | 853 | spin_unlock_irq(&xhci->lock); |
| 854 | return -ETIMEDOUT; | 854 | return -ETIMEDOUT; |
| 855 | } | 855 | } |
| @@ -3906,7 +3906,7 @@ static u16 xhci_get_timeout_no_hub_lpm(struct usb_device *udev, | |||
| 3906 | default: | 3906 | default: |
| 3907 | dev_warn(&udev->dev, "%s: Can't get timeout for non-U1 or U2 state.\n", | 3907 | dev_warn(&udev->dev, "%s: Can't get timeout for non-U1 or U2 state.\n", |
| 3908 | __func__); | 3908 | __func__); |
| 3909 | return -EINVAL; | 3909 | return USB3_LPM_DISABLED; |
| 3910 | } | 3910 | } |
| 3911 | 3911 | ||
| 3912 | if (sel <= max_sel_pel && pel <= max_sel_pel) | 3912 | if (sel <= max_sel_pel && pel <= max_sel_pel) |
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index 6e8c527e07c9..27483f91a4a3 100644 --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c | |||
| @@ -757,7 +757,7 @@ static int usb_serial_probe(struct usb_interface *interface, | |||
| 757 | 757 | ||
| 758 | if (retval) { | 758 | if (retval) { |
| 759 | dbg("sub driver rejected device"); | 759 | dbg("sub driver rejected device"); |
| 760 | kfree(serial); | 760 | usb_serial_put(serial); |
| 761 | module_put(type->driver.owner); | 761 | module_put(type->driver.owner); |
| 762 | return retval; | 762 | return retval; |
| 763 | } | 763 | } |
| @@ -829,7 +829,7 @@ static int usb_serial_probe(struct usb_interface *interface, | |||
| 829 | */ | 829 | */ |
| 830 | if (num_bulk_in == 0 || num_bulk_out == 0) { | 830 | if (num_bulk_in == 0 || num_bulk_out == 0) { |
| 831 | dev_info(&interface->dev, "PL-2303 hack: descriptors matched but endpoints did not\n"); | 831 | dev_info(&interface->dev, "PL-2303 hack: descriptors matched but endpoints did not\n"); |
| 832 | kfree(serial); | 832 | usb_serial_put(serial); |
| 833 | module_put(type->driver.owner); | 833 | module_put(type->driver.owner); |
| 834 | return -ENODEV; | 834 | return -ENODEV; |
| 835 | } | 835 | } |
| @@ -843,7 +843,7 @@ static int usb_serial_probe(struct usb_interface *interface, | |||
| 843 | if (num_ports == 0) { | 843 | if (num_ports == 0) { |
| 844 | dev_err(&interface->dev, | 844 | dev_err(&interface->dev, |
| 845 | "Generic device with no bulk out, not allowed.\n"); | 845 | "Generic device with no bulk out, not allowed.\n"); |
| 846 | kfree(serial); | 846 | usb_serial_put(serial); |
| 847 | module_put(type->driver.owner); | 847 | module_put(type->driver.owner); |
| 848 | return -EIO; | 848 | return -EIO; |
| 849 | } | 849 | } |
diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h index 1719886bb9be..caf22bf5f822 100644 --- a/drivers/usb/storage/unusual_devs.h +++ b/drivers/usb/storage/unusual_devs.h | |||
| @@ -1107,6 +1107,13 @@ UNUSUAL_DEV( 0x090a, 0x1200, 0x0000, 0x9999, | |||
| 1107 | USB_SC_RBC, USB_PR_BULK, NULL, | 1107 | USB_SC_RBC, USB_PR_BULK, NULL, |
| 1108 | 0 ), | 1108 | 0 ), |
| 1109 | 1109 | ||
| 1110 | /* Feiya QDI U2 DISK, reported by Hans de Goede <hdegoede@redhat.com> */ | ||
| 1111 | UNUSUAL_DEV( 0x090c, 0x1000, 0x0000, 0xffff, | ||
| 1112 | "Feiya", | ||
| 1113 | "QDI U2 DISK", | ||
| 1114 | USB_SC_DEVICE, USB_PR_DEVICE, NULL, | ||
| 1115 | US_FL_NO_READ_CAPACITY_16 ), | ||
| 1116 | |||
| 1110 | /* aeb */ | 1117 | /* aeb */ |
| 1111 | UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff, | 1118 | UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff, |
| 1112 | "Feiya", | 1119 | "Feiya", |
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index fa2b03750316..2979292650d6 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig | |||
| @@ -88,7 +88,7 @@ config LCD_PLATFORM | |||
| 88 | 88 | ||
| 89 | config LCD_TOSA | 89 | config LCD_TOSA |
| 90 | tristate "Sharp SL-6000 LCD Driver" | 90 | tristate "Sharp SL-6000 LCD Driver" |
| 91 | depends on SPI && MACH_TOSA | 91 | depends on I2C && SPI && MACH_TOSA |
| 92 | help | 92 | help |
| 93 | If you have an Sharp SL-6000 Zaurus say Y to enable a driver | 93 | If you have an Sharp SL-6000 Zaurus say Y to enable a driver |
| 94 | for its LCD. | 94 | for its LCD. |
diff --git a/drivers/video/backlight/ili9320.c b/drivers/video/backlight/ili9320.c index 6c9399341bcf..9327cd1b3143 100644 --- a/drivers/video/backlight/ili9320.c +++ b/drivers/video/backlight/ili9320.c | |||
| @@ -263,7 +263,7 @@ int __devinit ili9320_probe_spi(struct spi_device *spi, | |||
| 263 | 263 | ||
| 264 | EXPORT_SYMBOL_GPL(ili9320_probe_spi); | 264 | EXPORT_SYMBOL_GPL(ili9320_probe_spi); |
| 265 | 265 | ||
| 266 | int __devexit ili9320_remove(struct ili9320 *ili) | 266 | int ili9320_remove(struct ili9320 *ili) |
| 267 | { | 267 | { |
| 268 | ili9320_power(ili, FB_BLANK_POWERDOWN); | 268 | ili9320_power(ili, FB_BLANK_POWERDOWN); |
| 269 | 269 | ||
diff --git a/drivers/video/bfin_adv7393fb.c b/drivers/video/bfin_adv7393fb.c index 33ea874c87d2..9bdd4b0c18c8 100644 --- a/drivers/video/bfin_adv7393fb.c +++ b/drivers/video/bfin_adv7393fb.c | |||
| @@ -353,18 +353,16 @@ adv7393_read_proc(char *page, char **start, off_t off, | |||
| 353 | 353 | ||
| 354 | static int | 354 | static int |
| 355 | adv7393_write_proc(struct file *file, const char __user * buffer, | 355 | adv7393_write_proc(struct file *file, const char __user * buffer, |
| 356 | unsigned long count, void *data) | 356 | size_t count, void *data) |
| 357 | { | 357 | { |
| 358 | struct adv7393fb_device *fbdev = data; | 358 | struct adv7393fb_device *fbdev = data; |
| 359 | char line[8]; | ||
| 360 | unsigned int val; | 359 | unsigned int val; |
| 361 | int ret; | 360 | int ret; |
| 362 | 361 | ||
| 363 | ret = copy_from_user(line, buffer, count); | 362 | ret = kstrtouint_from_user(buffer, count, 0, &val); |
| 364 | if (ret) | 363 | if (ret) |
| 365 | return -EFAULT; | 364 | return -EFAULT; |
| 366 | 365 | ||
| 367 | val = simple_strtoul(line, NULL, 0); | ||
| 368 | adv7393_write(fbdev->client, val >> 8, val & 0xff); | 366 | adv7393_write(fbdev->client, val >> 8, val & 0xff); |
| 369 | 367 | ||
| 370 | return count; | 368 | return count; |
diff --git a/drivers/video/broadsheetfb.c b/drivers/video/broadsheetfb.c index 377dde3d5bfc..c95b417d0d41 100644 --- a/drivers/video/broadsheetfb.c +++ b/drivers/video/broadsheetfb.c | |||
| @@ -1211,7 +1211,7 @@ static int __devexit broadsheetfb_remove(struct platform_device *dev) | |||
| 1211 | 1211 | ||
| 1212 | static struct platform_driver broadsheetfb_driver = { | 1212 | static struct platform_driver broadsheetfb_driver = { |
| 1213 | .probe = broadsheetfb_probe, | 1213 | .probe = broadsheetfb_probe, |
| 1214 | .remove = broadsheetfb_remove, | 1214 | .remove = __devexit_p(broadsheetfb_remove), |
| 1215 | .driver = { | 1215 | .driver = { |
| 1216 | .owner = THIS_MODULE, | 1216 | .owner = THIS_MODULE, |
| 1217 | .name = "broadsheetfb", | 1217 | .name = "broadsheetfb", |
diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig index c2d11fef114b..e2c96d01d8f5 100644 --- a/drivers/video/console/Kconfig +++ b/drivers/video/console/Kconfig | |||
| @@ -224,5 +224,19 @@ config FONT_10x18 | |||
| 224 | big letters. It fits between the sun 12x22 and the normal 8x16 font. | 224 | big letters. It fits between the sun 12x22 and the normal 8x16 font. |
| 225 | If other fonts are too big or too small for you, say Y, otherwise say N. | 225 | If other fonts are too big or too small for you, say Y, otherwise say N. |
| 226 | 226 | ||
| 227 | config FONT_AUTOSELECT | ||
| 228 | def_bool y | ||
| 229 | depends on FRAMEBUFFER_CONSOLE || SGI_NEWPORT_CONSOLE || STI_CONSOLE || USB_SISUSBVGA_CON | ||
| 230 | depends on !FONT_8x8 | ||
| 231 | depends on !FONT_6x11 | ||
| 232 | depends on !FONT_7x14 | ||
| 233 | depends on !FONT_PEARL_8x8 | ||
| 234 | depends on !FONT_ACORN_8x8 | ||
| 235 | depends on !FONT_MINI_4x6 | ||
| 236 | depends on !FONT_SUN8x16 | ||
| 237 | depends on !FONT_SUN12x22 | ||
| 238 | depends on !FONT_10x18 | ||
| 239 | select FONT_8x16 | ||
| 240 | |||
| 227 | endmenu | 241 | endmenu |
| 228 | 242 | ||
diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c index ab0a8e527333..85e4f44bfa61 100644 --- a/drivers/video/mbx/mbxfb.c +++ b/drivers/video/mbx/mbxfb.c | |||
| @@ -1045,7 +1045,7 @@ static int __devexit mbxfb_remove(struct platform_device *dev) | |||
| 1045 | 1045 | ||
| 1046 | static struct platform_driver mbxfb_driver = { | 1046 | static struct platform_driver mbxfb_driver = { |
| 1047 | .probe = mbxfb_probe, | 1047 | .probe = mbxfb_probe, |
| 1048 | .remove = mbxfb_remove, | 1048 | .remove = __devexit_p(mbxfb_remove), |
| 1049 | .suspend = mbxfb_suspend, | 1049 | .suspend = mbxfb_suspend, |
| 1050 | .resume = mbxfb_resume, | 1050 | .resume = mbxfb_resume, |
| 1051 | .driver = { | 1051 | .driver = { |
diff --git a/drivers/video/omap2/displays/panel-taal.c b/drivers/video/omap2/displays/panel-taal.c index 2ce9992f403b..901576eb5a84 100644 --- a/drivers/video/omap2/displays/panel-taal.c +++ b/drivers/video/omap2/displays/panel-taal.c | |||
| @@ -526,7 +526,7 @@ static ssize_t taal_num_errors_show(struct device *dev, | |||
| 526 | { | 526 | { |
| 527 | struct omap_dss_device *dssdev = to_dss_device(dev); | 527 | struct omap_dss_device *dssdev = to_dss_device(dev); |
| 528 | struct taal_data *td = dev_get_drvdata(&dssdev->dev); | 528 | struct taal_data *td = dev_get_drvdata(&dssdev->dev); |
| 529 | u8 errors; | 529 | u8 errors = 0; |
| 530 | int r; | 530 | int r; |
| 531 | 531 | ||
| 532 | mutex_lock(&td->lock); | 532 | mutex_lock(&td->lock); |
diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c index 72ded9cd2cb0..5066eee10ccf 100644 --- a/drivers/video/omap2/dss/core.c +++ b/drivers/video/omap2/dss/core.c | |||
| @@ -194,8 +194,7 @@ static inline int dss_initialize_debugfs(void) | |||
| 194 | static inline void dss_uninitialize_debugfs(void) | 194 | static inline void dss_uninitialize_debugfs(void) |
| 195 | { | 195 | { |
| 196 | } | 196 | } |
| 197 | static inline int dss_debugfs_create_file(const char *name, | 197 | int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) |
| 198 | void (*write)(struct seq_file *)) | ||
| 199 | { | 198 | { |
| 200 | return 0; | 199 | return 0; |
| 201 | } | 200 | } |
diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c index ec363d8390ed..ca8382d346e9 100644 --- a/drivers/video/omap2/dss/dsi.c +++ b/drivers/video/omap2/dss/dsi.c | |||
| @@ -3724,7 +3724,7 @@ static int dsi_compute_interleave_lp(int blank, int enter_hs, int exit_hs, | |||
| 3724 | /* CLKIN4DDR = 16 * TXBYTECLKHS */ | 3724 | /* CLKIN4DDR = 16 * TXBYTECLKHS */ |
| 3725 | tlp_avail = thsbyte_clk * (blank - trans_lp); | 3725 | tlp_avail = thsbyte_clk * (blank - trans_lp); |
| 3726 | 3726 | ||
| 3727 | ttxclkesc = tdsi_fclk / lp_clk_div; | 3727 | ttxclkesc = tdsi_fclk * lp_clk_div; |
| 3728 | 3728 | ||
| 3729 | lp_inter = ((tlp_avail - 8 * thsbyte_clk - 5 * tdsi_fclk) / ttxclkesc - | 3729 | lp_inter = ((tlp_avail - 8 * thsbyte_clk - 5 * tdsi_fclk) / ttxclkesc - |
| 3730 | 26) / 16; | 3730 | 26) / 16; |
diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c index 6ea1ff149f6f..770632359a17 100644 --- a/drivers/video/omap2/dss/dss.c +++ b/drivers/video/omap2/dss/dss.c | |||
| @@ -731,7 +731,7 @@ static void dss_runtime_put(void) | |||
| 731 | DSSDBG("dss_runtime_put\n"); | 731 | DSSDBG("dss_runtime_put\n"); |
| 732 | 732 | ||
| 733 | r = pm_runtime_put_sync(&dss.pdev->dev); | 733 | r = pm_runtime_put_sync(&dss.pdev->dev); |
| 734 | WARN_ON(r < 0); | 734 | WARN_ON(r < 0 && r != -EBUSY); |
| 735 | } | 735 | } |
| 736 | 736 | ||
| 737 | /* DEBUGFS */ | 737 | /* DEBUGFS */ |
diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c index 5f9d8e69029e..ea7b661e7229 100644 --- a/drivers/video/s3c-fb.c +++ b/drivers/video/s3c-fb.c | |||
| @@ -361,7 +361,7 @@ static int s3c_fb_calc_pixclk(struct s3c_fb *sfb, unsigned int pixclk) | |||
| 361 | result = (unsigned int)tmp / 1000; | 361 | result = (unsigned int)tmp / 1000; |
| 362 | 362 | ||
| 363 | dev_dbg(sfb->dev, "pixclk=%u, clk=%lu, div=%d (%lu)\n", | 363 | dev_dbg(sfb->dev, "pixclk=%u, clk=%lu, div=%d (%lu)\n", |
| 364 | pixclk, clk, result, clk / result); | 364 | pixclk, clk, result, result ? clk / result : clk); |
| 365 | 365 | ||
| 366 | return result; | 366 | return result; |
| 367 | } | 367 | } |
| @@ -1348,8 +1348,14 @@ static void s3c_fb_clear_win(struct s3c_fb *sfb, int win) | |||
| 1348 | writel(0, regs + VIDOSD_A(win, sfb->variant)); | 1348 | writel(0, regs + VIDOSD_A(win, sfb->variant)); |
| 1349 | writel(0, regs + VIDOSD_B(win, sfb->variant)); | 1349 | writel(0, regs + VIDOSD_B(win, sfb->variant)); |
| 1350 | writel(0, regs + VIDOSD_C(win, sfb->variant)); | 1350 | writel(0, regs + VIDOSD_C(win, sfb->variant)); |
| 1351 | reg = readl(regs + SHADOWCON); | 1351 | |
| 1352 | writel(reg & ~SHADOWCON_WINx_PROTECT(win), regs + SHADOWCON); | 1352 | if (sfb->variant.has_shadowcon) { |
| 1353 | reg = readl(sfb->regs + SHADOWCON); | ||
| 1354 | reg &= ~(SHADOWCON_WINx_PROTECT(win) | | ||
| 1355 | SHADOWCON_CHx_ENABLE(win) | | ||
| 1356 | SHADOWCON_CHx_LOCAL_ENABLE(win)); | ||
| 1357 | writel(reg, sfb->regs + SHADOWCON); | ||
| 1358 | } | ||
| 1353 | } | 1359 | } |
| 1354 | 1360 | ||
| 1355 | static int __devinit s3c_fb_probe(struct platform_device *pdev) | 1361 | static int __devinit s3c_fb_probe(struct platform_device *pdev) |
diff --git a/drivers/video/savage/savagefb_driver.c b/drivers/video/savage/savagefb_driver.c index cee7803a0a1c..f3d3b9ce4751 100644 --- a/drivers/video/savage/savagefb_driver.c +++ b/drivers/video/savage/savagefb_driver.c | |||
| @@ -1351,7 +1351,7 @@ static void savagefb_set_par_int(struct savagefb_par *par, struct savage_reg *r | |||
| 1351 | /* following part not present in X11 driver */ | 1351 | /* following part not present in X11 driver */ |
| 1352 | cr67 = vga_in8(0x3d5, par) & 0xf; | 1352 | cr67 = vga_in8(0x3d5, par) & 0xf; |
| 1353 | vga_out8(0x3d5, 0x50 | cr67, par); | 1353 | vga_out8(0x3d5, 0x50 | cr67, par); |
| 1354 | udelay(10000); | 1354 | mdelay(10); |
| 1355 | vga_out8(0x3d4, 0x67, par); | 1355 | vga_out8(0x3d4, 0x67, par); |
| 1356 | /* end of part */ | 1356 | /* end of part */ |
| 1357 | vga_out8(0x3d5, reg->CR67 & ~0x0c, par); | 1357 | vga_out8(0x3d5, reg->CR67 & ~0x0c, par); |
| @@ -1904,11 +1904,11 @@ static int savage_init_hw(struct savagefb_par *par) | |||
| 1904 | vga_out8(0x3d4, 0x66, par); | 1904 | vga_out8(0x3d4, 0x66, par); |
| 1905 | cr66 = vga_in8(0x3d5, par); | 1905 | cr66 = vga_in8(0x3d5, par); |
| 1906 | vga_out8(0x3d5, cr66 | 0x02, par); | 1906 | vga_out8(0x3d5, cr66 | 0x02, par); |
| 1907 | udelay(10000); | 1907 | mdelay(10); |
| 1908 | 1908 | ||
| 1909 | vga_out8(0x3d4, 0x66, par); | 1909 | vga_out8(0x3d4, 0x66, par); |
| 1910 | vga_out8(0x3d5, cr66 & ~0x02, par); /* clear reset flag */ | 1910 | vga_out8(0x3d5, cr66 & ~0x02, par); /* clear reset flag */ |
| 1911 | udelay(10000); | 1911 | mdelay(10); |
| 1912 | 1912 | ||
| 1913 | 1913 | ||
| 1914 | /* | 1914 | /* |
| @@ -1918,11 +1918,11 @@ static int savage_init_hw(struct savagefb_par *par) | |||
| 1918 | vga_out8(0x3d4, 0x3f, par); | 1918 | vga_out8(0x3d4, 0x3f, par); |
| 1919 | cr3f = vga_in8(0x3d5, par); | 1919 | cr3f = vga_in8(0x3d5, par); |
| 1920 | vga_out8(0x3d5, cr3f | 0x08, par); | 1920 | vga_out8(0x3d5, cr3f | 0x08, par); |
| 1921 | udelay(10000); | 1921 | mdelay(10); |
| 1922 | 1922 | ||
| 1923 | vga_out8(0x3d4, 0x3f, par); | 1923 | vga_out8(0x3d4, 0x3f, par); |
| 1924 | vga_out8(0x3d5, cr3f & ~0x08, par); /* clear reset flags */ | 1924 | vga_out8(0x3d5, cr3f & ~0x08, par); /* clear reset flags */ |
| 1925 | udelay(10000); | 1925 | mdelay(10); |
| 1926 | 1926 | ||
| 1927 | /* Savage ramdac speeds */ | 1927 | /* Savage ramdac speeds */ |
| 1928 | par->numClocks = 4; | 1928 | par->numClocks = 4; |
diff --git a/drivers/xen/events.c b/drivers/xen/events.c index 6908e4ce2a0d..7595581d032c 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c | |||
| @@ -827,6 +827,9 @@ int bind_evtchn_to_irq(unsigned int evtchn) | |||
| 827 | handle_edge_irq, "event"); | 827 | handle_edge_irq, "event"); |
| 828 | 828 | ||
| 829 | xen_irq_info_evtchn_init(irq, evtchn); | 829 | xen_irq_info_evtchn_init(irq, evtchn); |
| 830 | } else { | ||
| 831 | struct irq_info *info = info_for_irq(irq); | ||
| 832 | WARN_ON(info == NULL || info->type != IRQT_EVTCHN); | ||
| 830 | } | 833 | } |
| 831 | 834 | ||
| 832 | out: | 835 | out: |
| @@ -862,6 +865,9 @@ static int bind_ipi_to_irq(unsigned int ipi, unsigned int cpu) | |||
| 862 | xen_irq_info_ipi_init(cpu, irq, evtchn, ipi); | 865 | xen_irq_info_ipi_init(cpu, irq, evtchn, ipi); |
| 863 | 866 | ||
| 864 | bind_evtchn_to_cpu(evtchn, cpu); | 867 | bind_evtchn_to_cpu(evtchn, cpu); |
| 868 | } else { | ||
| 869 | struct irq_info *info = info_for_irq(irq); | ||
| 870 | WARN_ON(info == NULL || info->type != IRQT_IPI); | ||
| 865 | } | 871 | } |
| 866 | 872 | ||
| 867 | out: | 873 | out: |
| @@ -939,6 +945,9 @@ int bind_virq_to_irq(unsigned int virq, unsigned int cpu) | |||
| 939 | xen_irq_info_virq_init(cpu, irq, evtchn, virq); | 945 | xen_irq_info_virq_init(cpu, irq, evtchn, virq); |
| 940 | 946 | ||
| 941 | bind_evtchn_to_cpu(evtchn, cpu); | 947 | bind_evtchn_to_cpu(evtchn, cpu); |
| 948 | } else { | ||
| 949 | struct irq_info *info = info_for_irq(irq); | ||
| 950 | WARN_ON(info == NULL || info->type != IRQT_VIRQ); | ||
| 942 | } | 951 | } |
| 943 | 952 | ||
| 944 | out: | 953 | out: |
diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c index b84bf0b6cc34..18fff88254eb 100644 --- a/drivers/xen/pci.c +++ b/drivers/xen/pci.c | |||
| @@ -59,7 +59,7 @@ static int xen_add_device(struct device *dev) | |||
| 59 | 59 | ||
| 60 | #ifdef CONFIG_ACPI | 60 | #ifdef CONFIG_ACPI |
| 61 | handle = DEVICE_ACPI_HANDLE(&pci_dev->dev); | 61 | handle = DEVICE_ACPI_HANDLE(&pci_dev->dev); |
| 62 | if (!handle) | 62 | if (!handle && pci_dev->bus->bridge) |
| 63 | handle = DEVICE_ACPI_HANDLE(pci_dev->bus->bridge); | 63 | handle = DEVICE_ACPI_HANDLE(pci_dev->bus->bridge); |
| 64 | #ifdef CONFIG_PCI_IOV | 64 | #ifdef CONFIG_PCI_IOV |
| 65 | if (!handle && pci_dev->is_virtfn) | 65 | if (!handle && pci_dev->is_virtfn) |
