aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDoron Cohen <doronc@siano-ms.com>2011-07-20 08:07:36 -0400
committerMauro Carvalho Chehab <mchehab@redhat.com>2011-08-27 08:56:06 -0400
commitea3709435c7f2da8852c3d676874cd727253fc60 (patch)
tree99e3914fa0b2b6aba64f96216921d3e61f21320d /drivers
parentfda516b72afcddbb617c75c93fe6316e4356a14b (diff)
[media] siano: apply debug flag to module level
Siano modules already had sms_dbg flag which is a module parameter which sets the debug mode so module prints messages to dmesg for debugging. The variable was static therefore apply only to the file which defines the module. In modules as smsmdtv.ko that contain a few files, the debug flag applied only for functions in that main file. flag was changed to be non-static and therefore can be accessed by all module files (although it is still not exported out of the module). Signed-off-by: Doron Cohen <doronc@siano-ms.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/media/dvb/siano/sms-cards.c4
-rw-r--r--drivers/media/dvb/siano/smscoreapi.c2
-rw-r--r--drivers/media/dvb/siano/smscoreapi.h1
-rw-r--r--drivers/media/dvb/siano/smsdvb.c4
-rw-r--r--drivers/media/dvb/siano/smsusb.c4
5 files changed, 2 insertions, 13 deletions
diff --git a/drivers/media/dvb/siano/sms-cards.c b/drivers/media/dvb/siano/sms-cards.c
index af121db88ea0..cf442dc4c191 100644
--- a/drivers/media/dvb/siano/sms-cards.c
+++ b/drivers/media/dvb/siano/sms-cards.c
@@ -20,10 +20,6 @@
20#include "sms-cards.h" 20#include "sms-cards.h"
21#include "smsir.h" 21#include "smsir.h"
22 22
23static int sms_dbg;
24module_param_named(cards_dbg, sms_dbg, int, 0644);
25MODULE_PARM_DESC(cards_dbg, "set debug level (info=1, adv=2 (or-able))");
26
27static struct sms_board sms_boards[] = { 23static struct sms_board sms_boards[] = {
28 [SMS_BOARD_UNKNOWN] = { 24 [SMS_BOARD_UNKNOWN] = {
29 .name = "Unknown board", 25 .name = "Unknown board",
diff --git a/drivers/media/dvb/siano/smscoreapi.c b/drivers/media/dvb/siano/smscoreapi.c
index 7331e8450d1a..c0acacc42dc6 100644
--- a/drivers/media/dvb/siano/smscoreapi.c
+++ b/drivers/media/dvb/siano/smscoreapi.c
@@ -39,7 +39,7 @@
39#include "smsir.h" 39#include "smsir.h"
40#include "smsendian.h" 40#include "smsendian.h"
41 41
42static int sms_dbg; 42int sms_dbg;
43module_param_named(debug, sms_dbg, int, 0644); 43module_param_named(debug, sms_dbg, int, 0644);
44MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))"); 44MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");
45 45
diff --git a/drivers/media/dvb/siano/smscoreapi.h b/drivers/media/dvb/siano/smscoreapi.h
index c592ae090397..bd1cafc2224b 100644
--- a/drivers/media/dvb/siano/smscoreapi.h
+++ b/drivers/media/dvb/siano/smscoreapi.h
@@ -751,6 +751,7 @@ int smscore_led_state(struct smscore_device_t *core, int led);
751 751
752 752
753/* ------------------------------------------------------------------------ */ 753/* ------------------------------------------------------------------------ */
754extern int sms_dbg;
754 755
755#define DBG_INFO 1 756#define DBG_INFO 1
756#define DBG_ADV 2 757#define DBG_ADV 2
diff --git a/drivers/media/dvb/siano/smsdvb.c b/drivers/media/dvb/siano/smsdvb.c
index 37c594f82782..b1f4911e8359 100644
--- a/drivers/media/dvb/siano/smsdvb.c
+++ b/drivers/media/dvb/siano/smsdvb.c
@@ -60,10 +60,6 @@ struct smsdvb_client_t {
60static struct list_head g_smsdvb_clients; 60static struct list_head g_smsdvb_clients;
61static struct mutex g_smsdvb_clientslock; 61static struct mutex g_smsdvb_clientslock;
62 62
63static int sms_dbg;
64module_param_named(debug, sms_dbg, int, 0644);
65MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");
66
67/* Events that may come from DVB v3 adapter */ 63/* Events that may come from DVB v3 adapter */
68static void sms_board_dvb3_event(struct smsdvb_client_t *client, 64static void sms_board_dvb3_event(struct smsdvb_client_t *client,
69 enum SMS_DVB3_EVENTS event) { 65 enum SMS_DVB3_EVENTS event) {
diff --git a/drivers/media/dvb/siano/smsusb.c b/drivers/media/dvb/siano/smsusb.c
index 0c8164a2cc36..f8dca557fef9 100644
--- a/drivers/media/dvb/siano/smsusb.c
+++ b/drivers/media/dvb/siano/smsusb.c
@@ -29,10 +29,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
29#include "sms-cards.h" 29#include "sms-cards.h"
30#include "smsendian.h" 30#include "smsendian.h"
31 31
32static int sms_dbg;
33module_param_named(debug, sms_dbg, int, 0644);
34MODULE_PARM_DESC(debug, "set debug level (info=1, adv=2 (or-able))");
35
36#define USB1_BUFFER_SIZE 0x1000 32#define USB1_BUFFER_SIZE 0x1000
37#define USB2_BUFFER_SIZE 0x4000 33#define USB2_BUFFER_SIZE 0x4000
38 34