aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorDavid Woodhouse <dwmw2@infradead.org>2008-05-20 06:47:16 -0400
committerJohn W. Linville <linville@tuxdriver.com>2008-05-21 21:47:37 -0400
commite37fc6e11c79899451e394319cff18cc53d6448d (patch)
treeb35c86f804ec3fbc5aa7ec6c7bb3fe631270e3d1 /drivers
parentf9d1cf53cf9e934f15ce0371b5fd568407032ea2 (diff)
libertas: Increase priority of 'unknown command' warnings
Using the deprecated lbs_prepare_and_send_command() function for a command which it doesn't understand is an error; complain loudly about it even when we're not debugging. The mesh stats bug, where we converted MESH_ACCESS to a direct command but accidentally missed one user which was still trying to do it through lbs_prepare_and_send_command(), would have been caught a lot quicker if we'd done this sooner. Such bugs aren't entirely unlikely in future too, as we convert more code to stop using this function. Signed-off-by: David Woodhouse <dwmw2@infradead.org> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/wireless/libertas/cmd.c2
-rw-r--r--drivers/net/wireless/libertas/cmdresp.c4
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/wireless/libertas/cmd.c b/drivers/net/wireless/libertas/cmd.c
index c2dd43ece069..bed68e9add02 100644
--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -1452,7 +1452,7 @@ int lbs_prepare_and_send_command(struct lbs_private *priv,
1452 ret = lbs_cmd_bcn_ctrl(priv, cmdptr, cmd_action); 1452 ret = lbs_cmd_bcn_ctrl(priv, cmdptr, cmd_action);
1453 break; 1453 break;
1454 default: 1454 default:
1455 lbs_deb_host("PREP_CMD: unknown command 0x%04x\n", cmd_no); 1455 lbs_pr_err("PREP_CMD: unknown command 0x%04x\n", cmd_no);
1456 ret = -1; 1456 ret = -1;
1457 break; 1457 break;
1458 } 1458 }
diff --git a/drivers/net/wireless/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
index 5abecb7673e6..9e50fdd94810 100644
--- a/drivers/net/wireless/libertas/cmdresp.c
+++ b/drivers/net/wireless/libertas/cmdresp.c
@@ -376,8 +376,8 @@ static inline int handle_cmd_response(struct lbs_private *priv,
376 break; 376 break;
377 377
378 default: 378 default:
379 lbs_deb_host("CMD_RESP: unknown cmd response 0x%04x\n", 379 lbs_pr_err("CMD_RESP: unknown cmd response 0x%04x\n",
380 le16_to_cpu(resp->command)); 380 le16_to_cpu(resp->command));
381 break; 381 break;
382 } 382 }
383 lbs_deb_leave(LBS_DEB_HOST); 383 lbs_deb_leave(LBS_DEB_HOST);