diff options
| author | Himangi Saraogi <himangi774@gmail.com> | 2013-10-28 20:58:03 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-10-29 11:44:54 -0400 |
| commit | d5a499671ba008915e886e95af6c498f168f42d4 (patch) | |
| tree | 4debfd1f39c457c9864a3c2a5cf1b84bc3c252ce /drivers | |
| parent | 17607ca280221c26d0a53bf7d53c339489a936cc (diff) | |
Stging: bcm: Adapter.h : removed typedef from struct _U_IP_ADDRESS and changed it to lowercase
Running checkpatch.pl on the file drivers/staging/bcm/Adapter.h gave
an error as it is a mistake to use typedef for structures
according to CodeingStyle as it reduces readability. The typedef was
removed and all occurrences of the typedef union were replaced with
union u_ip_address as types are all lowercase.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/bcm/Adapter.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h index d6c9630a8822..5dfdf5a4411d 100644 --- a/drivers/staging/bcm/Adapter.h +++ b/drivers/staging/bcm/Adapter.h | |||
| @@ -35,7 +35,7 @@ struct bcm_link_request { | |||
| 35 | #define MAX_PROTOCOL_LENGTH 32 | 35 | #define MAX_PROTOCOL_LENGTH 32 |
| 36 | #define IPV6_ADDRESS_SIZEINBYTES 0x10 | 36 | #define IPV6_ADDRESS_SIZEINBYTES 0x10 |
| 37 | 37 | ||
| 38 | typedef union _U_IP_ADDRESS { | 38 | union u_ip_address { |
| 39 | struct { | 39 | struct { |
| 40 | ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address Range */ | 40 | ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address Range */ |
| 41 | ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask Address Range */ | 41 | ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask Address Range */ |
| @@ -52,7 +52,7 @@ typedef union _U_IP_ADDRESS { | |||
| 52 | UCHAR ucIpv6Address[MAX_IP_RANGE_LENGTH * IPV6_ADDRESS_SIZEINBYTES]; | 52 | UCHAR ucIpv6Address[MAX_IP_RANGE_LENGTH * IPV6_ADDRESS_SIZEINBYTES]; |
| 53 | UCHAR ucIpv6Mask[MAX_IP_RANGE_LENGTH * IPV6_ADDRESS_SIZEINBYTES]; | 53 | UCHAR ucIpv6Mask[MAX_IP_RANGE_LENGTH * IPV6_ADDRESS_SIZEINBYTES]; |
| 54 | }; | 54 | }; |
| 55 | } U_IP_ADDRESS; | 55 | }; |
| 56 | 56 | ||
| 57 | struct bcm_hdr_suppression_contextinfo { | 57 | struct bcm_hdr_suppression_contextinfo { |
| 58 | UCHAR ucaHdrSuppressionInBuf[MAX_PHS_LENGTHS]; /* Intermediate buffer to accumulate pkt Header for PHS */ | 58 | UCHAR ucaHdrSuppressionInBuf[MAX_PHS_LENGTHS]; /* Intermediate buffer to accumulate pkt Header for PHS */ |
| @@ -66,10 +66,10 @@ struct bcm_classifier_rule { | |||
| 66 | bool bUsed; | 66 | bool bUsed; |
| 67 | USHORT usVCID_Value; | 67 | USHORT usVCID_Value; |
| 68 | B_UINT8 u8ClassifierRulePriority; /* This field detemines the Classifier Priority */ | 68 | B_UINT8 u8ClassifierRulePriority; /* This field detemines the Classifier Priority */ |
| 69 | U_IP_ADDRESS stSrcIpAddress; | 69 | union u_ip_address stSrcIpAddress; |
| 70 | UCHAR ucIPSourceAddressLength; /* Ip Source Address Length */ | 70 | UCHAR ucIPSourceAddressLength; /* Ip Source Address Length */ |
| 71 | 71 | ||
| 72 | U_IP_ADDRESS stDestIpAddress; | 72 | union u_ip_address stDestIpAddress; |
| 73 | UCHAR ucIPDestinationAddressLength; /* Ip Destination Address Length */ | 73 | UCHAR ucIPDestinationAddressLength; /* Ip Destination Address Length */ |
| 74 | UCHAR ucIPTypeOfServiceLength; /* Type of service Length */ | 74 | UCHAR ucIPTypeOfServiceLength; /* Type of service Length */ |
| 75 | UCHAR ucTosLow; /* Tos Low */ | 75 | UCHAR ucTosLow; /* Tos Low */ |