diff options
| author | Yijing Wang <wangyijing@huawei.com> | 2014-11-11 19:45:45 -0500 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2014-11-12 09:49:38 -0500 |
| commit | c2791b806988100cc1c047e2b0b5c5d0914aa3b6 (patch) | |
| tree | fb159818659112e661aafab65e52d4a422360564 /drivers | |
| parent | f8338694270224970cbaae7e404517ec39f9c753 (diff) | |
PCI/MSI: Rename "struct msi_chip" to "struct msi_controller"
"msi_chip" isn't very descriptive, so rename it to "msi_controller". That
tells a little more about what it does and is already used in device tree
bindings.
No functional change.
[bhelgaas: changelog, change *only* the struct name so it's reviewable]
Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/irqchip/irq-armada-370-xp.c | 6 | ||||
| -rw-r--r-- | drivers/of/of_pci.c | 8 | ||||
| -rw-r--r-- | drivers/pci/host/pci-keystone-dw.c | 2 | ||||
| -rw-r--r-- | drivers/pci/host/pci-keystone.h | 2 | ||||
| -rw-r--r-- | drivers/pci/host/pci-mvebu.c | 2 | ||||
| -rw-r--r-- | drivers/pci/host/pci-tegra.c | 11 | ||||
| -rw-r--r-- | drivers/pci/host/pcie-designware.c | 6 | ||||
| -rw-r--r-- | drivers/pci/host/pcie-designware.h | 2 | ||||
| -rw-r--r-- | drivers/pci/host/pcie-rcar.c | 8 | ||||
| -rw-r--r-- | drivers/pci/host/pcie-xilinx.c | 7 | ||||
| -rw-r--r-- | drivers/pci/msi.c | 4 |
11 files changed, 30 insertions, 28 deletions
diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c index 3e238cd049e6..4e202375e027 100644 --- a/drivers/irqchip/irq-armada-370-xp.c +++ b/drivers/irqchip/irq-armada-370-xp.c | |||
| @@ -129,7 +129,7 @@ static void armada_370_xp_free_msi(int hwirq) | |||
| 129 | mutex_unlock(&msi_used_lock); | 129 | mutex_unlock(&msi_used_lock); |
| 130 | } | 130 | } |
| 131 | 131 | ||
| 132 | static int armada_370_xp_setup_msi_irq(struct msi_chip *chip, | 132 | static int armada_370_xp_setup_msi_irq(struct msi_controller *chip, |
| 133 | struct pci_dev *pdev, | 133 | struct pci_dev *pdev, |
| 134 | struct msi_desc *desc) | 134 | struct msi_desc *desc) |
| 135 | { | 135 | { |
| @@ -160,7 +160,7 @@ static int armada_370_xp_setup_msi_irq(struct msi_chip *chip, | |||
| 160 | return 0; | 160 | return 0; |
| 161 | } | 161 | } |
| 162 | 162 | ||
| 163 | static void armada_370_xp_teardown_msi_irq(struct msi_chip *chip, | 163 | static void armada_370_xp_teardown_msi_irq(struct msi_controller *chip, |
| 164 | unsigned int irq) | 164 | unsigned int irq) |
| 165 | { | 165 | { |
| 166 | struct irq_data *d = irq_get_irq_data(irq); | 166 | struct irq_data *d = irq_get_irq_data(irq); |
| @@ -195,7 +195,7 @@ static const struct irq_domain_ops armada_370_xp_msi_irq_ops = { | |||
| 195 | static int armada_370_xp_msi_init(struct device_node *node, | 195 | static int armada_370_xp_msi_init(struct device_node *node, |
| 196 | phys_addr_t main_int_phys_base) | 196 | phys_addr_t main_int_phys_base) |
| 197 | { | 197 | { |
| 198 | struct msi_chip *msi_chip; | 198 | struct msi_controller *msi_chip; |
| 199 | u32 reg; | 199 | u32 reg; |
| 200 | int ret; | 200 | int ret; |
| 201 | 201 | ||
diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c index 8882b467be95..88471d3d98cd 100644 --- a/drivers/of/of_pci.c +++ b/drivers/of/of_pci.c | |||
| @@ -236,7 +236,7 @@ EXPORT_SYMBOL_GPL(of_pci_get_host_bridge_resources); | |||
| 236 | static LIST_HEAD(of_pci_msi_chip_list); | 236 | static LIST_HEAD(of_pci_msi_chip_list); |
| 237 | static DEFINE_MUTEX(of_pci_msi_chip_mutex); | 237 | static DEFINE_MUTEX(of_pci_msi_chip_mutex); |
| 238 | 238 | ||
| 239 | int of_pci_msi_chip_add(struct msi_chip *chip) | 239 | int of_pci_msi_chip_add(struct msi_controller *chip) |
| 240 | { | 240 | { |
| 241 | if (!of_property_read_bool(chip->of_node, "msi-controller")) | 241 | if (!of_property_read_bool(chip->of_node, "msi-controller")) |
| 242 | return -EINVAL; | 242 | return -EINVAL; |
| @@ -249,7 +249,7 @@ int of_pci_msi_chip_add(struct msi_chip *chip) | |||
| 249 | } | 249 | } |
| 250 | EXPORT_SYMBOL_GPL(of_pci_msi_chip_add); | 250 | EXPORT_SYMBOL_GPL(of_pci_msi_chip_add); |
| 251 | 251 | ||
| 252 | void of_pci_msi_chip_remove(struct msi_chip *chip) | 252 | void of_pci_msi_chip_remove(struct msi_controller *chip) |
| 253 | { | 253 | { |
| 254 | mutex_lock(&of_pci_msi_chip_mutex); | 254 | mutex_lock(&of_pci_msi_chip_mutex); |
| 255 | list_del(&chip->list); | 255 | list_del(&chip->list); |
| @@ -257,9 +257,9 @@ void of_pci_msi_chip_remove(struct msi_chip *chip) | |||
| 257 | } | 257 | } |
| 258 | EXPORT_SYMBOL_GPL(of_pci_msi_chip_remove); | 258 | EXPORT_SYMBOL_GPL(of_pci_msi_chip_remove); |
| 259 | 259 | ||
| 260 | struct msi_chip *of_pci_find_msi_chip_by_node(struct device_node *of_node) | 260 | struct msi_controller *of_pci_find_msi_chip_by_node(struct device_node *of_node) |
| 261 | { | 261 | { |
| 262 | struct msi_chip *c; | 262 | struct msi_controller *c; |
| 263 | 263 | ||
| 264 | mutex_lock(&of_pci_msi_chip_mutex); | 264 | mutex_lock(&of_pci_msi_chip_mutex); |
| 265 | list_for_each_entry(c, &of_pci_msi_chip_list, list) { | 265 | list_for_each_entry(c, &of_pci_msi_chip_list, list) { |
diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c index 34086ce88e8e..ac3d08c42770 100644 --- a/drivers/pci/host/pci-keystone-dw.c +++ b/drivers/pci/host/pci-keystone-dw.c | |||
| @@ -205,7 +205,7 @@ const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = { | |||
| 205 | .map = ks_dw_pcie_msi_map, | 205 | .map = ks_dw_pcie_msi_map, |
| 206 | }; | 206 | }; |
| 207 | 207 | ||
| 208 | int ks_dw_pcie_msi_host_init(struct pcie_port *pp, struct msi_chip *chip) | 208 | int ks_dw_pcie_msi_host_init(struct pcie_port *pp, struct msi_controller *chip) |
| 209 | { | 209 | { |
| 210 | struct keystone_pcie *ks_pcie = to_keystone_pcie(pp); | 210 | struct keystone_pcie *ks_pcie = to_keystone_pcie(pp); |
| 211 | int i; | 211 | int i; |
diff --git a/drivers/pci/host/pci-keystone.h b/drivers/pci/host/pci-keystone.h index 1fc1fceede9e..478d932b602d 100644 --- a/drivers/pci/host/pci-keystone.h +++ b/drivers/pci/host/pci-keystone.h | |||
| @@ -55,4 +55,4 @@ void ks_dw_pcie_msi_set_irq(struct pcie_port *pp, int irq); | |||
| 55 | void ks_dw_pcie_msi_clear_irq(struct pcie_port *pp, int irq); | 55 | void ks_dw_pcie_msi_clear_irq(struct pcie_port *pp, int irq); |
| 56 | void ks_dw_pcie_v3_65_scan_bus(struct pcie_port *pp); | 56 | void ks_dw_pcie_v3_65_scan_bus(struct pcie_port *pp); |
| 57 | int ks_dw_pcie_msi_host_init(struct pcie_port *pp, | 57 | int ks_dw_pcie_msi_host_init(struct pcie_port *pp, |
| 58 | struct msi_chip *chip); | 58 | struct msi_controller *chip); |
diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c index b1315e197ffb..cf907fec0652 100644 --- a/drivers/pci/host/pci-mvebu.c +++ b/drivers/pci/host/pci-mvebu.c | |||
| @@ -99,7 +99,7 @@ struct mvebu_pcie_port; | |||
| 99 | struct mvebu_pcie { | 99 | struct mvebu_pcie { |
| 100 | struct platform_device *pdev; | 100 | struct platform_device *pdev; |
| 101 | struct mvebu_pcie_port *ports; | 101 | struct mvebu_pcie_port *ports; |
| 102 | struct msi_chip *msi; | 102 | struct msi_controller *msi; |
| 103 | struct resource io; | 103 | struct resource io; |
| 104 | char io_name[30]; | 104 | char io_name[30]; |
| 105 | struct resource realio; | 105 | struct resource realio; |
diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c index 3d43874319be..5529de7328ba 100644 --- a/drivers/pci/host/pci-tegra.c +++ b/drivers/pci/host/pci-tegra.c | |||
| @@ -238,7 +238,7 @@ | |||
| 238 | ) | 238 | ) |
| 239 | 239 | ||
| 240 | struct tegra_msi { | 240 | struct tegra_msi { |
| 241 | struct msi_chip chip; | 241 | struct msi_controller chip; |
| 242 | DECLARE_BITMAP(used, INT_PCI_MSI_NR); | 242 | DECLARE_BITMAP(used, INT_PCI_MSI_NR); |
| 243 | struct irq_domain *domain; | 243 | struct irq_domain *domain; |
| 244 | unsigned long pages; | 244 | unsigned long pages; |
| @@ -259,7 +259,7 @@ struct tegra_pcie_soc_data { | |||
| 259 | bool has_gen2; | 259 | bool has_gen2; |
| 260 | }; | 260 | }; |
| 261 | 261 | ||
| 262 | static inline struct tegra_msi *to_tegra_msi(struct msi_chip *chip) | 262 | static inline struct tegra_msi *to_tegra_msi(struct msi_controller *chip) |
| 263 | { | 263 | { |
| 264 | return container_of(chip, struct tegra_msi, chip); | 264 | return container_of(chip, struct tegra_msi, chip); |
| 265 | } | 265 | } |
| @@ -1283,8 +1283,8 @@ static irqreturn_t tegra_pcie_msi_irq(int irq, void *data) | |||
| 1283 | return processed > 0 ? IRQ_HANDLED : IRQ_NONE; | 1283 | return processed > 0 ? IRQ_HANDLED : IRQ_NONE; |
| 1284 | } | 1284 | } |
| 1285 | 1285 | ||
| 1286 | static int tegra_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev, | 1286 | static int tegra_msi_setup_irq(struct msi_controller *chip, |
| 1287 | struct msi_desc *desc) | 1287 | struct pci_dev *pdev, struct msi_desc *desc) |
| 1288 | { | 1288 | { |
| 1289 | struct tegra_msi *msi = to_tegra_msi(chip); | 1289 | struct tegra_msi *msi = to_tegra_msi(chip); |
| 1290 | struct msi_msg msg; | 1290 | struct msi_msg msg; |
| @@ -1313,7 +1313,8 @@ static int tegra_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev, | |||
| 1313 | return 0; | 1313 | return 0; |
| 1314 | } | 1314 | } |
| 1315 | 1315 | ||
| 1316 | static void tegra_msi_teardown_irq(struct msi_chip *chip, unsigned int irq) | 1316 | static void tegra_msi_teardown_irq(struct msi_controller *chip, |
| 1317 | unsigned int irq) | ||
| 1317 | { | 1318 | { |
| 1318 | struct tegra_msi *msi = to_tegra_msi(chip); | 1319 | struct tegra_msi *msi = to_tegra_msi(chip); |
| 1319 | struct irq_data *d = irq_get_irq_data(irq); | 1320 | struct irq_data *d = irq_get_irq_data(irq); |
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index dfed00aa3ac0..f4decad80ee4 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c | |||
| @@ -276,7 +276,7 @@ no_valid_irq: | |||
| 276 | return -ENOSPC; | 276 | return -ENOSPC; |
| 277 | } | 277 | } |
| 278 | 278 | ||
| 279 | static int dw_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev, | 279 | static int dw_msi_setup_irq(struct msi_controller *chip, struct pci_dev *pdev, |
| 280 | struct msi_desc *desc) | 280 | struct msi_desc *desc) |
| 281 | { | 281 | { |
| 282 | int irq, pos; | 282 | int irq, pos; |
| @@ -303,7 +303,7 @@ static int dw_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev, | |||
| 303 | return 0; | 303 | return 0; |
| 304 | } | 304 | } |
| 305 | 305 | ||
| 306 | static void dw_msi_teardown_irq(struct msi_chip *chip, unsigned int irq) | 306 | static void dw_msi_teardown_irq(struct msi_controller *chip, unsigned int irq) |
| 307 | { | 307 | { |
| 308 | struct irq_data *data = irq_get_irq_data(irq); | 308 | struct irq_data *data = irq_get_irq_data(irq); |
| 309 | struct msi_desc *msi = irq_data_get_msi(data); | 309 | struct msi_desc *msi = irq_data_get_msi(data); |
| @@ -312,7 +312,7 @@ static void dw_msi_teardown_irq(struct msi_chip *chip, unsigned int irq) | |||
| 312 | clear_irq_range(pp, irq, 1, data->hwirq); | 312 | clear_irq_range(pp, irq, 1, data->hwirq); |
| 313 | } | 313 | } |
| 314 | 314 | ||
| 315 | static struct msi_chip dw_pcie_msi_chip = { | 315 | static struct msi_controller dw_pcie_msi_chip = { |
| 316 | .setup_irq = dw_msi_setup_irq, | 316 | .setup_irq = dw_msi_setup_irq, |
| 317 | .teardown_irq = dw_msi_teardown_irq, | 317 | .teardown_irq = dw_msi_teardown_irq, |
| 318 | }; | 318 | }; |
diff --git a/drivers/pci/host/pcie-designware.h b/drivers/pci/host/pcie-designware.h index c6256751daff..d0bbd276840d 100644 --- a/drivers/pci/host/pcie-designware.h +++ b/drivers/pci/host/pcie-designware.h | |||
| @@ -73,7 +73,7 @@ struct pcie_host_ops { | |||
| 73 | u32 (*get_msi_addr)(struct pcie_port *pp); | 73 | u32 (*get_msi_addr)(struct pcie_port *pp); |
| 74 | u32 (*get_msi_data)(struct pcie_port *pp, int pos); | 74 | u32 (*get_msi_data)(struct pcie_port *pp, int pos); |
| 75 | void (*scan_bus)(struct pcie_port *pp); | 75 | void (*scan_bus)(struct pcie_port *pp); |
| 76 | int (*msi_host_init)(struct pcie_port *pp, struct msi_chip *chip); | 76 | int (*msi_host_init)(struct pcie_port *pp, struct msi_controller *chip); |
| 77 | }; | 77 | }; |
| 78 | 78 | ||
| 79 | int dw_pcie_cfg_read(void __iomem *addr, int where, int size, u32 *val); | 79 | int dw_pcie_cfg_read(void __iomem *addr, int where, int size, u32 *val); |
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c index 61158e03ab5f..b986c51d4df3 100644 --- a/drivers/pci/host/pcie-rcar.c +++ b/drivers/pci/host/pcie-rcar.c | |||
| @@ -111,14 +111,14 @@ | |||
| 111 | struct rcar_msi { | 111 | struct rcar_msi { |
| 112 | DECLARE_BITMAP(used, INT_PCI_MSI_NR); | 112 | DECLARE_BITMAP(used, INT_PCI_MSI_NR); |
| 113 | struct irq_domain *domain; | 113 | struct irq_domain *domain; |
| 114 | struct msi_chip chip; | 114 | struct msi_controller chip; |
| 115 | unsigned long pages; | 115 | unsigned long pages; |
| 116 | struct mutex lock; | 116 | struct mutex lock; |
| 117 | int irq1; | 117 | int irq1; |
| 118 | int irq2; | 118 | int irq2; |
| 119 | }; | 119 | }; |
| 120 | 120 | ||
| 121 | static inline struct rcar_msi *to_rcar_msi(struct msi_chip *chip) | 121 | static inline struct rcar_msi *to_rcar_msi(struct msi_controller *chip) |
| 122 | { | 122 | { |
| 123 | return container_of(chip, struct rcar_msi, chip); | 123 | return container_of(chip, struct rcar_msi, chip); |
| 124 | } | 124 | } |
| @@ -622,7 +622,7 @@ static irqreturn_t rcar_pcie_msi_irq(int irq, void *data) | |||
| 622 | return IRQ_HANDLED; | 622 | return IRQ_HANDLED; |
| 623 | } | 623 | } |
| 624 | 624 | ||
| 625 | static int rcar_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev, | 625 | static int rcar_msi_setup_irq(struct msi_controller *chip, struct pci_dev *pdev, |
| 626 | struct msi_desc *desc) | 626 | struct msi_desc *desc) |
| 627 | { | 627 | { |
| 628 | struct rcar_msi *msi = to_rcar_msi(chip); | 628 | struct rcar_msi *msi = to_rcar_msi(chip); |
| @@ -652,7 +652,7 @@ static int rcar_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev, | |||
| 652 | return 0; | 652 | return 0; |
| 653 | } | 653 | } |
| 654 | 654 | ||
| 655 | static void rcar_msi_teardown_irq(struct msi_chip *chip, unsigned int irq) | 655 | static void rcar_msi_teardown_irq(struct msi_controller *chip, unsigned int irq) |
| 656 | { | 656 | { |
| 657 | struct rcar_msi *msi = to_rcar_msi(chip); | 657 | struct rcar_msi *msi = to_rcar_msi(chip); |
| 658 | struct irq_data *d = irq_get_irq_data(irq); | 658 | struct irq_data *d = irq_get_irq_data(irq); |
diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c index ccc496b33a97..f41bc601b7b0 100644 --- a/drivers/pci/host/pcie-xilinx.c +++ b/drivers/pci/host/pcie-xilinx.c | |||
| @@ -335,7 +335,8 @@ static int xilinx_pcie_assign_msi(struct xilinx_pcie_port *port) | |||
| 335 | * @chip: MSI Chip descriptor | 335 | * @chip: MSI Chip descriptor |
| 336 | * @irq: MSI IRQ to destroy | 336 | * @irq: MSI IRQ to destroy |
| 337 | */ | 337 | */ |
| 338 | static void xilinx_msi_teardown_irq(struct msi_chip *chip, unsigned int irq) | 338 | static void xilinx_msi_teardown_irq(struct msi_controller *chip, |
| 339 | unsigned int irq) | ||
| 339 | { | 340 | { |
| 340 | xilinx_pcie_destroy_msi(irq); | 341 | xilinx_pcie_destroy_msi(irq); |
| 341 | } | 342 | } |
| @@ -348,7 +349,7 @@ static void xilinx_msi_teardown_irq(struct msi_chip *chip, unsigned int irq) | |||
| 348 | * | 349 | * |
| 349 | * Return: '0' on success and error value on failure | 350 | * Return: '0' on success and error value on failure |
| 350 | */ | 351 | */ |
| 351 | static int xilinx_pcie_msi_setup_irq(struct msi_chip *chip, | 352 | static int xilinx_pcie_msi_setup_irq(struct msi_controller *chip, |
| 352 | struct pci_dev *pdev, | 353 | struct pci_dev *pdev, |
| 353 | struct msi_desc *desc) | 354 | struct msi_desc *desc) |
| 354 | { | 355 | { |
| @@ -380,7 +381,7 @@ static int xilinx_pcie_msi_setup_irq(struct msi_chip *chip, | |||
| 380 | } | 381 | } |
| 381 | 382 | ||
| 382 | /* MSI Chip Descriptor */ | 383 | /* MSI Chip Descriptor */ |
| 383 | static struct msi_chip xilinx_pcie_msi_chip = { | 384 | static struct msi_controller xilinx_pcie_msi_chip = { |
| 384 | .setup_irq = xilinx_pcie_msi_setup_irq, | 385 | .setup_irq = xilinx_pcie_msi_setup_irq, |
| 385 | .teardown_irq = xilinx_msi_teardown_irq, | 386 | .teardown_irq = xilinx_msi_teardown_irq, |
| 386 | }; | 387 | }; |
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index d9a92cf6a6d6..0260f3933211 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c | |||
| @@ -32,7 +32,7 @@ int pci_msi_ignore_mask; | |||
| 32 | 32 | ||
| 33 | int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc) | 33 | int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc) |
| 34 | { | 34 | { |
| 35 | struct msi_chip *chip = dev->bus->msi; | 35 | struct msi_controller *chip = dev->bus->msi; |
| 36 | int err; | 36 | int err; |
| 37 | 37 | ||
| 38 | if (!chip || !chip->setup_irq) | 38 | if (!chip || !chip->setup_irq) |
| @@ -49,7 +49,7 @@ int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc) | |||
| 49 | 49 | ||
| 50 | void __weak arch_teardown_msi_irq(unsigned int irq) | 50 | void __weak arch_teardown_msi_irq(unsigned int irq) |
| 51 | { | 51 | { |
| 52 | struct msi_chip *chip = irq_get_chip_data(irq); | 52 | struct msi_controller *chip = irq_get_chip_data(irq); |
| 53 | 53 | ||
| 54 | if (!chip || !chip->teardown_irq) | 54 | if (!chip || !chip->teardown_irq) |
| 55 | return; | 55 | return; |
