aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorAndreas Gruenbacher <agruen@linbit.com>2011-08-17 06:43:25 -0400
committerPhilipp Reisner <philipp.reisner@linbit.com>2012-11-08 10:58:02 -0500
commita209b4aec31d4b672b7a70f5de272ebf6ce40e1b (patch)
tree76d1b913a30423968b14101bb873db092e6aac59 /drivers
parentc4e7afdc01b9496f81653959dac8093030c8f286 (diff)
drbd: Update some outdated comments to match the code
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/block/drbd/drbd_bitmap.c4
-rw-r--r--drivers/block/drbd/drbd_nl.c2
-rw-r--r--drivers/block/drbd/drbd_req.c7
-rw-r--r--drivers/block/drbd/drbd_worker.c2
4 files changed, 7 insertions, 8 deletions
diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c
index 706e5220dd4a..092f8273e6bd 100644
--- a/drivers/block/drbd/drbd_bitmap.c
+++ b/drivers/block/drbd/drbd_bitmap.c
@@ -389,8 +389,8 @@ static struct page **bm_realloc_pages(struct drbd_bitmap *b, unsigned long want)
389 389
390 /* Trying kmalloc first, falling back to vmalloc. 390 /* Trying kmalloc first, falling back to vmalloc.
391 * GFP_KERNEL is ok, as this is done when a lower level disk is 391 * GFP_KERNEL is ok, as this is done when a lower level disk is
392 * "attached" to the drbd. Context is receiver thread or cqueue 392 * "attached" to the drbd. Context is receiver thread or drbdsetup /
393 * thread. As we have no disk yet, we are not in the IO path, 393 * netlink process. As we have no disk yet, we are not in the IO path,
394 * not even the IO path of the peer. */ 394 * not even the IO path of the peer. */
395 bytes = sizeof(struct page *)*want; 395 bytes = sizeof(struct page *)*want;
396 new_pages = kmalloc(bytes, GFP_KERNEL); 396 new_pages = kmalloc(bytes, GFP_KERNEL);
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 92adb3dc82c2..684e2e4d48e1 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -2038,7 +2038,7 @@ int drbd_adm_connect(struct sk_buff *skb, struct genl_info *info)
2038 goto fail; 2038 goto fail;
2039 } 2039 }
2040 2040
2041 /* allocation not in the IO path, cqueue thread context */ 2041 /* allocation not in the IO path, drbdsetup / netlink process context */
2042 new_conf = kzalloc(sizeof(*new_conf), GFP_KERNEL); 2042 new_conf = kzalloc(sizeof(*new_conf), GFP_KERNEL);
2043 if (!new_conf) { 2043 if (!new_conf) {
2044 retcode = ERR_NOMEM; 2044 retcode = ERR_NOMEM;
diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
index 60fc186d0a3d..d61309db14a2 100644
--- a/drivers/block/drbd/drbd_req.c
+++ b/drivers/block/drbd/drbd_req.c
@@ -292,13 +292,12 @@ void _req_may_be_done(struct drbd_request *req, struct bio_and_error *m)
292 292
293 if ((s & RQ_NET_MASK) == 0 || (s & RQ_NET_DONE)) { 293 if ((s & RQ_NET_MASK) == 0 || (s & RQ_NET_DONE)) {
294 /* this is disconnected (local only) operation, 294 /* this is disconnected (local only) operation,
295 * or protocol C P_WRITE_ACK, 295 * or protocol A, B, or C P_BARRIER_ACK,
296 * or protocol A or B P_BARRIER_ACK,
297 * or killed from the transfer log due to connection loss. */ 296 * or killed from the transfer log due to connection loss. */
298 _req_is_done(mdev, req, rw); 297 _req_is_done(mdev, req, rw);
299 } 298 }
300 /* else: network part and not DONE yet. that is 299 /* else: network part and not DONE yet. that is
301 * protocol A or B, barrier ack still pending... */ 300 * protocol A, B, or C, barrier ack still pending... */
302} 301}
303 302
304static void _req_may_be_done_not_susp(struct drbd_request *req, struct bio_and_error *m) 303static void _req_may_be_done_not_susp(struct drbd_request *req, struct bio_and_error *m)
@@ -668,7 +667,7 @@ int __req_mod(struct drbd_request *req, enum drbd_req_event what,
668 break; 667 break;
669 668
670 if (req->rq_state & RQ_NET_PENDING) { 669 if (req->rq_state & RQ_NET_PENDING) {
671 /* barrier came in before all requests have been acked. 670 /* barrier came in before all requests were acked.
672 * this is bad, because if the connection is lost now, 671 * this is bad, because if the connection is lost now,
673 * we won't be able to clean them up... */ 672 * we won't be able to clean them up... */
674 dev_err(DEV, "FIXME (BARRIER_ACKED but pending)\n"); 673 dev_err(DEV, "FIXME (BARRIER_ACKED but pending)\n");
diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index c57e47c0a1f5..34a6065d95e6 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -969,7 +969,7 @@ int w_e_end_data_req(struct drbd_work *w, int cancel)
969} 969}
970 970
971/** 971/**
972 * w_e_end_rsdata_req() - Worker callback to send a P_RS_DATA_REPLY packet in response to a P_RS_DATA_REQUESTRS 972 * w_e_end_rsdata_req() - Worker callback to send a P_RS_DATA_REPLY packet in response to a P_RS_DATA_REQUEST
973 * @mdev: DRBD device. 973 * @mdev: DRBD device.
974 * @w: work object. 974 * @w: work object.
975 * @cancel: The connection will be closed anyways 975 * @cancel: The connection will be closed anyways