diff options
author | Sarah Sharp <sarah.a.sharp@linux.intel.com> | 2010-01-04 15:20:17 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-03-02 17:54:01 -0500 |
commit | 9c9a7dbf9a73191a24a13b9a0412355254a122c7 (patch) | |
tree | 2e0a8a758e175b63505e5bf7803fff100e3ca63f /drivers | |
parent | c38b94017c74061cabc342d3222387e0a5e8b6cd (diff) |
USB: xhci: Fix compile issues with xhci_get_slot_state()
Randy Dunlap reported this error when compiling the xHCI driver:
linux-next-20100104/drivers/usb/host/xhci.h:1214:
sorry, unimplemented: inlining failed in call to 'xhci_get_slot_state': function body not available
The xhci_get_slot_state() function belongs in xhci-dbg.c, since it
involves debugging internal xHCI structures. However, it is only used in
xhci-hcd.c. Some toolchains may have issues since the inlined function
body is not in the xhci.h header file. Remove the inline keyword to avoid
this.
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/usb/host/xhci-dbg.c | 2 | ||||
-rw-r--r-- | drivers/usb/host/xhci.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c index b2915aea47ee..105fa8b025bb 100644 --- a/drivers/usb/host/xhci-dbg.c +++ b/drivers/usb/host/xhci-dbg.c | |||
@@ -406,7 +406,7 @@ static void dbg_rsvd64(struct xhci_hcd *xhci, u64 *ctx, dma_addr_t dma) | |||
406 | } | 406 | } |
407 | } | 407 | } |
408 | 408 | ||
409 | inline char *xhci_get_slot_state(struct xhci_hcd *xhci, | 409 | char *xhci_get_slot_state(struct xhci_hcd *xhci, |
410 | struct xhci_container_ctx *ctx) | 410 | struct xhci_container_ctx *ctx) |
411 | { | 411 | { |
412 | struct xhci_slot_ctx *slot_ctx = xhci_get_slot_ctx(xhci, ctx); | 412 | struct xhci_slot_ctx *slot_ctx = xhci_get_slot_ctx(xhci, ctx); |
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h index 741ece482e31..e5eb09b2f38e 100644 --- a/drivers/usb/host/xhci.h +++ b/drivers/usb/host/xhci.h | |||
@@ -1210,7 +1210,7 @@ void xhci_dbg_erst(struct xhci_hcd *xhci, struct xhci_erst *erst); | |||
1210 | void xhci_dbg_cmd_ptrs(struct xhci_hcd *xhci); | 1210 | void xhci_dbg_cmd_ptrs(struct xhci_hcd *xhci); |
1211 | void xhci_dbg_ring_ptrs(struct xhci_hcd *xhci, struct xhci_ring *ring); | 1211 | void xhci_dbg_ring_ptrs(struct xhci_hcd *xhci, struct xhci_ring *ring); |
1212 | void xhci_dbg_ctx(struct xhci_hcd *xhci, struct xhci_container_ctx *ctx, unsigned int last_ep); | 1212 | void xhci_dbg_ctx(struct xhci_hcd *xhci, struct xhci_container_ctx *ctx, unsigned int last_ep); |
1213 | inline char *xhci_get_slot_state(struct xhci_hcd *xhci, | 1213 | char *xhci_get_slot_state(struct xhci_hcd *xhci, |
1214 | struct xhci_container_ctx *ctx); | 1214 | struct xhci_container_ctx *ctx); |
1215 | 1215 | ||
1216 | /* xHCI memory management */ | 1216 | /* xHCI memory management */ |