diff options
author | Maciej Patelczyk <maciej.patelczyk@intel.com> | 2011-04-28 18:06:01 -0400 |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2011-07-03 07:00:38 -0400 |
commit | 9a0fff7bf0ffd4f57fc71d8075a92008b606eb61 (patch) | |
tree | 107921d78e26f44cb5e407773ebcfa142febf544 /drivers | |
parent | e76d80579c2b5b4ecac107b83c22ceeb9e23bd1b (diff) |
isci: Removed struct sci_base_object from state machine.
Changed any occurrence of struct sci_base_object into void.
Signed-off-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/scsi/isci/core/sci_base_state.h | 8 | ||||
-rw-r--r-- | drivers/scsi/isci/core/sci_base_state_machine.c | 2 | ||||
-rw-r--r-- | drivers/scsi/isci/core/sci_base_state_machine.h | 4 | ||||
-rw-r--r-- | drivers/scsi/isci/core/scic_sds_controller.c | 32 | ||||
-rw-r--r-- | drivers/scsi/isci/core/scic_sds_phy.c | 109 | ||||
-rw-r--r-- | drivers/scsi/isci/core/scic_sds_port.c | 68 | ||||
-rw-r--r-- | drivers/scsi/isci/core/scic_sds_request.c | 31 | ||||
-rw-r--r-- | drivers/scsi/isci/core/scic_sds_smp_request.c | 8 | ||||
-rw-r--r-- | drivers/scsi/isci/core/scic_sds_ssp_request.c | 8 | ||||
-rw-r--r-- | drivers/scsi/isci/core/scic_sds_stp_request.c | 24 | ||||
-rw-r--r-- | drivers/scsi/isci/remote_device.c | 28 | ||||
-rw-r--r-- | drivers/scsi/isci/remote_node_context.c | 22 | ||||
-rw-r--r-- | drivers/scsi/isci/smp_remote_device.c | 13 | ||||
-rw-r--r-- | drivers/scsi/isci/stp_remote_device.c | 16 |
14 files changed, 152 insertions, 221 deletions
diff --git a/drivers/scsi/isci/core/sci_base_state.h b/drivers/scsi/isci/core/sci_base_state.h index 4272a6f116de..62d2a7c30f07 100644 --- a/drivers/scsi/isci/core/sci_base_state.h +++ b/drivers/scsi/isci/core/sci_base_state.h | |||
@@ -58,13 +58,9 @@ | |||
58 | 58 | ||
59 | #include "sci_object.h" | 59 | #include "sci_object.h" |
60 | 60 | ||
61 | typedef void (*sci_base_state_handler_t)( | 61 | typedef void (*sci_base_state_handler_t)(void); |
62 | void | ||
63 | ); | ||
64 | 62 | ||
65 | typedef void (*sci_state_transition_t)( | 63 | typedef void (*sci_state_transition_t)(void *base_object); |
66 | struct sci_base_object *base_object | ||
67 | ); | ||
68 | 64 | ||
69 | /** | 65 | /** |
70 | * struct sci_base_state - The base state object abstracts the fields common to | 66 | * struct sci_base_state - The base state object abstracts the fields common to |
diff --git a/drivers/scsi/isci/core/sci_base_state_machine.c b/drivers/scsi/isci/core/sci_base_state_machine.c index bc416d504d7e..a704709eed87 100644 --- a/drivers/scsi/isci/core/sci_base_state_machine.c +++ b/drivers/scsi/isci/core/sci_base_state_machine.c | |||
@@ -100,7 +100,7 @@ static void sci_state_machine_enter_state(struct sci_base_state_machine *sm) | |||
100 | * | 100 | * |
101 | */ | 101 | */ |
102 | void sci_base_state_machine_construct(struct sci_base_state_machine *sm, | 102 | void sci_base_state_machine_construct(struct sci_base_state_machine *sm, |
103 | struct sci_base_object *owner, | 103 | void *owner, |
104 | const struct sci_base_state *state_table, | 104 | const struct sci_base_state *state_table, |
105 | u32 initial_state) | 105 | u32 initial_state) |
106 | { | 106 | { |
diff --git a/drivers/scsi/isci/core/sci_base_state_machine.h b/drivers/scsi/isci/core/sci_base_state_machine.h index 13f6ee80e15c..c0cf33bbecc8 100644 --- a/drivers/scsi/isci/core/sci_base_state_machine.h +++ b/drivers/scsi/isci/core/sci_base_state_machine.h | |||
@@ -94,7 +94,7 @@ struct sci_base_state_machine { | |||
94 | * associated. It serves as a cookie to be provided to the state | 94 | * associated. It serves as a cookie to be provided to the state |
95 | * enter/exit methods. | 95 | * enter/exit methods. |
96 | */ | 96 | */ |
97 | struct sci_base_object *state_machine_owner; | 97 | void *state_machine_owner; |
98 | 98 | ||
99 | /** | 99 | /** |
100 | * This field simply indicates the state value for the state machine's | 100 | * This field simply indicates the state value for the state machine's |
@@ -121,7 +121,7 @@ struct sci_base_state_machine { | |||
121 | 121 | ||
122 | void sci_base_state_machine_construct( | 122 | void sci_base_state_machine_construct( |
123 | struct sci_base_state_machine *this_state_machine, | 123 | struct sci_base_state_machine *this_state_machine, |
124 | struct sci_base_object *state_machine_owner, | 124 | void *state_machine_owner, |
125 | const struct sci_base_state *state_table, | 125 | const struct sci_base_state *state_table, |
126 | u32 initial_state); | 126 | u32 initial_state); |
127 | 127 | ||
diff --git a/drivers/scsi/isci/core/scic_sds_controller.c b/drivers/scsi/isci/core/scic_sds_controller.c index 5e8dea57b5ef..135aa3e5e132 100644 --- a/drivers/scsi/isci/core/scic_sds_controller.c +++ b/drivers/scsi/isci/core/scic_sds_controller.c | |||
@@ -2882,7 +2882,7 @@ enum sci_status scic_controller_start(struct scic_sds_controller *scic, | |||
2882 | 2882 | ||
2883 | /** | 2883 | /** |
2884 | * | 2884 | * |
2885 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_controller | 2885 | * @object: This is the object which is cast to a struct scic_sds_controller |
2886 | * object. | 2886 | * object. |
2887 | * | 2887 | * |
2888 | * This method implements the actions taken by the struct scic_sds_controller on entry | 2888 | * This method implements the actions taken by the struct scic_sds_controller on entry |
@@ -2890,8 +2890,7 @@ enum sci_status scic_controller_start(struct scic_sds_controller *scic, | |||
2890 | * controllers initial state. none This function should initialze the | 2890 | * controllers initial state. none This function should initialze the |
2891 | * controller object. | 2891 | * controller object. |
2892 | */ | 2892 | */ |
2893 | static void scic_sds_controller_initial_state_enter( | 2893 | static void scic_sds_controller_initial_state_enter(void *object) |
2894 | struct sci_base_object *object) | ||
2895 | { | 2894 | { |
2896 | struct scic_sds_controller *scic; | 2895 | struct scic_sds_controller *scic; |
2897 | 2896 | ||
@@ -2903,15 +2902,14 @@ static void scic_sds_controller_initial_state_enter( | |||
2903 | 2902 | ||
2904 | /** | 2903 | /** |
2905 | * | 2904 | * |
2906 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_controller | 2905 | * @object: This is the object which is cast to a struct scic_sds_controller |
2907 | * object. | 2906 | * object. |
2908 | * | 2907 | * |
2909 | * This method implements the actions taken by the struct scic_sds_controller on exit | 2908 | * This method implements the actions taken by the struct scic_sds_controller on exit |
2910 | * from the SCI_BASE_CONTROLLER_STATE_STARTING. - This function stops the | 2909 | * from the SCI_BASE_CONTROLLER_STATE_STARTING. - This function stops the |
2911 | * controller starting timeout timer. none | 2910 | * controller starting timeout timer. none |
2912 | */ | 2911 | */ |
2913 | static inline void scic_sds_controller_starting_state_exit( | 2912 | static inline void scic_sds_controller_starting_state_exit(void *object) |
2914 | struct sci_base_object *object) | ||
2915 | { | 2913 | { |
2916 | struct scic_sds_controller *scic = (struct scic_sds_controller *)object; | 2914 | struct scic_sds_controller *scic = (struct scic_sds_controller *)object; |
2917 | 2915 | ||
@@ -2920,15 +2918,14 @@ static inline void scic_sds_controller_starting_state_exit( | |||
2920 | 2918 | ||
2921 | /** | 2919 | /** |
2922 | * | 2920 | * |
2923 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_controller | 2921 | * @object: This is the object which is cast to a struct scic_sds_controller |
2924 | * object. | 2922 | * object. |
2925 | * | 2923 | * |
2926 | * This method implements the actions taken by the struct scic_sds_controller on entry | 2924 | * This method implements the actions taken by the struct scic_sds_controller on entry |
2927 | * to the SCI_BASE_CONTROLLER_STATE_READY. - Set the state handlers to the | 2925 | * to the SCI_BASE_CONTROLLER_STATE_READY. - Set the state handlers to the |
2928 | * controllers ready state. none | 2926 | * controllers ready state. none |
2929 | */ | 2927 | */ |
2930 | static void scic_sds_controller_ready_state_enter( | 2928 | static void scic_sds_controller_ready_state_enter(void *object) |
2931 | struct sci_base_object *object) | ||
2932 | { | 2929 | { |
2933 | struct scic_sds_controller *scic; | 2930 | struct scic_sds_controller *scic; |
2934 | 2931 | ||
@@ -2941,14 +2938,13 @@ static void scic_sds_controller_ready_state_enter( | |||
2941 | 2938 | ||
2942 | /** | 2939 | /** |
2943 | * | 2940 | * |
2944 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_controller | 2941 | * @object: This is the object which is cast to a struct scic_sds_controller |
2945 | * object. | 2942 | * object. |
2946 | * | 2943 | * |
2947 | * This method implements the actions taken by the struct scic_sds_controller on exit | 2944 | * This method implements the actions taken by the struct scic_sds_controller on exit |
2948 | * from the SCI_BASE_CONTROLLER_STATE_READY. - This function does nothing. none | 2945 | * from the SCI_BASE_CONTROLLER_STATE_READY. - This function does nothing. none |
2949 | */ | 2946 | */ |
2950 | static void scic_sds_controller_ready_state_exit( | 2947 | static void scic_sds_controller_ready_state_exit(void *object) |
2951 | struct sci_base_object *object) | ||
2952 | { | 2948 | { |
2953 | struct scic_sds_controller *scic; | 2949 | struct scic_sds_controller *scic; |
2954 | 2950 | ||
@@ -2960,7 +2956,7 @@ static void scic_sds_controller_ready_state_exit( | |||
2960 | 2956 | ||
2961 | /** | 2957 | /** |
2962 | * | 2958 | * |
2963 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_controller | 2959 | * @object: This is the object which is cast to a struct scic_sds_controller |
2964 | * object. | 2960 | * object. |
2965 | * | 2961 | * |
2966 | * This method implements the actions taken by the struct scic_sds_controller on entry | 2962 | * This method implements the actions taken by the struct scic_sds_controller on entry |
@@ -2968,8 +2964,7 @@ static void scic_sds_controller_ready_state_exit( | |||
2968 | * controllers ready state. - Stop the phys on this controller - Stop the ports | 2964 | * controllers ready state. - Stop the phys on this controller - Stop the ports |
2969 | * on this controller - Stop all of the remote devices on this controller none | 2965 | * on this controller - Stop all of the remote devices on this controller none |
2970 | */ | 2966 | */ |
2971 | static void scic_sds_controller_stopping_state_enter( | 2967 | static void scic_sds_controller_stopping_state_enter(void *object) |
2972 | struct sci_base_object *object) | ||
2973 | { | 2968 | { |
2974 | struct scic_sds_controller *scic; | 2969 | struct scic_sds_controller *scic; |
2975 | 2970 | ||
@@ -2983,15 +2978,14 @@ static void scic_sds_controller_stopping_state_enter( | |||
2983 | 2978 | ||
2984 | /** | 2979 | /** |
2985 | * | 2980 | * |
2986 | * @object: This is the struct sci_base_object which is cast to a struct | 2981 | * @object: This is the object which is cast to a struct |
2987 | * scic_sds_controller object. | 2982 | * scic_sds_controller object. |
2988 | * | 2983 | * |
2989 | * This funciton implements the actions taken by the struct scic_sds_controller | 2984 | * This funciton implements the actions taken by the struct scic_sds_controller |
2990 | * on exit from the SCI_BASE_CONTROLLER_STATE_STOPPING. - | 2985 | * on exit from the SCI_BASE_CONTROLLER_STATE_STOPPING. - |
2991 | * This function stops the controller stopping timeout timer. | 2986 | * This function stops the controller stopping timeout timer. |
2992 | */ | 2987 | */ |
2993 | static inline void scic_sds_controller_stopping_state_exit( | 2988 | static inline void scic_sds_controller_stopping_state_exit(void *object) |
2994 | struct sci_base_object *object) | ||
2995 | { | 2989 | { |
2996 | struct scic_sds_controller *scic = | 2990 | struct scic_sds_controller *scic = |
2997 | (struct scic_sds_controller *)object; | 2991 | (struct scic_sds_controller *)object; |
@@ -2999,7 +2993,7 @@ static inline void scic_sds_controller_stopping_state_exit( | |||
2999 | isci_timer_stop(scic->timeout_timer); | 2993 | isci_timer_stop(scic->timeout_timer); |
3000 | } | 2994 | } |
3001 | 2995 | ||
3002 | static void scic_sds_controller_resetting_state_enter(struct sci_base_object *object) | 2996 | static void scic_sds_controller_resetting_state_enter(void *object) |
3003 | { | 2997 | { |
3004 | struct scic_sds_controller *scic; | 2998 | struct scic_sds_controller *scic; |
3005 | 2999 | ||
diff --git a/drivers/scsi/isci/core/scic_sds_phy.c b/drivers/scsi/isci/core/scic_sds_phy.c index 09018466f993..972b977a7c11 100644 --- a/drivers/scsi/isci/core/scic_sds_phy.c +++ b/drivers/scsi/isci/core/scic_sds_phy.c | |||
@@ -1556,14 +1556,14 @@ static const struct scic_sds_phy_state_handler scic_sds_phy_starting_substate_ha | |||
1556 | 1556 | ||
1557 | /** | 1557 | /** |
1558 | * scic_sds_phy_starting_initial_substate_enter - | 1558 | * scic_sds_phy_starting_initial_substate_enter - |
1559 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 1559 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1560 | * | 1560 | * |
1561 | * This method will perform the actions required by the struct scic_sds_phy on | 1561 | * This method will perform the actions required by the struct scic_sds_phy on |
1562 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_INITIAL. - The initial state | 1562 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_INITIAL. - The initial state |
1563 | * handlers are put in place for the struct scic_sds_phy object. - The state is | 1563 | * handlers are put in place for the struct scic_sds_phy object. - The state is |
1564 | * changed to the wait phy type event notification. none | 1564 | * changed to the wait phy type event notification. none |
1565 | */ | 1565 | */ |
1566 | static void scic_sds_phy_starting_initial_substate_enter(struct sci_base_object *object) | 1566 | static void scic_sds_phy_starting_initial_substate_enter(void *object) |
1567 | { | 1567 | { |
1568 | struct scic_sds_phy *sci_phy; | 1568 | struct scic_sds_phy *sci_phy; |
1569 | 1569 | ||
@@ -1579,14 +1579,13 @@ static void scic_sds_phy_starting_initial_substate_enter(struct sci_base_object | |||
1579 | 1579 | ||
1580 | /** | 1580 | /** |
1581 | * | 1581 | * |
1582 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 1582 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1583 | * | 1583 | * |
1584 | * This method will perform the actions required by the struct scic_sds_phy on | 1584 | * This method will perform the actions required by the struct scic_sds_phy on |
1585 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_PHY_TYPE_EN. - Set the | 1585 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_PHY_TYPE_EN. - Set the |
1586 | * struct scic_sds_phy object state handlers for this state. none | 1586 | * struct scic_sds_phy object state handlers for this state. none |
1587 | */ | 1587 | */ |
1588 | static void scic_sds_phy_starting_await_ossp_en_substate_enter( | 1588 | static void scic_sds_phy_starting_await_ossp_en_substate_enter(void *object) |
1589 | struct sci_base_object *object) | ||
1590 | { | 1589 | { |
1591 | struct scic_sds_phy *sci_phy; | 1590 | struct scic_sds_phy *sci_phy; |
1592 | 1591 | ||
@@ -1599,14 +1598,14 @@ static void scic_sds_phy_starting_await_ossp_en_substate_enter( | |||
1599 | 1598 | ||
1600 | /** | 1599 | /** |
1601 | * | 1600 | * |
1602 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 1601 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1603 | * | 1602 | * |
1604 | * This method will perform the actions required by the struct scic_sds_phy on | 1603 | * This method will perform the actions required by the struct scic_sds_phy on |
1605 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SPEED_EN. - Set the | 1604 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SPEED_EN. - Set the |
1606 | * struct scic_sds_phy object state handlers for this state. none | 1605 | * struct scic_sds_phy object state handlers for this state. none |
1607 | */ | 1606 | */ |
1608 | static void scic_sds_phy_starting_await_sas_speed_en_substate_enter( | 1607 | static void scic_sds_phy_starting_await_sas_speed_en_substate_enter( |
1609 | struct sci_base_object *object) | 1608 | void *object) |
1610 | { | 1609 | { |
1611 | struct scic_sds_phy *sci_phy; | 1610 | struct scic_sds_phy *sci_phy; |
1612 | 1611 | ||
@@ -1619,14 +1618,13 @@ static void scic_sds_phy_starting_await_sas_speed_en_substate_enter( | |||
1619 | 1618 | ||
1620 | /** | 1619 | /** |
1621 | * | 1620 | * |
1622 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 1621 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1623 | * | 1622 | * |
1624 | * This method will perform the actions required by the struct scic_sds_phy on | 1623 | * This method will perform the actions required by the struct scic_sds_phy on |
1625 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_IAF_UF. - Set the | 1624 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_IAF_UF. - Set the |
1626 | * struct scic_sds_phy object state handlers for this state. none | 1625 | * struct scic_sds_phy object state handlers for this state. none |
1627 | */ | 1626 | */ |
1628 | static void scic_sds_phy_starting_await_iaf_uf_substate_enter( | 1627 | static void scic_sds_phy_starting_await_iaf_uf_substate_enter(void *object) |
1629 | struct sci_base_object *object) | ||
1630 | { | 1628 | { |
1631 | struct scic_sds_phy *sci_phy; | 1629 | struct scic_sds_phy *sci_phy; |
1632 | 1630 | ||
@@ -1639,15 +1637,14 @@ static void scic_sds_phy_starting_await_iaf_uf_substate_enter( | |||
1639 | 1637 | ||
1640 | /** | 1638 | /** |
1641 | * | 1639 | * |
1642 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 1640 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1643 | * | 1641 | * |
1644 | * This method will perform the actions required by the struct scic_sds_phy on | 1642 | * This method will perform the actions required by the struct scic_sds_phy on |
1645 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SAS_POWER. - Set the | 1643 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SAS_POWER. - Set the |
1646 | * struct scic_sds_phy object state handlers for this state. - Add this phy object to | 1644 | * struct scic_sds_phy object state handlers for this state. - Add this phy object to |
1647 | * the power control queue none | 1645 | * the power control queue none |
1648 | */ | 1646 | */ |
1649 | static void scic_sds_phy_starting_await_sas_power_substate_enter( | 1647 | static void scic_sds_phy_starting_await_sas_power_substate_enter(void *object) |
1650 | struct sci_base_object *object) | ||
1651 | { | 1648 | { |
1652 | struct scic_sds_phy *sci_phy; | 1649 | struct scic_sds_phy *sci_phy; |
1653 | 1650 | ||
@@ -1665,14 +1662,13 @@ static void scic_sds_phy_starting_await_sas_power_substate_enter( | |||
1665 | 1662 | ||
1666 | /** | 1663 | /** |
1667 | * | 1664 | * |
1668 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 1665 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1669 | * | 1666 | * |
1670 | * This method will perform the actions required by the struct scic_sds_phy on exiting | 1667 | * This method will perform the actions required by the struct scic_sds_phy on exiting |
1671 | * the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SAS_POWER. - Remove the | 1668 | * the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SAS_POWER. - Remove the |
1672 | * struct scic_sds_phy object from the power control queue. none | 1669 | * struct scic_sds_phy object from the power control queue. none |
1673 | */ | 1670 | */ |
1674 | static void scic_sds_phy_starting_await_sas_power_substate_exit( | 1671 | static void scic_sds_phy_starting_await_sas_power_substate_exit(void *object) |
1675 | struct sci_base_object *object) | ||
1676 | { | 1672 | { |
1677 | struct scic_sds_phy *sci_phy; | 1673 | struct scic_sds_phy *sci_phy; |
1678 | 1674 | ||
@@ -1685,15 +1681,14 @@ static void scic_sds_phy_starting_await_sas_power_substate_exit( | |||
1685 | 1681 | ||
1686 | /** | 1682 | /** |
1687 | * | 1683 | * |
1688 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 1684 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1689 | * | 1685 | * |
1690 | * This method will perform the actions required by the struct scic_sds_phy on | 1686 | * This method will perform the actions required by the struct scic_sds_phy on |
1691 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_POWER. - Set the | 1687 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_POWER. - Set the |
1692 | * struct scic_sds_phy object state handlers for this state. - Add this phy object to | 1688 | * struct scic_sds_phy object state handlers for this state. - Add this phy object to |
1693 | * the power control queue none | 1689 | * the power control queue none |
1694 | */ | 1690 | */ |
1695 | static void scic_sds_phy_starting_await_sata_power_substate_enter( | 1691 | static void scic_sds_phy_starting_await_sata_power_substate_enter(void *object) |
1696 | struct sci_base_object *object) | ||
1697 | { | 1692 | { |
1698 | struct scic_sds_phy *sci_phy; | 1693 | struct scic_sds_phy *sci_phy; |
1699 | 1694 | ||
@@ -1711,14 +1706,13 @@ static void scic_sds_phy_starting_await_sata_power_substate_enter( | |||
1711 | 1706 | ||
1712 | /** | 1707 | /** |
1713 | * | 1708 | * |
1714 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 1709 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1715 | * | 1710 | * |
1716 | * This method will perform the actions required by the struct scic_sds_phy on exiting | 1711 | * This method will perform the actions required by the struct scic_sds_phy on exiting |
1717 | * the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_POWER. - Remove the | 1712 | * the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_POWER. - Remove the |
1718 | * struct scic_sds_phy object from the power control queue. none | 1713 | * struct scic_sds_phy object from the power control queue. none |
1719 | */ | 1714 | */ |
1720 | static void scic_sds_phy_starting_await_sata_power_substate_exit( | 1715 | static void scic_sds_phy_starting_await_sata_power_substate_exit(void *object) |
1721 | struct sci_base_object *object) | ||
1722 | { | 1716 | { |
1723 | struct scic_sds_phy *sci_phy; | 1717 | struct scic_sds_phy *sci_phy; |
1724 | 1718 | ||
@@ -1732,15 +1726,13 @@ static void scic_sds_phy_starting_await_sata_power_substate_exit( | |||
1732 | 1726 | ||
1733 | /** | 1727 | /** |
1734 | * | 1728 | * |
1735 | * @object: This is the struct sci_base_object which is cast to a | 1729 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1736 | * struct scic_sds_phy object. | ||
1737 | * | 1730 | * |
1738 | * This function will perform the actions required by the struct scic_sds_phy on | 1731 | * This function will perform the actions required by the struct scic_sds_phy on |
1739 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_PHY_EN. - Set the | 1732 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_PHY_EN. - Set the |
1740 | * struct scic_sds_phy object state handlers for this state. none | 1733 | * struct scic_sds_phy object state handlers for this state. none |
1741 | */ | 1734 | */ |
1742 | static void scic_sds_phy_starting_await_sata_phy_substate_enter( | 1735 | static void scic_sds_phy_starting_await_sata_phy_substate_enter(void *object) |
1743 | struct sci_base_object *object) | ||
1744 | { | 1736 | { |
1745 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; | 1737 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; |
1746 | 1738 | ||
@@ -1754,8 +1746,7 @@ static void scic_sds_phy_starting_await_sata_phy_substate_enter( | |||
1754 | 1746 | ||
1755 | /** | 1747 | /** |
1756 | * | 1748 | * |
1757 | * @object: This is the struct sci_base_object which is cast to a | 1749 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1758 | * struct scic_sds_phy object. | ||
1759 | * | 1750 | * |
1760 | * This method will perform the actions required by the struct scic_sds_phy | 1751 | * This method will perform the actions required by the struct scic_sds_phy |
1761 | * on exiting | 1752 | * on exiting |
@@ -1763,7 +1754,7 @@ static void scic_sds_phy_starting_await_sata_phy_substate_enter( | |||
1763 | * that was started on entry to await sata phy event notification none | 1754 | * that was started on entry to await sata phy event notification none |
1764 | */ | 1755 | */ |
1765 | static inline void scic_sds_phy_starting_await_sata_phy_substate_exit( | 1756 | static inline void scic_sds_phy_starting_await_sata_phy_substate_exit( |
1766 | struct sci_base_object *object) | 1757 | void *object) |
1767 | { | 1758 | { |
1768 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; | 1759 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; |
1769 | 1760 | ||
@@ -1772,14 +1763,13 @@ static inline void scic_sds_phy_starting_await_sata_phy_substate_exit( | |||
1772 | 1763 | ||
1773 | /** | 1764 | /** |
1774 | * | 1765 | * |
1775 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 1766 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1776 | * | 1767 | * |
1777 | * This method will perform the actions required by the struct scic_sds_phy on | 1768 | * This method will perform the actions required by the struct scic_sds_phy on |
1778 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_SPEED_EN. - Set the | 1769 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SATA_SPEED_EN. - Set the |
1779 | * struct scic_sds_phy object state handlers for this state. none | 1770 | * struct scic_sds_phy object state handlers for this state. none |
1780 | */ | 1771 | */ |
1781 | static void scic_sds_phy_starting_await_sata_speed_substate_enter( | 1772 | static void scic_sds_phy_starting_await_sata_speed_substate_enter(void *object) |
1782 | struct sci_base_object *object) | ||
1783 | { | 1773 | { |
1784 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; | 1774 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; |
1785 | 1775 | ||
@@ -1793,8 +1783,7 @@ static void scic_sds_phy_starting_await_sata_speed_substate_enter( | |||
1793 | 1783 | ||
1794 | /** | 1784 | /** |
1795 | * | 1785 | * |
1796 | * @object: This is the struct sci_base_object which is cast to a | 1786 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1797 | * struct scic_sds_phy object. | ||
1798 | * | 1787 | * |
1799 | * This function will perform the actions required by the | 1788 | * This function will perform the actions required by the |
1800 | * struct scic_sds_phy on exiting | 1789 | * struct scic_sds_phy on exiting |
@@ -1802,7 +1791,7 @@ static void scic_sds_phy_starting_await_sata_speed_substate_enter( | |||
1802 | * that was started on entry to await sata phy event notification none | 1791 | * that was started on entry to await sata phy event notification none |
1803 | */ | 1792 | */ |
1804 | static inline void scic_sds_phy_starting_await_sata_speed_substate_exit( | 1793 | static inline void scic_sds_phy_starting_await_sata_speed_substate_exit( |
1805 | struct sci_base_object *object) | 1794 | void *object) |
1806 | { | 1795 | { |
1807 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; | 1796 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; |
1808 | 1797 | ||
@@ -1811,8 +1800,7 @@ static inline void scic_sds_phy_starting_await_sata_speed_substate_exit( | |||
1811 | 1800 | ||
1812 | /** | 1801 | /** |
1813 | * | 1802 | * |
1814 | * @object: This is the struct sci_base_object which is cast to a | 1803 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1815 | * struct scic_sds_phy object. | ||
1816 | * | 1804 | * |
1817 | * This function will perform the actions required by the struct scic_sds_phy on | 1805 | * This function will perform the actions required by the struct scic_sds_phy on |
1818 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SIG_FIS_UF. - Set the | 1806 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_AWAIT_SIG_FIS_UF. - Set the |
@@ -1820,8 +1808,7 @@ static inline void scic_sds_phy_starting_await_sata_speed_substate_exit( | |||
1820 | * - Start the SIGNATURE FIS | 1808 | * - Start the SIGNATURE FIS |
1821 | * timeout timer none | 1809 | * timeout timer none |
1822 | */ | 1810 | */ |
1823 | static void scic_sds_phy_starting_await_sig_fis_uf_substate_enter( | 1811 | static void scic_sds_phy_starting_await_sig_fis_uf_substate_enter(void *object) |
1824 | struct sci_base_object *object) | ||
1825 | { | 1812 | { |
1826 | bool continue_to_ready_state; | 1813 | bool continue_to_ready_state; |
1827 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; | 1814 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; |
@@ -1851,8 +1838,7 @@ static void scic_sds_phy_starting_await_sig_fis_uf_substate_enter( | |||
1851 | 1838 | ||
1852 | /** | 1839 | /** |
1853 | * | 1840 | * |
1854 | * @object: This is the struct sci_base_object which is cast to a | 1841 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1855 | * struct scic_sds_phy object. | ||
1856 | * | 1842 | * |
1857 | * This function will perform the actions required by the | 1843 | * This function will perform the actions required by the |
1858 | * struct scic_sds_phy on exiting | 1844 | * struct scic_sds_phy on exiting |
@@ -1860,7 +1846,7 @@ static void scic_sds_phy_starting_await_sig_fis_uf_substate_enter( | |||
1860 | * FIS timeout timer. none | 1846 | * FIS timeout timer. none |
1861 | */ | 1847 | */ |
1862 | static inline void scic_sds_phy_starting_await_sig_fis_uf_substate_exit( | 1848 | static inline void scic_sds_phy_starting_await_sig_fis_uf_substate_exit( |
1863 | struct sci_base_object *object) | 1849 | void *object) |
1864 | { | 1850 | { |
1865 | struct scic_sds_phy *sci_phy; | 1851 | struct scic_sds_phy *sci_phy; |
1866 | 1852 | ||
@@ -1871,14 +1857,14 @@ static inline void scic_sds_phy_starting_await_sig_fis_uf_substate_exit( | |||
1871 | 1857 | ||
1872 | /** | 1858 | /** |
1873 | * | 1859 | * |
1874 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 1860 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
1875 | * | 1861 | * |
1876 | * This method will perform the actions required by the struct scic_sds_phy on | 1862 | * This method will perform the actions required by the struct scic_sds_phy on |
1877 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_FINAL. - Set the struct scic_sds_phy | 1863 | * entering the SCIC_SDS_PHY_STARTING_SUBSTATE_FINAL. - Set the struct scic_sds_phy |
1878 | * object state handlers for this state. - Change base state machine to the | 1864 | * object state handlers for this state. - Change base state machine to the |
1879 | * ready state. none | 1865 | * ready state. none |
1880 | */ | 1866 | */ |
1881 | static void scic_sds_phy_starting_final_substate_enter(struct sci_base_object *object) | 1867 | static void scic_sds_phy_starting_final_substate_enter(void *object) |
1882 | { | 1868 | { |
1883 | struct scic_sds_phy *sci_phy; | 1869 | struct scic_sds_phy *sci_phy; |
1884 | 1870 | ||
@@ -2206,14 +2192,13 @@ static void scu_link_layer_tx_hard_reset( | |||
2206 | 2192 | ||
2207 | /** | 2193 | /** |
2208 | * | 2194 | * |
2209 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 2195 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
2210 | * | 2196 | * |
2211 | * This method will perform the actions required by the struct scic_sds_phy on | 2197 | * This method will perform the actions required by the struct scic_sds_phy on |
2212 | * entering the SCI_BASE_PHY_STATE_INITIAL. - This function sets the state | 2198 | * entering the SCI_BASE_PHY_STATE_INITIAL. - This function sets the state |
2213 | * handlers for the phy object base state machine initial state. none | 2199 | * handlers for the phy object base state machine initial state. none |
2214 | */ | 2200 | */ |
2215 | static void scic_sds_phy_initial_state_enter( | 2201 | static void scic_sds_phy_initial_state_enter(void *object) |
2216 | struct sci_base_object *object) | ||
2217 | { | 2202 | { |
2218 | struct scic_sds_phy *sci_phy; | 2203 | struct scic_sds_phy *sci_phy; |
2219 | 2204 | ||
@@ -2224,15 +2209,14 @@ static void scic_sds_phy_initial_state_enter( | |||
2224 | 2209 | ||
2225 | /** | 2210 | /** |
2226 | * | 2211 | * |
2227 | * @object: This is the struct sci_base_object which is cast to a | 2212 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
2228 | * struct scic_sds_phy object. | ||
2229 | * | 2213 | * |
2230 | * This function will perform the actions required by the struct scic_sds_phy on | 2214 | * This function will perform the actions required by the struct scic_sds_phy on |
2231 | * entering the SCI_BASE_PHY_STATE_INITIAL. - This function sets the state | 2215 | * entering the SCI_BASE_PHY_STATE_INITIAL. - This function sets the state |
2232 | * handlers for the phy object base state machine initial state. - The SCU | 2216 | * handlers for the phy object base state machine initial state. - The SCU |
2233 | * hardware is requested to stop the protocol engine. none | 2217 | * hardware is requested to stop the protocol engine. none |
2234 | */ | 2218 | */ |
2235 | static void scic_sds_phy_stopped_state_enter(struct sci_base_object *object) | 2219 | static void scic_sds_phy_stopped_state_enter(void *object) |
2236 | { | 2220 | { |
2237 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; | 2221 | struct scic_sds_phy *sci_phy = (struct scic_sds_phy *)object; |
2238 | struct scic_sds_controller *scic = scic_sds_phy_get_controller(sci_phy); | 2222 | struct scic_sds_controller *scic = scic_sds_phy_get_controller(sci_phy); |
@@ -2266,7 +2250,7 @@ static void scic_sds_phy_stopped_state_enter(struct sci_base_object *object) | |||
2266 | 2250 | ||
2267 | /** | 2251 | /** |
2268 | * | 2252 | * |
2269 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 2253 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
2270 | * | 2254 | * |
2271 | * This method will perform the actions required by the struct scic_sds_phy on | 2255 | * This method will perform the actions required by the struct scic_sds_phy on |
2272 | * entering the SCI_BASE_PHY_STATE_STARTING. - This function sets the state | 2256 | * entering the SCI_BASE_PHY_STATE_STARTING. - This function sets the state |
@@ -2276,8 +2260,7 @@ static void scic_sds_phy_stopped_state_enter(struct sci_base_object *object) | |||
2276 | * state then the struct scic_sds_controller is informed that the phy has gone link | 2260 | * state then the struct scic_sds_controller is informed that the phy has gone link |
2277 | * down. none | 2261 | * down. none |
2278 | */ | 2262 | */ |
2279 | static void scic_sds_phy_starting_state_enter( | 2263 | static void scic_sds_phy_starting_state_enter(void *object) |
2280 | struct sci_base_object *object) | ||
2281 | { | 2264 | { |
2282 | struct scic_sds_phy *sci_phy; | 2265 | struct scic_sds_phy *sci_phy; |
2283 | 2266 | ||
@@ -2307,7 +2290,7 @@ static void scic_sds_phy_starting_state_enter( | |||
2307 | 2290 | ||
2308 | /** | 2291 | /** |
2309 | * | 2292 | * |
2310 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 2293 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
2311 | * | 2294 | * |
2312 | * This method will perform the actions required by the struct scic_sds_phy on | 2295 | * This method will perform the actions required by the struct scic_sds_phy on |
2313 | * entering the SCI_BASE_PHY_STATE_READY. - This function sets the state | 2296 | * entering the SCI_BASE_PHY_STATE_READY. - This function sets the state |
@@ -2315,8 +2298,7 @@ static void scic_sds_phy_starting_state_enter( | |||
2315 | * hardware protocol engine is resumed. - The struct scic_sds_controller is informed | 2298 | * hardware protocol engine is resumed. - The struct scic_sds_controller is informed |
2316 | * that the phy object has gone link up. none | 2299 | * that the phy object has gone link up. none |
2317 | */ | 2300 | */ |
2318 | static void scic_sds_phy_ready_state_enter( | 2301 | static void scic_sds_phy_ready_state_enter(void *object) |
2319 | struct sci_base_object *object) | ||
2320 | { | 2302 | { |
2321 | struct scic_sds_phy *sci_phy; | 2303 | struct scic_sds_phy *sci_phy; |
2322 | 2304 | ||
@@ -2333,14 +2315,13 @@ static void scic_sds_phy_ready_state_enter( | |||
2333 | 2315 | ||
2334 | /** | 2316 | /** |
2335 | * | 2317 | * |
2336 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 2318 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
2337 | * | 2319 | * |
2338 | * This method will perform the actions required by the struct scic_sds_phy on exiting | 2320 | * This method will perform the actions required by the struct scic_sds_phy on exiting |
2339 | * the SCI_BASE_PHY_STATE_INITIAL. This function suspends the SCU hardware | 2321 | * the SCI_BASE_PHY_STATE_INITIAL. This function suspends the SCU hardware |
2340 | * protocol engine represented by this struct scic_sds_phy object. none | 2322 | * protocol engine represented by this struct scic_sds_phy object. none |
2341 | */ | 2323 | */ |
2342 | static void scic_sds_phy_ready_state_exit( | 2324 | static void scic_sds_phy_ready_state_exit(void *object) |
2343 | struct sci_base_object *object) | ||
2344 | { | 2325 | { |
2345 | struct scic_sds_phy *sci_phy; | 2326 | struct scic_sds_phy *sci_phy; |
2346 | 2327 | ||
@@ -2351,14 +2332,13 @@ static void scic_sds_phy_ready_state_exit( | |||
2351 | 2332 | ||
2352 | /** | 2333 | /** |
2353 | * | 2334 | * |
2354 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 2335 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
2355 | * | 2336 | * |
2356 | * This method will perform the actions required by the struct scic_sds_phy on | 2337 | * This method will perform the actions required by the struct scic_sds_phy on |
2357 | * entering the SCI_BASE_PHY_STATE_RESETTING. - This function sets the state | 2338 | * entering the SCI_BASE_PHY_STATE_RESETTING. - This function sets the state |
2358 | * handlers for the phy object base state machine resetting state. none | 2339 | * handlers for the phy object base state machine resetting state. none |
2359 | */ | 2340 | */ |
2360 | static void scic_sds_phy_resetting_state_enter( | 2341 | static void scic_sds_phy_resetting_state_enter(void *object) |
2361 | struct sci_base_object *object) | ||
2362 | { | 2342 | { |
2363 | struct scic_sds_phy *sci_phy; | 2343 | struct scic_sds_phy *sci_phy; |
2364 | 2344 | ||
@@ -2387,14 +2367,13 @@ static void scic_sds_phy_resetting_state_enter( | |||
2387 | 2367 | ||
2388 | /** | 2368 | /** |
2389 | * | 2369 | * |
2390 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_phy object. | 2370 | * @object: This is the object which is cast to a struct scic_sds_phy object. |
2391 | * | 2371 | * |
2392 | * This method will perform the actions required by the struct scic_sds_phy on | 2372 | * This method will perform the actions required by the struct scic_sds_phy on |
2393 | * entering the SCI_BASE_PHY_STATE_FINAL. - This function sets the state | 2373 | * entering the SCI_BASE_PHY_STATE_FINAL. - This function sets the state |
2394 | * handlers for the phy object base state machine final state. none | 2374 | * handlers for the phy object base state machine final state. none |
2395 | */ | 2375 | */ |
2396 | static void scic_sds_phy_final_state_enter( | 2376 | static void scic_sds_phy_final_state_enter(void *object) |
2397 | struct sci_base_object *object) | ||
2398 | { | 2377 | { |
2399 | struct scic_sds_phy *sci_phy; | 2378 | struct scic_sds_phy *sci_phy; |
2400 | 2379 | ||
diff --git a/drivers/scsi/isci/core/scic_sds_port.c b/drivers/scsi/isci/core/scic_sds_port.c index 057f95a79be9..1cbf1d6b2f9a 100644 --- a/drivers/scsi/isci/core/scic_sds_port.c +++ b/drivers/scsi/isci/core/scic_sds_port.c | |||
@@ -1623,15 +1623,14 @@ scic_sds_port_resume_port_task_scheduler(struct scic_sds_port *port) | |||
1623 | 1623 | ||
1624 | /** | 1624 | /** |
1625 | * | 1625 | * |
1626 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_port object. | 1626 | * @object: This is the object which is cast to a struct scic_sds_port object. |
1627 | * | 1627 | * |
1628 | * This method will perform the actions required by the struct scic_sds_port on | 1628 | * This method will perform the actions required by the struct scic_sds_port on |
1629 | * entering the SCIC_SDS_PORT_READY_SUBSTATE_WAITING. This function checks the | 1629 | * entering the SCIC_SDS_PORT_READY_SUBSTATE_WAITING. This function checks the |
1630 | * port for any ready phys. If there is at least one phy in a ready state then | 1630 | * port for any ready phys. If there is at least one phy in a ready state then |
1631 | * the port transitions to the ready operational substate. none | 1631 | * the port transitions to the ready operational substate. none |
1632 | */ | 1632 | */ |
1633 | static void scic_sds_port_ready_substate_waiting_enter( | 1633 | static void scic_sds_port_ready_substate_waiting_enter(void *object) |
1634 | struct sci_base_object *object) | ||
1635 | { | 1634 | { |
1636 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; | 1635 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; |
1637 | 1636 | ||
@@ -1654,16 +1653,14 @@ static void scic_sds_port_ready_substate_waiting_enter( | |||
1654 | 1653 | ||
1655 | /** | 1654 | /** |
1656 | * | 1655 | * |
1657 | * @object: This is the struct sci_base_object which is cast to a | 1656 | * @object: This is the object which is cast to a struct scic_sds_port object. |
1658 | * struct scic_sds_port object. | ||
1659 | * | 1657 | * |
1660 | * This function will perform the actions required by the struct scic_sds_port | 1658 | * This function will perform the actions required by the struct scic_sds_port |
1661 | * on entering the SCIC_SDS_PORT_READY_SUBSTATE_OPERATIONAL. This function sets | 1659 | * on entering the SCIC_SDS_PORT_READY_SUBSTATE_OPERATIONAL. This function sets |
1662 | * the state handlers for the port object, notifies the SCI User that the port | 1660 | * the state handlers for the port object, notifies the SCI User that the port |
1663 | * is ready, and resumes port operations. none | 1661 | * is ready, and resumes port operations. none |
1664 | */ | 1662 | */ |
1665 | static void scic_sds_port_ready_substate_operational_enter( | 1663 | static void scic_sds_port_ready_substate_operational_enter(void *object) |
1666 | struct sci_base_object *object) | ||
1667 | { | 1664 | { |
1668 | u32 index; | 1665 | u32 index; |
1669 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; | 1666 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; |
@@ -1699,14 +1696,13 @@ static void scic_sds_port_ready_substate_operational_enter( | |||
1699 | 1696 | ||
1700 | /** | 1697 | /** |
1701 | * | 1698 | * |
1702 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_port object. | 1699 | * @object: This is the object which is cast to a struct scic_sds_port object. |
1703 | * | 1700 | * |
1704 | * This method will perform the actions required by the struct scic_sds_port on | 1701 | * This method will perform the actions required by the struct scic_sds_port on |
1705 | * exiting the SCIC_SDS_PORT_READY_SUBSTATE_OPERATIONAL. This function reports | 1702 | * exiting the SCIC_SDS_PORT_READY_SUBSTATE_OPERATIONAL. This function reports |
1706 | * the port not ready and suspends the port task scheduler. none | 1703 | * the port not ready and suspends the port task scheduler. none |
1707 | */ | 1704 | */ |
1708 | static void scic_sds_port_ready_substate_operational_exit( | 1705 | static void scic_sds_port_ready_substate_operational_exit(void *object) |
1709 | struct sci_base_object *object) | ||
1710 | { | 1706 | { |
1711 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; | 1707 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; |
1712 | struct scic_sds_controller *scic = | 1708 | struct scic_sds_controller *scic = |
@@ -1731,15 +1727,13 @@ static void scic_sds_port_ready_substate_operational_exit( | |||
1731 | 1727 | ||
1732 | /** | 1728 | /** |
1733 | * scic_sds_port_ready_substate_configuring_enter() - | 1729 | * scic_sds_port_ready_substate_configuring_enter() - |
1734 | * @object: This is the struct sci_base_object which is cast to a | 1730 | * @object: This is the object which is cast to a struct scic_sds_port object. |
1735 | * struct scic_sds_port object. | ||
1736 | * | 1731 | * |
1737 | * This method will perform the actions required by the struct scic_sds_port on | 1732 | * This method will perform the actions required by the struct scic_sds_port on |
1738 | * exiting the SCIC_SDS_PORT_READY_SUBSTATE_OPERATIONAL. This function reports | 1733 | * exiting the SCIC_SDS_PORT_READY_SUBSTATE_OPERATIONAL. This function reports |
1739 | * the port not ready and suspends the port task scheduler. none | 1734 | * the port not ready and suspends the port task scheduler. none |
1740 | */ | 1735 | */ |
1741 | static void scic_sds_port_ready_substate_configuring_enter( | 1736 | static void scic_sds_port_ready_substate_configuring_enter(void *object) |
1742 | struct sci_base_object *object) | ||
1743 | { | 1737 | { |
1744 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; | 1738 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; |
1745 | struct scic_sds_controller *scic = | 1739 | struct scic_sds_controller *scic = |
@@ -1763,8 +1757,7 @@ static void scic_sds_port_ready_substate_configuring_enter( | |||
1763 | SCIC_SDS_PORT_READY_SUBSTATE_OPERATIONAL); | 1757 | SCIC_SDS_PORT_READY_SUBSTATE_OPERATIONAL); |
1764 | } | 1758 | } |
1765 | 1759 | ||
1766 | static void scic_sds_port_ready_substate_configuring_exit( | 1760 | static void scic_sds_port_ready_substate_configuring_exit(void *object) |
1767 | struct sci_base_object *object) | ||
1768 | { | 1761 | { |
1769 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; | 1762 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; |
1770 | 1763 | ||
@@ -2253,15 +2246,14 @@ static void scic_sds_port_invalidate_dummy_remote_node(struct scic_sds_port *sci | |||
2253 | 2246 | ||
2254 | /** | 2247 | /** |
2255 | * | 2248 | * |
2256 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_port object. | 2249 | * @object: This is the object which is cast to a struct scic_sds_port object. |
2257 | * | 2250 | * |
2258 | * This method will perform the actions required by the struct scic_sds_port on | 2251 | * This method will perform the actions required by the struct scic_sds_port on |
2259 | * entering the SCI_BASE_PORT_STATE_STOPPED. This function sets the stopped | 2252 | * entering the SCI_BASE_PORT_STATE_STOPPED. This function sets the stopped |
2260 | * state handlers for the struct scic_sds_port object and disables the port task | 2253 | * state handlers for the struct scic_sds_port object and disables the port task |
2261 | * scheduler in the hardware. none | 2254 | * scheduler in the hardware. none |
2262 | */ | 2255 | */ |
2263 | static void scic_sds_port_stopped_state_enter( | 2256 | static void scic_sds_port_stopped_state_enter(void *object) |
2264 | struct sci_base_object *object) | ||
2265 | { | 2257 | { |
2266 | struct scic_sds_port *sci_port; | 2258 | struct scic_sds_port *sci_port; |
2267 | 2259 | ||
@@ -2285,14 +2277,13 @@ static void scic_sds_port_stopped_state_enter( | |||
2285 | 2277 | ||
2286 | /** | 2278 | /** |
2287 | * | 2279 | * |
2288 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_port object. | 2280 | * @object: This is the object which is cast to a struct scic_sds_port object. |
2289 | * | 2281 | * |
2290 | * This method will perform the actions required by the struct scic_sds_port on | 2282 | * This method will perform the actions required by the struct scic_sds_port on |
2291 | * exiting the SCI_BASE_STATE_STOPPED. This function enables the SCU hardware | 2283 | * exiting the SCI_BASE_STATE_STOPPED. This function enables the SCU hardware |
2292 | * port task scheduler. none | 2284 | * port task scheduler. none |
2293 | */ | 2285 | */ |
2294 | static void scic_sds_port_stopped_state_exit( | 2286 | static void scic_sds_port_stopped_state_exit(void *object) |
2295 | struct sci_base_object *object) | ||
2296 | { | 2287 | { |
2297 | struct scic_sds_port *sci_port; | 2288 | struct scic_sds_port *sci_port; |
2298 | 2289 | ||
@@ -2304,14 +2295,14 @@ static void scic_sds_port_stopped_state_exit( | |||
2304 | 2295 | ||
2305 | /** | 2296 | /** |
2306 | * scic_sds_port_ready_state_enter - | 2297 | * scic_sds_port_ready_state_enter - |
2307 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_port object. | 2298 | * @object: This is the object which is cast to a struct scic_sds_port object. |
2308 | * | 2299 | * |
2309 | * This method will perform the actions required by the struct scic_sds_port on | 2300 | * This method will perform the actions required by the struct scic_sds_port on |
2310 | * entering the SCI_BASE_PORT_STATE_READY. This function sets the ready state | 2301 | * entering the SCI_BASE_PORT_STATE_READY. This function sets the ready state |
2311 | * handlers for the struct scic_sds_port object, reports the port object as | 2302 | * handlers for the struct scic_sds_port object, reports the port object as |
2312 | * not ready and starts the ready substate machine. none | 2303 | * not ready and starts the ready substate machine. none |
2313 | */ | 2304 | */ |
2314 | static void scic_sds_port_ready_state_enter(struct sci_base_object *object) | 2305 | static void scic_sds_port_ready_state_enter(void *object) |
2315 | { | 2306 | { |
2316 | struct scic_sds_controller *scic; | 2307 | struct scic_sds_controller *scic; |
2317 | struct scic_sds_port *sci_port; | 2308 | struct scic_sds_port *sci_port; |
@@ -2340,7 +2331,7 @@ static void scic_sds_port_ready_state_enter(struct sci_base_object *object) | |||
2340 | sci_base_state_machine_start(&sci_port->ready_substate_machine); | 2331 | sci_base_state_machine_start(&sci_port->ready_substate_machine); |
2341 | } | 2332 | } |
2342 | 2333 | ||
2343 | static void scic_sds_port_ready_state_exit(struct sci_base_object *object) | 2334 | static void scic_sds_port_ready_state_exit(void *object) |
2344 | { | 2335 | { |
2345 | struct scic_sds_port *sci_port; | 2336 | struct scic_sds_port *sci_port; |
2346 | 2337 | ||
@@ -2351,14 +2342,13 @@ static void scic_sds_port_ready_state_exit(struct sci_base_object *object) | |||
2351 | 2342 | ||
2352 | /** | 2343 | /** |
2353 | * | 2344 | * |
2354 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_port object. | 2345 | * @object: This is the object which is cast to a struct scic_sds_port object. |
2355 | * | 2346 | * |
2356 | * This method will perform the actions required by the struct scic_sds_port on | 2347 | * This method will perform the actions required by the struct scic_sds_port on |
2357 | * entering the SCI_BASE_PORT_STATE_RESETTING. This function sets the resetting | 2348 | * entering the SCI_BASE_PORT_STATE_RESETTING. This function sets the resetting |
2358 | * state handlers for the struct scic_sds_port object. none | 2349 | * state handlers for the struct scic_sds_port object. none |
2359 | */ | 2350 | */ |
2360 | static void scic_sds_port_resetting_state_enter( | 2351 | static void scic_sds_port_resetting_state_enter(void *object) |
2361 | struct sci_base_object *object) | ||
2362 | { | 2352 | { |
2363 | struct scic_sds_port *sci_port; | 2353 | struct scic_sds_port *sci_port; |
2364 | 2354 | ||
@@ -2371,15 +2361,13 @@ static void scic_sds_port_resetting_state_enter( | |||
2371 | 2361 | ||
2372 | /** | 2362 | /** |
2373 | * | 2363 | * |
2374 | * @object: This is the struct sci_base_object which is cast to a | 2364 | * @object: This is the object which is cast to a struct scic_sds_port object. |
2375 | * struct scic_sds_port object. | ||
2376 | * | 2365 | * |
2377 | * This function will perform the actions required by the | 2366 | * This function will perform the actions required by the |
2378 | * struct scic_sds_port on | 2367 | * struct scic_sds_port on |
2379 | * exiting the SCI_BASE_STATE_RESETTING. This function does nothing. none | 2368 | * exiting the SCI_BASE_STATE_RESETTING. This function does nothing. none |
2380 | */ | 2369 | */ |
2381 | static inline void scic_sds_port_resetting_state_exit( | 2370 | static inline void scic_sds_port_resetting_state_exit(void *object) |
2382 | struct sci_base_object *object) | ||
2383 | { | 2371 | { |
2384 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; | 2372 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; |
2385 | 2373 | ||
@@ -2388,14 +2376,14 @@ static inline void scic_sds_port_resetting_state_exit( | |||
2388 | 2376 | ||
2389 | /** | 2377 | /** |
2390 | * | 2378 | * |
2391 | * @object: This is the struct sci_base_object which is cast to a struct scic_sds_port object. | 2379 | * @object: This is the void object which is cast to a |
2380 | * struct scic_sds_port object. | ||
2392 | * | 2381 | * |
2393 | * This method will perform the actions required by the struct scic_sds_port on | 2382 | * This method will perform the actions required by the struct scic_sds_port on |
2394 | * entering the SCI_BASE_PORT_STATE_STOPPING. This function sets the stopping | 2383 | * entering the SCI_BASE_PORT_STATE_STOPPING. This function sets the stopping |
2395 | * state handlers for the struct scic_sds_port object. none | 2384 | * state handlers for the struct scic_sds_port object. none |
2396 | */ | 2385 | */ |
2397 | static void scic_sds_port_stopping_state_enter( | 2386 | static void scic_sds_port_stopping_state_enter(void *object) |
2398 | struct sci_base_object *object) | ||
2399 | { | 2387 | { |
2400 | struct scic_sds_port *sci_port; | 2388 | struct scic_sds_port *sci_port; |
2401 | 2389 | ||
@@ -2408,15 +2396,14 @@ static void scic_sds_port_stopping_state_enter( | |||
2408 | 2396 | ||
2409 | /** | 2397 | /** |
2410 | * | 2398 | * |
2411 | * @object: This is the struct sci_base_object which is cast to a | 2399 | * @object: This is the object which is cast to a struct scic_sds_port object. |
2412 | * struct scic_sds_port object. | ||
2413 | * | 2400 | * |
2414 | * This function will perform the actions required by the | 2401 | * This function will perform the actions required by the |
2415 | * struct scic_sds_port on | 2402 | * struct scic_sds_port on |
2416 | * exiting the SCI_BASE_STATE_STOPPING. This function does nothing. none | 2403 | * exiting the SCI_BASE_STATE_STOPPING. This function does nothing. none |
2417 | */ | 2404 | */ |
2418 | static inline void | 2405 | static inline void |
2419 | scic_sds_port_stopping_state_exit(struct sci_base_object *object) | 2406 | scic_sds_port_stopping_state_exit(void *object) |
2420 | { | 2407 | { |
2421 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; | 2408 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; |
2422 | 2409 | ||
@@ -2427,15 +2414,14 @@ scic_sds_port_stopping_state_exit(struct sci_base_object *object) | |||
2427 | 2414 | ||
2428 | /** | 2415 | /** |
2429 | * | 2416 | * |
2430 | * @object: This is the struct sci_base_object which is cast to a | 2417 | * @object: This is the object which is cast to a struct scic_sds_port object. |
2431 | * struct scic_sds_port object. | ||
2432 | * | 2418 | * |
2433 | * This function will perform the actions required by the | 2419 | * This function will perform the actions required by the |
2434 | * struct scic_sds_port on | 2420 | * struct scic_sds_port on |
2435 | * entering the SCI_BASE_PORT_STATE_STOPPING. This function sets the stopping | 2421 | * entering the SCI_BASE_PORT_STATE_STOPPING. This function sets the stopping |
2436 | * state handlers for the struct scic_sds_port object. none | 2422 | * state handlers for the struct scic_sds_port object. none |
2437 | */ | 2423 | */ |
2438 | static void scic_sds_port_failed_state_enter(struct sci_base_object *object) | 2424 | static void scic_sds_port_failed_state_enter(void *object) |
2439 | { | 2425 | { |
2440 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; | 2426 | struct scic_sds_port *sci_port = (struct scic_sds_port *)object; |
2441 | struct isci_port *iport = sci_object_get_association(sci_port); | 2427 | struct isci_port *iport = sci_object_get_association(sci_port); |
diff --git a/drivers/scsi/isci/core/scic_sds_request.c b/drivers/scsi/isci/core/scic_sds_request.c index 395080d0fc53..3ebfb7f8b702 100644 --- a/drivers/scsi/isci/core/scic_sds_request.c +++ b/drivers/scsi/isci/core/scic_sds_request.c | |||
@@ -1521,8 +1521,7 @@ static const struct scic_sds_io_request_state_handler scic_sds_request_state_han | |||
1521 | * base request is constructed. Entry into the initial state sets all handlers | 1521 | * base request is constructed. Entry into the initial state sets all handlers |
1522 | * for the io request object to their default handlers. none | 1522 | * for the io request object to their default handlers. none |
1523 | */ | 1523 | */ |
1524 | static void scic_sds_request_initial_state_enter( | 1524 | static void scic_sds_request_initial_state_enter(void *object) |
1525 | struct sci_base_object *object) | ||
1526 | { | 1525 | { |
1527 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1526 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1528 | 1527 | ||
@@ -1541,8 +1540,7 @@ static void scic_sds_request_initial_state_enter( | |||
1541 | * SCI_BASE_REQUEST_STATE_CONSTRUCTED state. The method sets the state handlers | 1540 | * SCI_BASE_REQUEST_STATE_CONSTRUCTED state. The method sets the state handlers |
1542 | * for the the constructed state. none | 1541 | * for the the constructed state. none |
1543 | */ | 1542 | */ |
1544 | static void scic_sds_request_constructed_state_enter( | 1543 | static void scic_sds_request_constructed_state_enter(void *object) |
1545 | struct sci_base_object *object) | ||
1546 | { | 1544 | { |
1547 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1545 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1548 | 1546 | ||
@@ -1556,14 +1554,13 @@ static void scic_sds_request_constructed_state_enter( | |||
1556 | /** | 1554 | /** |
1557 | * scic_sds_request_started_state_enter() - | 1555 | * scic_sds_request_started_state_enter() - |
1558 | * @object: This parameter specifies the base object for which the state | 1556 | * @object: This parameter specifies the base object for which the state |
1559 | * transition is occuring. This is cast into a SCIC_SDS_IO_REQUEST object. | 1557 | * transition is occurring. This is cast into a SCIC_SDS_IO_REQUEST object. |
1560 | * | 1558 | * |
1561 | * This method implements the actions taken when entering the | 1559 | * This method implements the actions taken when entering the |
1562 | * SCI_BASE_REQUEST_STATE_STARTED state. If the io request object type is a | 1560 | * SCI_BASE_REQUEST_STATE_STARTED state. If the io request object type is a |
1563 | * SCSI Task request we must enter the started substate machine. none | 1561 | * SCSI Task request we must enter the started substate machine. none |
1564 | */ | 1562 | */ |
1565 | static void scic_sds_request_started_state_enter( | 1563 | static void scic_sds_request_started_state_enter(void *object) |
1566 | struct sci_base_object *object) | ||
1567 | { | 1564 | { |
1568 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1565 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1569 | 1566 | ||
@@ -1583,15 +1580,14 @@ static void scic_sds_request_started_state_enter( | |||
1583 | /** | 1580 | /** |
1584 | * scic_sds_request_started_state_exit() - | 1581 | * scic_sds_request_started_state_exit() - |
1585 | * @object: This parameter specifies the base object for which the state | 1582 | * @object: This parameter specifies the base object for which the state |
1586 | * transition is occuring. This object is cast into a SCIC_SDS_IO_REQUEST | 1583 | * transition is occurring. This object is cast into a SCIC_SDS_IO_REQUEST |
1587 | * object. | 1584 | * object. |
1588 | * | 1585 | * |
1589 | * This method implements the actions taken when exiting the | 1586 | * This method implements the actions taken when exiting the |
1590 | * SCI_BASE_REQUEST_STATE_STARTED state. For task requests the action will be | 1587 | * SCI_BASE_REQUEST_STATE_STARTED state. For task requests the action will be |
1591 | * to stop the started substate machine. none | 1588 | * to stop the started substate machine. none |
1592 | */ | 1589 | */ |
1593 | static void scic_sds_request_started_state_exit( | 1590 | static void scic_sds_request_started_state_exit(void *object) |
1594 | struct sci_base_object *object) | ||
1595 | { | 1591 | { |
1596 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1592 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1597 | 1593 | ||
@@ -1602,7 +1598,7 @@ static void scic_sds_request_started_state_exit( | |||
1602 | /** | 1598 | /** |
1603 | * scic_sds_request_completed_state_enter() - | 1599 | * scic_sds_request_completed_state_enter() - |
1604 | * @object: This parameter specifies the base object for which the state | 1600 | * @object: This parameter specifies the base object for which the state |
1605 | * transition is occuring. This object is cast into a SCIC_SDS_IO_REQUEST | 1601 | * transition is occurring. This object is cast into a SCIC_SDS_IO_REQUEST |
1606 | * object. | 1602 | * object. |
1607 | * | 1603 | * |
1608 | * This method implements the actions taken when entering the | 1604 | * This method implements the actions taken when entering the |
@@ -1611,8 +1607,7 @@ static void scic_sds_request_started_state_exit( | |||
1611 | * completion status and convert it to an enum sci_status to return in the | 1607 | * completion status and convert it to an enum sci_status to return in the |
1612 | * completion callback function. none | 1608 | * completion callback function. none |
1613 | */ | 1609 | */ |
1614 | static void scic_sds_request_completed_state_enter( | 1610 | static void scic_sds_request_completed_state_enter(void *object) |
1615 | struct sci_base_object *object) | ||
1616 | { | 1611 | { |
1617 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1612 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1618 | struct scic_sds_controller *scic = | 1613 | struct scic_sds_controller *scic = |
@@ -1636,14 +1631,13 @@ static void scic_sds_request_completed_state_enter( | |||
1636 | /** | 1631 | /** |
1637 | * scic_sds_request_aborting_state_enter() - | 1632 | * scic_sds_request_aborting_state_enter() - |
1638 | * @object: This parameter specifies the base object for which the state | 1633 | * @object: This parameter specifies the base object for which the state |
1639 | * transition is occuring. This object is cast into a SCIC_SDS_IO_REQUEST | 1634 | * transition is occurring. This object is cast into a SCIC_SDS_IO_REQUEST |
1640 | * object. | 1635 | * object. |
1641 | * | 1636 | * |
1642 | * This method implements the actions taken when entering the | 1637 | * This method implements the actions taken when entering the |
1643 | * SCI_BASE_REQUEST_STATE_ABORTING state. none | 1638 | * SCI_BASE_REQUEST_STATE_ABORTING state. none |
1644 | */ | 1639 | */ |
1645 | static void scic_sds_request_aborting_state_enter( | 1640 | static void scic_sds_request_aborting_state_enter(void *object) |
1646 | struct sci_base_object *object) | ||
1647 | { | 1641 | { |
1648 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1642 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1649 | 1643 | ||
@@ -1660,14 +1654,13 @@ static void scic_sds_request_aborting_state_enter( | |||
1660 | /** | 1654 | /** |
1661 | * scic_sds_request_final_state_enter() - | 1655 | * scic_sds_request_final_state_enter() - |
1662 | * @object: This parameter specifies the base object for which the state | 1656 | * @object: This parameter specifies the base object for which the state |
1663 | * transition is occuring. This is cast into a SCIC_SDS_IO_REQUEST object. | 1657 | * transition is occurring. This is cast into a SCIC_SDS_IO_REQUEST object. |
1664 | * | 1658 | * |
1665 | * This method implements the actions taken when entering the | 1659 | * This method implements the actions taken when entering the |
1666 | * SCI_BASE_REQUEST_STATE_FINAL state. The only action required is to put the | 1660 | * SCI_BASE_REQUEST_STATE_FINAL state. The only action required is to put the |
1667 | * state handlers in place. none | 1661 | * state handlers in place. none |
1668 | */ | 1662 | */ |
1669 | static void scic_sds_request_final_state_enter( | 1663 | static void scic_sds_request_final_state_enter(void *object) |
1670 | struct sci_base_object *object) | ||
1671 | { | 1664 | { |
1672 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1665 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1673 | 1666 | ||
diff --git a/drivers/scsi/isci/core/scic_sds_smp_request.c b/drivers/scsi/isci/core/scic_sds_smp_request.c index d4009e57acaf..429973759776 100644 --- a/drivers/scsi/isci/core/scic_sds_smp_request.c +++ b/drivers/scsi/isci/core/scic_sds_smp_request.c | |||
@@ -518,12 +518,12 @@ static const struct scic_sds_io_request_state_handler scic_sds_smp_request_start | |||
518 | * SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_TC_RESPONSE sub-state. This | 518 | * SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_TC_RESPONSE sub-state. This |
519 | * includes setting the IO request state handlers for this sub-state. | 519 | * includes setting the IO request state handlers for this sub-state. |
520 | * @object: This parameter specifies the request object for which the sub-state | 520 | * @object: This parameter specifies the request object for which the sub-state |
521 | * change is occuring. | 521 | * change is occurring. |
522 | * | 522 | * |
523 | * none. | 523 | * none. |
524 | */ | 524 | */ |
525 | static void scic_sds_smp_request_started_await_response_substate_enter( | 525 | static void scic_sds_smp_request_started_await_response_substate_enter( |
526 | struct sci_base_object *object) | 526 | void *object) |
527 | { | 527 | { |
528 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 528 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
529 | 529 | ||
@@ -539,12 +539,12 @@ static void scic_sds_smp_request_started_await_response_substate_enter( | |||
539 | * SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_TC_COMPLETION sub-state. | 539 | * SCIC_SDS_SMP_REQUEST_STARTED_SUBSTATE_AWAIT_TC_COMPLETION sub-state. |
540 | * This includes setting the SMP request state handlers for this sub-state. | 540 | * This includes setting the SMP request state handlers for this sub-state. |
541 | * @object: This parameter specifies the request object for which the sub-state | 541 | * @object: This parameter specifies the request object for which the sub-state |
542 | * change is occuring. | 542 | * change is occurring. |
543 | * | 543 | * |
544 | * none. | 544 | * none. |
545 | */ | 545 | */ |
546 | static void scic_sds_smp_request_started_await_tc_completion_substate_enter( | 546 | static void scic_sds_smp_request_started_await_tc_completion_substate_enter( |
547 | struct sci_base_object *object) | 547 | void *object) |
548 | { | 548 | { |
549 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 549 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
550 | 550 | ||
diff --git a/drivers/scsi/isci/core/scic_sds_ssp_request.c b/drivers/scsi/isci/core/scic_sds_ssp_request.c index 03676682e6ef..a7297abdb1bd 100644 --- a/drivers/scsi/isci/core/scic_sds_ssp_request.c +++ b/drivers/scsi/isci/core/scic_sds_ssp_request.c | |||
@@ -195,12 +195,12 @@ static const struct scic_sds_io_request_state_handler scic_sds_ssp_task_request_ | |||
195 | * sub-state. This includes setting the IO request state handlers for this | 195 | * sub-state. This includes setting the IO request state handlers for this |
196 | * sub-state. | 196 | * sub-state. |
197 | * @object: This parameter specifies the request object for which the sub-state | 197 | * @object: This parameter specifies the request object for which the sub-state |
198 | * change is occuring. | 198 | * change is occurring. |
199 | * | 199 | * |
200 | * none. | 200 | * none. |
201 | */ | 201 | */ |
202 | static void scic_sds_io_request_started_task_mgmt_await_tc_completion_substate_enter( | 202 | static void scic_sds_io_request_started_task_mgmt_await_tc_completion_substate_enter( |
203 | struct sci_base_object *object) | 203 | void *object) |
204 | { | 204 | { |
205 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 205 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
206 | 206 | ||
@@ -216,12 +216,12 @@ static void scic_sds_io_request_started_task_mgmt_await_tc_completion_substate_e | |||
216 | * SCIC_SDS_IO_REQUEST_STARTED_SUBSTATE_AWAIT_TC_RESPONSE sub-state. This | 216 | * SCIC_SDS_IO_REQUEST_STARTED_SUBSTATE_AWAIT_TC_RESPONSE sub-state. This |
217 | * includes setting the IO request state handlers for this sub-state. | 217 | * includes setting the IO request state handlers for this sub-state. |
218 | * @object: This parameter specifies the request object for which the sub-state | 218 | * @object: This parameter specifies the request object for which the sub-state |
219 | * change is occuring. | 219 | * change is occurring. |
220 | * | 220 | * |
221 | * none. | 221 | * none. |
222 | */ | 222 | */ |
223 | static void scic_sds_io_request_started_task_mgmt_await_task_response_substate_enter( | 223 | static void scic_sds_io_request_started_task_mgmt_await_task_response_substate_enter( |
224 | struct sci_base_object *object) | 224 | void *object) |
225 | { | 225 | { |
226 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 226 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
227 | 227 | ||
diff --git a/drivers/scsi/isci/core/scic_sds_stp_request.c b/drivers/scsi/isci/core/scic_sds_stp_request.c index 59c5f1b8f1f6..2c6b62ee5fe8 100644 --- a/drivers/scsi/isci/core/scic_sds_stp_request.c +++ b/drivers/scsi/isci/core/scic_sds_stp_request.c | |||
@@ -564,7 +564,7 @@ static const struct scic_sds_io_request_state_handler scic_sds_stp_request_start | |||
564 | }; | 564 | }; |
565 | 565 | ||
566 | static void scic_sds_stp_request_started_non_data_await_h2d_completion_enter( | 566 | static void scic_sds_stp_request_started_non_data_await_h2d_completion_enter( |
567 | struct sci_base_object *object) | 567 | void *object) |
568 | { | 568 | { |
569 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 569 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
570 | 570 | ||
@@ -579,8 +579,7 @@ static void scic_sds_stp_request_started_non_data_await_h2d_completion_enter( | |||
579 | ); | 579 | ); |
580 | } | 580 | } |
581 | 581 | ||
582 | static void scic_sds_stp_request_started_non_data_await_d2h_enter( | 582 | static void scic_sds_stp_request_started_non_data_await_d2h_enter(void *object) |
583 | struct sci_base_object *object) | ||
584 | { | 583 | { |
585 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 584 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
586 | 585 | ||
@@ -1214,7 +1213,7 @@ static const struct scic_sds_io_request_state_handler scic_sds_stp_request_start | |||
1214 | }; | 1213 | }; |
1215 | 1214 | ||
1216 | static void scic_sds_stp_request_started_pio_await_h2d_completion_enter( | 1215 | static void scic_sds_stp_request_started_pio_await_h2d_completion_enter( |
1217 | struct sci_base_object *object) | 1216 | void *object) |
1218 | { | 1217 | { |
1219 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1218 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1220 | 1219 | ||
@@ -1228,8 +1227,7 @@ static void scic_sds_stp_request_started_pio_await_h2d_completion_enter( | |||
1228 | sci_req->target_device, sci_req); | 1227 | sci_req->target_device, sci_req); |
1229 | } | 1228 | } |
1230 | 1229 | ||
1231 | static void scic_sds_stp_request_started_pio_await_frame_enter( | 1230 | static void scic_sds_stp_request_started_pio_await_frame_enter(void *object) |
1232 | struct sci_base_object *object) | ||
1233 | { | 1231 | { |
1234 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1232 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1235 | 1233 | ||
@@ -1241,7 +1239,7 @@ static void scic_sds_stp_request_started_pio_await_frame_enter( | |||
1241 | } | 1239 | } |
1242 | 1240 | ||
1243 | static void scic_sds_stp_request_started_pio_data_in_await_data_enter( | 1241 | static void scic_sds_stp_request_started_pio_data_in_await_data_enter( |
1244 | struct sci_base_object *object) | 1242 | void *object) |
1245 | { | 1243 | { |
1246 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1244 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1247 | 1245 | ||
@@ -1253,7 +1251,7 @@ static void scic_sds_stp_request_started_pio_data_in_await_data_enter( | |||
1253 | } | 1251 | } |
1254 | 1252 | ||
1255 | static void scic_sds_stp_request_started_pio_data_out_transmit_data_enter( | 1253 | static void scic_sds_stp_request_started_pio_data_out_transmit_data_enter( |
1256 | struct sci_base_object *object) | 1254 | void *object) |
1257 | { | 1255 | { |
1258 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1256 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1259 | 1257 | ||
@@ -1485,7 +1483,7 @@ static const struct scic_sds_io_request_state_handler scic_sds_stp_request_start | |||
1485 | }; | 1483 | }; |
1486 | 1484 | ||
1487 | static void scic_sds_stp_request_started_udma_await_tc_completion_enter( | 1485 | static void scic_sds_stp_request_started_udma_await_tc_completion_enter( |
1488 | struct sci_base_object *object) | 1486 | void *object) |
1489 | { | 1487 | { |
1490 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1488 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1491 | 1489 | ||
@@ -1504,7 +1502,7 @@ static void scic_sds_stp_request_started_udma_await_tc_completion_enter( | |||
1504 | * will UF the D2H register FIS to complete the IO. | 1502 | * will UF the D2H register FIS to complete the IO. |
1505 | */ | 1503 | */ |
1506 | static void scic_sds_stp_request_started_udma_await_d2h_reg_fis_enter( | 1504 | static void scic_sds_stp_request_started_udma_await_d2h_reg_fis_enter( |
1507 | struct sci_base_object *object) | 1505 | void *object) |
1508 | { | 1506 | { |
1509 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1507 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1510 | 1508 | ||
@@ -1732,7 +1730,7 @@ static const struct scic_sds_io_request_state_handler scic_sds_stp_request_start | |||
1732 | }; | 1730 | }; |
1733 | 1731 | ||
1734 | static void scic_sds_stp_request_started_soft_reset_await_h2d_asserted_completion_enter( | 1732 | static void scic_sds_stp_request_started_soft_reset_await_h2d_asserted_completion_enter( |
1735 | struct sci_base_object *object) | 1733 | void *object) |
1736 | { | 1734 | { |
1737 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1735 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1738 | 1736 | ||
@@ -1748,7 +1746,7 @@ static void scic_sds_stp_request_started_soft_reset_await_h2d_asserted_completio | |||
1748 | } | 1746 | } |
1749 | 1747 | ||
1750 | static void scic_sds_stp_request_started_soft_reset_await_h2d_diagnostic_completion_enter( | 1748 | static void scic_sds_stp_request_started_soft_reset_await_h2d_diagnostic_completion_enter( |
1751 | struct sci_base_object *object) | 1749 | void *object) |
1752 | { | 1750 | { |
1753 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1751 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1754 | struct scu_task_context *task_context; | 1752 | struct scu_task_context *task_context; |
@@ -1775,7 +1773,7 @@ static void scic_sds_stp_request_started_soft_reset_await_h2d_diagnostic_complet | |||
1775 | } | 1773 | } |
1776 | 1774 | ||
1777 | static void scic_sds_stp_request_started_soft_reset_await_d2h_response_enter( | 1775 | static void scic_sds_stp_request_started_soft_reset_await_d2h_response_enter( |
1778 | struct sci_base_object *object) | 1776 | void *object) |
1779 | { | 1777 | { |
1780 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; | 1778 | struct scic_sds_request *sci_req = (struct scic_sds_request *)object; |
1781 | 1779 | ||
diff --git a/drivers/scsi/isci/remote_device.c b/drivers/scsi/isci/remote_device.c index 6d5ab728ccd1..b23f9a5a085d 100644 --- a/drivers/scsi/isci/remote_device.c +++ b/drivers/scsi/isci/remote_device.c | |||
@@ -1099,8 +1099,7 @@ static const struct scic_sds_remote_device_state_handler scic_sds_remote_device_ | |||
1099 | } | 1099 | } |
1100 | }; | 1100 | }; |
1101 | 1101 | ||
1102 | static void scic_sds_remote_device_initial_state_enter( | 1102 | static void scic_sds_remote_device_initial_state_enter(void *object) |
1103 | struct sci_base_object *object) | ||
1104 | { | 1103 | { |
1105 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; | 1104 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; |
1106 | 1105 | ||
@@ -1202,8 +1201,7 @@ static void isci_remote_device_stop_complete(struct isci_host *ihost, | |||
1202 | isci_remote_device_deconstruct(ihost, idev); | 1201 | isci_remote_device_deconstruct(ihost, idev); |
1203 | } | 1202 | } |
1204 | 1203 | ||
1205 | static void scic_sds_remote_device_stopped_state_enter( | 1204 | static void scic_sds_remote_device_stopped_state_enter(void *object) |
1206 | struct sci_base_object *object) | ||
1207 | { | 1205 | { |
1208 | struct scic_sds_remote_device *sci_dev; | 1206 | struct scic_sds_remote_device *sci_dev; |
1209 | struct scic_sds_controller *scic; | 1207 | struct scic_sds_controller *scic; |
@@ -1229,7 +1227,7 @@ static void scic_sds_remote_device_stopped_state_enter( | |||
1229 | scic_sds_controller_remote_device_stopped(scic, sci_dev); | 1227 | scic_sds_controller_remote_device_stopped(scic, sci_dev); |
1230 | } | 1228 | } |
1231 | 1229 | ||
1232 | static void scic_sds_remote_device_starting_state_enter(struct sci_base_object *object) | 1230 | static void scic_sds_remote_device_starting_state_enter(void *object) |
1233 | { | 1231 | { |
1234 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), | 1232 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), |
1235 | parent); | 1233 | parent); |
@@ -1244,7 +1242,7 @@ static void scic_sds_remote_device_starting_state_enter(struct sci_base_object * | |||
1244 | SCIC_REMOTE_DEVICE_NOT_READY_START_REQUESTED); | 1242 | SCIC_REMOTE_DEVICE_NOT_READY_START_REQUESTED); |
1245 | } | 1243 | } |
1246 | 1244 | ||
1247 | static void scic_sds_remote_device_ready_state_enter(struct sci_base_object *object) | 1245 | static void scic_sds_remote_device_ready_state_enter(void *object) |
1248 | { | 1246 | { |
1249 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), | 1247 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), |
1250 | parent); | 1248 | parent); |
@@ -1264,8 +1262,7 @@ static void scic_sds_remote_device_ready_state_enter(struct sci_base_object *obj | |||
1264 | isci_remote_device_ready(ihost, idev); | 1262 | isci_remote_device_ready(ihost, idev); |
1265 | } | 1263 | } |
1266 | 1264 | ||
1267 | static void scic_sds_remote_device_ready_state_exit( | 1265 | static void scic_sds_remote_device_ready_state_exit(void *object) |
1268 | struct sci_base_object *object) | ||
1269 | { | 1266 | { |
1270 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), | 1267 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), |
1271 | parent); | 1268 | parent); |
@@ -1281,8 +1278,7 @@ static void scic_sds_remote_device_ready_state_exit( | |||
1281 | } | 1278 | } |
1282 | } | 1279 | } |
1283 | 1280 | ||
1284 | static void scic_sds_remote_device_stopping_state_enter( | 1281 | static void scic_sds_remote_device_stopping_state_enter(void *object) |
1285 | struct sci_base_object *object) | ||
1286 | { | 1282 | { |
1287 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; | 1283 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; |
1288 | 1284 | ||
@@ -1293,8 +1289,7 @@ static void scic_sds_remote_device_stopping_state_enter( | |||
1293 | ); | 1289 | ); |
1294 | } | 1290 | } |
1295 | 1291 | ||
1296 | static void scic_sds_remote_device_failed_state_enter( | 1292 | static void scic_sds_remote_device_failed_state_enter(void *object) |
1297 | struct sci_base_object *object) | ||
1298 | { | 1293 | { |
1299 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; | 1294 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; |
1300 | 1295 | ||
@@ -1305,8 +1300,7 @@ static void scic_sds_remote_device_failed_state_enter( | |||
1305 | ); | 1300 | ); |
1306 | } | 1301 | } |
1307 | 1302 | ||
1308 | static void scic_sds_remote_device_resetting_state_enter( | 1303 | static void scic_sds_remote_device_resetting_state_enter(void *object) |
1309 | struct sci_base_object *object) | ||
1310 | { | 1304 | { |
1311 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; | 1305 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; |
1312 | 1306 | ||
@@ -1320,16 +1314,14 @@ static void scic_sds_remote_device_resetting_state_enter( | |||
1320 | &sci_dev->rnc, SCI_SOFTWARE_SUSPENSION, NULL, NULL); | 1314 | &sci_dev->rnc, SCI_SOFTWARE_SUSPENSION, NULL, NULL); |
1321 | } | 1315 | } |
1322 | 1316 | ||
1323 | static void scic_sds_remote_device_resetting_state_exit( | 1317 | static void scic_sds_remote_device_resetting_state_exit(void *object) |
1324 | struct sci_base_object *object) | ||
1325 | { | 1318 | { |
1326 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; | 1319 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; |
1327 | 1320 | ||
1328 | scic_sds_remote_node_context_resume(&sci_dev->rnc, NULL, NULL); | 1321 | scic_sds_remote_node_context_resume(&sci_dev->rnc, NULL, NULL); |
1329 | } | 1322 | } |
1330 | 1323 | ||
1331 | static void scic_sds_remote_device_final_state_enter( | 1324 | static void scic_sds_remote_device_final_state_enter(void *object) |
1332 | struct sci_base_object *object) | ||
1333 | { | 1325 | { |
1334 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; | 1326 | struct scic_sds_remote_device *sci_dev = (struct scic_sds_remote_device *)object; |
1335 | 1327 | ||
diff --git a/drivers/scsi/isci/remote_node_context.c b/drivers/scsi/isci/remote_node_context.c index 291df19f027b..bc51ecf76b14 100644 --- a/drivers/scsi/isci/remote_node_context.c +++ b/drivers/scsi/isci/remote_node_context.c | |||
@@ -970,8 +970,7 @@ static void scic_sds_remote_node_context_invalidate_context_buffer( | |||
970 | * | 970 | * |
971 | * | 971 | * |
972 | */ | 972 | */ |
973 | static void scic_sds_remote_node_context_initial_state_enter( | 973 | static void scic_sds_remote_node_context_initial_state_enter(void *object) |
974 | struct sci_base_object *object) | ||
975 | { | 974 | { |
976 | struct scic_sds_remote_node_context *rnc; | 975 | struct scic_sds_remote_node_context *rnc; |
977 | 976 | ||
@@ -1001,8 +1000,7 @@ static void scic_sds_remote_node_context_initial_state_enter( | |||
1001 | * | 1000 | * |
1002 | * | 1001 | * |
1003 | */ | 1002 | */ |
1004 | static void scic_sds_remote_node_context_posting_state_enter( | 1003 | static void scic_sds_remote_node_context_posting_state_enter(void *object) |
1005 | struct sci_base_object *object) | ||
1006 | { | 1004 | { |
1007 | struct scic_sds_remote_node_context *sci_rnc; | 1005 | struct scic_sds_remote_node_context *sci_rnc; |
1008 | 1006 | ||
@@ -1022,8 +1020,7 @@ static void scic_sds_remote_node_context_posting_state_enter( | |||
1022 | * | 1020 | * |
1023 | * | 1021 | * |
1024 | */ | 1022 | */ |
1025 | static void scic_sds_remote_node_context_invalidating_state_enter( | 1023 | static void scic_sds_remote_node_context_invalidating_state_enter(void *object) |
1026 | struct sci_base_object *object) | ||
1027 | { | 1024 | { |
1028 | struct scic_sds_remote_node_context *rnc; | 1025 | struct scic_sds_remote_node_context *rnc; |
1029 | 1026 | ||
@@ -1043,8 +1040,7 @@ static void scic_sds_remote_node_context_invalidating_state_enter( | |||
1043 | * | 1040 | * |
1044 | * | 1041 | * |
1045 | */ | 1042 | */ |
1046 | static void scic_sds_remote_node_context_resuming_state_enter( | 1043 | static void scic_sds_remote_node_context_resuming_state_enter(void *object) |
1047 | struct sci_base_object *object) | ||
1048 | { | 1044 | { |
1049 | struct scic_sds_remote_node_context *rnc; | 1045 | struct scic_sds_remote_node_context *rnc; |
1050 | struct scic_sds_remote_device *sci_dev; | 1046 | struct scic_sds_remote_device *sci_dev; |
@@ -1079,8 +1075,7 @@ static void scic_sds_remote_node_context_resuming_state_enter( | |||
1079 | * | 1075 | * |
1080 | * | 1076 | * |
1081 | */ | 1077 | */ |
1082 | static void scic_sds_remote_node_context_ready_state_enter( | 1078 | static void scic_sds_remote_node_context_ready_state_enter(void *object) |
1083 | struct sci_base_object *object) | ||
1084 | { | 1079 | { |
1085 | struct scic_sds_remote_node_context *rnc; | 1080 | struct scic_sds_remote_node_context *rnc; |
1086 | 1081 | ||
@@ -1104,8 +1099,7 @@ static void scic_sds_remote_node_context_ready_state_enter( | |||
1104 | * | 1099 | * |
1105 | * | 1100 | * |
1106 | */ | 1101 | */ |
1107 | static void scic_sds_remote_node_context_tx_suspended_state_enter( | 1102 | static void scic_sds_remote_node_context_tx_suspended_state_enter(void *object) |
1108 | struct sci_base_object *object) | ||
1109 | { | 1103 | { |
1110 | struct scic_sds_remote_node_context *rnc; | 1104 | struct scic_sds_remote_node_context *rnc; |
1111 | 1105 | ||
@@ -1126,7 +1120,7 @@ static void scic_sds_remote_node_context_tx_suspended_state_enter( | |||
1126 | * | 1120 | * |
1127 | */ | 1121 | */ |
1128 | static void scic_sds_remote_node_context_tx_rx_suspended_state_enter( | 1122 | static void scic_sds_remote_node_context_tx_rx_suspended_state_enter( |
1129 | struct sci_base_object *object) | 1123 | void *object) |
1130 | { | 1124 | { |
1131 | struct scic_sds_remote_node_context *rnc; | 1125 | struct scic_sds_remote_node_context *rnc; |
1132 | 1126 | ||
@@ -1147,7 +1141,7 @@ static void scic_sds_remote_node_context_tx_rx_suspended_state_enter( | |||
1147 | * | 1141 | * |
1148 | */ | 1142 | */ |
1149 | static void scic_sds_remote_node_context_await_suspension_state_enter( | 1143 | static void scic_sds_remote_node_context_await_suspension_state_enter( |
1150 | struct sci_base_object *object) | 1144 | void *object) |
1151 | { | 1145 | { |
1152 | struct scic_sds_remote_node_context *rnc; | 1146 | struct scic_sds_remote_node_context *rnc; |
1153 | 1147 | ||
diff --git a/drivers/scsi/isci/smp_remote_device.c b/drivers/scsi/isci/smp_remote_device.c index 718ddaf49343..a38dc90da943 100644 --- a/drivers/scsi/isci/smp_remote_device.c +++ b/drivers/scsi/isci/smp_remote_device.c | |||
@@ -237,14 +237,14 @@ static const struct scic_sds_remote_device_state_handler scic_sds_smp_remote_dev | |||
237 | 237 | ||
238 | /** | 238 | /** |
239 | * | 239 | * |
240 | * @object: This is the struct sci_base_object which is cast into a | 240 | * @object: This is the object which is cast into a |
241 | * struct scic_sds_remote_device. | 241 | * struct scic_sds_remote_device. |
242 | * | 242 | * |
243 | * This is the SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_IDLE enter method. | 243 | * This is the SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_IDLE enter method. |
244 | * This function sets the ready cmd substate handlers and reports the device as | 244 | * This function sets the ready cmd substate handlers and reports the device as |
245 | * ready. none | 245 | * ready. none |
246 | */ | 246 | */ |
247 | static void scic_sds_smp_remote_device_ready_idle_substate_enter(struct sci_base_object *object) | 247 | static void scic_sds_smp_remote_device_ready_idle_substate_enter(void *object) |
248 | { | 248 | { |
249 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), | 249 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), |
250 | parent); | 250 | parent); |
@@ -261,15 +261,14 @@ static void scic_sds_smp_remote_device_ready_idle_substate_enter(struct sci_base | |||
261 | 261 | ||
262 | /** | 262 | /** |
263 | * | 263 | * |
264 | * @object: This is the struct sci_base_object which is cast into a | 264 | * @object: This is the object which is cast into a |
265 | * struct scic_sds_remote_device. | 265 | * struct scic_sds_remote_device. |
266 | * | 266 | * |
267 | * This is the SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_CMD enter method. This | 267 | * This is the SCIC_SDS_SMP_REMOTE_DEVICE_READY_SUBSTATE_CMD enter method. This |
268 | * function sets the remote device objects ready cmd substate handlers, and | 268 | * function sets the remote device objects ready cmd substate handlers, and |
269 | * notify core user that the device is not ready. none | 269 | * notify core user that the device is not ready. none |
270 | */ | 270 | */ |
271 | static void scic_sds_smp_remote_device_ready_cmd_substate_enter( | 271 | static void scic_sds_smp_remote_device_ready_cmd_substate_enter(void *object) |
272 | struct sci_base_object *object) | ||
273 | { | 272 | { |
274 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), | 273 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), |
275 | parent); | 274 | parent); |
@@ -289,12 +288,12 @@ static void scic_sds_smp_remote_device_ready_cmd_substate_enter( | |||
289 | 288 | ||
290 | /** | 289 | /** |
291 | * | 290 | * |
292 | * @object: This is the struct sci_base_object which is cast into a | 291 | * @object: This is the object which is cast into a |
293 | * struct scic_sds_remote_device. | 292 | * struct scic_sds_remote_device. |
294 | * | 293 | * |
295 | * This is the SCIC_SDS_SSP_REMOTE_DEVICE_READY_SUBSTATE_CMD exit method. none | 294 | * This is the SCIC_SDS_SSP_REMOTE_DEVICE_READY_SUBSTATE_CMD exit method. none |
296 | */ | 295 | */ |
297 | static void scic_sds_smp_remote_device_ready_cmd_substate_exit(struct sci_base_object *object) | 296 | static void scic_sds_smp_remote_device_ready_cmd_substate_exit(void *object) |
298 | { | 297 | { |
299 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), | 298 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), |
300 | parent); | 299 | parent); |
diff --git a/drivers/scsi/isci/stp_remote_device.c b/drivers/scsi/isci/stp_remote_device.c index 0fbfe52208fa..1e6f77331af1 100644 --- a/drivers/scsi/isci/stp_remote_device.c +++ b/drivers/scsi/isci/stp_remote_device.c | |||
@@ -601,12 +601,11 @@ scic_sds_stp_remote_device_ready_idle_substate_resume_complete_handler(void *use | |||
601 | 601 | ||
602 | /** | 602 | /** |
603 | * | 603 | * |
604 | * @device: This is the SCI base object which is cast into a | 604 | * @device: This is the object which is cast into a |
605 | * struct scic_sds_remote_device object. | 605 | * struct scic_sds_remote_device object. |
606 | * | 606 | * |
607 | */ | 607 | */ |
608 | static void scic_sds_stp_remote_device_ready_idle_substate_enter( | 608 | static void scic_sds_stp_remote_device_ready_idle_substate_enter(void *device) |
609 | struct sci_base_object *device) | ||
610 | { | 609 | { |
611 | struct scic_sds_remote_device *sci_dev; | 610 | struct scic_sds_remote_device *sci_dev; |
612 | 611 | ||
@@ -635,7 +634,7 @@ static void scic_sds_stp_remote_device_ready_idle_substate_enter( | |||
635 | } | 634 | } |
636 | } | 635 | } |
637 | 636 | ||
638 | static void scic_sds_stp_remote_device_ready_cmd_substate_enter(struct sci_base_object *object) | 637 | static void scic_sds_stp_remote_device_ready_cmd_substate_enter(void *object) |
639 | { | 638 | { |
640 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), | 639 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), |
641 | parent); | 640 | parent); |
@@ -653,7 +652,7 @@ static void scic_sds_stp_remote_device_ready_cmd_substate_enter(struct sci_base_ | |||
653 | SCIC_REMOTE_DEVICE_NOT_READY_SATA_REQUEST_STARTED); | 652 | SCIC_REMOTE_DEVICE_NOT_READY_SATA_REQUEST_STARTED); |
654 | } | 653 | } |
655 | 654 | ||
656 | static void scic_sds_stp_remote_device_ready_ncq_substate_enter(struct sci_base_object *object) | 655 | static void scic_sds_stp_remote_device_ready_ncq_substate_enter(void *object) |
657 | { | 656 | { |
658 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), | 657 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), |
659 | parent); | 658 | parent); |
@@ -662,7 +661,8 @@ static void scic_sds_stp_remote_device_ready_ncq_substate_enter(struct sci_base_ | |||
662 | SCIC_SDS_STP_REMOTE_DEVICE_READY_SUBSTATE_NCQ); | 661 | SCIC_SDS_STP_REMOTE_DEVICE_READY_SUBSTATE_NCQ); |
663 | } | 662 | } |
664 | 663 | ||
665 | static void scic_sds_stp_remote_device_ready_ncq_error_substate_enter(struct sci_base_object *object) | 664 | static void scic_sds_stp_remote_device_ready_ncq_error_substate_enter( |
665 | void *object) | ||
666 | { | 666 | { |
667 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), | 667 | struct scic_sds_remote_device *sci_dev = container_of(object, typeof(*sci_dev), |
668 | parent); | 668 | parent); |
@@ -686,12 +686,12 @@ static void scic_sds_stp_remote_device_ready_ncq_error_substate_enter(struct sci | |||
686 | 686 | ||
687 | /** | 687 | /** |
688 | * The enter routine to READY AWAIT RESET substate. | 688 | * The enter routine to READY AWAIT RESET substate. |
689 | * @device: This is the SCI base object which is cast into a | 689 | * @device: This is the object which is cast into a |
690 | * struct scic_sds_remote_device object. | 690 | * struct scic_sds_remote_device object. |
691 | * | 691 | * |
692 | */ | 692 | */ |
693 | static void scic_sds_stp_remote_device_ready_await_reset_substate_enter( | 693 | static void scic_sds_stp_remote_device_ready_await_reset_substate_enter( |
694 | struct sci_base_object *device) | 694 | void *device) |
695 | { | 695 | { |
696 | struct scic_sds_remote_device *sci_dev; | 696 | struct scic_sds_remote_device *sci_dev; |
697 | 697 | ||