diff options
author | Jiang Liu <jiang.liu@linux.intel.com> | 2015-02-05 00:44:43 -0500 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2015-02-05 09:09:25 -0500 |
commit | 90e97820619dc912b52cc9d103272819d8b51259 (patch) | |
tree | 20e8c3000c47b0dea7eca79ef7c49db916606d65 /drivers | |
parent | 62d1141ff34e35de496ba06491c8e854b23b3f3e (diff) |
resources: Move struct resource_list_entry from ACPI into resource core
Currently ACPI, PCI and pnp all implement the same resource list
management with different data structure. We need to transfer from
one data structure into another when passing resources from one
subsystem into another subsystem. So move struct resource_list_entry
from ACPI into resource core and rename it as resource_entry,
then it could be reused by different subystems and avoid the data
structure conversion.
Introduce dedicated header file resource_ext.h instead of embedding
it into ioport.h to avoid header file inclusion order issues.
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/acpi/acpi_lpss.c | 8 | ||||
-rw-r--r-- | drivers/acpi/acpi_platform.c | 4 | ||||
-rw-r--r-- | drivers/acpi/resource.c | 17 | ||||
-rw-r--r-- | drivers/dma/acpi-dma.c | 10 |
4 files changed, 17 insertions, 22 deletions
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c index 4f3febf8a589..dfd1b8095dad 100644 --- a/drivers/acpi/acpi_lpss.c +++ b/drivers/acpi/acpi_lpss.c | |||
@@ -313,7 +313,7 @@ static int acpi_lpss_create_device(struct acpi_device *adev, | |||
313 | { | 313 | { |
314 | struct lpss_device_desc *dev_desc; | 314 | struct lpss_device_desc *dev_desc; |
315 | struct lpss_private_data *pdata; | 315 | struct lpss_private_data *pdata; |
316 | struct resource_list_entry *rentry; | 316 | struct resource_entry *rentry; |
317 | struct list_head resource_list; | 317 | struct list_head resource_list; |
318 | struct platform_device *pdev; | 318 | struct platform_device *pdev; |
319 | int ret; | 319 | int ret; |
@@ -333,12 +333,12 @@ static int acpi_lpss_create_device(struct acpi_device *adev, | |||
333 | goto err_out; | 333 | goto err_out; |
334 | 334 | ||
335 | list_for_each_entry(rentry, &resource_list, node) | 335 | list_for_each_entry(rentry, &resource_list, node) |
336 | if (resource_type(&rentry->res) == IORESOURCE_MEM) { | 336 | if (resource_type(rentry->res) == IORESOURCE_MEM) { |
337 | if (dev_desc->prv_size_override) | 337 | if (dev_desc->prv_size_override) |
338 | pdata->mmio_size = dev_desc->prv_size_override; | 338 | pdata->mmio_size = dev_desc->prv_size_override; |
339 | else | 339 | else |
340 | pdata->mmio_size = resource_size(&rentry->res); | 340 | pdata->mmio_size = resource_size(rentry->res); |
341 | pdata->mmio_base = ioremap(rentry->res.start, | 341 | pdata->mmio_base = ioremap(rentry->res->start, |
342 | pdata->mmio_size); | 342 | pdata->mmio_size); |
343 | break; | 343 | break; |
344 | } | 344 | } |
diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c index 6ba8beb6b9d2..1284138e42ab 100644 --- a/drivers/acpi/acpi_platform.c +++ b/drivers/acpi/acpi_platform.c | |||
@@ -45,7 +45,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev) | |||
45 | struct platform_device *pdev = NULL; | 45 | struct platform_device *pdev = NULL; |
46 | struct acpi_device *acpi_parent; | 46 | struct acpi_device *acpi_parent; |
47 | struct platform_device_info pdevinfo; | 47 | struct platform_device_info pdevinfo; |
48 | struct resource_list_entry *rentry; | 48 | struct resource_entry *rentry; |
49 | struct list_head resource_list; | 49 | struct list_head resource_list; |
50 | struct resource *resources = NULL; | 50 | struct resource *resources = NULL; |
51 | int count; | 51 | int count; |
@@ -71,7 +71,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev) | |||
71 | } | 71 | } |
72 | count = 0; | 72 | count = 0; |
73 | list_for_each_entry(rentry, &resource_list, node) | 73 | list_for_each_entry(rentry, &resource_list, node) |
74 | resources[count++] = rentry->res; | 74 | resources[count++] = *rentry->res; |
75 | 75 | ||
76 | acpi_dev_free_resource_list(&resource_list); | 76 | acpi_dev_free_resource_list(&resource_list); |
77 | } | 77 | } |
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 3ea0d17eb951..4752b9939987 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c | |||
@@ -444,12 +444,7 @@ EXPORT_SYMBOL_GPL(acpi_dev_resource_interrupt); | |||
444 | */ | 444 | */ |
445 | void acpi_dev_free_resource_list(struct list_head *list) | 445 | void acpi_dev_free_resource_list(struct list_head *list) |
446 | { | 446 | { |
447 | struct resource_list_entry *rentry, *re; | 447 | resource_list_free(list); |
448 | |||
449 | list_for_each_entry_safe(rentry, re, list, node) { | ||
450 | list_del(&rentry->node); | ||
451 | kfree(rentry); | ||
452 | } | ||
453 | } | 448 | } |
454 | EXPORT_SYMBOL_GPL(acpi_dev_free_resource_list); | 449 | EXPORT_SYMBOL_GPL(acpi_dev_free_resource_list); |
455 | 450 | ||
@@ -464,16 +459,16 @@ struct res_proc_context { | |||
464 | static acpi_status acpi_dev_new_resource_entry(struct resource_win *win, | 459 | static acpi_status acpi_dev_new_resource_entry(struct resource_win *win, |
465 | struct res_proc_context *c) | 460 | struct res_proc_context *c) |
466 | { | 461 | { |
467 | struct resource_list_entry *rentry; | 462 | struct resource_entry *rentry; |
468 | 463 | ||
469 | rentry = kmalloc(sizeof(*rentry), GFP_KERNEL); | 464 | rentry = resource_list_create_entry(NULL, 0); |
470 | if (!rentry) { | 465 | if (!rentry) { |
471 | c->error = -ENOMEM; | 466 | c->error = -ENOMEM; |
472 | return AE_NO_MEMORY; | 467 | return AE_NO_MEMORY; |
473 | } | 468 | } |
474 | rentry->res = win->res; | 469 | *rentry->res = win->res; |
475 | rentry->offset = win->offset; | 470 | rentry->offset = win->offset; |
476 | list_add_tail(&rentry->node, c->list); | 471 | resource_list_add_tail(rentry, c->list); |
477 | c->count++; | 472 | c->count++; |
478 | return AE_OK; | 473 | return AE_OK; |
479 | } | 474 | } |
@@ -534,7 +529,7 @@ static acpi_status acpi_dev_process_resource(struct acpi_resource *ares, | |||
534 | * returned as the final error code. | 529 | * returned as the final error code. |
535 | * | 530 | * |
536 | * The resultant struct resource objects are put on the list pointed to by | 531 | * The resultant struct resource objects are put on the list pointed to by |
537 | * @list, that must be empty initially, as members of struct resource_list_entry | 532 | * @list, that must be empty initially, as members of struct resource_entry |
538 | * objects. Callers of this routine should use %acpi_dev_free_resource_list() to | 533 | * objects. Callers of this routine should use %acpi_dev_free_resource_list() to |
539 | * free that list. | 534 | * free that list. |
540 | * | 535 | * |
diff --git a/drivers/dma/acpi-dma.c b/drivers/dma/acpi-dma.c index de361a156b34..5a635646e05c 100644 --- a/drivers/dma/acpi-dma.c +++ b/drivers/dma/acpi-dma.c | |||
@@ -43,7 +43,7 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp, | |||
43 | { | 43 | { |
44 | const struct acpi_csrt_shared_info *si; | 44 | const struct acpi_csrt_shared_info *si; |
45 | struct list_head resource_list; | 45 | struct list_head resource_list; |
46 | struct resource_list_entry *rentry; | 46 | struct resource_entry *rentry; |
47 | resource_size_t mem = 0, irq = 0; | 47 | resource_size_t mem = 0, irq = 0; |
48 | int ret; | 48 | int ret; |
49 | 49 | ||
@@ -56,10 +56,10 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp, | |||
56 | return 0; | 56 | return 0; |
57 | 57 | ||
58 | list_for_each_entry(rentry, &resource_list, node) { | 58 | list_for_each_entry(rentry, &resource_list, node) { |
59 | if (resource_type(&rentry->res) == IORESOURCE_MEM) | 59 | if (resource_type(rentry->res) == IORESOURCE_MEM) |
60 | mem = rentry->res.start; | 60 | mem = rentry->res->start; |
61 | else if (resource_type(&rentry->res) == IORESOURCE_IRQ) | 61 | else if (resource_type(rentry->res) == IORESOURCE_IRQ) |
62 | irq = rentry->res.start; | 62 | irq = rentry->res->start; |
63 | } | 63 | } |
64 | 64 | ||
65 | acpi_dev_free_resource_list(&resource_list); | 65 | acpi_dev_free_resource_list(&resource_list); |