diff options
author | Bruce Allan <bruce.w.allan@intel.com> | 2013-01-16 03:46:49 -0500 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2013-02-01 01:28:39 -0500 |
commit | 8bb628697fb05172f10a0960385b8369be15cb6c (patch) | |
tree | 641f3b8c29c7d6b283c831071a571dc5b1da5a37 /drivers | |
parent | 9e019901816ca4bad83bf4922b791610e6dd529e (diff) |
e1000e: resolve -Wunused-parameter compile warnings
Remove the unused parameter when possible, otherwise use __always_unused
attribute.
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/ethtool.c | 16 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/mac.c | 4 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/netdev.c | 33 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/phy.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/intel/e1000e/ptp.c | 5 |
6 files changed, 31 insertions, 33 deletions
diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index 58df18c2efc2..b1447783ff29 100644 --- a/drivers/net/ethernet/intel/e1000e/ethtool.c +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c | |||
@@ -418,7 +418,7 @@ static void e1000_set_msglevel(struct net_device *netdev, u32 data) | |||
418 | adapter->msg_enable = data; | 418 | adapter->msg_enable = data; |
419 | } | 419 | } |
420 | 420 | ||
421 | static int e1000_get_regs_len(struct net_device *netdev) | 421 | static int e1000_get_regs_len(struct net_device __always_unused *netdev) |
422 | { | 422 | { |
423 | #define E1000_REGS_LEN 32 /* overestimate */ | 423 | #define E1000_REGS_LEN 32 /* overestimate */ |
424 | return E1000_REGS_LEN * sizeof(u32); | 424 | return E1000_REGS_LEN * sizeof(u32); |
@@ -934,7 +934,7 @@ static int e1000_eeprom_test(struct e1000_adapter *adapter, u64 *data) | |||
934 | return *data; | 934 | return *data; |
935 | } | 935 | } |
936 | 936 | ||
937 | static irqreturn_t e1000_test_intr(int irq, void *data) | 937 | static irqreturn_t e1000_test_intr(int __always_unused irq, void *data) |
938 | { | 938 | { |
939 | struct net_device *netdev = (struct net_device *) data; | 939 | struct net_device *netdev = (struct net_device *) data; |
940 | struct e1000_adapter *adapter = netdev_priv(netdev); | 940 | struct e1000_adapter *adapter = netdev_priv(netdev); |
@@ -1705,7 +1705,8 @@ static int e1000_link_test(struct e1000_adapter *adapter, u64 *data) | |||
1705 | return *data; | 1705 | return *data; |
1706 | } | 1706 | } |
1707 | 1707 | ||
1708 | static int e1000e_get_sset_count(struct net_device *netdev, int sset) | 1708 | static int e1000e_get_sset_count(struct net_device __always_unused *netdev, |
1709 | int sset) | ||
1709 | { | 1710 | { |
1710 | switch (sset) { | 1711 | switch (sset) { |
1711 | case ETH_SS_TEST: | 1712 | case ETH_SS_TEST: |
@@ -1968,7 +1969,7 @@ static int e1000_nway_reset(struct net_device *netdev) | |||
1968 | } | 1969 | } |
1969 | 1970 | ||
1970 | static void e1000_get_ethtool_stats(struct net_device *netdev, | 1971 | static void e1000_get_ethtool_stats(struct net_device *netdev, |
1971 | struct ethtool_stats *stats, | 1972 | struct ethtool_stats __always_unused *stats, |
1972 | u64 *data) | 1973 | u64 *data) |
1973 | { | 1974 | { |
1974 | struct e1000_adapter *adapter = netdev_priv(netdev); | 1975 | struct e1000_adapter *adapter = netdev_priv(netdev); |
@@ -1997,8 +1998,8 @@ static void e1000_get_ethtool_stats(struct net_device *netdev, | |||
1997 | } | 1998 | } |
1998 | } | 1999 | } |
1999 | 2000 | ||
2000 | static void e1000_get_strings(struct net_device *netdev, u32 stringset, | 2001 | static void e1000_get_strings(struct net_device __always_unused *netdev, |
2001 | u8 *data) | 2002 | u32 stringset, u8 *data) |
2002 | { | 2003 | { |
2003 | u8 *p = data; | 2004 | u8 *p = data; |
2004 | int i; | 2005 | int i; |
@@ -2018,7 +2019,8 @@ static void e1000_get_strings(struct net_device *netdev, u32 stringset, | |||
2018 | } | 2019 | } |
2019 | 2020 | ||
2020 | static int e1000_get_rxnfc(struct net_device *netdev, | 2021 | static int e1000_get_rxnfc(struct net_device *netdev, |
2021 | struct ethtool_rxnfc *info, u32 *rule_locs) | 2022 | struct ethtool_rxnfc *info, |
2023 | u32 __always_unused *rule_locs) | ||
2022 | { | 2024 | { |
2023 | info->data = 0; | 2025 | info->data = 0; |
2024 | 2026 | ||
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c index 2ca6f2f502ea..5ca21f9b3334 100644 --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c | |||
@@ -1082,7 +1082,7 @@ static DEFINE_MUTEX(nvm_mutex); | |||
1082 | * | 1082 | * |
1083 | * Acquires the mutex for performing NVM operations. | 1083 | * Acquires the mutex for performing NVM operations. |
1084 | **/ | 1084 | **/ |
1085 | static s32 e1000_acquire_nvm_ich8lan(struct e1000_hw *hw) | 1085 | static s32 e1000_acquire_nvm_ich8lan(struct e1000_hw __always_unused *hw) |
1086 | { | 1086 | { |
1087 | mutex_lock(&nvm_mutex); | 1087 | mutex_lock(&nvm_mutex); |
1088 | 1088 | ||
@@ -1095,7 +1095,7 @@ static s32 e1000_acquire_nvm_ich8lan(struct e1000_hw *hw) | |||
1095 | * | 1095 | * |
1096 | * Releases the mutex used while performing NVM operations. | 1096 | * Releases the mutex used while performing NVM operations. |
1097 | **/ | 1097 | **/ |
1098 | static void e1000_release_nvm_ich8lan(struct e1000_hw *hw) | 1098 | static void e1000_release_nvm_ich8lan(struct e1000_hw __always_unused *hw) |
1099 | { | 1099 | { |
1100 | mutex_unlock(&nvm_mutex); | 1100 | mutex_unlock(&nvm_mutex); |
1101 | } | 1101 | } |
diff --git a/drivers/net/ethernet/intel/e1000e/mac.c b/drivers/net/ethernet/intel/e1000e/mac.c index 5992eefca54e..7365288f20f7 100644 --- a/drivers/net/ethernet/intel/e1000e/mac.c +++ b/drivers/net/ethernet/intel/e1000e/mac.c | |||
@@ -1356,8 +1356,8 @@ s32 e1000e_get_speed_and_duplex_copper(struct e1000_hw *hw, u16 *speed, | |||
1356 | * Sets the speed and duplex to gigabit full duplex (the only possible option) | 1356 | * Sets the speed and duplex to gigabit full duplex (the only possible option) |
1357 | * for fiber/serdes links. | 1357 | * for fiber/serdes links. |
1358 | **/ | 1358 | **/ |
1359 | s32 e1000e_get_speed_and_duplex_fiber_serdes(struct e1000_hw *hw, u16 *speed, | 1359 | s32 e1000e_get_speed_and_duplex_fiber_serdes(struct e1000_hw __always_unused |
1360 | u16 *duplex) | 1360 | *hw, u16 *speed, u16 *duplex) |
1361 | { | 1361 | { |
1362 | *speed = SPEED_1000; | 1362 | *speed = SPEED_1000; |
1363 | *duplex = FULL_DUPLEX; | 1363 | *duplex = FULL_DUPLEX; |
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 3bb7b014dd0e..eb01a55f60a6 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c | |||
@@ -1747,7 +1747,7 @@ static void e1000e_downshift_workaround(struct work_struct *work) | |||
1747 | * @irq: interrupt number | 1747 | * @irq: interrupt number |
1748 | * @data: pointer to a network interface device structure | 1748 | * @data: pointer to a network interface device structure |
1749 | **/ | 1749 | **/ |
1750 | static irqreturn_t e1000_intr_msi(int irq, void *data) | 1750 | static irqreturn_t e1000_intr_msi(int __always_unused irq, void *data) |
1751 | { | 1751 | { |
1752 | struct net_device *netdev = data; | 1752 | struct net_device *netdev = data; |
1753 | struct e1000_adapter *adapter = netdev_priv(netdev); | 1753 | struct e1000_adapter *adapter = netdev_priv(netdev); |
@@ -1813,7 +1813,7 @@ static irqreturn_t e1000_intr_msi(int irq, void *data) | |||
1813 | * @irq: interrupt number | 1813 | * @irq: interrupt number |
1814 | * @data: pointer to a network interface device structure | 1814 | * @data: pointer to a network interface device structure |
1815 | **/ | 1815 | **/ |
1816 | static irqreturn_t e1000_intr(int irq, void *data) | 1816 | static irqreturn_t e1000_intr(int __always_unused irq, void *data) |
1817 | { | 1817 | { |
1818 | struct net_device *netdev = data; | 1818 | struct net_device *netdev = data; |
1819 | struct e1000_adapter *adapter = netdev_priv(netdev); | 1819 | struct e1000_adapter *adapter = netdev_priv(netdev); |
@@ -1888,7 +1888,7 @@ static irqreturn_t e1000_intr(int irq, void *data) | |||
1888 | return IRQ_HANDLED; | 1888 | return IRQ_HANDLED; |
1889 | } | 1889 | } |
1890 | 1890 | ||
1891 | static irqreturn_t e1000_msix_other(int irq, void *data) | 1891 | static irqreturn_t e1000_msix_other(int __always_unused irq, void *data) |
1892 | { | 1892 | { |
1893 | struct net_device *netdev = data; | 1893 | struct net_device *netdev = data; |
1894 | struct e1000_adapter *adapter = netdev_priv(netdev); | 1894 | struct e1000_adapter *adapter = netdev_priv(netdev); |
@@ -1920,8 +1920,7 @@ no_link_interrupt: | |||
1920 | return IRQ_HANDLED; | 1920 | return IRQ_HANDLED; |
1921 | } | 1921 | } |
1922 | 1922 | ||
1923 | 1923 | static irqreturn_t e1000_intr_msix_tx(int __always_unused irq, void *data) | |
1924 | static irqreturn_t e1000_intr_msix_tx(int irq, void *data) | ||
1925 | { | 1924 | { |
1926 | struct net_device *netdev = data; | 1925 | struct net_device *netdev = data; |
1927 | struct e1000_adapter *adapter = netdev_priv(netdev); | 1926 | struct e1000_adapter *adapter = netdev_priv(netdev); |
@@ -1939,7 +1938,7 @@ static irqreturn_t e1000_intr_msix_tx(int irq, void *data) | |||
1939 | return IRQ_HANDLED; | 1938 | return IRQ_HANDLED; |
1940 | } | 1939 | } |
1941 | 1940 | ||
1942 | static irqreturn_t e1000_intr_msix_rx(int irq, void *data) | 1941 | static irqreturn_t e1000_intr_msix_rx(int __always_unused irq, void *data) |
1943 | { | 1942 | { |
1944 | struct net_device *netdev = data; | 1943 | struct net_device *netdev = data; |
1945 | struct e1000_adapter *adapter = netdev_priv(netdev); | 1944 | struct e1000_adapter *adapter = netdev_priv(netdev); |
@@ -2496,9 +2495,7 @@ void e1000e_free_rx_resources(struct e1000_ring *rx_ring) | |||
2496 | * while increasing bulk throughput. This functionality is controlled | 2495 | * while increasing bulk throughput. This functionality is controlled |
2497 | * by the InterruptThrottleRate module parameter. | 2496 | * by the InterruptThrottleRate module parameter. |
2498 | **/ | 2497 | **/ |
2499 | static unsigned int e1000_update_itr(struct e1000_adapter *adapter, | 2498 | static unsigned int e1000_update_itr(u16 itr_setting, int packets, int bytes) |
2500 | u16 itr_setting, int packets, | ||
2501 | int bytes) | ||
2502 | { | 2499 | { |
2503 | unsigned int retval = itr_setting; | 2500 | unsigned int retval = itr_setting; |
2504 | 2501 | ||
@@ -2558,18 +2555,16 @@ static void e1000_set_itr(struct e1000_adapter *adapter) | |||
2558 | goto set_itr_now; | 2555 | goto set_itr_now; |
2559 | } | 2556 | } |
2560 | 2557 | ||
2561 | adapter->tx_itr = e1000_update_itr(adapter, | 2558 | adapter->tx_itr = e1000_update_itr(adapter->tx_itr, |
2562 | adapter->tx_itr, | 2559 | adapter->total_tx_packets, |
2563 | adapter->total_tx_packets, | 2560 | adapter->total_tx_bytes); |
2564 | adapter->total_tx_bytes); | ||
2565 | /* conservative mode (itr 3) eliminates the lowest_latency setting */ | 2561 | /* conservative mode (itr 3) eliminates the lowest_latency setting */ |
2566 | if (adapter->itr_setting == 3 && adapter->tx_itr == lowest_latency) | 2562 | if (adapter->itr_setting == 3 && adapter->tx_itr == lowest_latency) |
2567 | adapter->tx_itr = low_latency; | 2563 | adapter->tx_itr = low_latency; |
2568 | 2564 | ||
2569 | adapter->rx_itr = e1000_update_itr(adapter, | 2565 | adapter->rx_itr = e1000_update_itr(adapter->rx_itr, |
2570 | adapter->rx_itr, | 2566 | adapter->total_rx_packets, |
2571 | adapter->total_rx_packets, | 2567 | adapter->total_rx_bytes); |
2572 | adapter->total_rx_bytes); | ||
2573 | /* conservative mode (itr 3) eliminates the lowest_latency setting */ | 2568 | /* conservative mode (itr 3) eliminates the lowest_latency setting */ |
2574 | if (adapter->itr_setting == 3 && adapter->rx_itr == lowest_latency) | 2569 | if (adapter->itr_setting == 3 && adapter->rx_itr == lowest_latency) |
2575 | adapter->rx_itr = low_latency; | 2570 | adapter->rx_itr = low_latency; |
@@ -4115,7 +4110,7 @@ static int e1000_sw_init(struct e1000_adapter *adapter) | |||
4115 | * @irq: interrupt number | 4110 | * @irq: interrupt number |
4116 | * @data: pointer to a network interface device structure | 4111 | * @data: pointer to a network interface device structure |
4117 | **/ | 4112 | **/ |
4118 | static irqreturn_t e1000_intr_msi_test(int irq, void *data) | 4113 | static irqreturn_t e1000_intr_msi_test(int __always_unused irq, void *data) |
4119 | { | 4114 | { |
4120 | struct net_device *netdev = data; | 4115 | struct net_device *netdev = data; |
4121 | struct e1000_adapter *adapter = netdev_priv(netdev); | 4116 | struct e1000_adapter *adapter = netdev_priv(netdev); |
@@ -6249,7 +6244,7 @@ static void e1000_shutdown(struct pci_dev *pdev) | |||
6249 | 6244 | ||
6250 | #ifdef CONFIG_NET_POLL_CONTROLLER | 6245 | #ifdef CONFIG_NET_POLL_CONTROLLER |
6251 | 6246 | ||
6252 | static irqreturn_t e1000_intr_msix(int irq, void *data) | 6247 | static irqreturn_t e1000_intr_msix(int __always_unused irq, void *data) |
6253 | { | 6248 | { |
6254 | struct net_device *netdev = data; | 6249 | struct net_device *netdev = data; |
6255 | struct e1000_adapter *adapter = netdev_priv(netdev); | 6250 | struct e1000_adapter *adapter = netdev_priv(netdev); |
diff --git a/drivers/net/ethernet/intel/e1000e/phy.c b/drivers/net/ethernet/intel/e1000e/phy.c index 8dd1da018713..6f32811dbcf0 100644 --- a/drivers/net/ethernet/intel/e1000e/phy.c +++ b/drivers/net/ethernet/intel/e1000e/phy.c | |||
@@ -2178,7 +2178,7 @@ s32 e1000e_phy_hw_reset_generic(struct e1000_hw *hw) | |||
2178 | * Generic function to wait 10 milli-seconds for configuration to complete | 2178 | * Generic function to wait 10 milli-seconds for configuration to complete |
2179 | * and return success. | 2179 | * and return success. |
2180 | **/ | 2180 | **/ |
2181 | s32 e1000e_get_cfg_done_generic(struct e1000_hw *hw) | 2181 | s32 e1000e_get_cfg_done_generic(struct e1000_hw __always_unused *hw) |
2182 | { | 2182 | { |
2183 | mdelay(10); | 2183 | mdelay(10); |
2184 | 2184 | ||
diff --git a/drivers/net/ethernet/intel/e1000e/ptp.c b/drivers/net/ethernet/intel/e1000e/ptp.c index 6b8df6587858..b477fa53ec94 100644 --- a/drivers/net/ethernet/intel/e1000e/ptp.c +++ b/drivers/net/ethernet/intel/e1000e/ptp.c | |||
@@ -165,8 +165,9 @@ static int e1000e_phc_settime(struct ptp_clock_info *ptp, | |||
165 | * Enable (or disable) ancillary features of the PHC subsystem. | 165 | * Enable (or disable) ancillary features of the PHC subsystem. |
166 | * Currently, no ancillary features are supported. | 166 | * Currently, no ancillary features are supported. |
167 | **/ | 167 | **/ |
168 | static int e1000e_phc_enable(struct ptp_clock_info *ptp, | 168 | static int e1000e_phc_enable(struct ptp_clock_info __always_unused *ptp, |
169 | struct ptp_clock_request *request, int on) | 169 | struct ptp_clock_request __always_unused *request, |
170 | int __always_unused on) | ||
170 | { | 171 | { |
171 | return -EOPNOTSUPP; | 172 | return -EOPNOTSUPP; |
172 | } | 173 | } |