USB: sierra: fix memory leak in attach error path

Make sure port private data is deallocated on errors in attach.

Cc: <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 8 insertions, 1 deletions

diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 76ef95bcbbf2..2cb27e49d4ac 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -905,7 +905,7 @@ static int sierra_startup(struct usb_serial *serial)
                         dev_dbg(&port->dev, "%s: kmalloc for "
                                 "sierra_port_private (%d) failed!\n",
                                 __func__, i);
-                        return -ENOMEM;
+                        goto err;
                 }
                 spin_lock_init(&portdata->lock);
                 init_usb_anchor(&portdata->active);
@@ -942,6 +942,13 @@ static int sierra_startup(struct usb_serial *serial)
         }
 
         return 0;
+err:
+        for (--i; i >= 0; --i) {
+                portdata = usb_get_serial_port_data(serial->port[i]);
+                kfree(portdata);
+        }
+
+        return -ENOMEM;
 }
 
 static void sierra_release(struct usb_serial *serial)