diff options
author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-01-04 20:10:19 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-01-04 20:10:19 -0500 |
commit | 6225f18b88b9ba6c6643aa8c1c96f51a9ad24380 (patch) | |
tree | a8f664e24e0b070f1ab00f6c1d718ead5d582a21 /drivers | |
parent | 534e04810304a9c6715220b392aa387197d5fa15 (diff) |
[media] Don't test for ops->info.type inside drivers
Now, ops->info.type is handled inside the dvb_frontend
core, only for DVBv3 calls, and according with the
delivery system. So, drivers should not care or use it,
otherwise, it may have issues with DVBv5 calls.
The drivers that were still using it were detected via
this small temporary hack:
--- a/include/linux/dvb/frontend.h
+++ b/include/linux/dvb/frontend.h
@@ -29,13 +29,16 @@
#include <linux/types.h>
typedef enum fe_type {
+#if defined(__DVB_CORE__) || !defined (__KERNEL__)
FE_QPSK,
FE_QAM,
FE_OFDM,
FE_ATSC
+#else
+FE_FOOO
+#endif
} fe_type_t;
-
typedef enum fe_caps {
FE_IS_STUPID = 0,
FE_CAN_INVERSION_AUTO = 0x1,
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/media/common/tuners/tda827x.c | 7 | ||||
-rw-r--r-- | drivers/media/dvb/firewire/firedtv-fe.c | 6 | ||||
-rw-r--r-- | drivers/staging/media/as102/as102_fe.c | 1 |
3 files changed, 7 insertions, 7 deletions
diff --git a/drivers/media/common/tuners/tda827x.c b/drivers/media/common/tuners/tda827x.c index e180def0a657..a0d176267470 100644 --- a/drivers/media/common/tuners/tda827x.c +++ b/drivers/media/common/tuners/tda827x.c | |||
@@ -540,9 +540,14 @@ static int tda827xa_set_params(struct dvb_frontend *fe) | |||
540 | } | 540 | } |
541 | tuner_freq = c->frequency; | 541 | tuner_freq = c->frequency; |
542 | 542 | ||
543 | if (fe->ops.info.type == FE_QAM) { | 543 | switch (c->delivery_system) { |
544 | case SYS_DVBC_ANNEX_A: | ||
545 | case SYS_DVBC_ANNEX_C: | ||
544 | dprintk("%s select tda827xa_dvbc\n", __func__); | 546 | dprintk("%s select tda827xa_dvbc\n", __func__); |
545 | frequency_map = tda827xa_dvbc; | 547 | frequency_map = tda827xa_dvbc; |
548 | break; | ||
549 | default: | ||
550 | break; | ||
546 | } | 551 | } |
547 | 552 | ||
548 | i = 0; | 553 | i = 0; |
diff --git a/drivers/media/dvb/firewire/firedtv-fe.c b/drivers/media/dvb/firewire/firedtv-fe.c index 39f5caafd2be..6fe9793b98b3 100644 --- a/drivers/media/dvb/firewire/firedtv-fe.c +++ b/drivers/media/dvb/firewire/firedtv-fe.c | |||
@@ -173,7 +173,6 @@ void fdtv_frontend_init(struct firedtv *fdtv, const char *name) | |||
173 | switch (fdtv->type) { | 173 | switch (fdtv->type) { |
174 | case FIREDTV_DVB_S: | 174 | case FIREDTV_DVB_S: |
175 | ops->delsys[0] = SYS_DVBS; | 175 | ops->delsys[0] = SYS_DVBS; |
176 | fi->type = FE_QPSK; | ||
177 | 176 | ||
178 | fi->frequency_min = 950000; | 177 | fi->frequency_min = 950000; |
179 | fi->frequency_max = 2150000; | 178 | fi->frequency_max = 2150000; |
@@ -193,8 +192,7 @@ void fdtv_frontend_init(struct firedtv *fdtv, const char *name) | |||
193 | 192 | ||
194 | case FIREDTV_DVB_S2: | 193 | case FIREDTV_DVB_S2: |
195 | ops->delsys[0] = SYS_DVBS; | 194 | ops->delsys[0] = SYS_DVBS; |
196 | ops->delsys[1] = SYS_DVBS; | 195 | ops->delsys[1] = SYS_DVBS2; |
197 | fi->type = FE_QPSK; | ||
198 | 196 | ||
199 | fi->frequency_min = 950000; | 197 | fi->frequency_min = 950000; |
200 | fi->frequency_max = 2150000; | 198 | fi->frequency_max = 2150000; |
@@ -215,7 +213,6 @@ void fdtv_frontend_init(struct firedtv *fdtv, const char *name) | |||
215 | 213 | ||
216 | case FIREDTV_DVB_C: | 214 | case FIREDTV_DVB_C: |
217 | ops->delsys[0] = SYS_DVBC_ANNEX_A; | 215 | ops->delsys[0] = SYS_DVBC_ANNEX_A; |
218 | fi->type = FE_QAM; | ||
219 | 216 | ||
220 | fi->frequency_min = 47000000; | 217 | fi->frequency_min = 47000000; |
221 | fi->frequency_max = 866000000; | 218 | fi->frequency_max = 866000000; |
@@ -234,7 +231,6 @@ void fdtv_frontend_init(struct firedtv *fdtv, const char *name) | |||
234 | 231 | ||
235 | case FIREDTV_DVB_T: | 232 | case FIREDTV_DVB_T: |
236 | ops->delsys[0] = SYS_DVBT; | 233 | ops->delsys[0] = SYS_DVBT; |
237 | fi->type = FE_OFDM; | ||
238 | 234 | ||
239 | fi->frequency_min = 49000000; | 235 | fi->frequency_min = 49000000; |
240 | fi->frequency_max = 861000000; | 236 | fi->frequency_max = 861000000; |
diff --git a/drivers/staging/media/as102/as102_fe.c b/drivers/staging/media/as102/as102_fe.c index 06bfe84aeb27..bdc5a38cddf7 100644 --- a/drivers/staging/media/as102/as102_fe.c +++ b/drivers/staging/media/as102/as102_fe.c | |||
@@ -282,7 +282,6 @@ static struct dvb_frontend_ops as102_fe_ops = { | |||
282 | .delsys = { SYS_DVBT }, | 282 | .delsys = { SYS_DVBT }, |
283 | .info = { | 283 | .info = { |
284 | .name = "Unknown AS102 device", | 284 | .name = "Unknown AS102 device", |
285 | .type = FE_OFDM, | ||
286 | .frequency_min = 174000000, | 285 | .frequency_min = 174000000, |
287 | .frequency_max = 862000000, | 286 | .frequency_max = 862000000, |
288 | .frequency_stepsize = 166667, | 287 | .frequency_stepsize = 166667, |