diff options
author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-03-26 11:17:21 -0500 |
---|---|---|
committer | Adrian Bunk <bunk@stusta.de> | 2006-03-26 11:17:21 -0500 |
commit | 56ee48277fa214b3b7b0fd91e7fd3464e12597de (patch) | |
tree | 58068d7f6ccf295aa8dc10a131e34fc9fe3c3528 /drivers | |
parent | 373ebfbf17a8ecad304f65cb92c4d2d10adc0a19 (diff) |
BUG_ON() Conversion in drivers/char
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/char/epca.c | 3 | ||||
-rw-r--r-- | drivers/char/tty_io.c | 11 |
2 files changed, 5 insertions, 9 deletions
diff --git a/drivers/char/epca.c b/drivers/char/epca.c index 765c5c108bf4..9cad8501d62c 100644 --- a/drivers/char/epca.c +++ b/drivers/char/epca.c | |||
@@ -486,8 +486,7 @@ static void pc_close(struct tty_struct * tty, struct file * filp) | |||
486 | } /* End channel is open more than once */ | 486 | } /* End channel is open more than once */ |
487 | 487 | ||
488 | /* Port open only once go ahead with shutdown & reset */ | 488 | /* Port open only once go ahead with shutdown & reset */ |
489 | if (ch->count < 0) | 489 | BUG_ON(ch->count < 0); |
490 | BUG(); | ||
491 | 490 | ||
492 | /* --------------------------------------------------------------- | 491 | /* --------------------------------------------------------------- |
493 | Let the rest of the driver know the channel is being closed. | 492 | Let the rest of the driver know the channel is being closed. |
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index 48d795bb8c4b..811dadb9ce3e 100644 --- a/drivers/char/tty_io.c +++ b/drivers/char/tty_io.c | |||
@@ -543,14 +543,12 @@ void tty_ldisc_put(int disc) | |||
543 | struct tty_ldisc *ld; | 543 | struct tty_ldisc *ld; |
544 | unsigned long flags; | 544 | unsigned long flags; |
545 | 545 | ||
546 | if (disc < N_TTY || disc >= NR_LDISCS) | 546 | BUG_ON(disc < N_TTY || disc >= NR_LDISCS); |
547 | BUG(); | ||
548 | 547 | ||
549 | spin_lock_irqsave(&tty_ldisc_lock, flags); | 548 | spin_lock_irqsave(&tty_ldisc_lock, flags); |
550 | ld = &tty_ldiscs[disc]; | 549 | ld = &tty_ldiscs[disc]; |
551 | if(ld->refcount == 0) | 550 | BUG_ON(ld->refcount == 0); |
552 | BUG(); | 551 | ld->refcount--; |
553 | ld->refcount --; | ||
554 | module_put(ld->owner); | 552 | module_put(ld->owner); |
555 | spin_unlock_irqrestore(&tty_ldisc_lock, flags); | 553 | spin_unlock_irqrestore(&tty_ldisc_lock, flags); |
556 | } | 554 | } |
@@ -645,8 +643,7 @@ void tty_ldisc_deref(struct tty_ldisc *ld) | |||
645 | { | 643 | { |
646 | unsigned long flags; | 644 | unsigned long flags; |
647 | 645 | ||
648 | if(ld == NULL) | 646 | BUG_ON(ld == NULL); |
649 | BUG(); | ||
650 | 647 | ||
651 | spin_lock_irqsave(&tty_ldisc_lock, flags); | 648 | spin_lock_irqsave(&tty_ldisc_lock, flags); |
652 | if(ld->refcount == 0) | 649 | if(ld->refcount == 0) |