diff options
author | Dan Williams <dan.j.williams@intel.com> | 2007-04-26 03:12:10 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-04-27 13:57:34 -0400 |
commit | 404d5b185b4eb56d6fa2f7bd27833f8df1c38ce4 (patch) | |
tree | 1130df0503191529ee7088ccf3868d3be81ebc2d /drivers | |
parent | 61a2f59af6c8ffd9d6dd53f0da32563d4434e790 (diff) |
dev_dbg: check dev_dbg() arguments
Duplicate what Zach Brown did for pr_debug in commit
8b2a1fd1b394c60eaa2587716102dd5e9b4e5990
[akpm@linux-foundation.org: fix a couple of things which broke]
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/usb/core/hub.c | 4 | ||||
-rw-r--r-- | drivers/usb/host/ohci-hcd.c | 6 |
2 files changed, 1 insertions, 9 deletions
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index b89a98e61323..7a6028599d62 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c | |||
@@ -119,8 +119,7 @@ MODULE_PARM_DESC(use_both_schemes, | |||
119 | "first one fails"); | 119 | "first one fails"); |
120 | 120 | ||
121 | 121 | ||
122 | #ifdef DEBUG | 122 | static inline char *portspeed(int portstatus) |
123 | static inline char *portspeed (int portstatus) | ||
124 | { | 123 | { |
125 | if (portstatus & (1 << USB_PORT_FEAT_HIGHSPEED)) | 124 | if (portstatus & (1 << USB_PORT_FEAT_HIGHSPEED)) |
126 | return "480 Mb/s"; | 125 | return "480 Mb/s"; |
@@ -129,7 +128,6 @@ static inline char *portspeed (int portstatus) | |||
129 | else | 128 | else |
130 | return "12 Mb/s"; | 129 | return "12 Mb/s"; |
131 | } | 130 | } |
132 | #endif | ||
133 | 131 | ||
134 | /* Note that hdev or one of its children must be locked! */ | 132 | /* Note that hdev or one of its children must be locked! */ |
135 | static inline struct usb_hub *hdev_to_hub(struct usb_device *hdev) | 133 | static inline struct usb_hub *hdev_to_hub(struct usb_device *hdev) |
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index f0d29eda3c6d..e8bbe8bc2598 100644 --- a/drivers/usb/host/ohci-hcd.c +++ b/drivers/usb/host/ohci-hcd.c | |||
@@ -486,9 +486,6 @@ static int ohci_run (struct ohci_hcd *ohci) | |||
486 | * or if bus glue did the same (e.g. for PCI add-in cards with | 486 | * or if bus glue did the same (e.g. for PCI add-in cards with |
487 | * PCI PM support). | 487 | * PCI PM support). |
488 | */ | 488 | */ |
489 | ohci_dbg (ohci, "resetting from state '%s', control = 0x%x\n", | ||
490 | hcfs2string (ohci->hc_control & OHCI_CTRL_HCFS), | ||
491 | ohci_readl (ohci, &ohci->regs->control)); | ||
492 | if ((ohci->hc_control & OHCI_CTRL_RWC) != 0 | 489 | if ((ohci->hc_control & OHCI_CTRL_RWC) != 0 |
493 | && !device_may_wakeup(hcd->self.controller)) | 490 | && !device_may_wakeup(hcd->self.controller)) |
494 | device_init_wakeup(hcd->self.controller, 1); | 491 | device_init_wakeup(hcd->self.controller, 1); |
@@ -744,9 +741,6 @@ static void ohci_stop (struct usb_hcd *hcd) | |||
744 | { | 741 | { |
745 | struct ohci_hcd *ohci = hcd_to_ohci (hcd); | 742 | struct ohci_hcd *ohci = hcd_to_ohci (hcd); |
746 | 743 | ||
747 | ohci_dbg (ohci, "stop %s controller (state 0x%02x)\n", | ||
748 | hcfs2string (ohci->hc_control & OHCI_CTRL_HCFS), | ||
749 | hcd->state); | ||
750 | ohci_dump (ohci, 1); | 744 | ohci_dump (ohci, 1); |
751 | 745 | ||
752 | flush_scheduled_work(); | 746 | flush_scheduled_work(); |