aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorCarsten Otte <cotte@de.ibm.com>2010-06-21 18:57:08 -0400
committerDavid S. Miller <davem@davemloft.net>2010-06-23 16:16:35 -0400
commit38593d019d08fef6d048bd7ab1db8076733e3709 (patch)
tree5ec61f72b4b5578171fd433f27c1eaffb8d5e168 /drivers
parentefd5d9a407f248bc7b684513a9ce9fe1fd19b478 (diff)
qeth: Fold qeth_qerr debug area
This patch removes the qerr debug area. Most info that goes in here is logged to the card's local debug area already, those duplicates are removed. All other elements are moved to the card's local debug area. Signed-off-by: Carsten Otte <cotte@de.ibm.com> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/s390/net/qeth_core.h1
-rw-r--r--drivers/s390/net/qeth_core_main.c14
2 files changed, 4 insertions, 11 deletions
diff --git a/drivers/s390/net/qeth_core.h b/drivers/s390/net/qeth_core.h
index ebb83d782263..0b4250d3a25d 100644
--- a/drivers/s390/net/qeth_core.h
+++ b/drivers/s390/net/qeth_core.h
@@ -40,7 +40,6 @@
40 */ 40 */
41enum qeth_dbf_names { 41enum qeth_dbf_names {
42 QETH_DBF_SETUP, 42 QETH_DBF_SETUP,
43 QETH_DBF_QERR,
44 QETH_DBF_MSG, 43 QETH_DBF_MSG,
45 QETH_DBF_CTRL, 44 QETH_DBF_CTRL,
46 QETH_DBF_INFOS /* must be last element */ 45 QETH_DBF_INFOS /* must be last element */
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index e4655feb52cb..d510dfa58562 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -32,8 +32,6 @@ struct qeth_dbf_info qeth_dbf[QETH_DBF_INFOS] = {
32 /* N P A M L V H */ 32 /* N P A M L V H */
33 [QETH_DBF_SETUP] = {"qeth_setup", 33 [QETH_DBF_SETUP] = {"qeth_setup",
34 8, 1, 8, 5, &debug_hex_ascii_view, NULL}, 34 8, 1, 8, 5, &debug_hex_ascii_view, NULL},
35 [QETH_DBF_QERR] = {"qeth_qerr",
36 2, 1, 8, 2, &debug_hex_ascii_view, NULL},
37 [QETH_DBF_MSG] = {"qeth_msg", 35 [QETH_DBF_MSG] = {"qeth_msg",
38 8, 1, 128, 3, &debug_sprintf_view, NULL}, 36 8, 1, 128, 3, &debug_sprintf_view, NULL},
39 [QETH_DBF_CTRL] = {"qeth_control", 37 [QETH_DBF_CTRL] = {"qeth_control",
@@ -2641,12 +2639,11 @@ int qeth_check_qdio_errors(struct qeth_card *card, struct qdio_buffer *buf,
2641{ 2639{
2642 if (qdio_error) { 2640 if (qdio_error) {
2643 QETH_CARD_TEXT(card, 2, dbftext); 2641 QETH_CARD_TEXT(card, 2, dbftext);
2644 QETH_DBF_TEXT(QERR, 2, dbftext); 2642 QETH_CARD_TEXT_(card, 2, " F15=%02X",
2645 QETH_DBF_TEXT_(QERR, 2, " F15=%02X",
2646 buf->element[15].flags & 0xff); 2643 buf->element[15].flags & 0xff);
2647 QETH_DBF_TEXT_(QERR, 2, " F14=%02X", 2644 QETH_CARD_TEXT_(card, 2, " F14=%02X",
2648 buf->element[14].flags & 0xff); 2645 buf->element[14].flags & 0xff);
2649 QETH_DBF_TEXT_(QERR, 2, " qerr=%X", qdio_error); 2646 QETH_CARD_TEXT_(card, 2, " qerr=%X", qdio_error);
2650 if ((buf->element[15].flags & 0xff) == 0x12) { 2647 if ((buf->element[15].flags & 0xff) == 0x12) {
2651 card->stats.rx_dropped++; 2648 card->stats.rx_dropped++;
2652 return 0; 2649 return 0;
@@ -3201,7 +3198,7 @@ int qeth_do_send_packet_fast(struct qeth_card *card,
3201 rc = dev_queue_xmit(skb); 3198 rc = dev_queue_xmit(skb);
3202 } else { 3199 } else {
3203 dev_kfree_skb_any(skb); 3200 dev_kfree_skb_any(skb);
3204 QETH_DBF_TEXT(QERR, 2, "qrdrop"); 3201 QETH_CARD_TEXT(card, 2, "qrdrop");
3205 } 3202 }
3206 } 3203 }
3207 return 0; 3204 return 0;
@@ -4112,9 +4109,6 @@ struct sk_buff *qeth_core_get_next_skb(struct qeth_card *card,
4112 if (skb_len) { 4109 if (skb_len) {
4113 if (qeth_is_last_sbale(element)) { 4110 if (qeth_is_last_sbale(element)) {
4114 QETH_CARD_TEXT(card, 4, "unexeob"); 4111 QETH_CARD_TEXT(card, 4, "unexeob");
4115 QETH_DBF_TEXT(QERR, 2, "unexeob");
4116 QETH_DBF_TEXT_(QERR, 2, "%s",
4117 CARD_BUS_ID(card));
4118 QETH_CARD_HEX(card, 2, buffer, sizeof(void *)); 4112 QETH_CARD_HEX(card, 2, buffer, sizeof(void *));
4119 dev_kfree_skb_any(skb); 4113 dev_kfree_skb_any(skb);
4120 card->stats.rx_errors++; 4114 card->stats.rx_errors++;