diff options
| author | Jeff Garzik <jeff@garzik.org> | 2008-02-06 04:36:20 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-06 13:41:01 -0500 |
| commit | 15aafa2f9d8399b22e418c53a87dfc0c43f4030f (patch) | |
| tree | 7861111fb87f4f69e496901d8883d0b796521255 /drivers | |
| parent | bcfbf84d4067674b0740a39605f8057622ad5230 (diff) | |
Remove pointless casts from void pointers
Mostly in and around irq handlers.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: "Luck Tony" <tony.luck@intel.com>
Cc: Roman Zippel <zippel@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
Cc: Karsten Keil <kkeil@suse.de>
Acked-by: "John W. Linville" <linville@tuxdriver.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Cc: David Brownell <david-b@pacbell.net>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Acked-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/input/touchscreen/h3600_ts_input.c | 4 | ||||
| -rw-r--r-- | drivers/isdn/hardware/eicon/diva.c | 5 | ||||
| -rw-r--r-- | drivers/scsi/aic7xxx_old.c | 2 | ||||
| -rw-r--r-- | drivers/scsi/ibmvscsi/ibmvstgt.c | 4 | ||||
| -rw-r--r-- | drivers/serial/cpm_uart/cpm_uart_core.c | 2 | ||||
| -rw-r--r-- | drivers/serial/dz.c | 2 | ||||
| -rw-r--r-- | drivers/serial/imx.c | 4 | ||||
| -rw-r--r-- | drivers/serial/uartlite.c | 2 | ||||
| -rw-r--r-- | drivers/spi/spi_bfin5xx.c | 2 | ||||
| -rw-r--r-- | drivers/video/bf54x-lq043fb.c | 3 | ||||
| -rw-r--r-- | drivers/video/intelfb/intelfbhw.c | 2 |
11 files changed, 15 insertions, 17 deletions
diff --git a/drivers/input/touchscreen/h3600_ts_input.c b/drivers/input/touchscreen/h3600_ts_input.c index 2ae6c6016a86..28ae15ed12c5 100644 --- a/drivers/input/touchscreen/h3600_ts_input.c +++ b/drivers/input/touchscreen/h3600_ts_input.c | |||
| @@ -109,7 +109,7 @@ struct h3600_dev { | |||
| 109 | static irqreturn_t action_button_handler(int irq, void *dev_id) | 109 | static irqreturn_t action_button_handler(int irq, void *dev_id) |
| 110 | { | 110 | { |
| 111 | int down = (GPLR & GPIO_BITSY_ACTION_BUTTON) ? 0 : 1; | 111 | int down = (GPLR & GPIO_BITSY_ACTION_BUTTON) ? 0 : 1; |
| 112 | struct input_dev *dev = (struct input_dev *) dev_id; | 112 | struct input_dev *dev = dev_id; |
| 113 | 113 | ||
| 114 | input_report_key(dev, KEY_ENTER, down); | 114 | input_report_key(dev, KEY_ENTER, down); |
| 115 | input_sync(dev); | 115 | input_sync(dev); |
| @@ -120,7 +120,7 @@ static irqreturn_t action_button_handler(int irq, void *dev_id) | |||
| 120 | static irqreturn_t npower_button_handler(int irq, void *dev_id) | 120 | static irqreturn_t npower_button_handler(int irq, void *dev_id) |
| 121 | { | 121 | { |
| 122 | int down = (GPLR & GPIO_BITSY_NPOWER_BUTTON) ? 0 : 1; | 122 | int down = (GPLR & GPIO_BITSY_NPOWER_BUTTON) ? 0 : 1; |
| 123 | struct input_dev *dev = (struct input_dev *) dev_id; | 123 | struct input_dev *dev = dev_id; |
| 124 | 124 | ||
| 125 | /* | 125 | /* |
| 126 | * This interrupt is only called when we release the key. So we have | 126 | * This interrupt is only called when we release the key. So we have |
diff --git a/drivers/isdn/hardware/eicon/diva.c b/drivers/isdn/hardware/eicon/diva.c index ffa2afa77c2f..1403a5458e68 100644 --- a/drivers/isdn/hardware/eicon/diva.c +++ b/drivers/isdn/hardware/eicon/diva.c | |||
| @@ -515,12 +515,11 @@ diva_xdi_read(void *adapter, void *os_handle, void __user *dst, | |||
| 515 | 515 | ||
| 516 | irqreturn_t diva_os_irq_wrapper(int irq, void *context) | 516 | irqreturn_t diva_os_irq_wrapper(int irq, void *context) |
| 517 | { | 517 | { |
| 518 | diva_os_xdi_adapter_t *a = (diva_os_xdi_adapter_t *) context; | 518 | diva_os_xdi_adapter_t *a = context; |
| 519 | diva_xdi_clear_interrupts_proc_t clear_int_proc; | 519 | diva_xdi_clear_interrupts_proc_t clear_int_proc; |
| 520 | 520 | ||
| 521 | if (!a || !a->xdi_adapter.diva_isr_handler) { | 521 | if (!a || !a->xdi_adapter.diva_isr_handler) |
| 522 | return IRQ_NONE; | 522 | return IRQ_NONE; |
| 523 | } | ||
| 524 | 523 | ||
| 525 | if ((clear_int_proc = a->clear_interrupts_proc)) { | 524 | if ((clear_int_proc = a->clear_interrupts_proc)) { |
| 526 | (*clear_int_proc) (a); | 525 | (*clear_int_proc) (a); |
diff --git a/drivers/scsi/aic7xxx_old.c b/drivers/scsi/aic7xxx_old.c index 3bfd9296bbfa..93984c9dfe14 100644 --- a/drivers/scsi/aic7xxx_old.c +++ b/drivers/scsi/aic7xxx_old.c | |||
| @@ -6472,7 +6472,7 @@ do_aic7xxx_isr(int irq, void *dev_id) | |||
| 6472 | unsigned long cpu_flags; | 6472 | unsigned long cpu_flags; |
| 6473 | struct aic7xxx_host *p; | 6473 | struct aic7xxx_host *p; |
| 6474 | 6474 | ||
| 6475 | p = (struct aic7xxx_host *)dev_id; | 6475 | p = dev_id; |
| 6476 | if(!p) | 6476 | if(!p) |
| 6477 | return IRQ_NONE; | 6477 | return IRQ_NONE; |
| 6478 | spin_lock_irqsave(p->host->host_lock, cpu_flags); | 6478 | spin_lock_irqsave(p->host->host_lock, cpu_flags); |
diff --git a/drivers/scsi/ibmvscsi/ibmvstgt.c b/drivers/scsi/ibmvscsi/ibmvstgt.c index d63f11e95abf..bd62131b97a1 100644 --- a/drivers/scsi/ibmvscsi/ibmvstgt.c +++ b/drivers/scsi/ibmvscsi/ibmvstgt.c | |||
| @@ -539,9 +539,9 @@ out: | |||
| 539 | srp_iu_put(iue); | 539 | srp_iu_put(iue); |
| 540 | } | 540 | } |
| 541 | 541 | ||
| 542 | static irqreturn_t ibmvstgt_interrupt(int irq, void *data) | 542 | static irqreturn_t ibmvstgt_interrupt(int dummy, void *data) |
| 543 | { | 543 | { |
| 544 | struct srp_target *target = (struct srp_target *) data; | 544 | struct srp_target *target = data; |
| 545 | struct vio_port *vport = target_to_port(target); | 545 | struct vio_port *vport = target_to_port(target); |
| 546 | 546 | ||
| 547 | vio_disable_interrupts(vport->dma_dev); | 547 | vio_disable_interrupts(vport->dma_dev); |
diff --git a/drivers/serial/cpm_uart/cpm_uart_core.c b/drivers/serial/cpm_uart/cpm_uart_core.c index b5e4478de0e3..236af9d33851 100644 --- a/drivers/serial/cpm_uart/cpm_uart_core.c +++ b/drivers/serial/cpm_uart/cpm_uart_core.c | |||
| @@ -380,7 +380,7 @@ static void cpm_uart_int_rx(struct uart_port *port) | |||
| 380 | static irqreturn_t cpm_uart_int(int irq, void *data) | 380 | static irqreturn_t cpm_uart_int(int irq, void *data) |
| 381 | { | 381 | { |
| 382 | u8 events; | 382 | u8 events; |
| 383 | struct uart_port *port = (struct uart_port *)data; | 383 | struct uart_port *port = data; |
| 384 | struct uart_cpm_port *pinfo = (struct uart_cpm_port *)port; | 384 | struct uart_cpm_port *pinfo = (struct uart_cpm_port *)port; |
| 385 | smc_t __iomem *smcp = pinfo->smcp; | 385 | smc_t __iomem *smcp = pinfo->smcp; |
| 386 | scc_t __iomem *sccp = pinfo->sccp; | 386 | scc_t __iomem *sccp = pinfo->sccp; |
diff --git a/drivers/serial/dz.c b/drivers/serial/dz.c index d31721f2744d..bbae5a220219 100644 --- a/drivers/serial/dz.c +++ b/drivers/serial/dz.c | |||
| @@ -324,7 +324,7 @@ static inline void check_modem_status(struct dz_port *dport) | |||
| 324 | */ | 324 | */ |
| 325 | static irqreturn_t dz_interrupt(int irq, void *dev) | 325 | static irqreturn_t dz_interrupt(int irq, void *dev) |
| 326 | { | 326 | { |
| 327 | struct dz_port *dport = (struct dz_port *)dev; | 327 | struct dz_port *dport = dev; |
| 328 | unsigned short status; | 328 | unsigned short status; |
| 329 | 329 | ||
| 330 | /* get the reason why we just got an irq */ | 330 | /* get the reason why we just got an irq */ |
diff --git a/drivers/serial/imx.c b/drivers/serial/imx.c index dc1967176fe2..56af1f566a4c 100644 --- a/drivers/serial/imx.c +++ b/drivers/serial/imx.c | |||
| @@ -308,7 +308,7 @@ static void imx_start_tx(struct uart_port *port) | |||
| 308 | 308 | ||
| 309 | static irqreturn_t imx_rtsint(int irq, void *dev_id) | 309 | static irqreturn_t imx_rtsint(int irq, void *dev_id) |
| 310 | { | 310 | { |
| 311 | struct imx_port *sport = (struct imx_port *)dev_id; | 311 | struct imx_port *sport = dev_id; |
| 312 | unsigned int val = readl(sport->port.membase + USR1) & USR1_RTSS; | 312 | unsigned int val = readl(sport->port.membase + USR1) & USR1_RTSS; |
| 313 | unsigned long flags; | 313 | unsigned long flags; |
| 314 | 314 | ||
| @@ -324,7 +324,7 @@ static irqreturn_t imx_rtsint(int irq, void *dev_id) | |||
| 324 | 324 | ||
| 325 | static irqreturn_t imx_txint(int irq, void *dev_id) | 325 | static irqreturn_t imx_txint(int irq, void *dev_id) |
| 326 | { | 326 | { |
| 327 | struct imx_port *sport = (struct imx_port *)dev_id; | 327 | struct imx_port *sport = dev_id; |
| 328 | struct circ_buf *xmit = &sport->port.info->xmit; | 328 | struct circ_buf *xmit = &sport->port.info->xmit; |
| 329 | unsigned long flags; | 329 | unsigned long flags; |
| 330 | 330 | ||
diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c index 80943409edb0..bacf68dca01a 100644 --- a/drivers/serial/uartlite.c +++ b/drivers/serial/uartlite.c | |||
| @@ -142,7 +142,7 @@ static int ulite_transmit(struct uart_port *port, int stat) | |||
| 142 | 142 | ||
| 143 | static irqreturn_t ulite_isr(int irq, void *dev_id) | 143 | static irqreturn_t ulite_isr(int irq, void *dev_id) |
| 144 | { | 144 | { |
| 145 | struct uart_port *port = (struct uart_port *)dev_id; | 145 | struct uart_port *port = dev_id; |
| 146 | int busy; | 146 | int busy; |
| 147 | 147 | ||
| 148 | do { | 148 | do { |
diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c index 7ef39a6e8c06..61cc5e0c2cbb 100644 --- a/drivers/spi/spi_bfin5xx.c +++ b/drivers/spi/spi_bfin5xx.c | |||
| @@ -616,7 +616,7 @@ static void giveback(struct driver_data *drv_data) | |||
| 616 | 616 | ||
| 617 | static irqreturn_t dma_irq_handler(int irq, void *dev_id) | 617 | static irqreturn_t dma_irq_handler(int irq, void *dev_id) |
| 618 | { | 618 | { |
| 619 | struct driver_data *drv_data = (struct driver_data *)dev_id; | 619 | struct driver_data *drv_data = dev_id; |
| 620 | struct chip_data *chip = drv_data->cur_chip; | 620 | struct chip_data *chip = drv_data->cur_chip; |
| 621 | struct spi_message *msg = drv_data->cur_msg; | 621 | struct spi_message *msg = drv_data->cur_msg; |
| 622 | 622 | ||
diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c index c8e7427a0bc8..0ce791e6f79c 100644 --- a/drivers/video/bf54x-lq043fb.c +++ b/drivers/video/bf54x-lq043fb.c | |||
| @@ -498,8 +498,7 @@ static struct lcd_device *lcd_dev; | |||
| 498 | 498 | ||
| 499 | static irqreturn_t bfin_bf54x_irq_error(int irq, void *dev_id) | 499 | static irqreturn_t bfin_bf54x_irq_error(int irq, void *dev_id) |
| 500 | { | 500 | { |
| 501 | 501 | /*struct bfin_bf54xfb_info *info = dev_id;*/ | |
| 502 | /*struct bfin_bf54xfb_info *info = (struct bfin_bf54xfb_info *)dev_id;*/ | ||
| 503 | 502 | ||
| 504 | u16 status = bfin_read_EPPI0_STATUS(); | 503 | u16 status = bfin_read_EPPI0_STATUS(); |
| 505 | 504 | ||
diff --git a/drivers/video/intelfb/intelfbhw.c b/drivers/video/intelfb/intelfbhw.c index 5f6fb7d2c408..fa1fff553565 100644 --- a/drivers/video/intelfb/intelfbhw.c +++ b/drivers/video/intelfb/intelfbhw.c | |||
| @@ -1971,7 +1971,7 @@ void intelfbhw_cursor_reset(struct intelfb_info *dinfo) | |||
| 1971 | static irqreturn_t intelfbhw_irq(int irq, void *dev_id) | 1971 | static irqreturn_t intelfbhw_irq(int irq, void *dev_id) |
| 1972 | { | 1972 | { |
| 1973 | u16 tmp; | 1973 | u16 tmp; |
| 1974 | struct intelfb_info *dinfo = (struct intelfb_info *)dev_id; | 1974 | struct intelfb_info *dinfo = dev_id; |
| 1975 | 1975 | ||
| 1976 | spin_lock(&dinfo->int_lock); | 1976 | spin_lock(&dinfo->int_lock); |
| 1977 | 1977 | ||
