diff options
author | Joe Perches <joe@perches.com> | 2012-01-06 14:31:43 -0500 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2012-01-24 14:08:34 -0500 |
commit | 07839b143a360f9dcf38afb5600cf049f8cbee0e (patch) | |
tree | 270d6a43d1bc0fae70ca04ccb584778a07f5618b /drivers | |
parent | d9595ce30bd860a1c5bcafef8430f46faa26d6eb (diff) |
rtlwifi: Simplify chip version id logging
Reduce object size a few KB too.
$ size drivers/net/wireless/rtlwifi/built-in.o*
text data bss dec hex filename
584493 55333 126800 766626 bb2a2 drivers/net/wireless/rtlwifi/built-in.o.new
586904 55333 127216 769453 bbdad drivers/net/wireless/rtlwifi/built-in.o.old
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192ce/hw.c | 19 | ||||
-rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192cu/mac.c | 46 |
2 files changed, 27 insertions, 38 deletions
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c b/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c index 18f615c41212..971bd29ef9bc 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c | |||
@@ -991,6 +991,7 @@ static enum version_8192c _rtl92ce_read_chip_version(struct ieee80211_hw *hw) | |||
991 | struct rtl_phy *rtlphy = &(rtlpriv->phy); | 991 | struct rtl_phy *rtlphy = &(rtlpriv->phy); |
992 | enum version_8192c version = VERSION_UNKNOWN; | 992 | enum version_8192c version = VERSION_UNKNOWN; |
993 | u32 value32; | 993 | u32 value32; |
994 | const char *versionid; | ||
994 | 995 | ||
995 | value32 = rtl_read_dword(rtlpriv, REG_SYS_CFG); | 996 | value32 = rtl_read_dword(rtlpriv, REG_SYS_CFG); |
996 | if (value32 & TRP_VAUX_EN) { | 997 | if (value32 & TRP_VAUX_EN) { |
@@ -1003,27 +1004,25 @@ static enum version_8192c _rtl92ce_read_chip_version(struct ieee80211_hw *hw) | |||
1003 | 1004 | ||
1004 | switch (version) { | 1005 | switch (version) { |
1005 | case VERSION_B_CHIP_92C: | 1006 | case VERSION_B_CHIP_92C: |
1006 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 1007 | versionid = "B_CHIP_92C"; |
1007 | "Chip Version ID: VERSION_B_CHIP_92C\n"); | ||
1008 | break; | 1008 | break; |
1009 | case VERSION_B_CHIP_88C: | 1009 | case VERSION_B_CHIP_88C: |
1010 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 1010 | versionid = "B_CHIP_88C"; |
1011 | "Chip Version ID: VERSION_B_CHIP_88C\n"); | ||
1012 | break; | 1011 | break; |
1013 | case VERSION_A_CHIP_92C: | 1012 | case VERSION_A_CHIP_92C: |
1014 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 1013 | versionid = "A_CHIP_92C"; |
1015 | "Chip Version ID: VERSION_A_CHIP_92C\n"); | ||
1016 | break; | 1014 | break; |
1017 | case VERSION_A_CHIP_88C: | 1015 | case VERSION_A_CHIP_88C: |
1018 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 1016 | versionid = "A_CHIP_88C"; |
1019 | "Chip Version ID: VERSION_A_CHIP_88C\n"); | ||
1020 | break; | 1017 | break; |
1021 | default: | 1018 | default: |
1022 | RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, | 1019 | versionid = "Unknown. Bug?"; |
1023 | "Chip Version ID: Unknown. Bug?\n"); | ||
1024 | break; | 1020 | break; |
1025 | } | 1021 | } |
1026 | 1022 | ||
1023 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | ||
1024 | "Chip Version ID: %s\n", versionid); | ||
1025 | |||
1027 | switch (version & 0x3) { | 1026 | switch (version & 0x3) { |
1028 | case CHIP_88C: | 1027 | case CHIP_88C: |
1029 | rtlphy->rf_type = RF_1T1R; | 1028 | rtlphy->rf_type = RF_1T1R; |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c index 71c7aca0b431..060ed5fec690 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c | |||
@@ -57,6 +57,7 @@ void rtl92c_read_chip_version(struct ieee80211_hw *hw) | |||
57 | struct rtl_phy *rtlphy = &(rtlpriv->phy); | 57 | struct rtl_phy *rtlphy = &(rtlpriv->phy); |
58 | struct rtl_hal *rtlhal = rtl_hal(rtlpriv); | 58 | struct rtl_hal *rtlhal = rtl_hal(rtlpriv); |
59 | enum version_8192c chip_version = VERSION_UNKNOWN; | 59 | enum version_8192c chip_version = VERSION_UNKNOWN; |
60 | const char *versionid; | ||
60 | u32 value32; | 61 | u32 value32; |
61 | 62 | ||
62 | value32 = rtl_read_dword(rtlpriv, REG_SYS_CFG); | 63 | value32 = rtl_read_dword(rtlpriv, REG_SYS_CFG); |
@@ -87,62 +88,51 @@ void rtl92c_read_chip_version(struct ieee80211_hw *hw) | |||
87 | pr_info("Chip version 0x%x\n", chip_version); | 88 | pr_info("Chip version 0x%x\n", chip_version); |
88 | switch (rtlhal->version) { | 89 | switch (rtlhal->version) { |
89 | case VERSION_NORMAL_TSMC_CHIP_92C_1T2R: | 90 | case VERSION_NORMAL_TSMC_CHIP_92C_1T2R: |
90 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 91 | versionid = "NORMAL_B_CHIP_92C"; |
91 | "Chip Version ID: VERSION_B_CHIP_92C\n"); | ||
92 | break; | 92 | break; |
93 | case VERSION_NORMAL_TSMC_CHIP_92C: | 93 | case VERSION_NORMAL_TSMC_CHIP_92C: |
94 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 94 | versionid = "NORMAL_TSMC_CHIP_92C"; |
95 | "Chip Version ID: VERSION_NORMAL_TSMC_CHIP_92C\n"); | ||
96 | break; | 95 | break; |
97 | case VERSION_NORMAL_TSMC_CHIP_88C: | 96 | case VERSION_NORMAL_TSMC_CHIP_88C: |
98 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 97 | versionid = "NORMAL_TSMC_CHIP_88C"; |
99 | "Chip Version ID: VERSION_NORMAL_TSMC_CHIP_88C\n"); | ||
100 | break; | 98 | break; |
101 | case VERSION_NORMAL_UMC_CHIP_92C_1T2R_A_CUT: | 99 | case VERSION_NORMAL_UMC_CHIP_92C_1T2R_A_CUT: |
102 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 100 | versionid = "NORMAL_UMC_CHIP_i92C_1T2R_A_CUT"; |
103 | "Chip Version ID: VERSION_NORMAL_UMC_CHIP_i92C_1T2R_A_CUT\n"); | ||
104 | break; | 101 | break; |
105 | case VERSION_NORMAL_UMC_CHIP_92C_A_CUT: | 102 | case VERSION_NORMAL_UMC_CHIP_92C_A_CUT: |
106 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 103 | versionid = "NORMAL_UMC_CHIP_92C_A_CUT"; |
107 | "Chip Version ID: VERSION_NORMAL_UMC_CHIP_92C_A_CUT\n"); | ||
108 | break; | 104 | break; |
109 | case VERSION_NORMAL_UMC_CHIP_88C_A_CUT: | 105 | case VERSION_NORMAL_UMC_CHIP_88C_A_CUT: |
110 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 106 | versionid = "NORMAL_UMC_CHIP_88C_A_CUT"; |
111 | "Chip Version ID: VERSION_NORMAL_UMC_CHIP_88C_A_CUT\n"); | ||
112 | break; | 107 | break; |
113 | case VERSION_NORMAL_UMC_CHIP_92C_1T2R_B_CUT: | 108 | case VERSION_NORMAL_UMC_CHIP_92C_1T2R_B_CUT: |
114 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 109 | versionid = "NORMAL_UMC_CHIP_92C_1T2R_B_CUT"; |
115 | "Chip Version ID: VERSION_NORMAL_UMC_CHIP_92C_1T2R_B_CUT\n"); | ||
116 | break; | 110 | break; |
117 | case VERSION_NORMAL_UMC_CHIP_92C_B_CUT: | 111 | case VERSION_NORMAL_UMC_CHIP_92C_B_CUT: |
118 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 112 | versionid = "NORMAL_UMC_CHIP_92C_B_CUT"; |
119 | "Chip Version ID: VERSION_NORMAL_UMC_CHIP_92C_B_CUT\n"); | ||
120 | break; | 113 | break; |
121 | case VERSION_NORMAL_UMC_CHIP_88C_B_CUT: | 114 | case VERSION_NORMAL_UMC_CHIP_88C_B_CUT: |
122 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 115 | versionid = "NORMAL_UMC_CHIP_88C_B_CUT"; |
123 | "Chip Version ID: VERSION_NORMAL_UMC_CHIP_88C_B_CUT\n"); | ||
124 | break; | 116 | break; |
125 | case VERSION_NORMA_UMC_CHIP_8723_1T1R_A_CUT: | 117 | case VERSION_NORMA_UMC_CHIP_8723_1T1R_A_CUT: |
126 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 118 | versionid = "NORMAL_UMC_CHIP_8723_1T1R_A_CUT"; |
127 | "Chip Version ID: VERSION_NORMA_UMC_CHIP_8723_1T1R_A_CUT\n"); | ||
128 | break; | 119 | break; |
129 | case VERSION_NORMA_UMC_CHIP_8723_1T1R_B_CUT: | 120 | case VERSION_NORMA_UMC_CHIP_8723_1T1R_B_CUT: |
130 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 121 | versionid = "NORMAL_UMC_CHIP_8723_1T1R_B_CUT"; |
131 | "Chip Version ID: VERSION_NORMA_UMC_CHIP_8723_1T1R_B_CUT\n"); | ||
132 | break; | 122 | break; |
133 | case VERSION_TEST_CHIP_92C: | 123 | case VERSION_TEST_CHIP_92C: |
134 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 124 | versionid = "TEST_CHIP_92C"; |
135 | "Chip Version ID: VERSION_TEST_CHIP_92C\n"); | ||
136 | break; | 125 | break; |
137 | case VERSION_TEST_CHIP_88C: | 126 | case VERSION_TEST_CHIP_88C: |
138 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 127 | versionid = "TEST_CHIP_88C"; |
139 | "Chip Version ID: VERSION_TEST_CHIP_88C\n"); | ||
140 | break; | 128 | break; |
141 | default: | 129 | default: |
142 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 130 | versionid = "UNKNOWN"; |
143 | "Chip Version ID: ???????????????\n"); | ||
144 | break; | 131 | break; |
145 | } | 132 | } |
133 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | ||
134 | "Chip Version ID: %s\n", versionid); | ||
135 | |||
146 | if (IS_92C_SERIAL(rtlhal->version)) | 136 | if (IS_92C_SERIAL(rtlhal->version)) |
147 | rtlphy->rf_type = | 137 | rtlphy->rf_type = |
148 | (IS_92C_1T2R(rtlhal->version)) ? RF_1T2R : RF_2T2R; | 138 | (IS_92C_1T2R(rtlhal->version)) ? RF_1T2R : RF_2T2R; |