diff options
author | Vladimir Davydov <vdavydov@parallels.com> | 2015-04-14 18:46:45 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-04-14 19:49:03 -0400 |
commit | 53d85c98566535d7bc69470f008d7dcb09a0fec9 (patch) | |
tree | 2689f2205c941c8078a6b1be85389fe1f5b059e6 /drivers/xen | |
parent | 9de1626290eaa7d921413ddc83544bc3bae27283 (diff) |
cleancache: forbid overriding cleancache_ops
Currently, cleancache_register_ops returns the previous value of
cleancache_ops to allow chaining. However, chaining, as it is
implemented now, is extremely dangerous due to possible pool id
collisions. Suppose, a new cleancache driver is registered after the
previous one assigned an id to a super block. If the new driver assigns
the same id to another super block, which is perfectly possible, we will
have two different filesystems using the same id. No matter if the new
driver implements chaining or not, we are likely to get data corruption
with such a configuration eventually.
This patch therefore disables the ability to override cleancache_ops
altogether as potentially dangerous. If there is already cleancache
driver registered, all further calls to cleancache_register_ops will
return EBUSY. Since no user of cleancache implements chaining, we only
need to make minor changes to the code outside the cleancache core.
Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Stefan Hengelein <ilendir@googlemail.com>
Cc: Florian Schmaus <fschmaus@gmail.com>
Cc: Andor Daam <andor.daam@googlemail.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Bob Liu <lliubbo@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/xen')
-rw-r--r-- | drivers/xen/tmem.c | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/drivers/xen/tmem.c b/drivers/xen/tmem.c index 8a65423bc696..c4211a31612d 100644 --- a/drivers/xen/tmem.c +++ b/drivers/xen/tmem.c | |||
@@ -397,13 +397,15 @@ static int __init xen_tmem_init(void) | |||
397 | #ifdef CONFIG_CLEANCACHE | 397 | #ifdef CONFIG_CLEANCACHE |
398 | BUG_ON(sizeof(struct cleancache_filekey) != sizeof(struct tmem_oid)); | 398 | BUG_ON(sizeof(struct cleancache_filekey) != sizeof(struct tmem_oid)); |
399 | if (tmem_enabled && cleancache) { | 399 | if (tmem_enabled && cleancache) { |
400 | char *s = ""; | 400 | int err; |
401 | struct cleancache_ops *old_ops = | 401 | |
402 | cleancache_register_ops(&tmem_cleancache_ops); | 402 | err = cleancache_register_ops(&tmem_cleancache_ops); |
403 | if (old_ops) | 403 | if (err) |
404 | s = " (WARNING: cleancache_ops overridden)"; | 404 | pr_warn("xen-tmem: failed to enable cleancache: %d\n", |
405 | pr_info("cleancache enabled, RAM provided by Xen Transcendent Memory%s\n", | 405 | err); |
406 | s); | 406 | else |
407 | pr_info("cleancache enabled, RAM provided by " | ||
408 | "Xen Transcendent Memory\n"); | ||
407 | } | 409 | } |
408 | #endif | 410 | #endif |
409 | #ifdef CONFIG_XEN_SELFBALLOONING | 411 | #ifdef CONFIG_XEN_SELFBALLOONING |