aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/watchdog/sb_wdog.c
diff options
context:
space:
mode:
authorJean Delvare <jdelvare@suse.de>2013-10-21 11:38:49 -0400
committerWim Van Sebroeck <wim@iguana.be>2013-11-17 13:38:13 -0500
commit487722cf2d66126338217896642bd5eec832c34b (patch)
tree2f0d3b4293c3f4d1bba37889b7854f8e50ae45cb /drivers/watchdog/sb_wdog.c
parent67b9fbdf3602dfd525371d7b1f49346f1d11d37d (diff)
watchdog: Get rid of MODULE_ALIAS_MISCDEV statements
I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR) and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements. Either the device is enumerated and the driver already has a module alias (e.g. PCI, USB etc.) that will get the right driver loaded automatically. Or the device is not enumerated and loading its driver will lead to more or less intrusive hardware poking. Such hardware poking should be limited to a bare minimum, so the user should really decide which drivers should be tried and in what order. Trying them all in arbitrary order can't do any good. On top of that, loading that many drivers at once bloats the kernel log. Also many drivers will stay loaded afterward, bloating the output of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets loaded as a dependency) can't even be unloaded! If defining char-major-10-130 is needed then it should happen in user-space. Signed-off-by: Jean Delvare <jdelvare@suse.de> Acked-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@iguana.be> Cc: Stephen Warren <swarren@wwwdotorg.org> Cc: Mike Frysinger <vapier.adi@gmail.com> Cc: Wan ZongShun <mcuos.com@gmail.com> Cc: Ben Dooks <ben-linux@fluff.org> Cc: Kukjin Kim <kgene.kim@samsung.com> Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk> Cc: Jim Cromie <jim.cromie@gmail.com>
Diffstat (limited to 'drivers/watchdog/sb_wdog.c')
-rw-r--r--drivers/watchdog/sb_wdog.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/watchdog/sb_wdog.c b/drivers/watchdog/sb_wdog.c
index ea5d84a1fdad..3abae50773b8 100644
--- a/drivers/watchdog/sb_wdog.c
+++ b/drivers/watchdog/sb_wdog.c
@@ -341,7 +341,6 @@ MODULE_PARM_DESC(timeout,
341 "Watchdog timeout in microseconds (max/default 8388607 or 8.3ish secs)"); 341 "Watchdog timeout in microseconds (max/default 8388607 or 8.3ish secs)");
342 342
343MODULE_LICENSE("GPL"); 343MODULE_LICENSE("GPL");
344MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
345 344
346/* 345/*
347 * example code that can be put in a platform code area to utilize the 346 * example code that can be put in a platform code area to utilize the