aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/video/omap2/dss/venc.c
diff options
context:
space:
mode:
authorArchit Taneja <archit@ti.com>2012-05-18 05:06:54 -0400
committerTomi Valkeinen <tomi.valkeinen@ti.com>2012-05-22 04:00:01 -0400
commit2aefad49d8e3a898cf629d4c5264ffd061113531 (patch)
tree0fb4f039679cfcb544d795b21eb3c148fe9c1287 /drivers/video/omap2/dss/venc.c
parent65e006ff4bb06d42b532f866a846db6e4e637723 (diff)
OMAPDSS: VENC/DISPC: Delay dividing Y resolution for managers connected to VENC
DSS2 driver uses the timings in manager's private data to check the validity of overlay and manager infos written by the user. For VENC interface, we divide the Y resolution by half when writing to the DISPC_DIGIT_SIZE register as the content is interlaced. However, the height of the manager/display with respect to the content shown through VENC still remains the same. The VENC driver divides the y_res parameter in omap_video_timings by half, and then applies the configuration. This leads to manager's private data storing the wrong Y resolution. Hence, overlay related checks fail. Ensure that manager's private data stores the original timings, and the Y resolution is halved only when we write to the DISPC register. This is a hack, the proper solution would be to pass some sort of interlace parameter which makes the call whether we should divide y_res or not. Signed-off-by: Archit Taneja <archit@ti.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video/omap2/dss/venc.c')
-rw-r--r--drivers/video/omap2/dss/venc.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/video/omap2/dss/venc.c b/drivers/video/omap2/dss/venc.c
index 1dbf1550773e..09be43d02adf 100644
--- a/drivers/video/omap2/dss/venc.c
+++ b/drivers/video/omap2/dss/venc.c
@@ -422,7 +422,6 @@ static int venc_power_on(struct omap_dss_device *dssdev)
422{ 422{
423 u32 l; 423 u32 l;
424 int r; 424 int r;
425 struct omap_video_timings timings;
426 425
427 venc_reset(); 426 venc_reset();
428 venc_write_config(venc_timings_to_config(&dssdev->panel.timings)); 427 venc_write_config(venc_timings_to_config(&dssdev->panel.timings));
@@ -442,10 +441,7 @@ static int venc_power_on(struct omap_dss_device *dssdev)
442 441
443 venc_write_reg(VENC_OUTPUT_CONTROL, l); 442 venc_write_reg(VENC_OUTPUT_CONTROL, l);
444 443
445 timings = dssdev->panel.timings; 444 dss_mgr_set_timings(dssdev->manager, &dssdev->panel.timings);
446 timings.y_res /= 2;
447
448 dss_mgr_set_timings(dssdev->manager, &timings);
449 445
450 r = regulator_enable(venc.vdda_dac_reg); 446 r = regulator_enable(venc.vdda_dac_reg);
451 if (r) 447 if (r)