aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/video/omap2/displays
diff options
context:
space:
mode:
authorArchit Taneja <archit@ti.com>2012-11-21 01:38:40 -0500
committerTomi Valkeinen <tomi.valkeinen@ti.com>2013-04-03 08:21:09 -0400
commit64f938974ee39686b017ebe4b6087aa55e2f0a82 (patch)
treedc092da395c4e23583ee75cb1e624c1b11156692 /drivers/video/omap2/displays
parentb3fb8b98bbb896132dc123aa460caf9d53372636 (diff)
OMAPDSS: n8x0 panel: handle gpio data in panel driver
The n8x0 panel driver leaves gpio configurations to the platform_enable and disable calls in the platform's board file. These should happen in the panel driver itself. A platform data struct called panel_n8x0_data already exists to hold gpio numbers and other platform data. However, the gpio requests are expected to be done in the board file and not the panel driver. Request all the gpios in the panel driver so that the board files which use the the panel don't need to do it. This will help in removing the need for the panel drivers to have platform related callbacks. Signed-off-by: Archit Taneja <archit@ti.com>
Diffstat (limited to 'drivers/video/omap2/displays')
-rw-r--r--drivers/video/omap2/displays/panel-n8x0.c15
1 files changed, 15 insertions, 0 deletions
diff --git a/drivers/video/omap2/displays/panel-n8x0.c b/drivers/video/omap2/displays/panel-n8x0.c
index 9c55c9152863..c146a3d215e2 100644
--- a/drivers/video/omap2/displays/panel-n8x0.c
+++ b/drivers/video/omap2/displays/panel-n8x0.c
@@ -426,6 +426,7 @@ static int n8x0_panel_probe(struct omap_dss_device *dssdev)
426{ 426{
427 struct panel_n8x0_data *bdata = get_board_data(dssdev); 427 struct panel_n8x0_data *bdata = get_board_data(dssdev);
428 struct panel_drv_data *ddata; 428 struct panel_drv_data *ddata;
429 int r;
429 430
430 dev_dbg(&dssdev->dev, "probe\n"); 431 dev_dbg(&dssdev->dev, "probe\n");
431 432
@@ -444,6 +445,20 @@ static int n8x0_panel_probe(struct omap_dss_device *dssdev)
444 dssdev->ctrl.rfbi_timings = n8x0_panel_timings; 445 dssdev->ctrl.rfbi_timings = n8x0_panel_timings;
445 dssdev->caps = OMAP_DSS_DISPLAY_CAP_MANUAL_UPDATE; 446 dssdev->caps = OMAP_DSS_DISPLAY_CAP_MANUAL_UPDATE;
446 447
448 if (gpio_is_valid(bdata->panel_reset)) {
449 r = devm_gpio_request_one(&dssdev->dev, bdata->panel_reset,
450 GPIOF_OUT_INIT_LOW, "PANEL RESET");
451 if (r)
452 return r;
453 }
454
455 if (gpio_is_valid(bdata->ctrl_pwrdown)) {
456 r = devm_gpio_request_one(&dssdev->dev, bdata->ctrl_pwrdown,
457 GPIOF_OUT_INIT_LOW, "PANEL PWRDOWN");
458 if (r)
459 return r;
460 }
461
447 return 0; 462 return 0;
448} 463}
449 464