aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2013-10-15 20:45:00 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-10-16 16:44:54 -0400
commite92aee330837e4911553761490a8fb843f2053a6 (patch)
tree64e39faa5f0d1ad538659663eee49535397403ac /drivers/usb
parent06793f2d0cf9daabeeb5b024d4bf7082dcc71505 (diff)
usb: hub: Clear Port Reset Change during init/resume
This patch adds the Port Reset Change flag to the set of bits that are preemptively cleared on init/resume of a hub. In theory this bit should never be set unexpectedly... in practice it can still happen if BIOS, SMM or ACPI code plays around with USB devices without cleaning up correctly. This is especially dangerous for XHCI root hubs, which don't generate any more Port Status Change Events until all change bits are cleared, so this is a good precaution to have (similar to how it's already done for the Warm Port Reset Change flag). Signed-off-by: Julius Werner <jwerner@chromium.org> Acked-by: Alan Stern <stern@rowland.harvard.edu> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/core/hub.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 3f8933f10e7d..92dde941fdbe 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -1135,6 +1135,11 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type)
1135 usb_clear_port_feature(hub->hdev, port1, 1135 usb_clear_port_feature(hub->hdev, port1,
1136 USB_PORT_FEAT_C_ENABLE); 1136 USB_PORT_FEAT_C_ENABLE);
1137 } 1137 }
1138 if (portchange & USB_PORT_STAT_C_RESET) {
1139 need_debounce_delay = true;
1140 usb_clear_port_feature(hub->hdev, port1,
1141 USB_PORT_FEAT_C_RESET);
1142 }
1138 if ((portchange & USB_PORT_STAT_C_BH_RESET) && 1143 if ((portchange & USB_PORT_STAT_C_BH_RESET) &&
1139 hub_is_superspeed(hub->hdev)) { 1144 hub_is_superspeed(hub->hdev)) {
1140 need_debounce_delay = true; 1145 need_debounce_delay = true;