diff options
author | David Cohen <david.a.cohen@linux.intel.com> | 2013-09-11 20:42:47 -0400 |
---|---|---|
committer | Felipe Balbi <balbi@ti.com> | 2013-09-17 12:05:01 -0400 |
commit | e1f804676a95b9d5caaa3a822d90bc1101595468 (patch) | |
tree | c48ac2f81d78af981ea2415b4a6dc10178956c6d /drivers/usb | |
parent | bbaa7c81e61e339fbc6aae2594c7ce8f54196fa7 (diff) |
usb: dwc3: gadget: avoid memory leak when failing to allocate all eps
If dwc3_gadget_init_endpoint() fails after allocate some of the eps, we
need to free their memory to avoid leak.
Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/dwc3/gadget.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index f168eaebdef8..5452c0fce360 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c | |||
@@ -2611,15 +2611,13 @@ int dwc3_gadget_init(struct dwc3 *dwc) | |||
2611 | ret = usb_add_gadget_udc(dwc->dev, &dwc->gadget); | 2611 | ret = usb_add_gadget_udc(dwc->dev, &dwc->gadget); |
2612 | if (ret) { | 2612 | if (ret) { |
2613 | dev_err(dwc->dev, "failed to register udc\n"); | 2613 | dev_err(dwc->dev, "failed to register udc\n"); |
2614 | goto err5; | 2614 | goto err4; |
2615 | } | 2615 | } |
2616 | 2616 | ||
2617 | return 0; | 2617 | return 0; |
2618 | 2618 | ||
2619 | err5: | ||
2620 | dwc3_gadget_free_endpoints(dwc); | ||
2621 | |||
2622 | err4: | 2619 | err4: |
2620 | dwc3_gadget_free_endpoints(dwc); | ||
2623 | dma_free_coherent(dwc->dev, DWC3_EP0_BOUNCE_SIZE, | 2621 | dma_free_coherent(dwc->dev, DWC3_EP0_BOUNCE_SIZE, |
2624 | dwc->ep0_bounce, dwc->ep0_bounce_addr); | 2622 | dwc->ep0_bounce, dwc->ep0_bounce_addr); |
2625 | 2623 | ||