diff options
author | Felipe Balbi <balbi@ti.com> | 2014-07-16 13:19:12 -0400 |
---|---|---|
committer | Felipe Balbi <balbi@ti.com> | 2014-07-16 13:50:40 -0400 |
commit | bbb9f94cf9e9e1cd120ef757944f0304a89aac95 (patch) | |
tree | cb83eb4d47c5b0c5ee2585ada77928f2d05107b4 /drivers/usb | |
parent | 00a2430ff07d4e0e0e7e24e02fd8adede333b797 (diff) |
usb: gadget: udc: fsl_udc_core: fix sparse errors
No functional changes, just fixing some easy
to spot sparse errors.
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/gadget/udc/fsl_udc_core.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c index 57944ee8ad90..75b23ea077a7 100644 --- a/drivers/usb/gadget/udc/fsl_udc_core.c +++ b/drivers/usb/gadget/udc/fsl_udc_core.c | |||
@@ -59,9 +59,9 @@ | |||
59 | static const char driver_name[] = "fsl-usb2-udc"; | 59 | static const char driver_name[] = "fsl-usb2-udc"; |
60 | static const char driver_desc[] = DRIVER_DESC; | 60 | static const char driver_desc[] = DRIVER_DESC; |
61 | 61 | ||
62 | static struct usb_dr_device *dr_regs; | 62 | static struct usb_dr_device __iomem *dr_regs; |
63 | 63 | ||
64 | static struct usb_sys_interface *usb_sys_regs; | 64 | static struct usb_sys_interface __iomem *usb_sys_regs; |
65 | 65 | ||
66 | /* it is initialized in probe() */ | 66 | /* it is initialized in probe() */ |
67 | static struct fsl_udc *udc_controller = NULL; | 67 | static struct fsl_udc *udc_controller = NULL; |
@@ -159,6 +159,8 @@ static inline void fsl_set_accessors(struct fsl_usb2_platform_data *pdata) {} | |||
159 | * request is still in progress. | 159 | * request is still in progress. |
160 | *--------------------------------------------------------------*/ | 160 | *--------------------------------------------------------------*/ |
161 | static void done(struct fsl_ep *ep, struct fsl_req *req, int status) | 161 | static void done(struct fsl_ep *ep, struct fsl_req *req, int status) |
162 | __releases(ep->udc->lock) | ||
163 | __acquires(ep->udc->lock) | ||
162 | { | 164 | { |
163 | struct fsl_udc *udc = NULL; | 165 | struct fsl_udc *udc = NULL; |
164 | unsigned char stopped = ep->stopped; | 166 | unsigned char stopped = ep->stopped; |
@@ -1392,6 +1394,8 @@ stall: | |||
1392 | 1394 | ||
1393 | static void setup_received_irq(struct fsl_udc *udc, | 1395 | static void setup_received_irq(struct fsl_udc *udc, |
1394 | struct usb_ctrlrequest *setup) | 1396 | struct usb_ctrlrequest *setup) |
1397 | __releases(udc->lock) | ||
1398 | __acquires(udc->lock) | ||
1395 | { | 1399 | { |
1396 | u16 wValue = le16_to_cpu(setup->wValue); | 1400 | u16 wValue = le16_to_cpu(setup->wValue); |
1397 | u16 wIndex = le16_to_cpu(setup->wIndex); | 1401 | u16 wIndex = le16_to_cpu(setup->wIndex); |
@@ -1957,7 +1961,7 @@ static int fsl_udc_start(struct usb_gadget *g, | |||
1957 | &udc_controller->gadget); | 1961 | &udc_controller->gadget); |
1958 | if (retval < 0) { | 1962 | if (retval < 0) { |
1959 | ERR("can't bind to transceiver\n"); | 1963 | ERR("can't bind to transceiver\n"); |
1960 | udc_controller->driver = 0; | 1964 | udc_controller->driver = NULL; |
1961 | return retval; | 1965 | return retval; |
1962 | } | 1966 | } |
1963 | } | 1967 | } |
@@ -2379,7 +2383,7 @@ static int fsl_udc_probe(struct platform_device *pdev) | |||
2379 | goto err_release_mem_region; | 2383 | goto err_release_mem_region; |
2380 | } | 2384 | } |
2381 | 2385 | ||
2382 | pdata->regs = (void *)dr_regs; | 2386 | pdata->regs = (void __iomem *)dr_regs; |
2383 | 2387 | ||
2384 | /* | 2388 | /* |
2385 | * do platform specific init: check the clock, grab/config pins, etc. | 2389 | * do platform specific init: check the clock, grab/config pins, etc. |