diff options
author | Felipe Balbi <balbi@ti.com> | 2011-11-15 02:53:31 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-11-15 13:20:49 -0500 |
commit | 36f3a14ded234757f101c866452a8a26d1e83844 (patch) | |
tree | acf8aed19bdb84b452b4282adef7b8e27c56d314 /drivers/usb/storage | |
parent | b03379f7e0168791e29534044a9172fa97e498d6 (diff) |
usb: storage: ene_ub6250: fix sparse warnings
Fix the following sparse warnings:
| drivers/usb/storage/ene_ub6250.c:45:22: warning: symbol
| 'ene_ub6250_usb_ids' was not declared. Should it
| be static?
|
| drivers/usb/storage/ene_ub6250.c:780:5: warning: symbol
| 'ms_lib_alloc_logicalmap' was not declared. Should it
| be static?
|
| drivers/usb/storage/ene_ub6250.c:2251:5: warning: symbol
| 'ms_scsi_irp' was not declared. Should it be static?
|
| drivers/usb/storage/ene_ub6250.c:638:29: warning: right shift by bigger
| than source value
|
| drivers/usb/storage/ene_ub6250.c:639:29: warning: right shift by bigger
| than source value
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/storage')
-rw-r--r-- | drivers/usb/storage/ene_ub6250.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c index 4dca3ef0668c..9665f15f52a7 100644 --- a/drivers/usb/storage/ene_ub6250.c +++ b/drivers/usb/storage/ene_ub6250.c | |||
@@ -42,7 +42,7 @@ MODULE_LICENSE("GPL"); | |||
42 | { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \ | 42 | { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \ |
43 | .driver_info = (flags)|(USB_US_TYPE_STOR<<24) } | 43 | .driver_info = (flags)|(USB_US_TYPE_STOR<<24) } |
44 | 44 | ||
45 | struct usb_device_id ene_ub6250_usb_ids[] = { | 45 | static struct usb_device_id ene_ub6250_usb_ids[] = { |
46 | # include "unusual_ene_ub6250.h" | 46 | # include "unusual_ene_ub6250.h" |
47 | { } /* Terminating entry */ | 47 | { } /* Terminating entry */ |
48 | }; | 48 | }; |
@@ -607,8 +607,8 @@ static int sd_scsi_mode_sense(struct us_data *us, struct scsi_cmnd *srb) | |||
607 | 607 | ||
608 | static int sd_scsi_read_capacity(struct us_data *us, struct scsi_cmnd *srb) | 608 | static int sd_scsi_read_capacity(struct us_data *us, struct scsi_cmnd *srb) |
609 | { | 609 | { |
610 | u32 bl_num; | 610 | u32 bl_num; |
611 | u16 bl_len; | 611 | u32 bl_len; |
612 | unsigned int offset = 0; | 612 | unsigned int offset = 0; |
613 | unsigned char buf[8]; | 613 | unsigned char buf[8]; |
614 | struct scatterlist *sg = NULL; | 614 | struct scatterlist *sg = NULL; |
@@ -622,7 +622,7 @@ static int sd_scsi_read_capacity(struct us_data *us, struct scsi_cmnd *srb) | |||
622 | else | 622 | else |
623 | bl_num = (info->HC_C_SIZE + 1) * 1024 - 1; | 623 | bl_num = (info->HC_C_SIZE + 1) * 1024 - 1; |
624 | } else { | 624 | } else { |
625 | bl_len = 1<<(info->SD_READ_BL_LEN); | 625 | bl_len = 1 << (info->SD_READ_BL_LEN); |
626 | bl_num = info->SD_Block_Mult * (info->SD_C_SIZE + 1) | 626 | bl_num = info->SD_Block_Mult * (info->SD_C_SIZE + 1) |
627 | * (1 << (info->SD_C_SIZE_MULT + 2)) - 1; | 627 | * (1 << (info->SD_C_SIZE_MULT + 2)) - 1; |
628 | } | 628 | } |
@@ -777,7 +777,7 @@ static int ms_lib_free_logicalmap(struct us_data *us) | |||
777 | return 0; | 777 | return 0; |
778 | } | 778 | } |
779 | 779 | ||
780 | int ms_lib_alloc_logicalmap(struct us_data *us) | 780 | static int ms_lib_alloc_logicalmap(struct us_data *us) |
781 | { | 781 | { |
782 | u32 i; | 782 | u32 i; |
783 | struct ene_ub6250_info *info = (struct ene_ub6250_info *) us->extra; | 783 | struct ene_ub6250_info *info = (struct ene_ub6250_info *) us->extra; |
@@ -2249,7 +2249,7 @@ static int sd_scsi_irp(struct us_data *us, struct scsi_cmnd *srb) | |||
2249 | /* | 2249 | /* |
2250 | * ms_scsi_irp() | 2250 | * ms_scsi_irp() |
2251 | */ | 2251 | */ |
2252 | int ms_scsi_irp(struct us_data *us, struct scsi_cmnd *srb) | 2252 | static int ms_scsi_irp(struct us_data *us, struct scsi_cmnd *srb) |
2253 | { | 2253 | { |
2254 | int result; | 2254 | int result; |
2255 | struct ene_ub6250_info *info = (struct ene_ub6250_info *)us->extra; | 2255 | struct ene_ub6250_info *info = (struct ene_ub6250_info *)us->extra; |