diff options
author | Matthew Dharm <mdharm-usb@one-eyed-alien.net> | 2005-07-28 17:45:50 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-09-08 19:22:55 -0400 |
commit | 26186ba77b493204ae0fadc3c88a67b14f22168f (patch) | |
tree | 6fc0d50a4d286df33b18f21e0994b09637d0c6c8 /drivers/usb/storage/dpcm.c | |
parent | 77f46328fb83b64befd889ebce6d7fb959932509 (diff) |
[PATCH] USB Storage: close a race condition in disconnect near queuecommand
This patch started life as as534, and has been re-diffed against the latest
tree.
usb-storage has a small loophole, a window between the time queuecommand
accepts a new command and the time the control thread starts to execute
it. If disconnect is called during that window, the driver won't cancel
the pending command -- we've been relying on the SCSI core to cancel it
for us during host removal. But it's better for usb-storage to cancel
it; this avoids races and reduces reliance on the SCSI core.
Fortunately cancelling these commands is easy to do; the key is to do it
_before_ calling scsi_remove_host.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/storage/dpcm.c')
0 files changed, 0 insertions, 0 deletions